From f29d50e6ddf70da625c8045608b7e47f71978cdd Mon Sep 17 00:00:00 2001 From: Steven Zou Date: Tue, 30 Jul 2019 11:56:17 +0800 Subject: [PATCH] fix ut case failures Signed-off-by: Steven Zou --- src/pkg/retention/policy/action/performer_test.go | 12 ++++++------ src/pkg/retention/policy/alg/or/processor_test.go | 7 +++---- src/pkg/retention/policy/builder_test.go | 4 ++++ 3 files changed, 13 insertions(+), 10 deletions(-) diff --git a/src/pkg/retention/policy/action/performer_test.go b/src/pkg/retention/policy/action/performer_test.go index 330524997..2f6a6be15 100644 --- a/src/pkg/retention/policy/action/performer_test.go +++ b/src/pkg/retention/policy/action/performer_test.go @@ -15,15 +15,15 @@ package action import ( + "testing" + "time" + "github.com/goharbor/harbor/src/pkg/retention/dep" - "github.com/goharbor/harbor/src/pkg/retention/policy/lwp" "github.com/goharbor/harbor/src/pkg/retention/res" "github.com/pkg/errors" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "github.com/stretchr/testify/suite" - "testing" - "time" ) // TestPerformerSuite tests the performer related function @@ -106,7 +106,7 @@ func (frc *fakeRetentionClient) Delete(candidate *res.Candidate) error { return nil } -// SubmitTask ... -func (frc *fakeRetentionClient) SubmitTask(taskID int64, repository *res.Repository, meta *lwp.Metadata) (string, error) { - return "", errors.New("not implemented") +// DeleteRepository ... +func (frc *fakeRetentionClient) DeleteRepository(repo *res.Repository) error { + panic("implement me") } diff --git a/src/pkg/retention/policy/alg/or/processor_test.go b/src/pkg/retention/policy/alg/or/processor_test.go index 30b0d210f..d37a602c9 100644 --- a/src/pkg/retention/policy/alg/or/processor_test.go +++ b/src/pkg/retention/policy/alg/or/processor_test.go @@ -22,7 +22,6 @@ import ( "github.com/goharbor/harbor/src/pkg/retention/dep" "github.com/goharbor/harbor/src/pkg/retention/policy/action" "github.com/goharbor/harbor/src/pkg/retention/policy/alg" - "github.com/goharbor/harbor/src/pkg/retention/policy/lwp" "github.com/goharbor/harbor/src/pkg/retention/policy/rule" "github.com/goharbor/harbor/src/pkg/retention/policy/rule/always" "github.com/goharbor/harbor/src/pkg/retention/policy/rule/lastx" @@ -171,7 +170,7 @@ func (frc *fakeRetentionClient) Delete(candidate *res.Candidate) error { return nil } -// SubmitTask ... -func (frc *fakeRetentionClient) SubmitTask(taskID int64, repository *res.Repository, meta *lwp.Metadata) (string, error) { - return "", errors.New("not implemented") +// DeleteRepository ... +func (frc *fakeRetentionClient) DeleteRepository(repo *res.Repository) error { + panic("implement me") } diff --git a/src/pkg/retention/policy/builder_test.go b/src/pkg/retention/policy/builder_test.go index 515f57dfe..fb1f4271a 100644 --- a/src/pkg/retention/policy/builder_test.go +++ b/src/pkg/retention/policy/builder_test.go @@ -161,6 +161,10 @@ func (suite *TestBuilderSuite) TestBuild() { type fakeRetentionClient struct{} +func (frc *fakeRetentionClient) DeleteRepository(repo *res.Repository) error { + panic("implement me") +} + // GetCandidates ... func (frc *fakeRetentionClient) GetCandidates(repo *res.Repository) ([]*res.Candidate, error) { return nil, errors.New("not implemented")