Commit Graph

5387 Commits

Author SHA1 Message Date
Steven Zou
cfefcb7450
Merge pull request #5399 from steven-zou/fix_access_control_issue
Fix the access control checking issue
2018-07-26 15:27:30 +08:00
Qian Deng
0f7eab38b7
Merge pull request #5384 from wy65701436/update-migrator-aj
Update migrator for admin job
2018-07-26 03:19:31 -04:00
Qian Deng
508145019e
Merge pull request #5397 from zhoumeina/project_error_msg
Replicate project error message is not correct
2018-07-26 03:18:31 -04:00
Daniel Jiang
ad0c0eba36 Add registry to default no_proxy hosts for Clair
When proxy is set for Clair, there may be issue when Clair pulls image
from the registryif the `no_proxy` attribute is not updated.  This
commit adds `registry` to the default setting.
2018-07-26 14:41:03 +08:00
Mia ZHOU
4ff45b0624 Use capitalize in configuration dropdown menu
Problem Description:
configuration dropdown menu use all uppercase letters.

Fix:
Modify all of them in capitalize letters.

Note:Try to use css text-transform:Caplitalize but not working, if anyone know the reason, please kindly tell me.
2018-07-26 14:40:12 +08:00
Steven Zou
01fb95062c Fix the access control checking issue
should check access first, then check authentication
return 401/403 accroding to the checking results properly
2018-07-26 14:28:16 +08:00
Mia ZHOU
397af582a2 Replicate project error message is not correct
Problem description:
when user try to new a replication rule, he need to input source project name.
In this case, if user input a project name not exist. The error message will be:"Please add a project name",
this is not accurate.

Fix:
Modify the error message to "This project is not exist".

Plus:Modify the error popup using standard tooltip component.
2018-07-26 13:37:45 +08:00
Steven Zou
c1e1779ac0
Merge pull request #5396 from reasonerjt/scan-all-no-clair
No scan all policy if Clair is not installed.
2018-07-26 12:33:23 +08:00
Yan
9524c70f5e
Fix error in package offline installe (#5395)
It has a redundant slash in the end of docker save command,
that causes the command with merge the following lines into
save cmd, and then to fail package offline installer.
2018-07-26 10:09:22 +08:00
Daniel Jiang
97fb67f835 No scan all policy if Clair is not installed.
This commit fixes #5283 by not registering scan all policy when Harbor
is not deployed with Clair.
2018-07-25 19:52:16 +08:00
Mia ZHOU
9fba539bd4
Merge pull request #5392 from zhoumeina/new_label_fix
Fix configuration->label->new sometimes not enable.
2018-07-25 18:32:16 +08:00
Mia ZHOU
60f83843e3 Fix configuration->label->new sometimes not enable.
Problem description:
1 label enable sometimes not correct. User input good label names, submit button still disabled.
2 Some times click submit, not working.

Fix:

1 After review the new label code. It trying to use a global variable to control the progress of validation. In the progress of validation, it will disabled the submit button.

This will cause user bad experience. Just remove this logic.

2 Backend use fuzzy matching, the frontend logic did not change before. So when user already have a user name called "abcd",and then input another name called "abc" it will report duplicated name error.
This logic still need change.

3 This is the first version of refine. Can be refine again if find some other logic not correct.
2018-07-25 17:47:22 +08:00
Yan
602bcdfa5b
remove publish npm package step in the ci flow and set the (#5391)
env for admin and pwd for ci, make it same as nightly test.
2018-07-25 17:20:40 +08:00
Steven Zou
b8c7a8cb68
Merge pull request #5393 from steven-zou/fix_content_length_issue
Set the content length to -1 to let the reader read all the uploading…
2018-07-25 17:08:32 +08:00
Steven Zou
850af80762 Set the content length to -1 to let the reader read all the uploading contents in the request 2018-07-25 16:25:44 +08:00
Daniel Jiang
2fa0cf032c
Merge pull request #5335 from ywk253100/180717_chart
Support the configuration of registry storage in helm chart
2018-07-25 16:20:31 +08:00
Daniel Jiang
b76b982ded
Merge pull request #5390 from ywk253100/180725_doc
Update the user guide
2018-07-25 15:53:43 +08:00
Wenkai Yin
4ee6f6abdf Update the user guide
This commit updates the user guide according to the comments from Louis
2018-07-25 13:04:19 +08:00
Qian Deng
e597910c6f
Merge pull request #5389 from zhoumeina/notification_ui_refine
Notification should not hide content according to ux
2018-07-25 00:35:45 -04:00
wangyan
5b492ee321 Update migrator for support new table admin_job 2018-07-24 20:29:56 -07:00
Mia ZHOU
50678523c4 Notification should not hide content according to ux
Issue description:
Notification will hide some content when it popup.

According to ux requirement, we should make it not extend to the whole widh of UI, and should not hide the content.

Fix:
Use clarity alert-app-level style,it will show as ux design,and text in center too.
2018-07-25 11:29:08 +08:00
Daniel Jiang
c6c5745183 Remove vmware/photon image from offline package (#5347)
We used to package vmware/photon:1.0 in the offline package for product
integration.  Currently this is no longer needed by downstream product.
This commit removes it.
2018-07-25 11:03:00 +08:00
Wenkai Yin
0a8602709a
Merge pull request #5387 from steven-zou/fix_content_length_issue
Update content length of request when rewriting the content
2018-07-25 10:53:50 +08:00
Steven Zou
07bfad968a Update content length of request when rewriting the content 2018-07-24 23:10:42 +08:00
Qian Deng
7ee2e1053e
Merge pull request #5383 from zhoumeina/notification_ui_refine
Notification should not hide content according to ux
2018-07-24 10:00:33 -04:00
Daniel Jiang
3a2c58394b
Merge pull request #5382 from stonezdj/ldap_admin_role_rest
Ldap_group_admin_dn can not updated via rest
2018-07-24 19:46:10 +08:00
Daniel Jiang
5426cfa687
Merge pull request #5385 from wy65701436/bump-1.6.0
Bump harbor release version to 1.6.0
2018-07-24 19:43:35 +08:00
wangyan
6ece052824 Bump harbor release version to 1.6.0 2018-07-24 03:46:05 -07:00
Mia ZHOU
2240693a1d Notification should not hide content according to ux
Issue description:
Notification will hide some content when it popup.

According to ux requirement, we should make it not extend to the whole widh of UI, and should not hide the content.

Fix:
Modify the position from 'absolute' to 'relative', so that it will not hide the content.
2018-07-24 17:56:46 +08:00
stonezdj
9b209858f4 Ldap_group_admin_dn can not updated via rest 2018-07-24 17:47:57 +08:00
Qian Deng
eafee964c1
Merge pull request #5372 from zhoumeina/fix_configuration_button_validation
Fix issue install clair the first time use scan will have undefined e…
2018-07-24 02:07:59 -04:00
Mia ZHOU
19e2a9ad1b Fix issue install clair the first time use scan will have undefined error
Description:
Reproduce Steps:
1 User install Clair
2 User use scan to scan the image
2 There will be a notification pop with undefined error
Root cause:
In result-bar-chart-component.ts  copyValue function
  this.summary.scan_status = newVal.scan_status;
It try to set scan status to summary object.
Somehow, the first time summary is undefined. It will cause this error.

Fix:
1 Do a empty check before assign value to a object.
2 Set a default value to summary.
2018-07-24 13:36:39 +08:00
silenceshell
7745b79b2e var name should not be error (#5332)
Rename the variable names from "error" to "err"
2018-07-24 11:33:21 +08:00
Daniel Jiang
e9d5913d63
Merge pull request #5368 from ywk253100/180723_chart_redis
Add support for external Redis configuration in helm chart
2018-07-24 11:25:56 +08:00
Wenkai Yin
1c383473e1
Merge pull request #5367 from steven-zou/fix_issue_multipart
Fix the multipart form data content missing issue by refill the content again before passing to the backend server
2018-07-24 11:20:42 +08:00
Steven Zou
9f0f959749 Fix the multipart form data content missing issue by refill the content again before passing to the backend server
refill the multipart form data at harbor API layer
export write error functions from the chartserver package
refactor the error format to be compatiable with push plugin
2018-07-24 10:32:20 +08:00
Wenkai Yin
f22121dd03 Add support for external Redis configuration in helm chart
This commit adds "external" part in redis configuration in helm chart, by this way users can use the existing external Redis rather than using the internal one
2018-07-23 17:42:23 +08:00
Steven Zou
405e89158a
Merge pull request #5364 from steven-zou/fix_file_missing_issue
Fix the issue of returning '* file not found' error
2018-07-23 15:32:02 +08:00
Daniel Jiang
04cd861a18
Merge pull request #5362 from reasonerjt/clean-up-vendor
Clean up vendor folder
2018-07-23 15:28:40 +08:00
Steven Zou
2f0b706f84 Fix the issue of returning '* file not found' error
return default empty when file is not existing
2018-07-23 14:53:40 +08:00
Steven Zou
8436d2b4e6
Merge pull request #5363 from vmware/midofy_max_works_num
Modify the cfg option 'max_job_workers' from 50 to 10 to reduce the resource requirement
2018-07-23 14:40:35 +08:00
Daniel Jiang
b9762afbdd Clean up vendor folder
Add `prune` section to Gopkg.toml to remove the unused packages from
vendor folder.
Update the reference of `semver` and `distribution` repo.
2018-07-23 14:40:25 +08:00
Steven Zou
32f0ceade3 Modify the cfg option 'max_job_workers' from 50 to 10 to reduce the resource requirement 2018-07-23 13:36:46 +08:00
Steven Zou
bb380e6dbc
Merge pull request #5314 from steven-zou/chart_repo_supporting
Refactor chart API endpoints
2018-07-20 20:43:55 +08:00
Steven Zou
0227a1315a Keep the chart server related configurations in adminserver
append chart server related config options to the supporting list of adminserver
provide chart server related config access method in the API layer
update prepare script and ui env template file to enable cache driver config for chart server API
append flag info in the systeminfo API to indicate if chart server is deployed with Harbor
refactor the response rewriting logic to return structual error object
add api init method to initilizing objects required in API handlers
chage owner of the storage folder
update offline/online package scripts in Harbor-Util.robot
2018-07-20 19:40:33 +08:00
Yan
efdb57548f
add admin job api (#5344)
It supports Harbor admin to trigger job either manual or
schedule. The job will be populated to job service to execute. 
The api includes:
1. POST /api/system/gc
2, GET /api/system/gc/:id 
3, GET /api/system/gc/:id/log
4, PUT/GET/POST /api/system/gc/schedule
2018-07-20 19:22:37 +08:00
Wenkai Yin
bbb190327d
Merge pull request #5319 from BowlingX/master
Remove lost+found folder in database volume on initial start
2018-07-20 16:39:57 +08:00
Daniel Jiang
6c664ee993 Update photon base images (#5346)
This commit update the base photon image from vmware/photon:1.0 to
photon:1.0, per suggestion by photon team.
2018-07-19 20:45:20 +08:00
Daniel Jiang
b764eed123
Merge pull request #5345 from wy65701436/master-basea
Update e2e cases
2018-07-19 19:30:22 +08:00
Steven Zou
726d81803b Fix conflicts in Makefiles and prepare script files with upstream 2018-07-19 03:17:05 -07:00