Commit Graph

2530 Commits

Author SHA1 Message Date
Fangyuan Cheng
10effb0a02
Merge pull request #7581 from zhoumeina/fix_label_error
fix replication add label console error
2019-04-28 16:24:18 +08:00
Meina Zhou
f4dcac95fe fix replication add label console error
Signed-off-by: Meina Zhou <meinaz@vmware.com>
2019-04-28 15:49:28 +08:00
wang yan
b5cb984455 Remove the workaround for checking chart existence
Signed-off-by: wang yan <wangyan@vmware.com>
2019-04-28 15:24:17 +08:00
Wang Yan
c26f655bce
add periodic job UUID to upstream job id and use execution log as the… (#7530)
* add periodic job UUID to upstream job id and use execution log as the periodic log

Signed-off-by: wang yan <wangyan@vmware.com>

* add comments to fix codacy

Signed-off-by: wang yan <wangyan@vmware.com>

* Update code per comments

Signed-off-by: wang yan <wangyan@vmware.com>
2019-04-28 15:09:56 +08:00
Mia ZHOU
630fa48ac8
Merge pull request #7517 from pureshine/loading-num
Get the number of execution status every 10s and refresh the task list
2019-04-28 14:22:36 +08:00
Mia ZHOU
ae922d86e2
Merge pull request #7521 from pureshine/modify-tip
Modify tooltips for creating replication rule
2019-04-28 14:18:29 +08:00
Wenkai Yin
7af679af7e
Merge pull request #7567 from reasonerjt/oidc-google-refresh-token
Persist the new token in DB after login
2019-04-28 14:12:25 +08:00
Daniel Jiang
80176cc354 Check whether user is nil in Prepare() of users API (#7507)
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2019-04-28 14:06:35 +08:00
Daniel Jiang
15626fcae0 Return more details for error in exchange token
This commit update the response off OIDC callback when there's error in exchange token.
Additionally add comments to clarify that by default 500 error will not
contain any details.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2019-04-28 13:41:53 +08:00
Wenkai Yin
2a463016a9 Upgrade the distribution and notary library (#7516)
* Return 404 when the log of task doesn't exist

Return 404 when the log of task doesn't exist

Signed-off-by: Wenkai Yin <yinw@vmware.com>

* Upgrade the distribution and notary library

Upgrade the distribution library to 2.7.1, the notary library to 0.6.1

Signed-off-by: Wenkai Yin <yinw@vmware.com>
2019-04-28 12:00:26 +08:00
Daniel Jiang
473fed5689 Persist the new token in DB after login
This commit make sure the token is persist to DB after every time after
a user logs in via OIDC provider, to make sure the secret is usable for
the OIDC providers that don't provide refresh token.

It also updates the authorize URL for google to make sure the refresh
token will be returned.

Also some misc refinement included, including add comment to the
OIDC onboarded user, preset the username in onboard dialog.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2019-04-27 23:03:59 +08:00
Daniel Jiang
b9f5f1027c
Merge pull request #7504 from reasonerjt/reload-auth-proxy-cert-verify
Update Transport of HTTP cient in auth proxy client
2019-04-26 23:24:33 +08:00
Daniel Jiang
07d15a8553 Update Transport of HTTP cient in auth proxy client
This commit ensures that the TLS config of the HTTP client for auth
proxy is updated when the configuration is changed.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2019-04-26 18:39:28 +08:00
Wenkai Yin
621d2f20f3 Return immediately after creating the execution record when starting the replication
When fetching resources is slow, the starting replication request may timeout, this commit returns immediately after creating the execution record when starting the replication

Signed-off-by: Wenkai Yin <yinw@vmware.com>
2019-04-26 13:28:16 +08:00
Wenkai Yin
3c1be645bf
Merge pull request #7456 from yuanshuhan/replication_ng
fix a small issue, that if there is no manifest in huawei image repos…
2019-04-26 11:27:40 +08:00
FangyuanCheng
e45d402777 Modify tooltips for creating replication rule
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2019-04-26 10:54:41 +08:00
FangyuanCheng
4768ad33ed Get the number of execution status every 10s and refresh the task list
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2019-04-25 22:01:07 +08:00
Wenkai Yin
6511417ba6
Merge pull request #7495 from stonezdj/const_debts
Replace string with const in metadatalist.go
2019-04-25 17:41:04 +08:00
Mia ZHOU
3296e2acae
Merge pull request #7513 from pureshine/replication-delete
Get delete or replicate failure information directly and display
2019-04-25 17:11:35 +08:00
stonezdj
504eab56c3 Replace string with const in metadatalist.go
Signed-off-by: stonezdj <stonezdj@gmail.com>
2019-04-25 17:01:43 +08:00
FangyuanCheng
5e34cd3cf9 Fix some issues of replication
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2019-04-25 16:47:31 +08:00
Mia ZHOU
ffadd13ba6
Merge pull request #7487 from pureshine/fix-scan-error
Fix scan task never ends in UI
2019-04-25 12:16:47 +08:00
Mia ZHOU
5a9fa17b0b
Merge pull request #7506 from zhoumeina/fix_gc
use endpoint for gc log
2019-04-25 10:33:25 +08:00
FangyuanCheng
6f055cebc3 Fix Scan task never ends in UI target/1.8.0
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2019-04-25 10:27:28 +08:00
Wenkai Yin
7160e411cc
Merge pull request #7498 from ywk253100/190423_docker_hub
Support replicate public repositories from Docker Hub
2019-04-24 17:17:23 +08:00
Meina Zhou
f0d9b41bf5 use endpoint for gc log
Signed-off-by: Meina Zhou <meinaz@vmware.com>
2019-04-24 17:04:44 +08:00
Wenkai Yin
66087aac82
Merge pull request #7493 from stonezdj/tech_debts
Remove adminserver in sourcecode
2019-04-24 16:24:59 +08:00
Steven Zou
9bd2de3e35
Merge pull request #7452 from steven-zou/fix_issues_for_jobservice
Fix issues for jobservice
2019-04-24 16:15:43 +08:00
Wenkai Yin
5629bf8546 Support replicate public repositories from Docker Hub
Support replicate the public repositories from Docker Hub without providing the credential

Signed-off-by: Wenkai Yin <yinw@vmware.com>
2019-04-24 16:15:31 +08:00
Wenkai Yin
d8da6cb802
Merge pull request #7460 from ywk253100/190419_replication_bug_fix
Fix bug found in replication
2019-04-24 16:12:20 +08:00
jwangyangls
743b3914c3
Merge pull request #7494 from jwangyangls/remove_oidc_ability_to_change_password
Remove OIDC's ability to change passwords
2019-04-24 13:24:54 +08:00
Fangyuan Cheng
24acbcf300
Merge pull request #7485 from pureshine/add-tooltip
Add tooltips for creating replication rule
2019-04-24 13:22:46 +08:00
Mia ZHOU
c4bf07a2ed
Merge pull request #7377 from kofj/fix_history_display
Fix history display
2019-04-24 13:12:14 +08:00
Mia ZHOU
a1230a0ca1
Merge pull request #7490 from pureshine/label-tab
Align all tab spacing between project and configuration pages
2019-04-24 12:45:11 +08:00
Steven Zou
9bcbe2907b fix go vet issues in the code
Signed-off-by: Steven Zou <szou@vmware.com>
2019-04-24 07:31:37 +08:00
Wenkai Yin
d8310cc708 Fix replication bugs (#7470)
1. Only return the event based trigger for local Harbor
2. Valid the trigger pattern and cron string when creating/updating policies
3. Set the schema as "http" if it isn't specified when creating/updating registries

Signed-off-by: Wenkai Yin <yinw@vmware.com>
2019-04-23 19:34:29 +08:00
Steven Zou
823d9c04a9
Merge pull request #7497 from wy65701436/fix-replc-500
refine chart clint http response
2019-04-23 19:30:36 +08:00
Wenkai Yin
117232c1be Fix bug: cannot update the registry (#7483)
Fix bug: cannot update the registry that has no credential when creating it

Signed-off-by: Wenkai Yin <yinw@vmware.com>
2019-04-23 18:45:56 +08:00
wang yan
0d563fda9c refine chart clint http response
Chart client eats the http error if not status ok, after refactor, the
real http response will be catched in core api.

Signed-off-by: wang yan <wangyan@vmware.com>
2019-04-23 18:22:23 +08:00
Steven Zou
69d9a28860
Merge pull request #7482 from wy65701436/chart-upload
Fix chart upload issue on event based
2019-04-23 17:33:08 +08:00
stonezdj(Daojun Zhang)
e4506604e2 fix error message (#7459)
Signed-off-by: stonezdj <stonezdj@gmail.com>
2019-04-23 15:53:34 +08:00
Yogi_Wang
32fc76c666 Remove OIDC's ability to change passwords
remove the ability  to change passwords when user login harbor through OIDC.

Signed-off-by: Yogi_Wang <yawang@vmware.com>
2019-04-23 15:17:59 +08:00
stonezdj
d7798a12d2 Remove adminserver in sourcecode
Signed-off-by: stonezdj <stonezdj@gmail.com>
2019-04-23 15:05:29 +08:00
疯魔慕薇
d022ad4cd4 1. Add IsSpecificRepositoryName util method. (#7444)
2. Add IsSpecificRepositoryName unit test case.
3. Add Copyright header comment.

Signed-off-by: 慕薇疯魔 <kfanjian@gmail.com>
2019-04-23 13:37:40 +08:00
FangyuanCheng
85bd840ff1 Align all tab spacing between project and configuration pages
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2019-04-23 11:20:05 +08:00
jwangyangls
1323fbfa14
Merge pull request #7481 from jwangyangls/oidc_generate_cli
Add generate cli secret in user profile page
2019-04-23 11:10:50 +08:00
wang yan
a3763466b3 Update err message to general information
Signed-off-by: wang yan <wangyan@vmware.com>
2019-04-23 10:57:31 +08:00
wang yan
1b4c75af25 Add event into upload ctx
Signed-off-by: wang yan <wangyan@vmware.com>
2019-04-23 10:57:31 +08:00
wang yan
df6e0600c9 Fix chart upload issue on event based
Use chart API to load the uploaded chart file to get the name and version

Signed-off-by: wang yan <wangyan@vmware.com>
2019-04-23 10:57:31 +08:00
Wenkai Yin
ac4dfd5973
Merge pull request #7473 from pureshine/fix-ping-param
Modify some issues of test ping registry and edit registry
2019-04-23 10:13:39 +08:00
Yogi_Wang
f164738246 Add generate cli secret in user profile page
add cli secret button in user profile page, OIDC users can click this button to regenerate a cli secret, if the user does so, then the past cli secret will be abandoned.

Signed-off-by: Yogi_Wang <yawang@vmware.com>
2019-04-23 10:11:07 +08:00
FangyuanCheng
8cf0d58f1f Modify some issues of test ping registry and edit registry
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2019-04-23 01:31:45 +08:00
FangyuanCheng
1d4a7d8127 Add tooltips for creating replication rule
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2019-04-23 00:32:59 +08:00
Steven Zou
ad68a3f79d update the code of other components influenced by the js code change
Signed-off-by: Steven Zou <szou@vmware.com>
2019-04-22 22:21:49 +08:00
Steven Zou
3937c8b0dc Merge branch 'master' into fix_issues_for_jobservice 2019-04-22 19:26:51 +08:00
Steven Zou
fae5d1304d add more/refacotr current test cases of job service
Signed-off-by: Steven Zou <szou@vmware.com>
2019-04-22 19:24:37 +08:00
Daniel Jiang
1fdc2e6ba9 Provide API to generate CLI secret
This commit provide an API to allow a user that is onboarded via OIDC
authn update his CLI secret.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2019-04-22 13:34:12 +08:00
Steven Zou
6f8a80d21c refine the hook event and status update retry approach
Signed-off-by: Steven Zou <szou@vmware.com>
2019-04-20 15:00:32 +08:00
Wenkai Yin
aa3b07df69
Merge pull request #7454 from pureshine/fix-duration
Fix failed executions does not show duration
2019-04-20 09:14:16 +08:00
Steven Zou
c6a509b3dd exec dep ensure
Signed-off-by: Steven Zou <szou@vmware.com>
2019-04-19 21:22:37 +08:00
Steven Zou
8e734407c0 Merge branch 'master' into fix_issues_for_jobservice 2019-04-19 21:15:21 +08:00
Steven Zou
ea34bcc950 add retry for status switching
Signed-off-by: Steven Zou <szou@vmware.com>
2019-04-19 21:14:09 +08:00
FangyuanCheng
f2316601d8 Fix duration missed for failed jobs
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2019-04-19 17:48:27 +08:00
Wenkai Yin
5c944d98d5 Fix bug found in replication
Call filterResources direclty if resource isn't null in copy flow

Signed-off-by: Wenkai Yin <yinw@vmware.com>
2019-04-19 17:32:50 +08:00
Steven Zou
e92164c886
Merge pull request #7442 from ywk253100/190418_replication_bug_fix
Fix bug in replication
2019-04-19 17:04:34 +08:00
stonezdj(Daojun Zhang)
36d13e8243
Merge pull request #7328 from stonezdj/debts
Fix issue 6450 Test LDAP server error without save configuration
2019-04-19 16:51:57 +08:00
Yuan Lei
8205e87d4d fix a small issue, that if there is no manifest in huawei image repository, should return false rather than err
Signed-off-by: Yuan Lei <371304458@qq.com>
2019-04-19 16:16:10 +08:00
Daniel Jiang
6b45b5ef7c
Merge pull request #7451 from reasonerjt/oidc-logout
Skip verifying OIDC token for local user
2019-04-19 14:55:26 +08:00
Steven Zou
38e6df4edb fix code style issues: missing comments
Signed-off-by: Steven Zou <szou@vmware.com>
2019-04-19 14:16:08 +08:00
Steven Zou
f8feaa192e add get scheduled and periodic executions APIs
Signed-off-by: Steven Zou <szou@vmware.com>
2019-04-19 13:54:23 +08:00
Wenkai Yin
cf5cd5902f Fix bug in replication
1. Fix bug when creating the namespace
2. Keep the same logic for hiding access secret
3. Filter only push mode policies for event trigger

Signed-off-by: Wenkai Yin <yinw@vmware.com>
2019-04-19 13:34:04 +08:00
Wenkai Yin
3738b0a984
Merge pull request #7439 from wy65701436/pin-error
Pin pkg error version to v0.8.1
2019-04-19 13:16:47 +08:00
Daniel Jiang
5292aea89e Skip verifying OIDC token for local user
If a user does not have OIDC meta data in DB, it means he's not
onboarded via OIDC authn, hence, we should not check the token.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2019-04-19 13:07:06 +08:00
Steven Zou
d2c4f19a4c
Merge pull request #7450 from yuanshuhan/replication_ng
add huawei adapter to replication module, and adjust some interface a…
2019-04-19 12:52:21 +08:00
Wenkai Yin
059b75e97c
Merge pull request #7392 from reasonerjt/oidc-logout
Handle OIDC user invalidation from OIDC provider.
2019-04-19 12:46:36 +08:00
Fangyuan Cheng
efca5631fe
Merge pull request #7447 from pureshine/fix-bug
Fix replication tasks page cannot pagination
2019-04-19 12:10:50 +08:00
FangyuanCheng
87c2684724 Fix replication tasks page cannot pagination
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2019-04-19 11:40:10 +08:00
Yuan Lei
7ee009f1d2 add huawei adapter to replication module, and adjust some interface after testing
Signed-off-by: Yuan Lei <371304458@qq.com>
2019-04-19 10:05:39 +08:00
Daniel Jiang
239b33c5fb Handle OIDC user invalidation from OIDC provider.
Ths commmit ensures that when user's token is invalidated OIDC provider, he
cannot access protected resource in Harbor with the user info in his session.
We share the code path with secret verification b/c the refresh token
can be used only once, so it has to be stored in one place.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2019-04-19 01:27:31 +08:00
De Chen
4ce2ba8688 Support image delete in DockerHub adapter (#7422)
Signed-off-by: cd1989 <chende@caicloud.io>
2019-04-18 18:24:42 +08:00
De Chen
c3375e4ac2 Fix create ns failure in DockerHub (#7421)
Signed-off-by: cd1989 <chende@caicloud.io>
2019-04-18 18:24:28 +08:00
wang yan
d410a964a5 Pin pkg error version to v0.8.1
Signed-off-by: wang yan <wangyan@vmware.com>
2019-04-18 17:49:04 +08:00
Steven Zou
608354dd04 refine the returnning errors
Signed-off-by: Steven Zou <szou@vmware.com>
2019-04-18 17:15:55 +08:00
Steven Zou
16f97326ad
Merge pull request #7433 from goharbor/replication_ng
Merge the replication ng branch to master
2019-04-18 16:35:45 +08:00
FangyuanCheng
33852973e3 Hide vulnrability if clair is not installed
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2019-04-18 16:03:31 +08:00
Steven Zou
1f481e492c Refactor job servcie primary logic to fix related bugs
Signed-off-by: Steven Zou <szou@vmware.com>
2019-04-18 16:02:49 +08:00
FangyuanCheng
f7f5298ba2 Fix replication ui relate issues
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2019-04-18 15:06:11 +08:00
stonezdj
41a574e55c Fix issue 6450 Test LDAP server error without save configuration
Signed-off-by: stonezdj <stonezdj@gmail.com>
2019-04-18 14:24:21 +08:00
wang yan
ba76550d14 Disable throw internal error to UI
Signed-off-by: wang yan <wangyan@vmware.com>
2019-04-18 00:04:19 +08:00
慕薇疯魔
bf28e9779b 1. check is repository exist later at filterTags.
2. test case for image not found.

Signed-off-by: 慕薇疯魔 <kfanjian@gmail.com>
2019-04-17 23:01:44 +08:00
Wenkai Yin
7196abc77b
Merge pull request #7417 from pureshine/replication-case
Reload the task list when the task status is pending and scheduled
2019-04-17 20:03:36 +08:00
Wenkai Yin
a5cc228781
Merge pull request #7420 from ywk253100/190417_revert_local_harbor
Update the migration sql
2019-04-17 19:58:31 +08:00
Wenkai Yin
eb00c9cb70
Merge pull request #7404 from jwangyangls/replication_C
In add or edit replication page ,disable the mode of pull and push when editing the replication and delete src_namespaces and delete useless code and add a validate content that when I choose scheduled, the cron field is mandatory.
2019-04-17 19:11:46 +08:00
FangyuanCheng
f776e6de2c Reload the task list when the task status is pendding and scheduled
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2019-04-17 19:10:23 +08:00
wang yan
ddec7bd645 fix error handlering in job notification
Signed-off-by: wang yan <wangyan@vmware.com>
2019-04-17 18:19:01 +08:00
wang yan
e017294f71 merge with master latest
Signed-off-by: wang yan <wangyan@vmware.com>
2019-04-17 17:52:39 +08:00
Wenkai Yin
547c2337de Update the migration sql
1. Update the migration sql
2. Rename the ResourceRepository from repository to image

Signed-off-by: Wenkai Yin <yinw@vmware.com>
2019-04-17 17:18:03 +08:00
Yogi_Wang
8f152392b5 Change new and edit Replication page about pull and push mode.
1.disable the mode of pull and push when editing the replication;
2.delete src_namespaces
3.delete useless code
Signed-off-by: Yogi_Wang <yawang@vmware.com>
2019-04-17 16:57:03 +08:00
Wang Yan
a6af9e9972
Support well-formatted error returned from the REST APIs. (#6957)
Signed-off-by: wang yan <wangyan@vmware.com>
2019-04-17 16:43:06 +08:00
jwangyangls
cc868aa23e
Merge pull request #7407 from jwangyangls/fixHelmChartRouteIssue
Recovery a test case about 'should filter data by keyword' in the test file named repository-gridview.component.spec.ts
2019-04-17 15:24:56 +08:00