Commit Graph

10779 Commits

Author SHA1 Message Date
Daniel Jiang
422894a0f5 Remediate the empty subiss problem
This commit include 2 changes to mitigate and remediate the problem
described in #15241

1. When the token is to be updated in the "oidc_user" table, make sure
   only the column "token" will be udpated.
2. Restore the subiss column for the record that has this column cleared
   by mistake, by decoding the persisted token.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2021-07-16 00:07:47 +08:00
danfengliu
14ff3b2ca4 Add trigger file for building base
If build base images is needed in a unexpected situation, build base images action will be triggered by making a modification of .buildbaselog.

Signed-off-by: danfengliu <danfengl@vmware.com>
2021-07-15 17:22:37 +08:00
DQ
b7128a6afa Fix regex parsing IP issue in test scirpt
add `^` to constraint IP addr matching only when the pattern start from the begining

Signed-off-by: DQ <dengq@vmware.com>
2021-07-15 16:12:03 +08:00
danfengliu
5d11d61154
Merge pull request #15302 from danfengliu/fix-replication-test-issue-in-nightly
Fix replication test issue in nightly
2021-07-15 10:37:05 +08:00
stonezdj(Daojun Zhang)
2fa530eefa
Merge pull request #15247 from stonezdj/21jun30_remove_auth_user
Delete users under auth_mode other than db_auth
2021-07-14 13:25:43 +08:00
xaleeks
bbebaef90d
Merge pull request #15311 from reasonerjt/update-support-matrix
Update RELEASES doc
2021-07-14 00:32:43 -04:00
Daniel Jiang
8d31c97811 Update RELEASES doc
This updates support matrix to make it up to date.
It also update the upgrade path section to use 2.x as examples.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2021-07-14 11:17:52 +08:00
孙世军
8fb76689ab
Update UI to support deleting OIDC users (#15305)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2021-07-13 15:28:53 +08:00
Wang Yan
f7a4401dcb
deprecate version 1 robot account (#15296)
1, deprecate support for version 1 robot support, the robotv1 cannot be used anymore.
2, reserve the /project/{id_or_name}/robots api.

After the PR, user cannot use the robotv1 to login, and do any interaction with Harbor,
but still can view & delete them with UI or API.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2021-07-13 13:39:44 +08:00
Daniel Jiang
3e502ec9a4
Merge pull request #15196 from sixeIa/fix-basedn-empty
Add SearchDN error, mark field as required in UI
2021-07-12 12:32:52 +08:00
stonezdj
c163bc8317 Delete users under auth_mode other than db_auth
The following information should cleanup before delete user:
  Delete project member of this user.
  Delete oidc_user when auth_mode is oidc_auth.
  Fixes #8424
  It also removes the deleted user from project member and the deleted condition in the project member query for consistency
Signed-off-by: stonezdj <stonezdj@gmail.com>
2021-07-12 11:31:40 +08:00
stonezdj(Daojun Zhang)
7b84f4e137
Merge pull request #15270 from stonezdj/21jun05_fix_rest_int_parse_fail
Fix invalid syntax errors when int value is convert to scientific notation
2021-07-11 21:00:06 +08:00
danfengliu
8947a62dc4 Fix replication test issue in nightly
Signed-off-by: danfengliu <danfengl@vmware.com>
2021-07-11 17:54:55 +08:00
Alexis L
2ce814329b
Merge branch 'goharbor:master' into fix-basedn-empty 2021-07-09 22:32:35 +02:00
Alexis
d6283ee913
Add SearchDN error, mark field as required in UI
Signed-off-by: Alexis <60alexis@gmail.com>
2021-07-09 22:30:52 +02:00
ChenYu Zhang
304aff33db
Merge pull request #15280 from chlins/fix/p2p-task-time-format
fix(p2p): adjust task time format
2021-07-09 16:29:09 +08:00
Wang Yan
248be37c3e
clean code of common util (#15287)
Remove the useless code from the common util

Signed-off-by: Wang Yan <wangyan@vmware.com>
2021-07-09 15:35:05 +08:00
Kevin Schu
03b7b01f77 reverted unintentional committed change
Signed-off-by: Kevin Schu <kevin.schu@aoe.com>
2021-07-08 15:43:14 +02:00
Kevin Schu
0679f4701e if username is not available in remote, fall back to username from token
Signed-off-by: Kevin Schu <kevin.schu@aoe.com>
2021-07-08 15:36:18 +02:00
Wang Yan
494d74d32d
bump up go version to 1.16 (#15286)
Signed-off-by: Wang Yan <wangyan@vmware.com>
2021-07-08 16:25:15 +08:00
Wang Yan
cdb7f4514e
fix cross mount conformance test (#15274)
fixes #15273

set the cross mount namespace for conformance test, the default vaule cannot pass the reponame validation.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2021-07-08 15:11:01 +08:00
chlins
f93fc2aa0b fix(p2p): adjust task time format
Signed-off-by: chlins <chlins.zhang@gmail.com>
2021-07-07 21:39:46 +08:00
Wang Yan
b158086642
fix conformance failure (#15261)
fixes #15252

Give 404 for invalid digest when to get/head manifest

Signed-off-by: Wang Yan <wangyan@vmware.com>
2021-07-06 15:11:13 +08:00
stonezdj
41968091a2 Fix invalid syntax errors when int value is convert to scientific notation
Add parseInt function to parse the scientific notation

Signed-off-by: stonezdj <stonezdj@gmail.com>
2021-07-05 22:20:00 +08:00
Jiaolin Yang
ddb6619769
Merge pull request #15245 from ilyee/typo
Fix commentline typos in src/pkg/repository/model/model.go
2021-07-05 16:38:11 +08:00
Steven Zou
4ddaecdc3f
Merge pull request #15238 from chlins/fix/create-p2p-policy-permission
fix(p2p): fix p2p create policy permission
2021-07-05 11:04:28 +08:00
danfengliu
646ca80187
Fix nightly test failures broken by UI change (#15233)
1. Fix break of byte statistic unit changing;
2. Fix OIDC login UI changing.

Signed-off-by: danfengliu <danfengl@vmware.com>
2021-07-02 10:19:43 +08:00
elihe
426f7bc7bc Fix commentline typos in src/pkg/repository/model/model.go
Signed-off-by: elihe <elihe@tencent.com>
2021-07-02 10:12:15 +08:00
孙世军
bb57264f11
Improve login page for OIDC (#15214)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2021-07-02 09:42:04 +08:00
Kevin Schu
4147fbeba0 subiss needs to be part of selected fields, otherwise this attribute would be empty and will cause issues when working with the user object later on.
Signed-off-by: Kevin Schu <kevin.schu@aoe.com>
2021-07-01 15:12:28 +02:00
Wang Yan
29ccdff766
add retry for blob & manifest deletion in GC (#15235)
Fixes #15197

To handle the blob & manifest deletion error, add 1 minute retry.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2021-07-01 18:49:40 +08:00
chlins
f1456558db fix(p2p): fix p2p create policy permission
Signed-off-by: chlins <chlins.zhang@gmail.com>
2021-07-01 16:14:26 +08:00
stonezdj(Daojun Zhang)
4e1f6633af
Merge pull request #15229 from stonezdj/21jun28_update_swagger_search_group
Add ldap_group_dn parameter to search group with ldap group dn
2021-06-30 14:04:21 +08:00
Daniel Jiang
f6f9d714a2
Merge pull request #15230 from stonezdj/21jun29_ldap_verify_cert
Change XXXConfigItem cannot be omitted when empty
2021-06-30 11:40:42 +08:00
孙世军
91f4d412f0
Improve i18n service (#15215)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2021-06-30 10:22:48 +08:00
孙世军
f902db9d85
Change quota unit to Mebibyte (#15220)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2021-06-30 10:22:32 +08:00
stonezdj
a29bdd0b32 Change XXXConfigItem cannot be omitted when empty
Fixes #15206
 Includes:StringConfigItem, BoolConfigItem, IntegerConfigItem

Signed-off-by: stonezdj <stonezdj@gmail.com>
2021-06-29 21:50:39 +08:00
stonezdj
fcd2fbcfe7 Add ldap_group_dn parameter to search group with ldap group dn
Fixes #15171
 Cannot use q.Query because ldap_group_dn contains comma(,) and equal(=), which are reserved characters in q.Query

Signed-off-by: stonezdj <stonezdj@gmail.com>
2021-06-29 20:20:47 +08:00
孙世军
ff11cbafa1
Improve event log component (#15191)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2021-06-29 18:15:17 +08:00
Steven Zou
2a3b91a11a
Merge pull request #15217 from wy65701436/joblog-ref
refactor job log
2021-06-29 17:44:17 +08:00
Daniel Jiang
001e3cc01e
Merge pull request #15223 from wy65701436/notary-go14
roll back go for notary binary
2021-06-29 17:13:15 +08:00
Wang Yan
4017e995b7 roll back go for notary binary
Fixes #14932

Harbor recompiles the notary v0.6.1 with go 1.15 from v2.2.0, which introduces an break change that leads to notary key not found after migration.

[Root cause]
Notary v0.6.1 consumed an old version dvsekhvalnov/jose2, which is not compatible with go 1.15.

[References]
https://github.com/dvsekhvalnov/jose2go/issues/26
https://github.com/golang/go/issues/41089

[Resolve]
To resolve this issue, we have to roll back go vesrion to v1.14 for notary v0.6.1 binary and keep it until upstream have a patch release to support go 1.15 or above.

[Break change]
If you pushed and signed image using Harbor v2.2.0 ~ v2.2.2 and created new repository key in notary, you will encouter the same issue after migrate to v2.2.3(or above) or v2.3.1(or above) because of the go version downgrade. We will have a FAQ to help you to resovle this particular scenario.

The influence path of the particular case:
Harbor v2.1.0(or lower) --> [v2.2.0 ~ v2.2.2] --> v2.2.3(or above)
Harbor v2.1.0(or lower) --> v2.3.0 --> v2.3.1(or above)

The non influence path of the paticular case:
Harbor v2.1.0(or lower) --> v2.2.3(or above)
Harbor v2.1.0(or lower) --> v2.3.1(or above)

[Fix in Version]
Harbor v2.2.3 or above
Harbor v2.3.1 or above

[Note]
If you're a heavy user of notary, avoid using v2.2.0, v2.2.1, v2.2.2 and v2.3.0, and use the fixed version for instead.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2021-06-29 16:18:55 +08:00
stonezdj(Daojun Zhang)
08d47f471a
Move genyaml to cmd/swagger (#15062)
Signed-off-by: stonezdj <stonezdj@gmail.com>
2021-06-29 14:29:03 +08:00
Wang Yan
1abe978e87 refactor job log
Move job service logger to new program model

Signed-off-by: Wang Yan <wangyan@vmware.com>
2021-06-29 13:37:45 +08:00
Alexis L
573d97f15b
Add TiB support for display, fix unit to correct one (#15201)
* Add TiB support for display, fix unit to correct one

Signed-off-by: Alexis <60alexis@gmail.com>

* Fix unit test

Signed-off-by: Alexis <60alexis@gmail.com>
2021-06-29 10:40:30 +08:00
孙世军
b789674ada
Fix css bug for disabled checkbox (#15181)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2021-06-23 17:13:41 +08:00
孙世军
33301ec65e
Enhance swagger UI (#15168)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2021-06-23 16:28:14 +08:00
孙世军
0464305bcc
Bump up UI version to v2.4.0 (#15174)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2021-06-23 16:27:40 +08:00
danfengliu
89ab612aa7
Merge pull request #15180 from danfengliu/fix-replication-verification-keyword-in-nightly
Increase retry times for checking replication result
2021-06-23 13:57:57 +08:00
danfengliu
65663cae52 Increase retry times for checking replication result
Signed-off-by: danfengliu <danfengl@vmware.com>
2021-06-23 09:49:34 +08:00