Upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor.git synced 2024-12-19 15:17:43 +01:00
Code Issues Projects Releases Wiki Activity
5,693 Commits 55 Branches 319 Tags 338 MiB
9d5cf57373
Commit Graph

1962 Commits

Author SHA1 Message Date
Daniel Jiang
1188bd89b9 Use secure transport to access HTTP endpoint 
In various parts of the code, we used insecure transport in http Client
when we assume the endpoint is http.  This causes complaints form
security scanner.  We should use secure transport in such cases.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2018-10-10 17:51:02 +08:00
Qian Deng
7116baabed
Merge pull request #6001 from zhoumeina/fix_console_error_gc 
replace Observable.throw to observableThrowError to avoid undefined e…
 2018-10-10 16:19:38 +08:00
wang yan
a4ad4c7282 Fix gc api issues 
1, filter out the scan all jobs in the gc list.
2, make it able to delete unexecuted scheduler.

Signed-off-by: wang yan <wangyan@vmware.com>
 2018-10-10 15:45:03 +08:00
Mia ZHOU
a8d39c0b05
Merge pull request #5989 from ninjadq/add_buttons_to_chart_list_view 
Add buttons to chart list view
 2018-10-10 15:08:37 +08:00
Meina Zhou
1487b649ff replace Observable.throw to observableThrowError to avoid undefined error 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-10-10 15:05:41 +08:00
Qian Deng
b9697df44a Add download latest version button 
Add download button in chart list view to download latest chart

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-10-10 11:23:09 +08:00
Meina Zhou
081921cf89 refactor gauge component using angular way,remove jquery 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-10-10 10:49:20 +08:00
Qian Deng
2011e606fc Add delete chart button 
Add delete chart button to remove all version of seleted charts

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-10-09 15:42:35 +08:00
陈德
b648084d95 Improve code styles and fix after Harbor refactoring 
Signed-off-by: 陈德 <chende@caicloud.io>
 2018-10-09 10:49:03 +08:00
陈德
03d5157eaf Updae retag api spec 
Signed-off-by: 陈德 <chende@caicloud.io>
 2018-10-08 19:07:23 +08:00
陈德
75f1cdb449 Update swagger file to add retag API 
Signed-off-by: 陈德 <chende@caicloud.io>
 2018-10-08 19:07:22 +08:00
陈德
48d2435146 Fix notification event filtered because of user agent 
Signed-off-by: 陈德 <chende@caicloud.io>
 2018-10-08 19:07:22 +08:00
陈德
03af3c5936 Add image retag API 
Signed-off-by: 陈德 <chende@caicloud.io>
 2018-10-08 19:07:21 +08:00
James Zabala
e09a157dce
Merge pull request #5896 from erks/normalize_ldap_group_dn 
Normalize (make lowercase) ldap_group_dn during onboarding
 2018-10-02 16:03:03 -04:00
James Zabala
ce0e195d18
Merge pull request #5957 from reasonerjt/scan-all-jobsvc 
Schedule "scan all" via jobservice
 2018-10-02 15:31:42 -04:00
James Zabala
a9dcd7c475
Merge pull request #5967 from gnomeontherun/remove-bootstrap 
Remove unused Bootstrap from portal dependencies
 2018-10-02 15:29:58 -04:00
Daniel Jiang
b12dc3b5d8 Schedule "scan all" via jobservice 
This commit leverage the jobservice to trigger "scan all" and
gets rid of the local scheduler to make the harbor-core container
stateless.
It keeps using the notifer mechanism to handle the configuration change.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2018-09-28 15:42:37 +08:00
Fangyuan Cheng
832bbc3b9b
Merge pull request #5965 from pureshine/package 
Refactor and improve the format of vulnerability scan report
 2018-09-28 15:25:53 +08:00
Cheng
033523d223 Refactor and improve the format of vulnerability scan report 
Signed-off-by: Cheng <fangyuanc@vmware.com>
 2018-09-28 14:28:28 +08:00
Jeremy Wilken
329072bbb9 Remove unused Bootstrap from portal dependencies, add jQuery which was implicitly depended upon 
Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>
 2018-09-27 14:20:45 -05:00
Steven Zou
55c50f310d Fix #5956 issue: The APIs should not get chart information when Harbor is not installed with chart repo 
Signed-off-by: Steven Zou <szou@vmware.com>
 2018-09-27 13:22:25 +08:00
Mia ZHOU
1173955200
Merge pull request #5950 from pureshine/replication_dialog 
Make the replication dialog a little bit wider
 2018-09-26 16:47:47 +08:00
Cheng
79e5abe2df Make the replication dialog a little bit wider 
Signed-off-by: Cheng <fangyuanc@vmware.com>
 2018-09-26 14:14:12 +08:00
Meina Zhou
03d0ad0faf fresh page after job finished 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-09-26 13:07:41 +08:00
Cheng
98cba2a1a9 Make the replication dialog a little bit wider 
Signed-off-by: Cheng <fangyuanc@vmware.com>
 2018-09-26 12:50:24 +08:00
Cheng
f3cc7676ef Make the replication dialog a little bit wider 
Signed-off-by: Cheng <fangyuanc@vmware.com>
 2018-09-26 12:23:29 +08:00
Cheng
f1648602d5 Make the replication dialog a little bit wider 
Signed-off-by: Cheng <fangyuanc@vmware.com>
 2018-09-26 12:10:47 +08:00
Daniel Jiang
8e438d81d1
Merge pull request #5945 from steven-zou/provide_total_count_of_charts 
Return the total count of charts under the project in project API
 2018-09-25 18:32:29 +08:00
Steven Zou
8b538cbc0a Return the total count of charts under the project in project API 
- add new interface method to get total count of charts under namespaces by calling get index
- add new field 'chart_count' in project model
- append chart count to the project model in project API

Signed-off-by: Steven Zou <szou@vmware.com>
 2018-09-25 17:56:11 +08:00
Cheng
d9ac235fb2 Revert replication dialog 
Signed-off-by: Cheng <fangyuanc@vmware.com>
 2018-09-25 15:06:07 +08:00
Daniel Jiang
0699980924 Add Scan All job to job service (#5934) 
This commit adds the job to scan all images on registry.
It also makes necessary change to Secret based security context, to
job service has higher permission to call the API of core service.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2018-09-22 13:07:32 +08:00
Wenkai Yin
978f8721e6
Merge pull request #5927 from steven-zou/return_labels_in_chart_api 
Refactor the chart service implementation to provide more extending flexibilities
 2018-09-21 15:59:53 +08:00
Qian Deng
0cb430d463
Merge pull request #5932 from ninjadq/refactor_auth_api 
Refactor backend api for authrization
 2018-09-21 15:59:07 +08:00
Qian Deng
88bb461314 Reactor backend api for authrization 
1. Change backend api
2. Change frontend api
3. Change the proxy config file

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-09-21 14:03:17 +08:00
Steven Zou
78b9cbf35e Fix failures of UT cases of chart API related 
Signed-off-by: Steven Zou <szou@vmware.com>
 2018-09-21 14:02:45 +08:00
Meina Zhou
d8b917c097 Modify some small issues in gc ui 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-09-21 09:41:06 +08:00
Daniel Jiang
6c84a3dc4f
Merge pull request #5690 from goharbor/clouderati-copyright-update 
Updating copyright notices
 2018-09-20 19:38:26 +08:00
Steven Zou
d4c423ea8e Merge branch 'master' into return_labels_in_chart_api 2018-09-20 17:55:48 +08:00
Steven Zou
24c0be789d Add more UT cases for changed chart API 
- add more cases in the ChartRepositoryAPI controller
- move chart utility testing functions to a separate go file under testing
- ignore testing coverage for testing folder
- update other UT cases to reflect the change of adding chart testing utility functions

Signed-off-by: Steven Zou <szou@vmware.com>
 2018-09-20 17:51:27 +08:00
Cheng Fangyuan
8192bf2d62
Merge pull request #5930 from pureshine/modify_dropdown 
After selecting color, the color button is closed
 2018-09-20 14:55:15 +08:00
Cheng
3568673e85 After selecting color, the color button is closed 
Signed-off-by: Cheng <1309173081@qq.com>
 2018-09-20 14:10:40 +08:00
Cheng
e47e17ed3f After selecting color, the color button is closed 
Signed-off-by: Cheng <1309173081@qq.com>
 2018-09-20 14:09:05 +08:00
Mia ZHOU
f49ae02a1a
Merge pull request #5925 from zhoumeina/gc_ui 
Implementation of  GC UI
 2018-09-20 13:46:54 +08:00
Meina Zhou
aefb97dec8 Implement gc UI 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-09-20 13:21:22 +08:00
De Chen
970d84f1b9 Add comment format check to makefile and travis (#5832) 
* Add comment format check to makefile and travis

Signed-off-by: 陈德 <chende@caicloud.io>
 2018-09-20 11:48:38 +08:00
Cheng
7d9c6287b3 After selecting color, the color button is closed 
Signed-off-by: Cheng <1309173081@qq.com>
 2018-09-20 11:15:30 +08:00
Steven Zou
e6de7f080d Rename the import path of new package 'label' 
Signed-off-by: Steven Zou <szou@vmware.com>
 2018-09-20 10:31:29 +08:00
clouderati
587459df15 Replacing copyright notices with "Copyright Project Harbor Authors". 
Signed-off-by: clouderati <35942204+clouderati@users.noreply.github.com>
 2018-09-19 16:59:36 +00:00
Steven Zou
3a204dbf7d Rebase to fix conflicts 2018-09-19 17:46:47 +08:00
Qian Deng
7873a0312a Rename harbor-ui to harbor-core 
1. Update the nginx.conf
2. Update Makefile
3. Update docker-compose
4. Update image name
5. Rename folder ui to core
6. Change the harbor-ui's package name to core
7. Remove unused static file on harbor-core
8. Remove unused code for harbor-portal

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-09-19 16:35:13 +08:00
Steven Zou
df241c0666 Refactor the chart service implementation to provide more extemding flexibilities 
- use unified proxy handler to handle all the proxy traffic
- define interfaces for the handlers
- implement the interface at chart controller level
- refactor UT cases
- update other related reference code

Signed-off-by: Steven Zou <szou@vmware.com>
 2018-09-19 16:34:58 +08:00
Yan
29ca31cf6c
Update gc api to fix issues found by UI implemention (#5920) 
This commit is to update gc api to fix issues found by UI implemention:
1, Return json format of gc schedule
2, Unify capital and small letter
3，Return gc records by desc

Signed-off-by: wang yan <wangyan@vmware.com>
 2018-09-19 14:36:47 +08:00
Touch Ungboriboonpisal
e256547411 Normalize (make lowercase) the ldap group dn when onboarding 
Fixes #5895

Signed-off-by: Touch Ungboriboonpisal <tungbori@zynga.com>
 2018-09-18 13:37:35 -07:00
Cheng Fangyuan
262de58c55
Merge pull request #5898 from pureshine/modify_tooltips 
Modify the tooltip to increase and display the full content
 2018-09-18 18:28:23 +08:00
Cheng Fangyuan
6a0ccae913
Merge pull request #5903 from pureshine/modify_text 
Tooltip prompts 'repository read only'
 2018-09-18 17:46:32 +08:00
Cheng Fangyuan
407b46801b
Merge pull request #5899 from pureshine/modify_space 
Make the space between the button and the tab section consistent
 2018-09-18 17:44:47 +08:00
Cheng
27a5df5c90 Modify the tooltip to increase and display the full content 
Signed-off-by: Cheng <1309173081@qq.com>
 2018-09-18 14:02:31 +08:00
Cheng
efc3937368 Make the space between the button and the tab section consistent 
Signed-off-by: Cheng <1309173081@qq.com>
 2018-09-18 13:52:11 +08:00
Cheng
b9dae3f156 Make the space between the button and the tab section consistent 
Signed-off-by: Cheng <1309173081@qq.com>
 2018-09-18 13:45:33 +08:00
Cheng
76c66a9dea Tooltip prompts 'repository read only' 
Signed-off-by: Cheng <1309173081@qq.com>
 2018-09-18 11:58:23 +08:00
Cheng
014a81da68 Modify the tooltip to increase and display the full content 
Signed-off-by: Cheng <1309173081@qq.com>
 2018-09-18 11:37:35 +08:00
Cheng Fangyuan
8250bce9c5
Merge pull request #5897 from pureshine/modify_sort 
Remove the sort of project and endpoint name
 2018-09-18 10:21:26 +08:00
Cheng
d2f1681943 Tooltip prompts 'repository read only' 
Signed-off-by: Cheng <1309173081@qq.com>
 2018-09-17 15:52:57 +08:00
Cheng
61298e2673 Make the space between the button and the tab section consistent 
Signed-off-by: Cheng <1309173081@qq.com>
 2018-09-17 15:27:08 +08:00
Cheng
34e66a709e Modify the tooltip to increase and display the full 
Signed-off-by: Cheng <1309173081@qq.com>
 2018-09-17 10:54:30 +08:00
Cheng
9b8bc80012 fiexed by pr: #5472 Remove the sort of project and endpoint name 
Signed-off-by: Cheng <1309173081@qq.com>
 2018-09-17 09:54:50 +08:00
Mia ZHOU
424f5f80a7
Merge pull request #5892 from pureshine/modify_button 
Disable delete button when there is no group
 2018-09-14 17:00:23 +08:00
Wenkai Yin
dfcd6f044d
Merge pull request #5888 from steven-zou/mark_labels_to_chart 
Add API to support marking labels to charts
 2018-09-14 15:09:46 +08:00
Cheng
b8f9b71d89 Disable delete button when there is no group 
Signed-off-by: Cheng <1309173081@qq.com>
 2018-09-14 13:36:22 +08:00
Steven Zou
7b8fe27c22 Add API to support marking labels to charts 
- add related chart label API entries
- extract label related functionalities to a separate manager interface
- add a base controller for label related actions
- add related UT cases

Signed-off-by: Steven Zou <szou@vmware.com>
 2018-09-14 13:27:50 +08:00
Wenkai Yin
89893779fb Support configuring sslmode for the connection of database (#5861) 
The sslmode of the connection with postgresql is hardcoded as "disable" currently, this commit expose it as an environment variable so that users can configure it

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2018-09-14 13:05:05 +08:00
chengfangyuan
00c225f374 Make the replication dialog a little bit wider 
Signed-off-by: chengfangyuan <1309173081@qq.com>
 2018-09-14 10:07:39 +08:00
Qian Deng
8cdd2d29d9
Merge pull request #5862 from ninjadq/fix_rebot_case_for_angular6 
Fix xpath in robot case
 2018-09-11 10:20:08 +08:00
Qian Deng
dfeb1924c6 Fix xpath in robot case 
1. Fix xpath of Upload button
2. Fix xpath of status span

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-09-10 17:24:28 +08:00
Qian Deng
7a8c1bfbac
Merge pull request #5854 from zhoumeina/fix_remove_static 
remove static after angular 6 ugprade
 2018-09-10 16:58:06 +08:00
Wenkai Yin
1f195c2b5f
Merge pull request #5840 from Colstuwjx/fix-tcp-probe 
Fix `TestTCPConn` break issue.
 2018-09-10 14:46:04 +08:00
Meina Zhou
232a8f390a remove static after angular 6 ugprade 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-09-10 14:39:09 +08:00
Qian Deng
ac6c9d79ba Remove nodeclarity 
Remove the nodeclarity container related code and ui_builder parameter no longer needed when build clarity

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-09-08 20:33:21 +08:00
Qian Deng
8c26f78ae4 Fix tslint fail issues 
Fix issues that cause tslint fail

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-09-08 14:58:50 +08:00
Qian Deng
0578d51437 Remove clarity logo 
Replace favicon to harbor logo

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-09-07 17:37:05 +08:00
Qian Deng
aff8521c18 Add i18n to static assets 
Add i18n files to static asset

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-09-07 16:13:37 +08:00
Qian Deng
9f90306600 Merge branch 'angular6' of https://github.com/vmware/harbor into angular6 2018-09-07 16:12:33 +08:00
Qian Deng
ba4762095f Update dockerfile of portal based on angular6 upgrade 
1. Update entrypoint to reflect angular 6 upgrade

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-09-07 15:06:15 +08:00
Qian Deng
db8d7b9c1c Merge branch 'seprate_harbor_portal_from_harbor_core' into angular6 2018-09-07 14:56:16 +08:00
Qian Deng
d797c50438 Fix trivial issues about rename ui_ng to portal 
Update ui_ng to portal

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-09-07 13:25:41 +08:00
Qian Deng
870653a5fb Update nginx config to redirect traffic to specific backend 
1. Update nginx.conf file
2. Update photon makefile
3. Update global makefile

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-09-07 13:21:27 +08:00
Qian Deng
dc21f3f5e2 Add container for harbor-portal 
1. Add dockerfile for building harbor-portal
2. change the name from ui_ng to harbor-portal

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-09-07 13:20:08 +08:00
Meina Zhou
94f967e054 remove ng-package and use angular command to build lib 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-09-07 11:30:01 +08:00
Meina Zhou
20b4386256 remove rxjs-compat in package 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-09-07 11:30:00 +08:00
Meina Zhou
5c174d5090 fix i18n does not show correctly 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-09-07 11:30:00 +08:00
Meina Zhou
806fbaa49c fix build fail for angular 6 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-09-07 11:30:00 +08:00
Meina Zhou
a330d4e116 upgrade to angular 6 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-09-07 11:30:00 +08:00
Daniel Jiang
cd31cbf892
Merge pull request #5828 from stonezdj/ldap_caseinsense 
LDAP group DN should be case insensitively
 2018-09-07 10:48:31 +08:00
Colstuwjx
e49a9de2f4 Fix TestTCPConn break issue. 
Signed-off-by: Colstuwjx <Colstuwjx@gmail.com>
 2018-09-06 14:58:04 +08:00
Meina Zhou
66d2d25d26 remove ng-package and use angular command to build lib 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-09-06 14:41:50 +08:00
stonezdj
9dca49ba6e LDAP group DN should be case insensitive 
Fix issue #5776, LDAP servers are case insensitive. because only LDAP
group DN is used to compare/equal operation, lowercase all LDAP group DN
when retrieves it from LDAP server, and lowercase them before save in DB

Signed-off-by: stonezdj <stonezdj@gmail.com>
 2018-09-06 11:33:05 +08:00
Wenkai Yin
5427c0064c
Merge pull request #5731 from Colstuwjx/fix-log-test 
Fix logger test case, add SetSkipLine func.
 2018-09-06 08:17:17 +08:00
Colstuwjx
bab203c0f4 Fix logger test case. 
Signed-off-by: Colstuwjx <Colstuwjx@gmail.com>
 2018-09-05 19:25:17 +08:00
陈德
0582db9a82 Apply consistent format for comments 
Signed-off-by: 陈德 <chende@caicloud.io>
 2018-09-05 16:16:31 +08:00
Meina Zhou
0c1ba5a201 remove rxjs-compat in package 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-09-05 14:35:38 +08:00
Meina Zhou
6c8bd45f0b fix i18n does not show correctly 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-09-05 14:17:43 +08:00
Meina Zhou
4abf4e09ea fix build fail for angular 6 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-09-05 09:28:08 +08:00
Wenkai Yin
49bb5cfafb Test TCP connection before upgrading database schema 
This commit moves the database schema upgrading after database initialization. The init will test TCP connection.

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2018-09-05 02:07:47 +08:00
Wenkai Yin
b43024ccbf
Merge pull request #5829 from steven-zou/support_chart_search 
Enhance the global search API to include chart searching result
 2018-09-06 09:58:43 +08:00
Steven Zou
a9f2ff2c91 Enhance the global search API to include chart searching result 
- add chart search interface method in utility handler
- update the search API handler
- update the search API UT case

Signed-off-by: Steven Zou <szou@vmware.com>
 2018-09-05 20:13:27 +08:00
Meina Zhou
888fc21218 upgrade to angular 6 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-09-04 15:36:08 +08:00
陈德
6eb972c383 Add pull scope to post/put/patch method 
Signed-off-by: 陈德 <chende@caicloud.io>
 2018-09-03 11:12:11 +08:00
Daniel Jiang
22c53d9f34
Merge pull request #5761 from wy65701436/fix-4926 
Extend configuration length to 1024 in DB
 2018-08-31 14:50:12 +08:00
wang yan
f8b964d8cf Extend configuration length to 1024 in DB 
Signed-off-by: wang yan <wangyan@vmware.com>
 2018-08-31 13:42:24 +08:00
Steven Zou
7752595313
Merge pull request #5759 from steven-zou/support_delete_chart 
Delete all the versions of the specified chart
 2018-08-30 17:03:08 +08:00
Steven Zou
35603288e1
Merge pull request #5762 from steven-zou/enhance_js_webhook 
Return more data of the job when reporting status info via webhook
 2018-08-30 16:40:13 +08:00
Wenkai Yin
7564214946
Merge pull request #5767 from steven-zou/add_latest_version 
Append latest version of the chart when returning the chart list
 2018-08-30 16:37:44 +08:00
Steven Zou
34f19f437d Delete all the versions of the specified chart 
- add API route
- add DELETE chart method in utility handler of chart controller
- add UT case for the newly added methods
- update swagger.yaml to refelct the new change

Signed-off-by: Steven Zou <szou@vmware.com>
 2018-08-30 16:31:05 +08:00
Steven Zou
12c6f1ada3 Append latest version of the chart when returning the chart list 
- append `LatestVersion` to the `ChartInfo` model
- update the UT case to check the `LatestVersion`

Signed-off-by: Steven Zou <szou@vmware.com>
 2018-08-30 14:43:41 +08:00
Steven Zou
1636b138f2 Return more data of the job when reporting status info via webhook 
- update the status report func `RedisJobStatsManager.reportStatus`
- update the UT case for the above change

Signed-off-by: Steven Zou <szou@vmware.com>
 2018-08-30 14:28:12 +08:00
陈德
a59af8ce82 fix gofmt 
Signed-off-by: 陈德 <chende@caicloud.io>
 2018-08-30 14:11:18 +08:00
陈德
666bd692fe Support repo list sorting 
Signed-off-by: 陈德 <chende@caicloud.io>
 2018-08-30 10:56:50 +08:00
Steven Zou
4bf729caaf Sort the chart list before returning 
- updatet the chart getting API
- update the corresponding UT case

Signed-off-by: Steven Zou <szou@vmware.com>
 2018-08-29 15:26:21 +08:00
wang yan
aab761ac8a Fix gofmt check results 
Signed-off-by: wang yan <wangyan@vmware.com>
 2018-08-29 11:50:00 +08:00
Yan
fca2bb3a6b
Fix misspell checking results (#5749) 
Signed-off-by: wang yan <wangyan@vmware.com>
 2018-08-29 10:25:42 +08:00
Wenkai Yin
93a073ff64
Merge pull request #5695 from cd1989/macos-volume-capacity 
Fix volume capacity when run in MacOS
 2018-08-27 18:17:03 +08:00
陈德
0a62485365 Add comment to source code 
Signed-off-by: 陈德 <chende@caicloud.io>
 2018-08-27 15:18:35 +08:00
Wenkai Yin
2c5b06350e
Merge pull request #5716 from reasonerjt/update-go-import-path 
Update import path in go code
 2018-08-23 19:02:50 +08:00
Daniel Jiang
dcf4e2ee78 Update import path in go code 
vmware -> goharbor

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2018-08-23 17:50:53 +08:00
Steven Zou
d895ebef13
Merge pull request #5705 from steven-zou/fix_redis_parsing_issue 
Fix the issue of parsing redis connection address in chart API
 2018-08-23 15:06:08 +08:00
Steven Zou
d9256e401c Fix the issue of parsing redis connection address in chart API 
- update logic in func parseRedisConfig

Signed-off-by: Steven Zou <szou@vmware.com>

- Add UT case for redis addr parsing func
 2018-08-23 14:03:19 +08:00
Qian Deng
dac86844e4 Add github flavered table in markdown 
Add table style in markdown and
Fix deleted all version may cause 404

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-08-23 11:50:19 +08:00
陈德
ecadd564b1 Fix volume capacity when run in MacOS 
Signed-off-by: 陈德 <chende@caicloud.io>
 2018-08-22 17:31:07 +08:00
Qian Deng
7cf3f286ca
Merge pull request #5632 from ninjadq/fix_ui_issues 
Fix UI related issues
 2018-08-19 11:01:28 +08:00
Qian Deng
d5da3862b2 Refactor upload modal 
Using customized button to replace file input

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-08-17 18:24:08 +08:00
Qian Deng
8cf7d4f822 Fix item number and i18n issues 
Fix item number presentation on Group, charts, chart versions, member group add

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-08-17 16:00:49 +08:00
Daniel Jiang
257a728086
Merge pull request #5648 from ywk253100/180817_session 
Fix "gob: name not registered for interface" error
 2018-08-17 16:00:48 +08:00
Qian Deng
317a01fa99 Fix i18n translate with parameter not work problem 
The first parameter to translate should be the i18n key

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-08-17 16:00:48 +08:00
Qian Deng
6d91a0d66e Fix Group related issues 
1. Fix Ldap group name to required item
2. Edit Group DN is not allowed

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-08-17 16:00:48 +08:00
Qian Deng
07da2fd5d6 Edit the wording of version 
1. Fix word of app version on summary page
2. Fix version on version cart view

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-08-17 16:00:48 +08:00
Qian Deng
b98af169af Fix chart upload related issues 
1. Chart will reset when open modal
2. Empty chart shouldn't trigger upload action

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-08-17 16:00:48 +08:00
Qian Deng
4ecea1f5ad Fix incorrect UI views when logging in with a user in the group assigned with proper role 
This caused by project routing guard using a wrong way to get the project role info.

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-08-17 16:00:48 +08:00
Qian Deng
e5f9fe5961 Diable delete button when user not admin 
Binding the disable propety

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-08-17 15:58:54 +08:00
Qian Deng
a8ab6e3b1f Remove Upload Button on Chart Version List 
There is no method to constrict which chart to upload, so remove this button

Signed-off-by: Qian Deng <dengq@vmware.com>
 2018-08-17 15:58:54 +08:00
Mia ZHOU
e3a755ea14
Merge pull request #5642 from zhoumeina/pr/fix_chart_card_view_issues 
fix issue helmchart layout related issues
 2018-08-17 14:45:51 +08:00
Wenkai Yin
db844d42f6 Fix "gob: name not registered for interface" error 
This commits fixes the "gob: name not registered for interface" error when restarting Harbor by registering models.User

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2018-08-16 22:31:47 +08:00
Meina Zhou
c89fcd18f5 fix issue helmchart layout related issues 
1 Misc issues for chart repo card view
 2 Create group dialog ignores the error from backend
 3 The detail page of a scanned image has overlap of text fields.

Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-08-16 17:43:46 +08:00
Steven Zou
199b830019
Merge pull request #5628 from reasonerjt/fix-file-traversal-job-lob 
Validate job ID when getting job log
 2018-08-15 17:22:42 +08:00
Daniel Jiang
2e4295ba52
Merge pull request #5612 from stonezdj/fix_ldap_group_admin_dn 
Fix issue ldap_group_admin_dn doesn't take effect(master)
 2018-08-15 15:42:06 +08:00
Daniel Jiang
65cf02a1d7 Validate job ID when getting job log 
Add validation to job ID in the API to get job log in job service, to
prevent file path traversal attack.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2018-08-15 15:33:13 +08:00
stonezdj
764c43c995 If current user is in the group defined ldap_group_admin_dn, it doesn't have the harbor admin role. 
The current solution only fix the /api/users/currentuser, but for /api/users/:id it can display the real information. see issue #5620

Signed-off-by: stonezdj <stonezdj@gmail.com>
 2018-08-15 15:12:13 +08:00
stonezdj
865e4b04f9 user group name can not be empty 
Signed-off-by: stonezdj <stonezdj@gmail.com>
 2018-08-14 18:58:49 +08:00
wangyan
29d0d51403 Signed-off-by: wangyan <wangyan@vmware.com> 
Add clean registry cache to gc job

To workaround the issue: https://github.com/docker/distribution/issues/2094
GC needs to clean cache before to call the docker reigstry api to delete blobs.
Otherwise, the following docker push will not be performed as docker registry
does not clean cache in GC, it thinks the image is still there, and the new
blobs will be uploaded.
 2018-08-13 02:58:27 -07:00
Meina Zhou
45b11ddf6e remove vmware info in ui 
Signed-off-by: Meina Zhou <meinaz@vmware.com>
 2018-08-13 12:24:00 +08:00
Qian Deng
481c435c61
Merge pull request #5577 from zhoumeina/pr/fix_replication_button_disabled 
Fix replication rule sometimes save button can not click
 2018-08-10 14:20:53 +08:00
Mia ZHOU
63b64527b5
Merge pull request #5556 from zhoumeina/pr/remove_vmware_ui_change 
UI changed after harbor moved to CNCF
 2018-08-10 13:52:19 +08:00
Mia ZHOU
b0b9e29851 Fix replication rule sometimes save button can not click 
when user create a label filter and delete it in replication rule edit dialog, the save button is not enabled.
 2018-08-10 13:51:40 +08:00
Yan
9c86d0b86f
Update ldap user pwd for nightly (#5571) 2018-08-09 16:38:27 +08:00
Deng, Qian
e2a53c497a Fix repo is undefined issue on chart summary ui 
Because HTML render before component initialize, so assign value on onInit
 2018-08-09 11:58:27 +08:00
Mia ZHOU
4730a131ef UI changed after harbor moved to CNCF 
Changes include:
1 Modify the about dialog, remove vmware copyright
2 Remove VM tag in the login page.
3 Modify "vmware harbor" to "harbor" in login page.
 2018-08-08 15:41:33 +08:00
Deng, Qian
8d67330d9a Add status to charts and versions UI 
Add status to present if the chart or version is deprecated.
 2018-08-08 15:02:18 +08:00
Deng, Qian
cff8fc52ba Change UI about security table 
1. Change wording from 'sign' to 'ready'
2. Provide download for prov file
 2018-08-08 11:19:12 +08:00
Deng, Qian
173100be6d Refactor Chart Summary Commands UI 
1. Add Clipboard after command
2. Change the layout of command table
 2018-08-08 11:19:12 +08:00
Deng, Qian
2e99719d07 Fix wording of group list 
Fix i18n key in group list
 2018-08-08 11:12:10 +08:00
Mia ZHOU
e2edbef3df Refine helm chart card view 
Changes including:

1 chart list view will have icon which from the latest version.

2 Card View will change to the option2 (large icon).

3 version list will also have icons inside the data grid.
 2018-08-08 10:22:07 +08:00
Mia ZHOU
8f183c02ae modify helm chart card view 2018-08-07 15:23:22 +08:00
Mia ZHOU
72ffa4826e
Merge pull request #5544 from zhoumeina/pr/refine_chart_detail_layout 
Fix some layout issue in chart detail page
 2018-08-07 13:49:29 +08:00
Daniel Jiang
1f39bb4f13
Merge pull request #5520 from stonezdj/duplicate_group_dn 
Fix LDAP user group related issues
 2018-08-07 13:47:55 +08:00
Mia ZHOU
207cf384af Fix some layout issue in chart detail page 
Refine the layout in chart detail page.
 2018-08-07 12:25:37 +08:00
stonezdj
d9b4b18943 Fix LDAP group related issues 
User groups should not have same DN
Should not import an LDAP group if there is a user group with same DN
 2018-08-07 12:02:38 +08:00
Deng, Qian
637c43bef6 Fix style issues on chart detail values page 
1. Fix margin of title
2. Fix icon size to 24px
 2018-08-06 20:39:23 +08:00
Deng, Qian
d1a205581d Update i18n file for other languege 
Update i18n files
 2018-08-06 19:53:08 +08:00
Deng, Qian
5548eba238 Refine LDAP Group UI Text 
Refine some wording related to LDAP
 2018-08-06 19:53:07 +08:00
Deng, Qian
b52987bebd Fix Chart UI Source Repository URL redner issue 
1. When there are multiple source repos, the table should display multiple lines
2. Wrap text when url too long
 2018-08-06 19:53:07 +08:00
Deng, Qian
c04e752cf3 Fix issues on the list-view of helm chart registry 
1. Fix The header of version column
2. Fix word of no item placeholder
3. Fix the footer of gridview
4. Fix filter of version and chart
 2018-08-06 19:53:07 +08:00
Deng, Qian
91da5f015c Abstract style to mixin 
Abstract general style to mixin file for reuse.
 2018-08-06 19:53:07 +08:00
Deng, Qian
a9792c9c9a Back to charts page when delete whole versions 
Jump to charts page after you delete all the versions in a chart.
Because if you not do it, page will return 404.
 2018-08-06 19:53:07 +08:00
Deng, Qian
0e8e3304ab Fix spiner related issue on helmchart ui 
1. Fix spinner size on upload modal
2. Make the spinner into the center when chart detail page is loading
 2018-08-06 19:53:07 +08:00
Mia ZHOU
9bcf33212d
Merge pull request #5537 from zhoumeina/pr/fix_helm_chart_log 
Fix helm chart getImageLink was deleted by accident
 2018-08-06 18:50:36 +08:00
Mia ZHOU
ccd5ddf307 If user upload a not valid helm chart file, UI need to show the error from backend. 
Fix:
Modify the error handler to use the backend error instead of frontend hardcode.
 2018-08-06 17:39:09 +08:00
Mia ZHOU
8d66f057cd Fix helm chart getImageLink was deleted by accident 
add back getImageLink function
 2018-08-06 17:00:08 +08:00
Steven Zou
ecd8cc712d Add 'Deprecated' info for the chart 
info returned by getting /charts include 'Deprecated' field
amend error message in the access checking logic
 2018-08-06 16:31:41 +08:00
Steven Zou
bc6d7b69e7
Merge pull request #5524 from steven-zou/pro_deletable_enable 
Enhance the project deletable checking logic to include helm charts checking
 2018-08-06 16:00:38 +08:00
Steven Zou
b501199033 Enhance the project deletable checking logic to include helm charts checking 
add utility handler in chart controller to support getting charts by ns
add ut case for utility handler
update deletable checking logic in project controller

refactor project deletable test case
 2018-08-06 15:23:50 +08:00
Mia ZHOU
04261687cd Fix ldap cert verify has to align with ldap mode. should not show in other mode. 
Fix edit group sccess message.
This pr will focus on 2 issues:
1  In configuration,
LDAP verify cert should only show in ldap mode. It should not show in database mode.
2 When user using ldap mode to login harbor. And edit a group sccessfully, the popup message shows wrong. It should show "Edit group sccess".
 2018-08-06 09:43:04 +08:00
Mia ZHOU
034367f202
Merge pull request #5523 from zhoumeina/pr/error_log_fix 
Add onError for some logo return 404
 2018-08-06 09:18:06 +08:00
Yan
6ed80a370d
Fix go gas issue for chartserver (#5522) 
Add the error handling to fix go gas issue "Error unhandled"
 2018-08-03 19:25:39 +08:00
Mia ZHOU
4c8976da71 Add onError for some logo return 404 
We need to set a default logo for some logo may not exsit
 2018-08-03 17:51:57 +08:00
Qian Deng
0f519c9dc9
Merge pull request #5513 from ninjadq/hidden_chart_lib_without_chartmeseum 
Hide the helmcharts tab when chart museum is not installed.
 2018-08-03 05:41:06 -04:00
Wenkai Yin
5faf41e4a7
Merge pull request #5521 from wy65701436/cherry-pick-gas 
Cherry-pick -- Fix security issue found by gas
 2018-08-03 16:50:58 +08:00
wangyan
9a95f14918 Cherry-pick -- Fix security issue found by gas 2018-08-03 01:16:53 -07:00
Mia ZHOU
c6665934cd
Merge pull request #5516 from ninjadq/fix_ldap_parameter 
Fix bug of repository can not delete on card view
 2018-08-03 14:17:21 +08:00
Mia ZHOU
8319cbdc29
Merge pull request #5514 from zhoumeina/pr/fix_tooltip_content 
Modify configuration tooltip
 2018-08-03 13:54:34 +08:00
Deng, Qian
6a71188ecf Fix bug of repository can not delete on card view 
Fix argument types of repo delete function
 2018-08-03 13:34:31 +08:00
Mia ZHOU
8e66d90904 Modify cofiguration tooltip 
Refine the tooltip content in configuration tooltips
 2018-08-03 12:55:35 +08:00
Qian Deng
4cb0a3ee52
Merge pull request #5456 from zhoumeina/pr/fix_access_level_sort 
Fix access level can not sort
 2018-08-02 22:56:56 -04:00
Deng, Qian
66d85a12b4 Hide the helmcharts tab when chart museum is not installed. 
Add parameter for receving chartmuseum installation state.
Using that to decide the presentation of helmchart tab in project.
 2018-08-03 10:56:06 +08:00
Wenkai Yin
5f64bc8548
Merge pull request #5450 from ywk253100/180801_job_status 
Update job status when failed to submit it
 2018-08-03 09:33:39 +08:00
Wenkai Yin
3031e851ea
Merge pull request #5466 from steven-zou/fix_wrong_status_of_prov 
Fix issues described in #5464 and #5465
 2018-08-02 18:49:45 +08:00
Mia ZHOU
aaf4b49564 Fix remove button not clickable 
Remove comment
 2018-08-02 16:22:53 +08:00
Steven Zou
ce52f54e29 Fix issues described in #5464 and #5465 
return unified error format by the chart repo API
update the prov file status at anytime
 2018-08-02 14:07:04 +08:00
System Administrator
54f9b60ea4 Fix access level can not sort 
Issue description:
In project list page. User click sort according access level, it does not work.

Fix:

Remodify the compare method.
 2018-08-02 13:21:45 +08:00
Deng, Qian
8feb49c64e Feature of helm chart UI 
1. Add Charts list view
2. Add Charts card view
3. Add Chart version list view
4. Add chart version card view
5. Add Chart Detail Summary
6. Add Chart Detail Value
6. Add Chart Detail Deps
7. Update nodeclarity Dockerfile
8. Add markdown support
9. Add package-lock file to src
 2018-08-01 13:20:06 +08:00
Wenkai Yin
4ecbf3c0f5 Update job status when failed to submit it 
Set the status of replication job to "error" when the submitting to jobservice fails
 2018-08-01 10:35:01 +08:00
Mia ZHOU
67beabb364 Add ldap admin DN 
Problem description:
currently, harbor does not support config ldap admin DN

Enhancement:
Add ldap admin dn in configuration as a optional config.
 2018-07-31 16:20:26 +08:00