Commit Graph

1673 Commits

Author SHA1 Message Date
Qian Deng
a8ab6e3b1f Remove Upload Button on Chart Version List
There is no method to constrict which chart to upload, so remove this button

Signed-off-by: Qian Deng <dengq@vmware.com>
2018-08-17 15:58:54 +08:00
Mia ZHOU
e3a755ea14
Merge pull request #5642 from zhoumeina/pr/fix_chart_card_view_issues
fix issue helmchart layout related issues
2018-08-17 14:45:51 +08:00
Meina Zhou
c89fcd18f5 fix issue helmchart layout related issues
1 Misc issues for chart repo card view
 2 Create group dialog ignores the error from backend
 3 The detail page of a scanned image has overlap of text fields.

Signed-off-by: Meina Zhou <meinaz@vmware.com>
2018-08-16 17:43:46 +08:00
Steven Zou
199b830019
Merge pull request #5628 from reasonerjt/fix-file-traversal-job-lob
Validate job ID when getting job log
2018-08-15 17:22:42 +08:00
Daniel Jiang
2e4295ba52
Merge pull request #5612 from stonezdj/fix_ldap_group_admin_dn
Fix issue ldap_group_admin_dn doesn't take effect(master)
2018-08-15 15:42:06 +08:00
Daniel Jiang
65cf02a1d7 Validate job ID when getting job log
Add validation to job ID in the API to get job log in job service, to
prevent file path traversal attack.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2018-08-15 15:33:13 +08:00
stonezdj
764c43c995 If current user is in the group defined ldap_group_admin_dn, it doesn't have the harbor admin role.
The current solution only fix the /api/users/currentuser, but for /api/users/:id it can display the real information. see issue #5620

Signed-off-by: stonezdj <stonezdj@gmail.com>
2018-08-15 15:12:13 +08:00
stonezdj
865e4b04f9 user group name can not be empty
Signed-off-by: stonezdj <stonezdj@gmail.com>
2018-08-14 18:58:49 +08:00
wangyan
29d0d51403 Signed-off-by: wangyan <wangyan@vmware.com>
Add clean registry cache to gc job

To workaround the issue: https://github.com/docker/distribution/issues/2094
GC needs to clean cache before to call the docker reigstry api to delete blobs.
Otherwise, the following docker push will not be performed as docker registry
does not clean cache in GC, it thinks the image is still there, and the new
blobs will be uploaded.
2018-08-13 02:58:27 -07:00
Meina Zhou
45b11ddf6e remove vmware info in ui
Signed-off-by: Meina Zhou <meinaz@vmware.com>
2018-08-13 12:24:00 +08:00
Qian Deng
481c435c61
Merge pull request #5577 from zhoumeina/pr/fix_replication_button_disabled
Fix replication rule sometimes save button can not click
2018-08-10 14:20:53 +08:00
Mia ZHOU
63b64527b5
Merge pull request #5556 from zhoumeina/pr/remove_vmware_ui_change
UI changed after harbor moved to CNCF
2018-08-10 13:52:19 +08:00
Mia ZHOU
b0b9e29851 Fix replication rule sometimes save button can not click
when user create a label filter and delete it in replication rule edit dialog, the save button is not enabled.
2018-08-10 13:51:40 +08:00
Yan
9c86d0b86f
Update ldap user pwd for nightly (#5571) 2018-08-09 16:38:27 +08:00
Deng, Qian
e2a53c497a Fix repo is undefined issue on chart summary ui
Because HTML render before component initialize, so assign value on onInit
2018-08-09 11:58:27 +08:00
Mia ZHOU
4730a131ef UI changed after harbor moved to CNCF
Changes include:
1 Modify the about dialog, remove vmware copyright
2 Remove VM tag in the login page.
3 Modify "vmware harbor" to "harbor" in login page.
2018-08-08 15:41:33 +08:00
Deng, Qian
8d67330d9a Add status to charts and versions UI
Add status to present if the chart or version is deprecated.
2018-08-08 15:02:18 +08:00
Deng, Qian
cff8fc52ba Change UI about security table
1. Change wording from 'sign' to 'ready'
2. Provide download for prov file
2018-08-08 11:19:12 +08:00
Deng, Qian
173100be6d Refactor Chart Summary Commands UI
1. Add Clipboard after command
2. Change the layout of command table
2018-08-08 11:19:12 +08:00
Deng, Qian
2e99719d07 Fix wording of group list
Fix i18n key in group list
2018-08-08 11:12:10 +08:00
Mia ZHOU
e2edbef3df Refine helm chart card view
Changes including:

1 chart list view will have icon which from the latest version.

2 Card View will change to the option2 (large icon).

3 version list will also have icons inside the data grid.
2018-08-08 10:22:07 +08:00
Mia ZHOU
8f183c02ae modify helm chart card view 2018-08-07 15:23:22 +08:00
Mia ZHOU
72ffa4826e
Merge pull request #5544 from zhoumeina/pr/refine_chart_detail_layout
Fix some layout issue in chart detail page
2018-08-07 13:49:29 +08:00
Daniel Jiang
1f39bb4f13
Merge pull request #5520 from stonezdj/duplicate_group_dn
Fix LDAP user group related issues
2018-08-07 13:47:55 +08:00
Mia ZHOU
207cf384af Fix some layout issue in chart detail page
Refine the layout in chart detail page.
2018-08-07 12:25:37 +08:00
stonezdj
d9b4b18943 Fix LDAP group related issues
User groups should not have same DN
Should not import an LDAP group if there is a user group with same DN
2018-08-07 12:02:38 +08:00
Deng, Qian
637c43bef6 Fix style issues on chart detail values page
1. Fix margin of title
2. Fix icon size to 24px
2018-08-06 20:39:23 +08:00
Deng, Qian
d1a205581d Update i18n file for other languege
Update i18n files
2018-08-06 19:53:08 +08:00
Deng, Qian
5548eba238 Refine LDAP Group UI Text
Refine some wording related to LDAP
2018-08-06 19:53:07 +08:00
Deng, Qian
b52987bebd Fix Chart UI Source Repository URL redner issue
1. When there are multiple source repos, the table should display multiple lines
2. Wrap text when url too long
2018-08-06 19:53:07 +08:00
Deng, Qian
c04e752cf3 Fix issues on the list-view of helm chart registry
1. Fix The header of version column
2. Fix word of no item placeholder
3. Fix the footer of gridview
4. Fix filter of version and chart
2018-08-06 19:53:07 +08:00
Deng, Qian
91da5f015c Abstract style to mixin
Abstract general style to mixin file for reuse.
2018-08-06 19:53:07 +08:00
Deng, Qian
a9792c9c9a Back to charts page when delete whole versions
Jump to charts page after you delete all the versions in a chart.
Because if you not do it, page will return 404.
2018-08-06 19:53:07 +08:00
Deng, Qian
0e8e3304ab Fix spiner related issue on helmchart ui
1. Fix spinner size on upload modal
2. Make the spinner into the center when chart detail page is loading
2018-08-06 19:53:07 +08:00
Mia ZHOU
9bcf33212d
Merge pull request #5537 from zhoumeina/pr/fix_helm_chart_log
Fix helm chart getImageLink was deleted by accident
2018-08-06 18:50:36 +08:00
Mia ZHOU
ccd5ddf307 If user upload a not valid helm chart file, UI need to show the error from backend.
Fix:
Modify the error handler to use the backend error instead of frontend hardcode.
2018-08-06 17:39:09 +08:00
Mia ZHOU
8d66f057cd Fix helm chart getImageLink was deleted by accident
add back getImageLink function
2018-08-06 17:00:08 +08:00
Steven Zou
ecd8cc712d Add 'Deprecated' info for the chart
info returned by getting /charts include 'Deprecated' field
amend error message in the access checking logic
2018-08-06 16:31:41 +08:00
Steven Zou
bc6d7b69e7
Merge pull request #5524 from steven-zou/pro_deletable_enable
Enhance the project deletable checking logic to include helm charts checking
2018-08-06 16:00:38 +08:00
Steven Zou
b501199033 Enhance the project deletable checking logic to include helm charts checking
add utility handler in chart controller to support getting charts by ns
add ut case for utility handler
update deletable checking logic in project controller

refactor project deletable test case
2018-08-06 15:23:50 +08:00
Mia ZHOU
04261687cd Fix ldap cert verify has to align with ldap mode. should not show in other mode.
Fix edit group sccess message.
This pr will focus on 2 issues:
1  In configuration,
LDAP verify cert should only show in ldap mode. It should not show in database mode.
2 When user using ldap mode to login harbor. And edit a group sccessfully, the popup message shows wrong. It should show "Edit group sccess".
2018-08-06 09:43:04 +08:00
Mia ZHOU
034367f202
Merge pull request #5523 from zhoumeina/pr/error_log_fix
Add onError for some logo return 404
2018-08-06 09:18:06 +08:00
Yan
6ed80a370d
Fix go gas issue for chartserver (#5522)
Add the error handling to fix go gas issue "Error unhandled"
2018-08-03 19:25:39 +08:00
Mia ZHOU
4c8976da71 Add onError for some logo return 404
We need to set a default logo for some logo may not exsit
2018-08-03 17:51:57 +08:00
Qian Deng
0f519c9dc9
Merge pull request #5513 from ninjadq/hidden_chart_lib_without_chartmeseum
Hide the helmcharts tab when chart museum is not installed.
2018-08-03 05:41:06 -04:00
Wenkai Yin
5faf41e4a7
Merge pull request #5521 from wy65701436/cherry-pick-gas
Cherry-pick -- Fix security issue found by gas
2018-08-03 16:50:58 +08:00
wangyan
9a95f14918 Cherry-pick -- Fix security issue found by gas 2018-08-03 01:16:53 -07:00
Mia ZHOU
c6665934cd
Merge pull request #5516 from ninjadq/fix_ldap_parameter
Fix bug of repository can not delete on card view
2018-08-03 14:17:21 +08:00
Mia ZHOU
8319cbdc29
Merge pull request #5514 from zhoumeina/pr/fix_tooltip_content
Modify configuration tooltip
2018-08-03 13:54:34 +08:00
Deng, Qian
6a71188ecf Fix bug of repository can not delete on card view
Fix argument types of repo delete function
2018-08-03 13:34:31 +08:00