Steven Zou
d895ebef13
Merge pull request #5705 from steven-zou/fix_redis_parsing_issue
...
Fix the issue of parsing redis connection address in chart API
2018-08-23 15:06:08 +08:00
Steven Zou
d9256e401c
Fix the issue of parsing redis connection address in chart API
...
- update logic in func parseRedisConfig
Signed-off-by: Steven Zou <szou@vmware.com>
- Add UT case for redis addr parsing func
2018-08-23 14:03:19 +08:00
Qian Deng
dac86844e4
Add github flavered table in markdown
...
Add table style in markdown and
Fix deleted all version may cause 404
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-08-23 11:50:19 +08:00
Qian Deng
7cf3f286ca
Merge pull request #5632 from ninjadq/fix_ui_issues
...
Fix UI related issues
2018-08-19 11:01:28 +08:00
Qian Deng
d5da3862b2
Refactor upload modal
...
Using customized button to replace file input
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-08-17 18:24:08 +08:00
Qian Deng
8cf7d4f822
Fix item number and i18n issues
...
Fix item number presentation on Group, charts, chart versions, member group add
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-08-17 16:00:49 +08:00
Daniel Jiang
257a728086
Merge pull request #5648 from ywk253100/180817_session
...
Fix "gob: name not registered for interface" error
2018-08-17 16:00:48 +08:00
Qian Deng
317a01fa99
Fix i18n translate with parameter not work problem
...
The first parameter to translate should be the i18n key
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-08-17 16:00:48 +08:00
Qian Deng
6d91a0d66e
Fix Group related issues
...
1. Fix Ldap group name to required item
2. Edit Group DN is not allowed
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-08-17 16:00:48 +08:00
Qian Deng
07da2fd5d6
Edit the wording of version
...
1. Fix word of app version on summary page
2. Fix version on version cart view
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-08-17 16:00:48 +08:00
Qian Deng
b98af169af
Fix chart upload related issues
...
1. Chart will reset when open modal
2. Empty chart shouldn't trigger upload action
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-08-17 16:00:48 +08:00
Qian Deng
4ecea1f5ad
Fix incorrect UI views when logging in with a user in the group assigned with proper role
...
This caused by project routing guard using a wrong way to get the project role info.
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-08-17 16:00:48 +08:00
Qian Deng
e5f9fe5961
Diable delete button when user not admin
...
Binding the disable propety
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-08-17 15:58:54 +08:00
Qian Deng
a8ab6e3b1f
Remove Upload Button on Chart Version List
...
There is no method to constrict which chart to upload, so remove this button
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-08-17 15:58:54 +08:00
Mia ZHOU
e3a755ea14
Merge pull request #5642 from zhoumeina/pr/fix_chart_card_view_issues
...
fix issue helmchart layout related issues
2018-08-17 14:45:51 +08:00
Wenkai Yin
db844d42f6
Fix "gob: name not registered for interface" error
...
This commits fixes the "gob: name not registered for interface" error when restarting Harbor by registering models.User
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-08-16 22:31:47 +08:00
Meina Zhou
c89fcd18f5
fix issue helmchart layout related issues
...
1 Misc issues for chart repo card view
2 Create group dialog ignores the error from backend
3 The detail page of a scanned image has overlap of text fields.
Signed-off-by: Meina Zhou <meinaz@vmware.com>
2018-08-16 17:43:46 +08:00
Steven Zou
199b830019
Merge pull request #5628 from reasonerjt/fix-file-traversal-job-lob
...
Validate job ID when getting job log
2018-08-15 17:22:42 +08:00
Daniel Jiang
2e4295ba52
Merge pull request #5612 from stonezdj/fix_ldap_group_admin_dn
...
Fix issue ldap_group_admin_dn doesn't take effect(master)
2018-08-15 15:42:06 +08:00
Daniel Jiang
65cf02a1d7
Validate job ID when getting job log
...
Add validation to job ID in the API to get job log in job service, to
prevent file path traversal attack.
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2018-08-15 15:33:13 +08:00
stonezdj
764c43c995
If current user is in the group defined ldap_group_admin_dn, it doesn't have the harbor admin role.
...
The current solution only fix the /api/users/currentuser, but for /api/users/:id it can display the real information. see issue #5620
Signed-off-by: stonezdj <stonezdj@gmail.com>
2018-08-15 15:12:13 +08:00
stonezdj
865e4b04f9
user group name can not be empty
...
Signed-off-by: stonezdj <stonezdj@gmail.com>
2018-08-14 18:58:49 +08:00
wangyan
29d0d51403
Signed-off-by: wangyan <wangyan@vmware.com>
...
Add clean registry cache to gc job
To workaround the issue: https://github.com/docker/distribution/issues/2094
GC needs to clean cache before to call the docker reigstry api to delete blobs.
Otherwise, the following docker push will not be performed as docker registry
does not clean cache in GC, it thinks the image is still there, and the new
blobs will be uploaded.
2018-08-13 02:58:27 -07:00
Meina Zhou
45b11ddf6e
remove vmware info in ui
...
Signed-off-by: Meina Zhou <meinaz@vmware.com>
2018-08-13 12:24:00 +08:00
Qian Deng
481c435c61
Merge pull request #5577 from zhoumeina/pr/fix_replication_button_disabled
...
Fix replication rule sometimes save button can not click
2018-08-10 14:20:53 +08:00
Mia ZHOU
63b64527b5
Merge pull request #5556 from zhoumeina/pr/remove_vmware_ui_change
...
UI changed after harbor moved to CNCF
2018-08-10 13:52:19 +08:00
Mia ZHOU
b0b9e29851
Fix replication rule sometimes save button can not click
...
when user create a label filter and delete it in replication rule edit dialog, the save button is not enabled.
2018-08-10 13:51:40 +08:00
Yan
9c86d0b86f
Update ldap user pwd for nightly ( #5571 )
2018-08-09 16:38:27 +08:00
Deng, Qian
e2a53c497a
Fix repo is undefined issue on chart summary ui
...
Because HTML render before component initialize, so assign value on onInit
2018-08-09 11:58:27 +08:00
Mia ZHOU
4730a131ef
UI changed after harbor moved to CNCF
...
Changes include:
1 Modify the about dialog, remove vmware copyright
2 Remove VM tag in the login page.
3 Modify "vmware harbor" to "harbor" in login page.
2018-08-08 15:41:33 +08:00
Deng, Qian
8d67330d9a
Add status to charts and versions UI
...
Add status to present if the chart or version is deprecated.
2018-08-08 15:02:18 +08:00
Deng, Qian
cff8fc52ba
Change UI about security table
...
1. Change wording from 'sign' to 'ready'
2. Provide download for prov file
2018-08-08 11:19:12 +08:00
Deng, Qian
173100be6d
Refactor Chart Summary Commands UI
...
1. Add Clipboard after command
2. Change the layout of command table
2018-08-08 11:19:12 +08:00
Deng, Qian
2e99719d07
Fix wording of group list
...
Fix i18n key in group list
2018-08-08 11:12:10 +08:00
Mia ZHOU
e2edbef3df
Refine helm chart card view
...
Changes including:
1 chart list view will have icon which from the latest version.
2 Card View will change to the option2 (large icon).
3 version list will also have icons inside the data grid.
2018-08-08 10:22:07 +08:00
Mia ZHOU
8f183c02ae
modify helm chart card view
2018-08-07 15:23:22 +08:00
Mia ZHOU
72ffa4826e
Merge pull request #5544 from zhoumeina/pr/refine_chart_detail_layout
...
Fix some layout issue in chart detail page
2018-08-07 13:49:29 +08:00
Daniel Jiang
1f39bb4f13
Merge pull request #5520 from stonezdj/duplicate_group_dn
...
Fix LDAP user group related issues
2018-08-07 13:47:55 +08:00
Mia ZHOU
207cf384af
Fix some layout issue in chart detail page
...
Refine the layout in chart detail page.
2018-08-07 12:25:37 +08:00
stonezdj
d9b4b18943
Fix LDAP group related issues
...
User groups should not have same DN
Should not import an LDAP group if there is a user group with same DN
2018-08-07 12:02:38 +08:00
Deng, Qian
637c43bef6
Fix style issues on chart detail values page
...
1. Fix margin of title
2. Fix icon size to 24px
2018-08-06 20:39:23 +08:00
Deng, Qian
d1a205581d
Update i18n file for other languege
...
Update i18n files
2018-08-06 19:53:08 +08:00
Deng, Qian
5548eba238
Refine LDAP Group UI Text
...
Refine some wording related to LDAP
2018-08-06 19:53:07 +08:00
Deng, Qian
b52987bebd
Fix Chart UI Source Repository URL redner issue
...
1. When there are multiple source repos, the table should display multiple lines
2. Wrap text when url too long
2018-08-06 19:53:07 +08:00
Deng, Qian
c04e752cf3
Fix issues on the list-view of helm chart registry
...
1. Fix The header of version column
2. Fix word of no item placeholder
3. Fix the footer of gridview
4. Fix filter of version and chart
2018-08-06 19:53:07 +08:00
Deng, Qian
91da5f015c
Abstract style to mixin
...
Abstract general style to mixin file for reuse.
2018-08-06 19:53:07 +08:00
Deng, Qian
a9792c9c9a
Back to charts page when delete whole versions
...
Jump to charts page after you delete all the versions in a chart.
Because if you not do it, page will return 404.
2018-08-06 19:53:07 +08:00
Deng, Qian
0e8e3304ab
Fix spiner related issue on helmchart ui
...
1. Fix spinner size on upload modal
2. Make the spinner into the center when chart detail page is loading
2018-08-06 19:53:07 +08:00
Mia ZHOU
9bcf33212d
Merge pull request #5537 from zhoumeina/pr/fix_helm_chart_log
...
Fix helm chart getImageLink was deleted by accident
2018-08-06 18:50:36 +08:00
Mia ZHOU
ccd5ddf307
If user upload a not valid helm chart file, UI need to show the error from backend.
...
Fix:
Modify the error handler to use the backend error instead of frontend hardcode.
2018-08-06 17:39:09 +08:00