Commit Graph

11469 Commits

Author SHA1 Message Date
MinerYang
9d8e9158de
fix deadcode lint & update golangci-lint.yaml (#16896)
* fix deadcode lint & update golangci-lint.yaml

Signed-off-by: yminer <yminer@vmmware.com>

mock.go

Signed-off-by: yminer <yminer@vmmware.com>

commentfmt

Signed-off-by: yminer <yminer@vmmware.com>

mock.go update

Signed-off-by: yminer <yminer@vmmware.com>

update makefile

Signed-off-by: yminer <yminer@vmmware.com>

* update /pkg/allowlist/validator.go

Signed-off-by: yminer <yminer@vmmware.com>

Co-authored-by: yminer <yminer@vmmware.com>
2022-05-26 10:32:07 +08:00
Wang Yan
d26b5792c0
fix 16883 (#16911)
Fixes #16883, set the labels belonging to the subject manifest to the accessories on replication.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2022-05-26 01:30:53 +08:00
Mac Chaffee
ecc8c59101
Use exec in registryctl so signals are passed properly (#16642)
Signed-off-by: Mac Chaffee <machaffe@renci.org>
2022-05-25 14:11:31 +08:00
Shijun Sun
a9063d240d
Modify HarborDatetimePipe to pure pipe to improve performance (#16906)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-05-25 10:43:29 +08:00
Shijun Sun
e33197a487
Remove message prompt clearing (#16894)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-05-25 10:43:13 +08:00
stonezdj(Daojun Zhang)
4637af8866
Merge pull request #16865 from stonezdj/22may17_purge_audit_log_rest_api
Add REST API for purge audit log
2022-05-25 10:08:47 +08:00
Simon Alling
c4b782bc95
Add date/time format setting in portal (#16796)
* Add date/time format setting in portal

Currently, the format used for rendering dates and times is derived from the language/locale selected by the user. The formats used in the en-US locale ("English" in Harbor's GUI) are ambiguous and hard to understand for many users.

For example, is 10/11/21 the 10th of November, 2021, the 11th of October, 2021, or even something else like the 21nd of November, 2010? Even if one does know how to interpret it in theory, such dates are essentially enciphered and must be mentally deciphered by the user every time, incurring unnecessary cognitive load.

Similarly, many users are used to the 24-hour clock rather than the 12-hour clock (AM/PM), and so on.

This PR adds a dropdown next to the existing language selector that lets the user choose between the default format for the current locale and the internationally standardized, unambiguous ISO 8601 format. For example, when viewing a list of resources, the ISO 8601 option makes points in time display as

> 2021-10-11, 13:37

instead of

> 10/11/21, 1:37 PM

thereby improving the user experience considerably for users not familiar with the US date/time format (or, in general, the default format for the locale they have selected).

The localized versions of the "Default" label are copied from `SCANNER.DEFAULT` in each locale.

Signed-off-by: Simon Alling <alling.simon@gmail.com>

* Fix indentation

Signed-off-by: Simon Alling <alling.simon@gmail.com>

* Remove redundant localStorage existence check

Signed-off-by: Simon Alling <alling.simon@gmail.com>

* Run 'npm run lint -- --fix'
2022-05-24 17:45:34 +08:00
MinerYang
db45155365
bump up beego from v1.12.7 to v1.12.9 (#16904)
Signed-off-by: yminer <yminer@vmmware.com>

Co-authored-by: yminer <yminer@vmmware.com>
2022-05-24 12:18:48 +08:00
stonezdj
1839965c7a Add REST API for purge audit log
Add rest API for purge audit log
  Extract scheduler, execution, task from GC controller for common use

Signed-off-by: stonezdj <stonezdj@gmail.com>
2022-05-23 16:58:31 +08:00
chlins
f16cc4bda4 feat(project): introduce cache layer for project_metadata (#16891)
Implement cache layer for project_metadata and migrate metadata.Mgr to
pkg.ProjectMetaMgr.

Signed-off-by: chlins <chenyuzh@vmware.com>
2022-05-23 09:08:39 +08:00
Yang Jiao
783d20b0f2
Merge pull request #16886 from YangJiao0817/refresh-base-main-0520
Refresh base image
2022-05-20 16:40:55 +08:00
Yang Jiao
30043293fb Refresh base image
Signed-off-by: Yang Jiao <jiaoya@vmware.com>
2022-05-20 07:04:45 +00:00
chlins
7eed9db404 feat(manifest): introduce cache layer for manifest (#16459)
Implement cache layer for resource manifest, it will read manifest
from cache instead of proxying to distribution if enabled.

Signed-off-by: chlins <chenyuzh@vmware.com>
2022-05-19 10:25:50 +08:00
Shijun Sun
5a4f6c6167
Improve css for accessories component (#16868)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-05-18 14:58:50 +08:00
Shijun Sun
4f253731f4
Allow all roles to see 'listed in CVE allowlist' column (#16860)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-05-18 13:50:34 +08:00
Wang Yan
ae83f9a027
fix accessory count issue (#16866)
The count api should ignore the pagination.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2022-05-17 15:02:29 +08:00
stonezdj(Daojun Zhang)
2852a7606b
Merge pull request #16833 from stonezdj/22may10_purge_audit_log
(feat) Add job service to purge audit_log
2022-05-17 09:02:56 +08:00
stonezdj
3ac7281177 Add job service to purge audit_log
Add jobservice type PurgeAuditLog

Signed-off-by: stonezdj <stonezdj@gmail.com>
2022-05-16 21:52:58 +08:00
Chenyu Zhang
d56a505fa7
Merge pull request #16846 from chlins/feat/cache-layer-for-repo
feat(repository): introduce cache manager for repository (#16741)
2022-05-16 11:39:28 +08:00
Shijun Sun
bb8839b6a3
Upgrade clarity to the latest version (#16840)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-05-16 10:13:46 +08:00
Shijun Sun
73295ff891
migrate tslint to eslint (#16856)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-05-13 16:00:45 +08:00
Wang Yan
54a857f2aa
fix artifact count issue (#16851)
The count should filter out the accessory, the result should be consistent with list method.

Fixes #16816

Signed-off-by: Wang Yan <wangyan@vmware.com>
2022-05-13 11:48:20 +08:00
chlins
a82f1ba63d feat(repository): introduce cache manager for repository (#16741)
Implement cache layer for resource repository and migrate repository.Mgr
to pkg.RepositoryMgr.

Signed-off-by: chlins <chenyuzh@vmware.com>
2022-05-12 10:14:35 +08:00
Shengwen YU
ee214f0347
Merge pull request #16841 from zyyw/issue-16355-gc-update_time
fix: gc history update_time
2022-05-12 10:12:47 +08:00
Chenyu Zhang
f78047f169
Merge pull request #16807 from chlins/feat/cache-layer-for-project
feat(project): introduce cache manager for project (#16740)
2022-05-11 22:47:45 +08:00
Shengwen Yu
d2c4c4f71b fix: gc history update_time
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
2022-05-11 17:17:09 +08:00
chlins
0fd0c84446 feat(project): introduce cache manager for project (#16740)
Implement cached manager for resource project and migrate project.Mgr
to pkg.ProjectMgr.

Signed-off-by: chlins <chenyuzh@vmware.com>
2022-05-11 15:52:09 +08:00
Shijun Sun
6ca3665207
Improve css for tags column (#16811)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-05-10 17:47:09 +08:00
Yang Jiao
4d116893be
Merge pull request #16832 from YangJiao0817/update-cosign-testcase
Update cosign test case
2022-05-10 16:18:16 +08:00
Yang Jiao
2563cf1bfb
Merge pull request #16760 from YangJiao0817/add-imgpkg-copy-testcase
Add imgpkg copy test case
2022-05-10 16:17:50 +08:00
Wang Yan
d3d4ad6a34
fix staticcheck issues (#16828)
Fix the staticcheck problems that reported by golangci-line staticcheck

Signed-off-by: Wang Yan <wangyan@vmware.com>
2022-05-10 16:07:10 +08:00
Yang Jiao
49ddaee603 Update cosign test case
1 bump up cosign version to 1.8.0
2 Add cosign Verify test

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
2022-05-10 07:01:27 +00:00
prahaladdarkin
27ec871185
System Artifact Manager database schema creation, model definitons, and tests (#16678)
Closes:
https://github.com/goharbor/harbor/issues/16540
https://github.com/goharbor/harbor/issues/16541
https://github.com/goharbor/harbor/issues/16542

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
2022-05-09 17:32:57 +08:00
MinerYang
1f797fafc4
add lint with golangci-lint, remove golint (#16821)
Signed-off-by: yminer <yminer@vmmware.com>

test ut_install.sh

Signed-off-by: yminer <yminer@vmmware.com>

test ut_install.sh001

Signed-off-by: yminer <yminer@vmmware.com>

test ut_install002

Signed-off-by: yminer <yminer@vmmware.com>

use curl binary to download golangcilint instead of go get

Signed-off-by: yminer <yminer@vmmware.com>

test ut-ci make lint

Signed-off-by: yminer <yminer@vmmware.com>

check ci GO111MODULE

Signed-off-by: yminer <yminer@vmmware.com>

test ci go env

Signed-off-by: yminer <yminer@vmmware.com>

test ci goenv 002

Signed-off-by: yminer <yminer@vmmware.com>

test ci GO111MODULE=auto

Signed-off-by: yminer <yminer@vmmware.com>

ci test entire ut_install.sh

Signed-off-by: yminer <yminer@vmmware.com>

remove needless debug comment

Signed-off-by: yminer <yminer@vmmware.com>

Co-authored-by: yminer <yminer@vmmware.com>
2022-05-09 11:19:02 +08:00
Wang Yan
c333218ba2
fix close response missing (#16820)
It has to close the http response on deleting manifest

Signed-off-by: Wang Yan <wangyan@vmware.com>
2022-05-07 13:03:15 +08:00
Shengwen YU
2dceffe457
Merge pull request #16790 from zyyw/issue-16747-improve-gc-log
fix: improve GC log message
2022-05-07 09:16:06 +08:00
Shengwen Yu
d0c82db519 fix: improve GC log message
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
2022-05-06 15:01:45 +08:00
Shijun Sun
584245ec4d
Improve replication policy datagrid (#16806)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-05-05 17:36:11 +08:00
Simon Alling
16f38bc591
Fix lint errors in portal (#16799)
This PR fixes all lint errors reported by TSLint (`npm run lint` in `src/portal/`).

TSLint also reports multiple warnings (see #16798), but this PR doesn't fix any of them.

Signed-off-by: Simon Alling <alling.simon@gmail.com>
2022-05-05 13:48:09 +08:00
Simon Alling
bb007f70bb
Refactor portal language code (#16795)
* Refactor portal language code

This PR makes the following improvements:

  * The language code is DRYed up by defining `supportedLangs` in terms of `LANGUAGES` (previously `languageNames`).

  * The language selection dropdown code is DRYed up similarly.

  * The Angular locale registration code is DRYed up similarly: the omission of a supported language is now a static type error.

The above improvements mean that it's now impossible to forget to include a supported language in any of those contexts.

Furthermore:

  * The type of supported languages is replaced by a more accurate one than `string`, namely `SupportedLanguage`.

  * The value acquired from localStorage will never be used unless it is in fact a supported language. (Today, the GUI breaks pretty badly and errors are spammed in the console if localStorage contains an invalid value.)

  * Redundant implicit existence checks such as `localStorage &&` and `browserCultureLang &&` are removed.

  * The implementation of `initLangauge` is generally simplified and clarified.

Signed-off-by: Simon Alling <alling.simon@gmail.com>

* Restore accidentally deleted date check

Signed-off-by: Simon Alling <alling.simon@gmail.com>
2022-05-05 13:16:41 +08:00
Shijun Sun
ca019f4030
Upgrade Angular to 13.3.4 (#16772)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-04-29 16:24:30 +08:00
Shijun Sun
a5da06078f
Store default page size to local storage (#16753)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-04-29 16:24:07 +08:00
Shengwen YU
9821bea610
Merge pull request #16780 from zyyw/fix-registry-redis.patch
fix: registry/redis.patch & registry/builder
2022-04-29 15:51:54 +08:00
Shengwen Yu
3e8bf9faed fix: registry/redis.patch & registry/builder
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
2022-04-29 08:51:49 +08:00
Wang Yan
98c52e4478
enable default to build bin (#16763)
Change the default behavrior of building binaries for all the third parties to true.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2022-04-28 17:13:41 +08:00
MinerYang
615a4cbb52
install only htpasswd binary from photon package httpd (#16771)
Signed-off-by: yminer <yminer@vmmware.com>

cpio -u

Signed-off-by: yminer <yminer@vmmware.com>

Co-authored-by: yminer <yminer@vmmware.com>
2022-04-28 13:20:03 +08:00
MinerYang
083b44e719
bump up astaxie/beego@v1.12.1 to beego/beego/@v1.12.7 (#16770)
Signed-off-by: yminer <yminer@vmmware.com>

goo mod tidy

Signed-off-by: yminer <yminer@vmmware.com>

Co-authored-by: yminer <yminer@vmmware.com>
2022-04-28 11:58:44 +08:00
Orlix
030c61059e
Merge pull request #16634 from OrlinVasilev/auto-release-notes
Add release.yml to automate release notes #16633
2022-04-27 13:21:41 +03:00
OrlinVasilev
27463f4ef4 Add release.yml to automate release notes #16633
Use github autogeneration release notes and add action to check if the PR has labels

Complete and more readable relase notes
https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
Signed-off-by: OrlinVasilev <ovasilev@vmware.com>
2022-04-27 10:48:31 +03:00
Yang Jiao
18b9856dc5 Add imgpkg copy test case
Add this test case to make sure imgpkg copy to Harbor works.

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
2022-04-27 06:25:11 +00:00