Commit Graph

5658 Commits

Author SHA1 Message Date
Chlins Zhang
fbeeaa7537
fix: add checkpoint when enqueue scan tasks for scan all (#18680)
Fix the scanAll cannot be stopped in case of large number of artifacts,
add the checkpoint before submit scan tasks, mark the scanAll stopped
flag in the redis.

Fixes: #18044

Signed-off-by: chlins <chenyuzh@vmware.com>
2023-06-05 15:12:54 +08:00
Wang Yan
680c78d368
add more details in gc history (#18779)
Show more infors in the gc history, like the sweep size and how many blobs and manifests were removed by GC.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2023-06-02 17:33:09 +08:00
Chlins Zhang
a98711c0fc
fix: clean up scan executions and reports after deleting artifact (#18693)
Cleanup the associated resources(scan executions and scan reports) after
deletion of artifact.

Fixes: #18634

Signed-off-by: chlins <chenyuzh@vmware.com>
2023-05-31 14:54:52 +08:00
cui fliter
e19ec9623b
Fix: fix function name in comments (#18726)
fix function name in comments

Signed-off-by: cui fliter <imcusg@gmail.com>
2023-05-31 10:26:19 +08:00
orblazer
b021dbd2d6
fix invalid access action (#18188)
Signed-off-by: orblazer <orblazer.minecraft@gmail.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>
2023-05-30 17:49:01 +08:00
Wang Yan
5c42bc10ec
remove the legacy migration (#18754)
Delete the legacy migration and artifact abstration code for v2.0

Signed-off-by: Wang Yan <wangyan@vmware.com>
2023-05-30 15:17:24 +08:00
guangwu
b7b0e43a21
fix: import optimization (#18727)
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
2023-05-30 13:24:08 +08:00
lishaokai1995
04833d2daf
Fix syntax errors in comments (#18746)
Signed-off-by: lishaokai1995 <lishaokai1995@126.com>
2023-05-29 17:31:08 +08:00
rongfu.leng
4652d752b6
【optimization】Use URL.Redacted method repleace redacted (#18716)
use URL.Redacted method replease redacted

Signed-off-by: lengrongfu <1275177125@qq.com>
2023-05-29 16:37:51 +08:00
stonezdj(Daojun Zhang)
1b1af4a14c
Return error when proxy cache get too many request error(429) (#18728)
Add 429 too many request error in http error
  Fixes #18707

Signed-off-by: stonezdj <stonezdj@gmail.com>
2023-05-29 13:33:46 +08:00
Shijun Sun
11d6bb4437
Add a text to explain the time window for GC (#18735)
1.Fixes #18692

Signed-off-by: AllForNothing <sshijun@vmware.com>
2023-05-26 18:32:19 +02:00
Wang Yan
06aa87a72a
set tag pull time for proxy cache (#18731)
fixes #18708

to set the pull time of tag for the first time cache the artifact.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2023-05-26 13:08:37 +08:00
Shijun Sun
c399e5ee4a
Improve repo_read_only header on the UI (#18729)
1. Fixes #18694
2. Now non-system-admin users can also see the repo_read_only header

Signed-off-by: AllForNothing <sshijun@vmware.com>
2023-05-24 17:13:33 +08:00
Shijun Sun
43c6586af4
Upgrade Angular and Clarity to the latest version (#18709)
1.Upgrade Angular to 16.0.2
2.Upgrade Clarity to 15.4.0

Signed-off-by: AllForNothing <sshijun@vmware.com>
2023-05-23 15:59:31 +08:00
stonezdj(Daojun Zhang)
9d042ad585
Use subtle.ConstantTimeCompare instead of compare directly (#18697)
Signed-off-by: stonezdj <daojunz@vmware.com>
2023-05-22 16:16:52 +08:00
Aklis
6a79de761b
Fix the channel that never receives a value (#18139)
fix the channel that never receives a value
fix the code with the linter's recommendation by https://github.com/goharbor/harbor/blob/main/CONTRIBUTING.md#develop-build-and-test

Signed-off-by: iAklis <chenpinwei@gmail.com>
2023-05-19 09:17:46 +08:00
Wang Yan
bf7c82b9a8
remove the notary from backend (#18668)
Since harbor deprecates notary since v2.9.0, this pull request targets to remove the code related with notary.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2023-05-18 18:47:42 +08:00
Shengwen YU
845bcdb184
fix: add retry on the caller of v2DeleteManifest instead within v2DeleteManifest (#18662)
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>
2023-05-18 09:35:33 +08:00
MinerYang
954f1f3d06
bump up github.com/distribution/distribution v2.8.2 (#18687)
Signed-off-by: yminer <yminer@vmware.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>
2023-05-17 11:58:43 +08:00
Viktor
f8e28dbede
Changed logic search projects in gitlab adapter (#18529)
* fix(gitlab): change logic search projects usage search_namespaces

Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com>

* tests(gitlab): remove old data and actualization test

Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com>

* refactor(gitlab): added debug log

Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com>
(cherry picked from commit 732806221b1c1633682fe1adad4cbcd3a4687d0b)

* lint(gitlab): fix import order

Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com>

---------

Signed-off-by: lxShaDoWxl <lxshadowxkingxl@gmail.com>
2023-05-15 13:59:13 +08:00
Eng Zer Jun
18a33c2b40
chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml (#18606)
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>
Co-authored-by: MinerYang <yminer@vmware.com>
2023-05-12 18:21:26 +08:00
Shijun Sun
f2fc0f6a99
Remove notary UI (#18666)
1. Remove notary from the UI
2. Remove notary-related unit test cases

Signed-off-by: AllForNothing <sshijun@vmware.com>
2023-05-11 19:23:51 +08:00
Chlins Zhang
36c2b93fe6
fix: sweep executions of image scan job (#18649)
1. Change the SCAN_ALL job execution retain counts from 5 to 1(per
   current design, only one report be stored for every artifact, so
   retain latest 1 is enough).
2. Enable the sweep for IMAGE_SCAN job(retain latest 1).

Fixes: #18633

Signed-off-by: chlins <chenyuzh@vmware.com>
2023-05-10 13:23:54 +08:00
Peter Dave Hello
0e3e70bc7a
Improve zh-tw (Traditional Chinese) locale (#18608)
Improve zh-tw locale

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
2023-05-08 10:55:04 +08:00
Chlins Zhang
362387f914
fix: improve the performance of list artifacts (#18610)
1. Change the query for listing tasks of scan which can use the db
   index.
2. Add the gin index for task.extra_attrs.report_uuids

Fixes: #18013

Signed-off-by: chlins <chenyuzh@vmware.com>
2023-04-30 09:10:28 +08:00
Shijun Sun
1bbe8c57e7
Fix message prompt under the header (#18613)
1.Fixes #18601

Signed-off-by: AllForNothing <sshijun@vmware.com>
2023-04-27 18:03:05 +08:00
MoonStrider
bf6389e6c8
fix: error log use wrong variable err (#18602)
Update manager.go

Signed-off-by: MoonStrider <37744291+dyf991645@users.noreply.github.com>
2023-04-26 21:10:41 +08:00
MinerYang
ebac530b46
add goheader linter settings (#18503)
fix files for goheader linter

fix copyright 2018/2019

Signed-off-by: yminer <yminer@vmware.com>
2023-04-25 11:18:42 +08:00
Shijun Sun
dd973b1593
Add missing i18n key-value for helm chart (#18578)
1.Fixes #18572

Signed-off-by: AllForNothing <sshijun@vmware.com>
2023-04-23 15:03:04 +08:00
Shijun Sun
e793e2433d
Update position to vertical-align for copy button (#18563)
Fixes #17906

Signed-off-by: AllForNothing <sshijun@vmware.com>
2023-04-20 15:40:24 +08:00
MinerYang
8df99a5116
bump golang.org/x/net && helm.sh/helm/v3 on main (#18545)
bump golang.org/x/net v0.9.0 on main

Signed-off-by: yminer <yminer@vmware.com>

bump helm.sh/helm/v3 v3.11.3
2023-04-18 19:18:04 +08:00
pgillich
eec5342490
feat: log with trace ID (#18181)
feat: log trace ID

Implements #18029

If the Trace ID is sent to the Harbor in HTTP header or the tracing
is enabled (and the Trace ID is generated), the Trace ID will be
added to the log lines as a new field.

Signed-off-by: Peter Gillich <pgillich@gmail.com>
2023-04-17 15:03:00 +08:00
Shijun Sun
de6e517136
Upgrade harbor-portal to v2.9.0 (#18525)
1.Magrate protractor to cypress as protractor has been deprecated

Signed-off-by: AllForNothing <sshijun@vmware.com>
2023-04-13 18:52:06 +08:00
Chlins Zhang
d3d6e29aa3
fix: update stopped execution status immediately instead of async update (#18527)
Update the stopped execution status immediately becasue the user
experience is not good if wait long time when stop or reschedule a job.

Fixes: #18526

Signed-off-by: chlins <chenyuzh@vmware.com>
2023-04-13 17:52:41 +08:00
Iceber Gu
3afa525f0b
Change the permissions of the *.go file from 0755 to 0644 (#17919)
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
2023-04-13 09:07:36 +02:00
Danny Kulchinsky
14e4c07d94
GC: correctly handle manifest unknown (404) condition in v2DeleteManifest retry loop (#18386)
GC: handle manifest unknown (404) during V2 manifest delete retry loop

Signed-off-by: Danny Kulchinsky <dkulchinsky@fastly.com>
2023-04-12 22:52:52 +02:00
Shijun Sun
b201f9864f
Synchronize text modification of quota tooltip to all the i18n files (#18518) 2023-04-12 10:55:02 +03:00
Chlins Zhang
b755c43d12
fix: clean the redis if the execution is not found (#18517)
Delete the execution outdated status key in the redis when the execution
is not found.

Fixes: #18511

Signed-off-by: chlins <chenyuzh@vmware.com>
2023-04-12 14:17:42 +08:00
Orlix
7edb447e14
Reword quota definitions based on user input (#18512)
Fixes: https://github.com/goharbor/harbor/issues/17545

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>
2023-04-12 11:50:33 +08:00
Chlins Zhang
5791f0c979
fix: fix error bitsize of jobservice reaper scan locks (#18487)
Change the bitSize from 16 to 64 in the jobservice reaper, the 16 is too
small when the redis cursor over the max value of int16.

Fixes: #18486

Signed-off-by: chlins <chenyuzh@vmware.com>
2023-04-07 10:59:30 +08:00
Chlins Zhang
697f1c79ef
fix: fix the regexp of execution status outdate key (#18481)
Signed-off-by: chlins <chenyuzh@vmware.com>
2023-04-05 13:53:45 +08:00
Chlins Zhang
62bb56daf6
refactor: refresh the execution status in async mode (#18434)
Refactor the logic for updating the status of execution when receiving
the hook from jobservice, avoid the optimistic lock due to the multiple
tasks update one execution by refreshing the status asynchronously. But
still retain the old way by specifying the flag from ENV.

Fixes: #17584

Signed-off-by: chlins <chenyuzh@vmware.com>
2023-04-04 16:37:37 +08:00
Wang Yan
60d9664cbc
fix accessory replication issue (#18471)
Fixes #18404
Support multiple level accessories replication.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2023-04-04 12:46:46 +08:00
Chlins Zhang
a7cef5e24f
fix: wrap schedule/exec/task creation as orm tx (#18458)
Wrap orm tx when the scheduler try to create the task because submit job
maybe failure depends on the jobservice.

Fixes: #18452

Signed-off-by: chlins <chenyuzh@vmware.com>
2023-04-04 08:42:18 +08:00
Chlins Zhang
02c51c6b70
fix: correct the retention webhook payload (#18462)
Fix the incorrect number of total and retained in the retention webhook
payload, and completes the deleted_artifacts field.

Fixes: #18428

Signed-off-by: chlins <chenyuzh@vmware.com>
2023-04-03 17:51:02 +08:00
Shijun Sun
1499faf67d
Update styles for UI according to the designer's suggestions (#18463)
1. extend the width for event type label
2. add quotes for Retain image last pull time to make it more understandable

Signed-off-by: AllForNothing <sshijun@vmware.com>
2023-04-03 16:47:21 +08:00
Chlins Zhang
ca9e2d2f07
fix: generate uuid as CloudEvents id and add additional requestid (#18451)
1. Change the the value of CloudEvents id from requestid to uuid
2. Add additional requestid to trace to event

Fixes: #18448

Signed-off-by: chlins <chenyuzh@vmware.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>
2023-04-03 12:02:19 +08:00
Wang Yan
fddfaa7ba5
fix copy artifact issue (#18460)
To enable the middleware to save the project_blob data, make sure to set the accessories options to true when handling the artifact copy.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2023-04-03 10:58:17 +08:00
Chlins Zhang
cb0749c7ab
fix: add default payload_format for http type webhook (#18445)
1. Add migration SQL to handle the lost payload format for old policies.
2. Set payload format to 'Default' if not specified for http webhook in the API handler.
3. Fix the migration sql of notification_job

Fixes: #18401, #18453

Signed-off-by: chlins <chenyuzh@vmware.com>
2023-04-02 15:33:33 +08:00
Chlins Zhang
5d953b48b6
fix: escape the event data for slack webhook payload (#18424)
Escape the event data of slack webhook as original payload is invalid
when send to slack.

Fixes: #18423

Signed-off-by: chlins <chenyuzh@vmware.com>
2023-03-31 17:05:10 +08:00