From 5b44f81fca9a440551fcc14e2c9e040284a73e43 Mon Sep 17 00:00:00 2001 From: nossr50 Date: Sat, 15 Jan 2011 21:50:28 -0800 Subject: [PATCH] Fixed the last player name duping bug --- .../bukkit/nossr50/vPlayersOnline/vPlayerListener.java | 9 ++++++--- vPlayersOnline/plugin.yml | 2 +- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/vPlayersOnline/com/bukkit/nossr50/vPlayersOnline/vPlayerListener.java b/vPlayersOnline/com/bukkit/nossr50/vPlayersOnline/vPlayerListener.java index 5f4ba3830..95dbb8e7e 100644 --- a/vPlayersOnline/com/bukkit/nossr50/vPlayersOnline/vPlayerListener.java +++ b/vPlayersOnline/com/bukkit/nossr50/vPlayersOnline/vPlayerListener.java @@ -32,7 +32,8 @@ public class vPlayerListener extends PlayerListener { //Message to be sent when a player joins public void onPlayerJoin(PlayerEvent event) { Player player = event.getPlayer(); - player.sendMessage(ChatColor.GREEN + "There are " + playerCount() + " players online"); + //English Version + player.sendMessage(ChatColor.GREEN + "There are " + playerCount() + " players online."); } //Message to be sent when a player uses /list public void onPlayerCommand(PlayerChatEvent event) { @@ -44,12 +45,14 @@ public class vPlayerListener extends PlayerListener { int x = 0; for(Player p : plugin.getServer().getOnlinePlayers()) { + if(p != null && x+1 == playerCount()){ + tempList+= p.getName(); + x++; + } if(p != null && x < playerCount()){ tempList+= p.getName() +", "; x++; } - if(x >= playerCount()) - tempList+= p.getName(); } //Output the player list player.sendMessage(ChatColor.RED + "Player List ("+ChatColor.WHITE + tempList +ChatColor.RED+")"); diff --git a/vPlayersOnline/plugin.yml b/vPlayersOnline/plugin.yml index 3d3d62e2a..aa33b3400 100644 --- a/vPlayersOnline/plugin.yml +++ b/vPlayersOnline/plugin.yml @@ -1,3 +1,3 @@ name: vPlayersOnline main: com.bukkit.nossr50.vPlayersOnline.vPlayersOnline -version: 1.2 \ No newline at end of file +version: 1.3 \ No newline at end of file