From a677450d504ba01898f35f6feef0cffc95a978d9 Mon Sep 17 00:00:00 2001 From: nossr50 Date: Sun, 9 Jun 2019 05:07:34 -0700 Subject: [PATCH] Fix NPE on server shutdown with no user data --- Changelog.txt | 3 +++ pom.xml | 2 +- src/main/java/com/gmail/nossr50/util/player/UserManager.java | 3 +++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Changelog.txt b/Changelog.txt index 8b76c4e00..1f59bcc75 100644 --- a/Changelog.txt +++ b/Changelog.txt @@ -1,3 +1,6 @@ +Version 2.1.72 + Fixed a NPE if a server shutdown with no player data needing to be saved (the error is harmless but spammy) + Version 2.1.71 Salvage will now always ask for confirmation before breaking your items (instead of only asking for enchanted items) Repair will now always ask for confirmation before repairing items (instead of only asking for enchanted items) diff --git a/pom.xml b/pom.xml index 1db7c0f88..d4673e8c5 100755 --- a/pom.xml +++ b/pom.xml @@ -2,7 +2,7 @@ 4.0.0 com.gmail.nossr50.mcMMO mcMMO - 2.1.71 + 2.1.72-SNAPSHOT mcMMO https://github.com/mcMMO-Dev/mcMMO diff --git a/src/main/java/com/gmail/nossr50/util/player/UserManager.java b/src/main/java/com/gmail/nossr50/util/player/UserManager.java index c635300c5..ffb898086 100644 --- a/src/main/java/com/gmail/nossr50/util/player/UserManager.java +++ b/src/main/java/com/gmail/nossr50/util/player/UserManager.java @@ -66,6 +66,9 @@ public final class UserManager { * Save all users ON THIS THREAD. */ public static void saveAll() { + if(playerDataSet == null) + return; + ImmutableList trackedSyncData = ImmutableList.copyOf(playerDataSet); mcMMO.p.getLogger().info("Saving mcMMOPlayers... (" + trackedSyncData.size() + ")");