Upstream
/
mikrotik-exporter
mirror of https://github.com/nshttpd/mikrotik-exporter.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Quote DHCP hostname 

Some DHCP clients register wild hostnames no matter what RFC 1035 says.
That causes errors as Prometheus accepts only valid UTF-8.

Fix #116
This commit is contained in:
Vojtěch Káně 2022-03-22 12:21:08 +01:00
parent dc93f93f62
commit 553465385b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
collector/dhcp_lease_collector.go
View File

@ -76,7 +76,8 @@ func (c *dhcpLeaseCollector) collectMetric(ctx *collectorContext, re *proto.Sent
server := re.Map["server"]
status := re.Map["status"]
activeaddress := re.Map["active-address"]
hostname := re.Map["host-name"]
// QuoteToASCII because of broken DHCP clients
hostname := strconv.QuoteToASCII(re.Map["host-name"])
metric, err := prometheus.NewConstMetric(c.descriptions, prometheus.GaugeValue, v, ctx.device.Name, ctx.device.Address, activemacaddress, server, status, strconv.FormatFloat(f, 'f', 0, 64), activeaddress, hostname)
if err != nil {