Upstream/pihole-exporter
1
0
Fork 0
mirror of https://github.com/eko/pihole-exporter.git synced 2024-12-22 15:57:45 +01:00
Code Issues Projects Releases Wiki Activity

Avoid Panic During Authentication

Browse Source 
If a request to the statistics endpoint fails then resp is nil causing a
panic when looking for cookies. Properly handle errors when
authenticating to avoid crashing the exporter.
This commit is contained in:
Chris Marchbanks 2023-11-16 23:33:19 -07:00
parent 71f84fa416
commit 179b605128
No known key found for this signature in database
GPG Key ID: B7FD940BC86A8E7A
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
internal/pihole/client.go
View File

@ -162,12 +162,12 @@ func (c *Client) setMetrics(stats *Stats) {
}
}
func (c *Client) getPHPSessionID() (sessionID string) {
func (c *Client) getPHPSessionID() (string, error) {
values := url.Values{"pw": []string{c.config.PIHolePassword}}
req, err := http.NewRequest("POST", c.config.PIHoleLoginURL(), strings.NewReader(values.Encode()))
if err != nil {
log.Fatal("An error has occured when creating HTTP statistics request", err)
return "", fmt.Errorf("creating HTTP statistics request: %w", err)
}
req.Header.Add("Content-Type", "application/x-www-form-urlencoded")
@ -175,17 +175,16 @@ func (c *Client) getPHPSessionID() (sessionID string) {
resp, err := c.httpClient.Do(req)
if err != nil {
log.Errorf("An error has occured during login to Pi-hole: %v", err)
return "", fmt.Errorf("loging in to Pi-hole: %w", err)
}
for _, cookie := range resp.Cookies() {
if cookie.Name == "PHPSESSID" {
sessionID = cookie.Value
break
return cookie.Value, nil
}
}
return
return "", fmt.Errorf("no PHPSESSID cookie found")
}
func (c *Client) getStatistics() (*Stats, error) {
@ -203,7 +202,10 @@ func (c *Client) getStatistics() (*Stats, error) {
}
if c.isUsingPassword() {
c.authenticateRequest(req)
err := c.authenticateRequest(req)
if err != nil {
return nil, fmt.Errorf("an error has occurred authenticating the request: %w", err)
}
}
resp, err := c.httpClient.Do(req)
@ -233,7 +235,12 @@ func (c *Client) isUsingApiToken() bool {
return len(c.config.PIHoleApiToken) > 0
}
func (c *Client) authenticateRequest(req *http.Request) {
cookie := http.Cookie{Name: "PHPSESSID", Value: c.getPHPSessionID()}
func (c *Client) authenticateRequest(req *http.Request) error {
sessionID, err := c.getPHPSessionID()
if err != nil {
return err
}
cookie := http.Cookie{Name: "PHPSESSID", Value: sessionID}
req.AddCookie(&cookie)
return nil
}