Upstream/waveterm
1
0
Fork 0
mirror of https://github.com/wavetermdev/waveterm.git synced 2024-12-22 16:48:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix preview getting unset when app is idle (#43)

Browse Source 
I found that the drag preview images would get unset when the app went idle. I am now caching the preview image and resetting it every time a user hovers over a TileNode. I am also updating the logic for the placeholder slightly to reduce the number of variables floating around.
This commit is contained in:
Evan Simkowitz 2024-06-11 16:28:41 -07:00 committed by GitHub
parent 1b52160794
commit 9f32a53485
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 32 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
frontend/faraday/lib/TileLayout.tsx
View File

@ -33,7 +33,13 @@ import {
WritableLayoutTreeStateAtom, WritableLayoutTreeStateAtom,
} from "./model.js"; } from "./model.js";
import "./tilelayout.less"; import "./tilelayout.less";
import { FlexDirection, setTransform as createTransform, debounce, determineDropDirection } from "./utils.js"; import {
Dimensions,
FlexDirection,
setTransform as createTransform,
debounce,
determineDropDirection,
} from "./utils.js";
export interface TileLayoutProps<T> { export interface TileLayoutProps<T> {
layoutTreeStateAtom: WritableLayoutTreeStateAtom<T>; layoutTreeStateAtom: WritableLayoutTreeStateAtom<T>;
@ -276,20 +282,22 @@ const TileNode = <T,>({
); );
}, []); }, []);
// Ensure we only generate the preview image once // Cache the preview image after we generate it
const [previewImageSet, setPreviewImageSet] = useState<boolean>(false); const [previewImage, setPreviewImage] = useState<HTMLImageElement>();
// When a user first mouses over a node, generate a preview image and set it as the drag preview. // When a user first mouses over a node, generate a preview image and set it as the drag preview.
const generatePreviewImage = useCallback(() => { const generatePreviewImage = useCallback(() => {
if (!previewImageSet && previewRef.current) { if (previewImage) {
dragPreview(previewImage);
} else if (previewRef.current) {
toPng(previewRef.current).then((url) => { toPng(previewRef.current).then((url) => {
const img = new Image(); const img = new Image();
img.src = url; img.src = url;
img.onload = () => dragPreview(img); img.onload = () => dragPreview(img);
setPreviewImageSet(true); setPreviewImage(img);
}); });
} }
}, [previewRef, previewImageSet, dragPreview]); }, [previewRef, previewImage, dragPreview]);
// Register the tile item as a draggable component // Register the tile item as a draggable component
useEffect(() => { useEffect(() => {
@ -468,40 +476,37 @@ const Placeholder = <T,>({ layoutTreeState, overlayContainerRef, nodeRefs, style
const targetBoundingRect = targetRef.current.getBoundingClientRect(); const targetBoundingRect = targetRef.current.getBoundingClientRect();
// Placeholder should be either half the height or half the width of the targetNode, depending on the flex direction of the targetNode's parent. // Placeholder should be either half the height or half the width of the targetNode, depending on the flex direction of the targetNode's parent.
const placeholderHeight =
parentNode.flexDirection === FlexDirection.Column
? targetBoundingRect.height / 2
: targetBoundingRect.height;
const placeholderWidth =
parentNode.flexDirection === FlexDirection.Row
? targetBoundingRect.width / 2
: targetBoundingRect.width;
// Default to placing the placeholder in the first half of the target node. // Default to placing the placeholder in the first half of the target node.
let placeholderTop = targetBoundingRect.top - overlayBoundingRect.top; const placeholderDimensions: Dimensions = {
let placeholderLeft = targetBoundingRect.left - overlayBoundingRect.left; height:
parentNode.flexDirection === FlexDirection.Column
? targetBoundingRect.height / 2
: targetBoundingRect.height,
width:
parentNode.flexDirection === FlexDirection.Row
? targetBoundingRect.width / 2
: targetBoundingRect.width,
top: targetBoundingRect.top - overlayBoundingRect.top,
left: targetBoundingRect.left - overlayBoundingRect.left,
};
if (action.index > targetIndex) { if (action.index > targetIndex) {
if (action.index >= (parentNode.children?.length ?? 1)) { if (action.index >= (parentNode.children?.length ?? 1)) {
// If there are no more nodes after the specified index, place the placeholder in the second half of the target node (either right or bottom). // If there are no more nodes after the specified index, place the placeholder in the second half of the target node (either right or bottom).
placeholderTop += placeholderDimensions.top +=
parentNode.flexDirection === FlexDirection.Column && targetBoundingRect.height / 2; parentNode.flexDirection === FlexDirection.Column && targetBoundingRect.height / 2;
placeholderLeft += placeholderDimensions.left +=
parentNode.flexDirection === FlexDirection.Row && targetBoundingRect.width / 2; parentNode.flexDirection === FlexDirection.Row && targetBoundingRect.width / 2;
} else { } else {
// Otherwise, place the placeholder between the target node (the one after which it will be inserted) and the next node // Otherwise, place the placeholder between the target node (the one after which it will be inserted) and the next node
placeholderTop += placeholderDimensions.top +=
parentNode.flexDirection === FlexDirection.Column && parentNode.flexDirection === FlexDirection.Column &&
(3 * targetBoundingRect.height) / 4; (3 * targetBoundingRect.height) / 4;
placeholderLeft += placeholderDimensions.left +=
parentNode.flexDirection === FlexDirection.Row && (3 * targetBoundingRect.width) / 4; parentNode.flexDirection === FlexDirection.Row && (3 * targetBoundingRect.width) / 4;
} }
} }
const placeholderTransform = createTransform({ const placeholderTransform = createTransform(placeholderDimensions);
top: placeholderTop,
left: placeholderLeft,
width: placeholderWidth,
height: placeholderHeight,
});
newPlaceholderOverlay = <div className="placeholder" style={{ ...placeholderTransform }} />; newPlaceholderOverlay = <div className="placeholder" style={{ ...placeholderTransform }} />;
} }