From d97c1862c79667296e3c2dc7ff4b4e75829e7b0d Mon Sep 17 00:00:00 2001 From: sawka Date: Wed, 6 Sep 2023 21:57:41 -0700 Subject: [PATCH] should be 666 not 777 (don't set executable flag by default) --- pkg/server/server.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/server/server.go b/pkg/server/server.go index 67461682b..d8690fba0 100644 --- a/pkg/server/server.go +++ b/pkg/server/server.go @@ -311,7 +311,7 @@ func copyFile(dstName string, srcName string) error { return err } defer srcFd.Close() - dstFd, err := os.OpenFile(dstName, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0o777) // use 777 because OpenFile respects umask + dstFd, err := os.OpenFile(dstName, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0o666) // use 666 because OpenFile respects umask if err != nil { return err } @@ -349,7 +349,7 @@ func (m *MServer) writeFile(pk *packet.WriteFilePacketType, wfc *WriteFileContex return } } else { - writeFd, err = os.OpenFile(pk.Path, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0o777) // use 777 because OpenFile respects umask + writeFd, err = os.OpenFile(pk.Path, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0o666) // use 666 because OpenFile respects umask if err != nil { resp := packet.MakeWriteFileReadyPacket(pk.ReqId) resp.Error = fmt.Sprintf("write-file could not open file: %v", err)