diff --git a/cmd/wsh/cmd/wshcmd-setmeta.go b/cmd/wsh/cmd/wshcmd-setmeta.go index 2058bc2c4..7590256a4 100644 --- a/cmd/wsh/cmd/wshcmd-setmeta.go +++ b/cmd/wsh/cmd/wshcmd-setmeta.go @@ -53,7 +53,6 @@ func parseMetaSets(metaSets []string) (map[string]interface{}, error) { meta[fields[0]] = setVal } } - meta[fields[0]] = fields[1] } return meta, nil } diff --git a/frontend/app/block/block.tsx b/frontend/app/block/block.tsx index b2705bb15..c002d715c 100644 --- a/frontend/app/block/block.tsx +++ b/frontend/app/block/block.tsx @@ -42,7 +42,6 @@ function processTitleString(titleString: string): React.ReactNode[] { lastPart.push(before); lastIdx = match.index + match[0].length; const [_, isClosing, tagName, tagParam] = match; - console.log("match", match); if (tagName == "icon" && !isClosing) { if (tagParam == null) { continue; @@ -92,13 +91,12 @@ function processTitleString(titleString: string): React.ReactNode[] { return partsStack[0]; } -function getBlockHeaderText(blockData: Block): React.ReactNode { +function getBlockHeaderText(blockIcon: string, blockData: Block): React.ReactNode { if (!blockData) { return "no block data"; } - let blockIcon: React.ReactNode = null; - if (!util.isBlank(blockData?.meta?.["icon"])) { - const iconName = blockData.meta.icon; + let blockIconElem: React.ReactNode = null; + if (!util.isBlank(blockIcon)) { let iconColor = blockData.meta["icon:color"]; if (iconColor && !iconColor.match(colorRegex)) { iconColor = null; @@ -107,23 +105,25 @@ function getBlockHeaderText(blockData: Block): React.ReactNode { if (!util.isBlank(iconColor)) { iconStyle = { color: iconColor }; } - if (iconName.match(/^[a-z0-9-]+$/)) { - blockIcon = ; + if (blockIcon.match(/^[a-z0-9-]+$/)) { + blockIconElem = ( + + ); } } if (!util.isBlank(blockData?.meta?.title)) { try { const rtn = processTitleString(blockData.meta.title) ?? []; - if (blockIcon) { - rtn.unshift(blockIcon); + if (blockIconElem) { + rtn.unshift(blockIconElem); } return rtn; } catch (e) { console.error("error processing title", blockData.meta.title, e); - return [blockIcon, blockData.meta.title]; + return [blockIconElem, blockData.meta.title]; } } - return [blockIcon, `${blockData?.view} [${blockData.oid.substring(0, 8)}]`]; + return [blockIconElem, `${blockData?.view} [${blockData.oid.substring(0, 8)}]`]; } interface FramelessBlockHeaderProps { @@ -137,7 +137,7 @@ const FramelessBlockHeader = ({ blockId, onClose, dragHandleRef }: FramelessBloc return (