Upstream/waveterm
1
0
Fork 0
mirror of https://github.com/wavetermdev/waveterm.git synced 2025-01-22 21:42:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

handle IDisposables to prevent memory leak

Browse Source
This commit is contained in:
Evan Simkowitz 2024-12-29 16:43:06 -05:00
parent 7040f0091d
commit f30b415fc9
No known key found for this signature in database
1 changed files with 25 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
frontend/app/view/term/termwrap.ts
View File

@ -59,6 +59,7 @@ export class TermWrap {
handleResize_debounced: () => void;
hasResized: boolean;
onSearchResultsDidChange?: (result: { resultIndex: number; resultCount: number }) => void;
toDispose: TermTypes.IDisposable[] = [];
constructor(
blockId: string,
@ -98,9 +99,11 @@ export class TermWrap {
);
if (WebGLSupported && waveOptions.useWebGl) {
const webglAddon = new WebglAddon();
webglAddon.onContextLoss(() => {
webglAddon.dispose();
});
this.toDispose.push(
webglAddon.onContextLoss(() => {
webglAddon.dispose();
})
);
this.terminal.loadAddon(webglAddon);
if (!loggedWebGL) {
console.log("loaded webgl!");
@ -142,20 +145,22 @@ export class TermWrap {
async initTerminal() {
const copyOnSelectAtom = getSettingsKeyAtom("term:copyonselect");
this.terminal.onData(this.handleTermData.bind(this));
this.terminal.onSelectionChange(
debounce(50, () => {
if (!globalStore.get(copyOnSelectAtom)) {
return;
}
const selectedText = this.terminal.getSelection();
if (selectedText.length > 0) {
navigator.clipboard.writeText(selectedText);
}
})
this.toDispose.push(this.terminal.onData(this.handleTermData.bind(this)));
this.toDispose.push(
this.terminal.onSelectionChange(
debounce(50, () => {
if (!globalStore.get(copyOnSelectAtom)) {
return;
}
const selectedText = this.terminal.getSelection();
if (selectedText.length > 0) {
navigator.clipboard.writeText(selectedText);
}
})
)
);
if (this.onSearchResultsDidChange != null) {
this.searchAddon.onDidChangeResults(this.onSearchResultsDidChange.bind(this));
this.toDispose.push(this.searchAddon.onDidChangeResults(this.onSearchResultsDidChange.bind(this)));
}
this.mainFileSubject = getFileSubject(this.blockId, TermFileName);
this.mainFileSubject.subscribe(this.handleNewFileSubjectData.bind(this));
@ -169,6 +174,11 @@ export class TermWrap {
dispose() {
this.terminal.dispose();
this.toDispose.forEach((d) => {
try {
d.dispose();
} catch (_) {}
});
this.mainFileSubject.release();
}