From f606a743393abae93c5a9f2dcba6e58f3337c790 Mon Sep 17 00:00:00 2001 From: Evan Simkowitz Date: Mon, 2 Dec 2024 19:53:25 -0500 Subject: [PATCH] Remove child views before switching workspaces (#1371) This was causing a crash on Windows because we were destroying a TabView that was still parented to the window. Not sure why I couldn't repro this on Mac... --- emain/emain-window.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/emain/emain-window.ts b/emain/emain-window.ts index ead2bfaff..85e1334e5 100644 --- a/emain/emain-window.ts +++ b/emain/emain-window.ts @@ -274,6 +274,7 @@ export class WaveBrowserWindow extends BaseWindow { console.log("switchWorkspace newWs", newWs); if (this.allTabViews.size) { for (const tab of this.allTabViews.values()) { + this.contentView.removeChildView(tab); tab?.destroy(); } }