diff --git a/assets/appicon-windows.png b/assets/appicon-windows.png new file mode 100644 index 000000000..e2a8ed412 Binary files /dev/null and b/assets/appicon-windows.png differ diff --git a/assets/appicon-windows.svg b/assets/appicon-windows.svg new file mode 100644 index 000000000..6fbf2443c --- /dev/null +++ b/assets/appicon-windows.svg @@ -0,0 +1,20 @@ + + + + + + + + + + + + + + \ No newline at end of file diff --git a/build/appicon.png b/build/appicon.png deleted file mode 100644 index a10809fb0..000000000 Binary files a/build/appicon.png and /dev/null differ diff --git a/build/icons.icns b/build/icon.icns similarity index 100% rename from build/icons.icns rename to build/icon.icns diff --git a/build/icon.ico b/build/icon.ico index 523704eaa..a6d2d8787 100644 Binary files a/build/icon.ico and b/build/icon.ico differ diff --git a/electron-builder.config.cjs b/electron-builder.config.cjs index 89841c218..8768fcd3d 100644 --- a/electron-builder.config.cjs +++ b/electron-builder.config.cjs @@ -3,6 +3,8 @@ const pkg = require("./package.json"); const fs = require("fs"); const path = require("path"); +const windowsShouldSign = !!process.env.SM_CODE_SIGNING_CERT_SHA1_HASH; + /** * @type {import('electron-builder').Configuration} * @see https://www.electron.build/configuration/configuration @@ -47,7 +49,6 @@ const config = { arch: ["universal", "arm64", "x64"], }, ], - icon: "build/icons.icns", category: "public.app-category.developer-tools", minimumSystemVersion: "10.15.0", mergeASARs: true, @@ -57,7 +58,6 @@ const config = { artifactName: "${name}-${platform}-${arch}-${version}.${ext}", category: "TerminalEmulator", executableName: pkg.name, - icon: "build/icons.icns", target: ["zip", "deb", "rpm", "AppImage", "pacman"], synopsis: pkg.description, description: null, @@ -73,12 +73,13 @@ const config = { afterInstall: "build/deb-postinstall.tpl", }, win: { - icon: "build/icons.icns", - publisherName: "Command Line Inc", target: ["nsis", "msi", "zip"], - certificateSubjectName: "Command Line Inc", - certificateSha1: process.env.SM_CODE_SIGNING_CERT_SHA1_HASH, - signingHashAlgorithms: ["sha256"], + signtoolOptions: windowsShouldSign && { + signingHashAlgorithms: ["sha256"], + publisherName: "Command Line Inc", + certificateSubjectName: "Command Line Inc", + certificateSha1: process.env.SM_CODE_SIGNING_CERT_SHA1_HASH, + }, }, appImage: { license: "LICENSE",