Upstream/youtube-dl
1
0
Fork 0
mirror of https://github.com/ytdl-org/youtube-dl.git synced 2024-12-14 13:17:00 +01:00
Code Issues Projects Releases Wiki Activity

YoutubeDL: only set the ‘formats’ field of the info_dict if it was already set before

Browse Source 
It caused a circular reference error, when trying to dump it to json (for example with the test video for myvideo.de or any other video without formats)
This commit is contained in:
Jaime Marquínez Ferrándiz 2013-12-23 10:23:13 +01:00
parent 8958b6916c
commit b3d9ef88ec
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
youtube_dl/YoutubeDL.py
View File

@ -688,7 +688,12 @@ class YoutubeDL(object):
ext_ord) ext_ord)
formats = sorted(formats, key=_free_formats_key) formats = sorted(formats, key=_free_formats_key)
info_dict['formats'] = formats if formats[0] is not info_dict:
# only set the 'formats' fields if the original info_dict list them
# otherwise we end up with a circular reference, the first (and unique)
# element in the 'formats' field in info_dict is info_dict itself,
# wich can't be exported to json
info_dict['formats'] = formats
if self.params.get('listformats', None): if self.params.get('listformats', None):
self.list_formats(info_dict) self.list_formats(info_dict)
return return