Upstream/yt-dlp
1
0
Fork 0
mirror of https://github.com/yt-dlp/yt-dlp.git synced 2024-12-13 14:37:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

[extractor/youtube] Ignore incomplete data for comment threads by default (#7475)

Browse Source 
For both `--ignore-errors` and `--ignore-errors only_download`. Pass `--no-ignore-errors` to not ignore.

Closes https://github.com/yt-dlp/yt-dlp/issues/7474

Authored by: coletdjnz
This commit is contained in:
coletdjnz 2023-07-03 10:47:10 +00:00 committed by GitHub
parent 8776349ef6
commit 4dc4d8473c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
yt_dlp/extractor/youtube.py
View File

@ -3426,7 +3426,9 @@ def extract_thread(contents):
# Pinned comments may appear a second time in newest first sort # Pinned comments may appear a second time in newest first sort
# See: https://github.com/yt-dlp/yt-dlp/issues/6712 # See: https://github.com/yt-dlp/yt-dlp/issues/6712
continue continue
self.report_warning('Detected YouTube comments looping. Stopping comment extraction as we probably cannot get any more.') self.report_warning(
'Detected YouTube comments looping. Stopping comment extraction '
f'{"for this thread" if parent else ""} as we probably cannot get any more.')
yield yield
else: else:
tracker['seen_comment_ids'].add(comment['id']) tracker['seen_comment_ids'].add(comment['id'])
@ -3517,11 +3519,17 @@ def extract_thread(contents):
# Ignore incomplete data error for replies if retries didn't work. # Ignore incomplete data error for replies if retries didn't work.
# This is to allow any other parent comments and comment threads to be downloaded. # This is to allow any other parent comments and comment threads to be downloaded.
# See: https://github.com/yt-dlp/yt-dlp/issues/4669 # See: https://github.com/yt-dlp/yt-dlp/issues/4669
if 'incomplete data' in str(e).lower() and parent and self.get_param('ignoreerrors') is True: if 'incomplete data' in str(e).lower() and parent:
if self.get_param('ignoreerrors') in (True, 'only_download'):
self.report_warning( self.report_warning(
'Received incomplete data for a comment reply thread and retrying did not help. ' 'Received incomplete data for a comment reply thread and retrying did not help. '
'Ignoring to let other comments be downloaded.') 'Ignoring to let other comments be downloaded. Pass --no-ignore-errors to not ignore.')
return
else: else:
raise ExtractorError(
'Incomplete data received for comment reply thread. '
'Pass --ignore-errors to ignore and allow rest of comments to download.',
expected=True)
raise raise
is_forced_continuation = False is_forced_continuation = False
continuation = None continuation = None