From 6020e05d23ad451fff20b354c1c89c748ff27051 Mon Sep 17 00:00:00 2001 From: pukkandan Date: Mon, 3 Jan 2022 17:41:27 +0530 Subject: [PATCH] Raise error if subtitle download fails Closes #2212 --- yt_dlp/YoutubeDL.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/yt_dlp/YoutubeDL.py b/yt_dlp/YoutubeDL.py index 57c56f882b..d027e342e2 100644 --- a/yt_dlp/YoutubeDL.py +++ b/yt_dlp/YoutubeDL.py @@ -3746,9 +3746,10 @@ def _write_subtitles(self, info_dict, filename): self.dl(sub_filename, sub_copy, subtitle=True) sub_info['filepath'] = sub_filename ret.append((sub_filename, sub_filename_final)) - except (ExtractorError, IOError, OSError, ValueError) + network_exceptions as err: + except (DownloadError, ExtractorError, IOError, OSError, ValueError) + network_exceptions as err: + if self.params.get('ignoreerrors') is not True: # False or 'only_download' + raise DownloadError(f'Unable to download video subtitles for {sub_lang!r}: {err}', err) self.report_warning(f'Unable to download video subtitles for {sub_lang!r}: {err}') - continue return ret def _write_thumbnails(self, label, info_dict, filename, thumb_filename_base=None):