fix: references to services in portal subcommands

This commit is contained in:
Sekwah 2023-04-12 03:17:38 +01:00
parent c446c1602a
commit a9a337f2b5
No known key found for this signature in database
GPG Key ID: 9E0D654FC942286D
5 changed files with 46 additions and 25 deletions

View File

@ -1,17 +1,24 @@
package com.sekwah.advancedportals.core.commands.subcommands.portal; package com.sekwah.advancedportals.core.commands.subcommands.portal;
import com.google.inject.Inject;
import com.sekwah.advancedportals.core.commands.SubCommand; import com.sekwah.advancedportals.core.commands.SubCommand;
import com.sekwah.advancedportals.core.connector.containers.CommandSenderContainer; import com.sekwah.advancedportals.core.connector.containers.CommandSenderContainer;
import com.sekwah.advancedportals.core.connector.containers.PlayerContainer; import com.sekwah.advancedportals.core.connector.containers.PlayerContainer;
import com.sekwah.advancedportals.core.data.DataTag; import com.sekwah.advancedportals.core.data.DataTag;
import com.sekwah.advancedportals.core.portal.AdvancedPortal;
import com.sekwah.advancedportals.core.services.PortalServices;
import com.sekwah.advancedportals.core.util.Lang; import com.sekwah.advancedportals.core.util.Lang;
import com.sekwah.advancedportals.core.util.TagReader; import com.sekwah.advancedportals.core.util.TagReader;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays;
import java.util.List; import java.util.List;
public class CreatePortalSubCommand implements SubCommand { public class CreatePortalSubCommand implements SubCommand {
@Inject
PortalServices portalServices;
@Override @Override
public void onCommand(CommandSenderContainer sender, String[] args) { public void onCommand(CommandSenderContainer sender, String[] args) {
if(args.length > 1) { if(args.length > 1) {
@ -22,16 +29,15 @@ public class CreatePortalSubCommand implements SubCommand {
} }
ArrayList<DataTag> portalTags = TagReader.getTagsFromArgs(args); ArrayList<DataTag> portalTags = TagReader.getTagsFromArgs(args);
// TODO sort portal services AdvancedPortal portal = portalServices.createPortal(args[1], player, portalTags);
/*AdvancedPortal portal = AdvancedPortalsCore.getPortalServices().createPortal(args[1], player, portalTags);
if(portal != null) { if(portal != null) {
sender.sendMessage(Lang.translateColor("messageprefix.positive") + Lang.translateColor("command.create.complete")); sender.sendMessage(Lang.translate("messageprefix.positive") + Lang.translate("command.create.complete"));
sender.sendMessage(Lang.translateColor("command.create.tags")); sender.sendMessage(Lang.translate("command.create.tags"));
sender.sendMessage("\u00A7a" + "triggerBlock\u00A77:\u00A7e" + Arrays.toString(portal.getTriggerBlocks())); sender.sendMessage("\u00A7a" + "triggerBlock\u00A77:\u00A7e" + Arrays.toString(portal.getTriggerBlocks()));
for (DataTag tag: portal.getArgs()) { for (DataTag tag: portal.getArgs()) {
sender.sendMessage("\u00A7a" + tag.NAME + "\u00A77:\u00A7e" + tag.VALUE); sender.sendMessage("\u00A7a" + tag.NAME + "\u00A77:\u00A7e" + tag.VALUE);
} }
}*/ }
sender.sendMessage(Lang.translate("messageprefix.negative") + Lang.translate("command.create.error")); sender.sendMessage(Lang.translate("messageprefix.negative") + Lang.translate("command.create.error"));
} }
else { else {

View File

@ -18,7 +18,6 @@ public class LangUpdateSubCommand implements SubCommand {
@Override @Override
public void onCommand(CommandSenderContainer sender, String[] args) { public void onCommand(CommandSenderContainer sender, String[] args) {
//this.portalsCore.getDataStorage().copyDefaultFile("lang/en_GB.lang", true);
if(args.length > 1 && args[1].equalsIgnoreCase("overwrite")) { if(args.length > 1 && args[1].equalsIgnoreCase("overwrite")) {
this.portalsCore.getDataStorage().copyDefaultFile("lang/en_GB.lang", true); this.portalsCore.getDataStorage().copyDefaultFile("lang/en_GB.lang", true);
sender.sendMessage(Lang.translate("messageprefix.positive") + Lang.translate("translatedata.replaced")); sender.sendMessage(Lang.translate("messageprefix.positive") + Lang.translate("translatedata.replaced"));

View File

@ -4,6 +4,8 @@ import com.google.inject.Inject;
import com.sekwah.advancedportals.core.AdvancedPortalsCore; import com.sekwah.advancedportals.core.AdvancedPortalsCore;
import com.sekwah.advancedportals.core.commands.SubCommand; import com.sekwah.advancedportals.core.commands.SubCommand;
import com.sekwah.advancedportals.core.connector.containers.CommandSenderContainer; import com.sekwah.advancedportals.core.connector.containers.CommandSenderContainer;
import com.sekwah.advancedportals.core.services.DestinationServices;
import com.sekwah.advancedportals.core.services.PortalServices;
import com.sekwah.advancedportals.core.util.Lang; import com.sekwah.advancedportals.core.util.Lang;
import java.util.List; import java.util.List;
@ -13,13 +15,17 @@ public class ReloadSubCommand implements SubCommand {
@Inject @Inject
private AdvancedPortalsCore portalsCore; private AdvancedPortalsCore portalsCore;
@Inject
PortalServices portalServices;
@Inject
DestinationServices destinationServices;
@Override @Override
public void onCommand(CommandSenderContainer sender, String[] args) { public void onCommand(CommandSenderContainer sender, String[] args) {
portalsCore.loadPortalConfig(); portalsCore.loadPortalConfig();
// TODO re-add or figure out a replacement. portalServices.loadPortals();
//portalsCore.getPortalServices().loadPortals(); destinationServices.loadDestinations();
//portalsCore.getDestinationServices().loadDestinations();
// TODO also reload stuff like translations.
sender.sendMessage(Lang.translate("messageprefix.positive") + Lang.translate("command.reload.reloaded")); sender.sendMessage(Lang.translate("messageprefix.positive") + Lang.translate("command.reload.reloaded"));
} }

View File

@ -1,10 +1,12 @@
package com.sekwah.advancedportals.core.commands.subcommands.portal; package com.sekwah.advancedportals.core.commands.subcommands.portal;
import com.google.inject.Inject;
import com.sekwah.advancedportals.core.AdvancedPortalsCore; import com.sekwah.advancedportals.core.AdvancedPortalsCore;
import com.sekwah.advancedportals.core.commands.SubCommand; import com.sekwah.advancedportals.core.commands.SubCommand;
import com.sekwah.advancedportals.core.connector.containers.CommandSenderContainer; import com.sekwah.advancedportals.core.connector.containers.CommandSenderContainer;
import com.sekwah.advancedportals.core.connector.containers.PlayerContainer; import com.sekwah.advancedportals.core.connector.containers.PlayerContainer;
import com.sekwah.advancedportals.core.portal.AdvancedPortal; import com.sekwah.advancedportals.core.portal.AdvancedPortal;
import com.sekwah.advancedportals.core.services.PortalServices;
import com.sekwah.advancedportals.core.util.Lang; import com.sekwah.advancedportals.core.util.Lang;
import java.util.ArrayList; import java.util.ArrayList;
@ -14,17 +16,21 @@ import java.util.Map;
public class RemoveSubCommand implements SubCommand { public class RemoveSubCommand implements SubCommand {
@Inject
PortalServices portalServices;
@Override @Override
public void onCommand(CommandSenderContainer sender, String[] args) { public void onCommand(CommandSenderContainer sender, String[] args) {
if(args.length > 1) { if(args.length > 1) {
// TODO sort portal services // TODO sort portal services
/*if(AdvancedPortalsCore.getPortalServices().removePortal(args[1], sender.getPlayerContainer())) { if(portalServices.removePortal(args[1], sender.getPlayerContainer())) {
sender.sendMessage(Lang.translateColor("messageprefix.positive") + Lang.translateColor("command.remove.complete")); sender.sendMessage(Lang.translate("messageprefix.positive") + Lang.translate("command.remove.complete"));
} }
else { else {
sender.sendMessage(Lang.translateColor("messageprefix.negative") sender.sendMessage(Lang.translate("messageprefix.negative")
+ Lang.translateColor("command.remove.error")); + Lang.translate("command.remove.error"));
}*/ }
} }
else { else {
PlayerContainer player = sender.getPlayerContainer(); PlayerContainer player = sender.getPlayerContainer();
@ -32,14 +38,13 @@ public class RemoveSubCommand implements SubCommand {
sender.sendMessage(Lang.translate("command.remove.noname")); sender.sendMessage(Lang.translate("command.remove.noname"));
} }
else { else {
// TODO sort portal services if(portalServices.removePlayerSelection(player)) {
/*if(AdvancedPortalsCore.getPortalServices().removePlayerSelection(player)) {
} }
else { else {
sender.sendMessage(Lang.translateColor("messageprefix.negative") sender.sendMessage(Lang.translate("messageprefix.negative")
+ Lang.translateColor("command.remove.error")); + Lang.translate("command.remove.error"));
}*/ }
} }
} }
} }
@ -52,11 +57,10 @@ public class RemoveSubCommand implements SubCommand {
@Override @Override
public List<String> onTabComplete(CommandSenderContainer sender, String[] args) { public List<String> onTabComplete(CommandSenderContainer sender, String[] args) {
List<String> portalNames = new ArrayList<>(); List<String> portalNames = new ArrayList<>();
// TODO sort portal services for(Map.Entry<String, AdvancedPortal> portal : portalServices.getPortals()) {
/*for(Map.Entry<String, AdvancedPortal> portal : AdvancedPortalsCore.getPortalServices().getPortals()) {
portalNames.add(portal.getKey()); portalNames.add(portal.getKey());
} }
Collections.sort(portalNames);*/ Collections.sort(portalNames);
return portalNames; return portalNames;
} }

View File

@ -6,8 +6,11 @@ import com.sekwah.advancedportals.core.config.Config;
import com.sekwah.advancedportals.core.config.ConfigProvider; import com.sekwah.advancedportals.core.config.ConfigProvider;
import com.sekwah.advancedportals.core.data.DataStorage; import com.sekwah.advancedportals.core.data.DataStorage;
import com.sekwah.advancedportals.core.repository.ConfigRepository; import com.sekwah.advancedportals.core.repository.ConfigRepository;
import com.sekwah.advancedportals.core.repository.IDestinationRepository;
import com.sekwah.advancedportals.core.repository.IPortalRepository;
import com.sekwah.advancedportals.core.repository.impl.ConfigRepositoryImpl; import com.sekwah.advancedportals.core.repository.impl.ConfigRepositoryImpl;
import com.sekwah.advancedportals.core.services.PortalServices; import com.sekwah.advancedportals.core.repository.impl.DestinationRepositoryImpl;
import com.sekwah.advancedportals.core.repository.impl.PortalRepositoryImpl;
import com.sekwah.advancedportals.core.util.InfoLogger; import com.sekwah.advancedportals.core.util.InfoLogger;
import javax.annotation.Nonnull; import javax.annotation.Nonnull;
@ -31,11 +34,14 @@ public class AdvancedPortalsModule extends AbstractModule {
*/ */
@Override @Override
protected void configure() { protected void configure() {
bind(IPortalRepository.class).to(PortalRepositoryImpl.class).in(Scopes.SINGLETON);
bind(IDestinationRepository.class).to(DestinationRepositoryImpl.class).in(Scopes.SINGLETON);
bind(ConfigRepository.class).to(ConfigRepositoryImpl.class).in(Scopes.SINGLETON);
// Instances // Instances
bind(AdvancedPortalsCore.class).toInstance(advancedPortalsCore); bind(AdvancedPortalsCore.class).toInstance(advancedPortalsCore);
bind(InfoLogger.class).toInstance(advancedPortalsCore.getInfoLogger()); bind(InfoLogger.class).toInstance(advancedPortalsCore.getInfoLogger());
bind(DataStorage.class).toInstance(advancedPortalsCore.getDataStorage()); bind(DataStorage.class).toInstance(advancedPortalsCore.getDataStorage());
bind(ConfigRepository.class).to(ConfigRepositoryImpl.class).in(Scopes.SINGLETON);
// Providers // Providers
bind(Config.class).toProvider(ConfigProvider.class); bind(Config.class).toProvider(ConfigProvider.class);