Cleanup, updated some settings

src/main/java/fr/xephi/authme/listener/protocollib/AuthMeInventoryPacketAdapter.java

@@ -24,7 +24,6 @@ import com.comphenix.protocol.events.PacketContainer;
 import com.comphenix.protocol.events.PacketEvent;
 import fr.xephi.authme.AuthMe;
 import fr.xephi.authme.cache.auth.PlayerCache;
-import fr.xephi.authme.settings.Settings;
 import org.bukkit.Material;
 import org.bukkit.entity.Player;
 import org.bukkit.inventory.ItemStack;
@@ -52,8 +51,7 @@ public class AuthMeInventoryPacketAdapter extends PacketAdapter {
         PacketContainer packet = packetEvent.getPacket();
 
         byte windowId = packet.getIntegers().read(0).byteValue();
-        if (windowId == PLAYER_INVENTORY && Settings.protectInventoryBeforeLogInEnabled
+        if (windowId == PLAYER_INVENTORY && !PlayerCache.getInstance().isAuthenticated(player.getName())) {
-            && !PlayerCache.getInstance().isAuthenticated(player.getName())) {
             packetEvent.setCancelled(true);
         }
     }

src/main/java/fr/xephi/authme/process/join/AsynchronousJoin.java

@@ -65,9 +65,6 @@ public class AsynchronousJoin implements AsynchronousProcess {
     @Inject
     private BukkitService bukkitService;
 
-    @Inject
-    private ProtocolLibService protocolLibService;
-
     @Inject
     private LimboPlayerTaskManager limboPlayerTaskManager;
 

src/main/java/fr/xephi/authme/process/quit/ProcessSyncronousPlayerQuit.java

@@ -19,9 +19,6 @@ public class ProcessSyncronousPlayerQuit implements SynchronousProcess {
     @Inject
     private JsonCache jsonCache;
 
-    @Inject
-    private DataSource database;
-
     @Inject
     private ProcessService service;
 

src/main/java/fr/xephi/authme/settings/Settings.java

@@ -18,10 +18,7 @@ public final class Settings {
     public static List<String> getUnrestrictedName;
     public static boolean isPermissionCheckEnabled;
     public static boolean isTeleportToSpawnEnabled;
-    public static boolean isSessionsEnabled;
     public static boolean isAllowRestrictedIp;
-    public static boolean isSaveQuitLocationEnabled;
-    public static boolean protectInventoryBeforeLogInEnabled;
     public static boolean isStopEnabled;
     public static boolean reloadSupport;
     public static boolean noTeleport;
@@ -31,7 +28,6 @@ public final class Settings {
     public static String getRegisteredGroup;
     public static String defaultWorld;
     public static String crazyloginFileName;
-    public static int getSessionTimeout;
     public static int getNonActivatedGroup;
     private static FileConfiguration configFile;
 
@@ -48,17 +44,13 @@ public final class Settings {
     private static void loadVariables() {
         isPermissionCheckEnabled = load(PluginSettings.ENABLE_PERMISSION_CHECK);
         isTeleportToSpawnEnabled = load(RestrictionSettings.TELEPORT_UNAUTHED_TO_SPAWN);
-        isSessionsEnabled = load(PluginSettings.SESSIONS_ENABLED);
-        getSessionTimeout = configFile.getInt("settings.sessions.timeout", 10);
         isAllowRestrictedIp = load(RestrictionSettings.ENABLE_RESTRICTED_USERS);
         isRemoveSpeedEnabled = load(RestrictionSettings.REMOVE_SPEED);
-        isSaveQuitLocationEnabled = load(RestrictionSettings.SAVE_QUIT_LOCATION);
         getUnloggedinGroup = load(SecuritySettings.UNLOGGEDIN_GROUP);
         getNonActivatedGroup = configFile.getInt("ExternalBoardOptions.nonActivedUserGroup", -1);
         unRegisteredGroup = configFile.getString("GroupOptions.UnregisteredPlayerGroup", "");
         getUnrestrictedName = load(RestrictionSettings.UNRESTRICTED_NAMES);
         getRegisteredGroup = configFile.getString("GroupOptions.RegisteredPlayerGroup", "");
-        protectInventoryBeforeLogInEnabled = load(RestrictionSettings.PROTECT_INVENTORY_BEFORE_LOGIN);
         isStopEnabled = configFile.getBoolean("Security.SQLProblem.stopServer", true);
         reloadSupport = configFile.getBoolean("Security.ReloadCommand.useReloadCommandSupport", true);
         defaultWorld = configFile.getString("Purge.defaultWorld", "world");

src/test/java/fr/xephi/authme/task/PurgeServiceTest.java

@@ -126,6 +126,7 @@ public class PurgeServiceTest {
         verifyScheduledPurgeTask(null, "alpha", "charlie");
     }
 
+    @SuppressWarnings("unchecked")
     @Test
     public void shouldRecognizeNoPlayersToPurge() {
         // given