Commit Graph

1790 Commits

Author SHA1 Message Date
ljacqu
6341d00df0 Code householding - remove legacy settings and TODO messages
- Remove fields in legacy settings that are now unused
- Remove various irrelevant todo messages
- Reduce visibility on some elements
2016-05-24 18:59:01 +02:00
ljacqu
e54cd526de Add verification remarks in message files
- Result from automatic task which checks message files for missing messages or tags
2016-05-24 18:37:58 +02:00
ljacqu
8de1897412 Minor - Use explicit dependencies in ProcessService
- Replace AuthMe in favor of PermissionsManager
- Create missing tests for ProcessService
2016-05-24 18:25:38 +02:00
Gabriele C
a7d3e60abe Remove unused imports 2016-05-24 17:00:23 +02:00
Gabriele C
2a3ed384d5 Fix #720 invalid HU lang file 2016-05-24 16:51:03 +02:00
Gabriele C
55cc882002 Remove scheduler methods from the ProcessService
@ljacqu it's ok now? ;)
2016-05-24 16:07:03 +02:00
Gabriele C
5007ca45f0 Update HU language #720
Thanks to @rErEaT
2016-05-24 15:55:09 +02:00
Gabriele C
dbae4953cc Can't cancel sync player chat #722 2016-05-24 15:50:28 +02:00
Gabriele C
740b44ca36 cleanup 2016-05-23 23:49:56 +02:00
Gabriele C
da6431b4fc Suppress injection test warnings 2016-05-23 23:16:40 +02:00
ljacqu
30f62547d8 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 707-process-as-service 2016-05-23 21:41:41 +02:00
Gabriele C
7865d7dc2c Remove synchronized methods from the Cache (please check)
@Xephi @ljacqu @games647
2016-05-23 21:18:31 +02:00
Gabriele C
97e96ab16b Remove unused imports 2016-05-23 21:16:11 +02:00
Gabriele C
b3f184da78 stupid conflict 2016-05-23 21:12:12 +02:00
Gabriele C
22f54c1f3e Fix Chat Hider #719 2016-05-23 21:05:18 +02:00
Xephi
c0e8650c6f Move to antibot class 2016-05-23 10:10:01 +02:00
Xephi
37b6a2f96f Enable antibot automatically and check for bot into AsyncPreLogin #719 2016-05-23 10:03:10 +02:00
ljacqu
11350ec43a Iterate over all chat recipients 2016-05-22 10:52:34 +02:00
Gabriele C
dd5fb49065 Whoops forgot to commit this #719 2016-05-21 18:08:26 +02:00
Gabriele C
e0ef0e40c7 Add denied chat message #719 2016-05-21 18:01:21 +02:00
Gabriele C
fb6303bf4a Cleanup 2016-05-21 15:37:54 +02:00
Gabriele C
410d07a64c Remove commented code 2016-05-21 15:08:40 +02:00
Gabriele C
b2b65710b1 Also for SQLITE #719 2016-05-21 15:00:48 +02:00
Gabriele C
7a21294581 Don't use synchronized methods #719 2016-05-21 14:58:57 +02:00
Gabriele C
7ad39e2a5d Use default Hikari pool parameters 2016-05-21 14:54:03 +02:00
Gabriele C
4d06b63e64 Try to fix spambot resource leak #719 2016-05-21 14:18:31 +02:00
ljacqu
53043ddc0d Create tool task that checks Mock fields of test classes 2016-05-21 11:54:54 +02:00
Gabriele C
6af65e6cd4 Fix wrong logic (my fault) 2016-05-20 22:02:26 +02:00
Gabriele C
6285a2137f Revert "Idk why, but it doesn't work!"
This reverts commit 0c2ee34db3.
2016-05-20 22:00:52 +02:00
Gabriele C
0c2ee34db3 Idk why, but it doesn't work! 2016-05-20 21:27:47 +02:00
ljacqu
c1885a381b Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 707-process-as-service
Conflicts:
	src/main/java/fr/xephi/authme/process/join/AsynchronousJoin.java
	src/main/java/fr/xephi/authme/process/login/AsynchronousLogin.java
2016-05-20 19:48:41 +02:00
ljacqu
3f039d641a #707 Convert sync processes into services 2016-05-20 19:42:30 +02:00
ljacqu
5adf819910 Minor - remove unused services from PurgeCommand
- Found by sgdc3 in 95b65ae20a
2016-05-20 18:03:22 +02:00
ljacqu
244e1a2b7d Injector - don't use instantiation fallback if PostConstruct method is present
- Do not instantiate classes with instantiation fallback if they have a PostConstruct method - thanks @sgdc3 for the hint
- Change Injector test to check exception messages also
2016-05-20 17:57:14 +02:00
ljacqu
a355c325c5 #513 Allow to run updateDocs task from command line 2016-05-20 17:15:53 +02:00
Gabriele C
2edcb703c1 Wtf was that? D: 2016-05-20 15:53:39 +02:00
Gabriele C
8dd5420e1a Whoops 2016-05-20 15:46:46 +02:00
Gabriele C
4303dca469 Apply no teleport to the respawn listener, remove Settings usage from the PlayerListener 2016-05-20 15:45:34 +02:00
Gabriele C
6abad1970c Revert "Cleanup"
This reverts commit 95b65ae20a.
2016-05-20 14:58:41 +02:00
Gabriele C
92287cb5dd Delay the first "please login/register" message on join 2016-05-19 23:18:16 +02:00
Gabriele C
95b65ae20a Cleanup 2016-05-19 23:06:55 +02:00
ljacqu
4d634086cd #701 Alternate accounts are shown to all players with their own name 2016-05-19 22:02:15 +02:00
ljacqu
9a72fe53b0 Minor - code householding
- Update inaccurate javadoc
- Remove unnecessary require call in PHP integration sample
2016-05-19 21:55:42 +02:00
ljacqu
f014485789 Service injector - implement stricter requirements for PostConstruct methods
- Implement similar restrictions as prescribed by the PostConstruct documentation:
   - Class may have at most one method annotated with PostConstruct
   - PostConstruct method must return void
- Javadoc: replace mentions of injector construction where any injection method was meant
2016-05-19 21:50:48 +02:00
ljacqu
14002ee75c #704 Reload settings of ConsoleLogger on /authme reload 2016-05-19 19:46:02 +02:00
ljacqu
92a8a5dd41 #704 Remove reloading from hash algorithms
- A new instance is created for every hash operation, so reloading will never happen on those classes
2016-05-18 19:09:38 +02:00
ljacqu
f5c89e897f #707 Convert async processes as services
(work in progress - rough, untested changes)
2016-05-17 19:49:06 +02:00
ljacqu
3ad76b8ec5 #712 fr messages - add untranslated messages and minor fixes 2016-05-16 17:50:26 +02:00
Gabriele C
df2329fd9a Fix conflict 2016-05-16 16:27:59 +02:00
Xephi59
9db330646e Try to fix #419 2016-05-15 17:52:54 +02:00
games647
0fc7674aa4 Introduce isLogin() for backwards compatibility with Plugins like
GuiRules (Fixes #705)
2016-05-14 14:40:56 +02:00
Gabriele C
c2c60caa5b Revert "Fix #705"
This reverts commit 9e688b410d.
2016-05-14 14:33:30 +02:00
Gabriele C
9e688b410d Fix #705
Idk why the player becomes null, maybe the isOnline check is enought
2016-05-14 00:25:24 +02:00
Gabriele C
c748501345 Fix Multiverse dependency + fix invalid test in Eclipse 2016-05-14 00:01:26 +02:00
ljacqu
9f5b995217 Fix datasource resource closing tests (#1) 2016-05-12 20:15:44 +02:00
ljacqu
e04f7dc711 #704 Implement reloading via injector
- Create interfaces Reloadable and SettingsDependent to recognize reloadable classes
- Iterate through instances in injector to reload
2016-05-12 19:51:10 +02:00
games647
5c850e46c4 Clean up a bit 2016-05-11 17:16:29 +02:00
games647
4bad04b160 Add debug statements for finding the source of #419 2016-05-11 16:57:41 +02:00
games647
b1957c9812 Do not lookup twice for banned players 2016-05-09 21:51:21 +02:00
games647
45ddacc88a Merge origin/master into balancedPurge 2016-05-09 21:16:39 +02:00
ljacqu
223f56425b #699 Unit test that config.yml values correspond to property defaults
- Create unit test
- Correct offending values
2016-05-09 21:15:11 +02:00
games647
3673e15ff7 Fix missing change from ee08087871
(Fixes #697) Thanks to @ljacqu for pointing that out
2016-05-09 21:04:38 +02:00
games647
74041725fa Collect offline players only once 2016-05-09 13:17:20 +02:00
games647
0bd6ac5cc8 Make the purge progress run more balanced (Fixes #696) 2016-05-09 13:09:40 +02:00
ljacqu
b728b297b8 #256 Add migration for moved properties 2016-05-08 22:30:53 +02:00
ljacqu
f2e49dbf1e Minor - fix compilation of task tool class list
- Set is declared as ToolTask but all elements extend from AutoToolTask, so the Set type is resolved to a too specific type
2016-05-08 21:55:08 +02:00
games647
ee08087871 Fix a couple race conditions (Fixes #698 and #697) 2016-05-08 20:44:18 +02:00
ljacqu
23da023d53 #513 Mark tools runnable by command line with specific interface 2016-05-08 17:22:02 +02:00
ljacqu
662f28ab4f #513 Fix class loading issue when running from mvn exec:java 2016-05-08 17:01:06 +02:00
ljacqu
8e878d6a5a Remove BukkitService from CommandService, inject where needed instead 2016-05-08 13:50:20 +02:00
ljacqu
5e5836f167 #432 Injector improvements
- Separate FieldInjection from default fallback for no-Inject public no-args constructor classes
- Make CommandInitializer a normal, instantiable service
- Add various injections instead of fetching through command service
2016-05-08 11:15:56 +02:00
Gabriele C
3e6223dc5a I'm so stupid 2016-05-05 23:01:06 +02:00
Gabriele C
084cdd0d3a Allow tool execution with argument 2016-05-05 20:20:40 +02:00
Gabriele C
09e2845cea Delete unused Profiler 2016-05-05 19:43:12 +02:00
Gabriele C
76a1ff29b0 Start working on #423 2016-05-05 19:36:26 +02:00
Gabriele C
dc65a4bd39 Fix #439 2016-05-05 19:16:08 +02:00
Gabriele C
fb4dd260f8 Correct pom properties 2016-05-05 18:39:35 +02:00
ljacqu
3fe2f0b6a8 Add missing test matcher
- Mock verifications need matchers on all parameters, or on none. Test fails otherwise
2016-05-04 18:40:06 +02:00
Gabriele C
7c52460c87 Merge branch 'pre-injector' 2016-05-04 18:03:33 +02:00
Gabriele C
1ea2f98727 Start working on #687
Next step: Future return of the async registration
2016-05-04 18:01:47 +02:00
Gabriele C
f38d3b4545 Remove deprecated method usage 2016-05-04 17:35:04 +02:00
Gabriele C
5ceabe2146 Cleanup 2016-05-04 17:26:58 +02:00
Gabriele C
39aaef8f8a Pom enhancements 2016-05-04 17:12:14 +02:00
ljacqu
67aea654cc #432 Fix broken tool tasks 2016-05-03 20:44:01 +02:00
ljacqu
3645806edc Move tools folder into test folder
- Classes still won't be present in JAR but classes will be automatically compiled by Maven inside of the test scope, facilitating the execution of tool tasks
2016-05-03 20:27:12 +02:00
ljacqu
23317caa46 Merge pull request #125 from AuthMe-Team/432-dependency-injection
432 dependency injection
2016-05-03 18:54:35 +02:00
NoChanceSD
0ea95fb93c Simplify force spawn location settings by grouping them
Also, seems to work fine. Closes https://github.com/Xephi/AuthMeReloaded/issues/256
2016-05-03 16:36:05 +01:00
ljacqu
491dc06de4 Fix RegisterAdminCommand test verifying that online player is kicked 2016-05-02 19:57:54 +02:00
ljacqu
f76a68cb26 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 432-dependency-injection
Conflicts:
	src/main/java/fr/xephi/authme/AuthMe.java
	src/main/java/fr/xephi/authme/command/executable/authme/RegisterAdminCommand.java
	src/main/java/fr/xephi/authme/hooks/PluginHooks.java
	src/main/java/fr/xephi/authme/listener/AuthMePlayerListener.java
	src/main/java/fr/xephi/authme/listener/AuthMeServerListener.java
	src/test/java/fr/xephi/authme/command/executable/authme/RegisterAdminCommandTest.java
2016-05-02 19:48:12 +02:00
ljacqu
9af596327a #432 Inject in commands: DataSource / AntiBot / PasswordSecurity / PlayerCache
- Inject the services instead of passing them through the command service
2016-05-02 18:52:34 +02:00
Xephi59
20a237dbdf [DEV] This test would fail until player couldn't be returned as he was
kicked
2016-05-02 03:38:25 +02:00
Xephi59
e97b4641a1 Kick player only Synchronously 2016-05-02 02:39:53 +02:00
Xephi59
121dd7e6fb Add Spigot API - 1.9 PlayerSpawnLocationEvent 2016-05-02 02:13:19 +02:00
ljacqu
1f0f3f1bea #675 Clean up country protection code
- Move validation to validation service
2016-04-30 14:11:38 +02:00
games647
c8b191fda0 Add warning if hideTablist is not compatible with the mc version
(Fixes #680)
2016-04-30 13:05:31 +02:00
ljacqu
e6dacd6951 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 432-dependency-injection 2016-04-30 12:17:33 +02:00
ljacqu
3c6415a6a4 #432 Use injector instantiate hash algorithms 2016-04-30 12:17:18 +02:00
ljacqu
908399e271 #432 Injector - prevent static field injection, add more tests 2016-04-30 10:44:32 +02:00
ljacqu
b32e5da4c5 #611 Admin unregister forces player to register even for optional registration
- Make /authme unregister behave the same way as /unregister for optional registration: user is informed but can continue playing; no teleportation to spawn
2016-04-30 09:30:52 +02:00
ljacqu
2c491803d3 Injector - disallow static PostConstruct methods, add more tests 2016-04-29 23:49:03 +02:00
ljacqu
7f44ecdb40 Create event consistency test + test code cleanup 2016-04-29 22:39:46 +02:00
ljacqu
8d489efffd #683 Plaintext to SHA256: Add warning message + skip SHA hashes
- Add message not to stop the server before conversion finishes
- Skip hashes starting with $SHA$ during conversion
- Create unit tests
2016-04-29 21:58:32 +02:00
ljacqu
077cb242f0 #550 Show welcome message only after login
- Never send welcome message just after registration (with no subsequent login)
- Always run force command options upon registration
2016-04-29 21:16:42 +02:00
ljacqu
ee08eb9efb Replace Java 1.8 method with 1.7 2016-04-27 23:15:32 +02:00
ljacqu
5963628fa6 #432 Add field injection to AccountsCommand 2016-04-27 22:59:44 +02:00
ljacqu
02079f1f5c #432 Create custom dependency injector 2016-04-27 22:49:20 +02:00
ljacqu
59d3bc95c0 Move getOnlinePlayers() from Utils to BukkitService; delete Wrapper 2016-04-23 15:24:41 +02:00
ljacqu
a78e0408c6 #449 Remove use of legacy settings in encryption methods 2016-04-23 12:46:30 +02:00
ljacqu
ee745f153d messages_de consistency: Lowercase all occurrences of "du" 2016-04-23 11:06:33 +02:00
Very Evil Olaf
229c8429cb Minor fixes
Some grammar stuff and eye candy
2016-04-23 08:37:46 +02:00
ljacqu
0dab887848 Code householding
- Various migrations from legacy settings to new settings
- PlayerListener: use shouldCancelEvent() to see if chat should be canceled
- Merge permission manager listener with general server listener
2016-04-23 00:18:03 +02:00
ljacqu
1182b58b99 Player listener - migrate legacy setting use to new settings 2016-04-22 21:55:25 +02:00
ljacqu
2cd43d599d Minor - MyBB has alphanumerical salts, not restricted to hexadecimal 2016-04-22 21:24:37 +02:00
games647
c67527aac0 Fix vanished players are visible after join (Fixes #670) 2016-04-22 17:04:46 +02:00
ljacqu
00cb01b3bd #663 Don't print stacktrace when encountering invalid hash formats 2016-04-21 18:05:47 +02:00
ljacqu
e818395575 #667 /authme switchantibot throws NullPointerException
- Antibot was not provided to CommandService (from where it's retrieved in the SwitchAntiBot command) because it was initialized afterwards
2016-04-20 21:39:13 +02:00
ljacqu
37fb29f8b9 #638 Register with Wordpress fails with SQL exception
- Remove semicolon in query, looks like executeBatch() does not like it
2016-04-20 21:22:57 +02:00
Maxetto
af2d493796 Update messages_it.yml
Added new translations,
Added Color Codes,
Reflect more the English one,
Consistency Update between Italian terms,
Reordered the lines to reflect the English ones.
(cherry picked from commit f747475)
2016-04-19 19:09:15 +02:00
ljacqu
92c476785b Remove generated code / allow import of new languages
- Exporting back messages to the remote server is now handled by IP whitelisting, not with temporary codes
2016-04-17 23:17:38 +02:00
ljacqu
354581160a Change export messages task to send updated file to remote server 2016-04-17 12:17:22 +02:00
ljacqu
6c49f5844f Improve saving in messages import
- Keep same style (messages wrapped in single quotes)
- Remove verification comments and run verification after merge again
2016-04-16 11:47:18 +02:00
ljacqu
f4bc4322f0 Create export/import messages task
- Allows communication with a web interface (PHP) to translate messages
- Saving via import still needs to be improved
2016-04-15 23:03:19 +02:00
Gabriele C
4911499333 Allow player falling, avoid useless lag and deny jumps! #618 2016-04-15 22:16:13 +02:00
Gabriele C
4040cd9ba6 #658 Add hide_chat setting 2016-04-15 21:50:32 +02:00
ljacqu
6c9297a667 #647 Update Hungarian messages
- By rErEaT
2016-04-15 15:21:29 +02:00
ljacqu
3674ac087c Code householding + settings migration
- Migrate and remove unused properties in legacy Settings
- Add forgotten space in Register command
- Fix javadoc errors shown on Jenkins
2016-04-15 15:17:58 +02:00
ljacqu
71515f188a #551 Email registration should fail if no server email is configured
- Stop registration and issue an error if the email address setting is empty for email registration
- Refactor register command into smaller portions
- Create tests
2016-04-15 14:37:47 +02:00
ljacqu
6074ba59d5 #654 Add test verifying nothing is sent for empty message
- Including various test simplifications
2016-04-15 12:27:34 +02:00
Gabriele C
b825f52a16 Ignore message if string is empty 2016-04-14 18:09:38 +02:00
ljacqu
ca0cbe6caf Code householding
- Move console initialization for tests into TestHelper
- Remove unused properties in legacy Settings
- Add issue number to TODO comments where applicable
2016-04-14 12:28:19 +02:00
ljacqu
3bb7ff2b85 #653 Empty salt column causes error when retrieving password
- Handle potentially empty salt column in MySQL and SQLite
- Create unit tests reflecting these cases
2016-04-14 11:48:24 +02:00
ljacqu
b7232d4508 Delete module code
- Remove code that has been unused for months. If modules come into discussion again it is better to start afresh once requirements are clearer
2016-04-09 14:55:39 +02:00
ljacqu
e2b50b72a5 Get player via BukkitService; add unit tests for commands 2016-04-08 19:56:44 +02:00
Gabriele C
0cda9a7698 cleanup 2016-04-08 14:44:18 +02:00
Gabriele C
30d109b01b Remove IPManager test 2016-04-08 14:35:42 +02:00
Gabriele C
ee177e8a3a Remove the IPManager
We don't need it anymore
2016-04-08 14:34:21 +02:00
Gabriele C
4ec98e5b3d Fix #646
Thanks to @hakumanatatu
2016-04-07 22:57:20 +02:00
Gabriele C
68ef28df08 Fix minor issues 2016-04-07 22:51:02 +02:00
Gabriele C
d56b63c5f0 Fix #644 2016-04-07 22:39:35 +02:00
Gabriele C
ee3299afd2 Fix startup error #643 2016-04-07 19:10:57 +02:00
ljacqu
83c02f487f Minor - improve previous commit 2016-04-07 17:48:33 +02:00
ljacqu
b3a3843b60 Tools: doc templates - add support for iterating tags
- Support iterating tags
- Generate (update) all docs
2016-04-07 17:19:52 +02:00
games647
70fbca3c47 Re-enable hideTablist because it's compatible with SkinRestorer 2016-04-06 15:20:29 +02:00
games647
d19d1772ba
Fix other players are invisble on hideTablist 2016-04-05 21:31:55 +02:00
games647
17ae88c94b
Fix other players are invisble on hideTablist 2016-04-05 21:30:32 +02:00
games647
48c5dd03bd
Fix restore of tablist hider 2016-04-05 21:22:19 +02:00
ljacqu
9ea75c502c #567 Move email validation logic to validation service 2016-04-03 20:44:13 +02:00
ljacqu
b6ccb3e632 #567 Add/change email should be aware of account threshold 2016-04-03 14:24:12 +02:00
Gabriele C
88e517635c wtf was that xD 2016-04-03 13:03:16 +02:00
ljacqu
c079692f1d Minor - code householding (tests)
- Remove redundant uses of WrapperMock
- Use assertThat() from JUnit, not hamcrest
- Use hamcrest Matchers everywhere (not BaseMatchers etc.)
- Favor Mockito's argThat() over using ArgumentCaptor (more succinct)
- Delete useless test classes
2016-04-03 07:38:13 +02:00