ljacqu
d81ef3168e
Command refactor - remove unused fields, reduce variable "scope"
...
Minor refactorings in the command section for familiarization.
1. Removed suppressWarning("Deprecated") - the method is deprecated for a reason and we should be made aware of that.
2. Removed same javadoc on ExecutableCommand implementation that just had the same as the interface (this is just clutter; @Override signals that it's an implementing class and a developer can view the superclass javadoc)
3. In places where the AuthMe instance was retrieved at the top but used at the very bottom, moved it to the bottom to reduce its "scope"
2015-11-21 17:18:14 +01:00
Tim Visée
8387924c64
Merge pull request #68 from ljacqu/master
...
Revert certain JavaDoc changes
2015-11-21 16:57:17 +01:00
Tim Visée
8181bda762
Minor update to hasGroupSupport method in permissions manager
2015-11-21 16:26:05 +01:00
Tim Visée
bb22daab33
Added some missing support for Nijikokun's Permissions in permissions manager
2015-11-21 16:21:38 +01:00
Tim Visée
6dc4066563
Added group support check to setGroups method in Utils class
2015-11-21 16:08:41 +01:00
Tim Visée
eaba2765fa
Created hasGroupSupport method in permissions manager
2015-11-21 16:07:02 +01:00
Tim Visée
69d6518b30
Improved setGroup method in Utils class, to replace legacy permissions code
2015-11-21 16:03:00 +01:00
Tim Visée
973c683c90
Minor fix for PermissionsBukkit support in permissions manager
2015-11-21 15:47:59 +01:00
Tim Visée
cfaece3eae
Simplefied some code
2015-11-21 15:46:10 +01:00
Tim Visée
f8cf9e2e48
Created inGroup method in permissions manager
2015-11-21 15:44:57 +01:00
Tim Visée
a05a97a0a6
Fixed setGroup method in permissions manager
2015-11-21 15:38:20 +01:00
Tim Visée
1091db0e15
Created removeAllGroups method in permissions manager
2015-11-21 15:34:38 +01:00
Tim Visée
f7f455a56a
Created setGroups method in permissions manager
2015-11-21 15:24:53 +01:00
Tim Visée
a84e219899
Fixed minor Essentials Group Manager issue in addGroup method of permissions manager
2015-11-21 15:18:01 +01:00
Tim Visée
462a2e9878
Created removeGroups method in permissions manager
2015-11-21 15:16:19 +01:00
Tim Visée
bcf4eeab00
Created removeGroup method in permissions manager
2015-11-21 15:15:04 +01:00
Tim Visée
b07e4b62cc
Created addGroups method in permissions manager
2015-11-21 15:07:46 +01:00
Tim Visée
a6fe728d79
Fixed addGroup method for PermissionsBukkit in permissions manager
2015-11-21 15:00:14 +01:00
Tim Visée
f4da63fee6
Added note to getGroups method in permissions manager for PermissionsBukkit
2015-11-21 14:57:34 +01:00
Tim Visée
42dee2e101
Created addGroup method in permissions manager
2015-11-21 14:44:43 +01:00
Tim Visée
400d014e7b
Fixed setGroup in PermissionsManager for Essentials Group Manager and zPermissions
2015-11-21 14:41:14 +01:00
ljacqu
9a68aa5517
Proper Javadoc example / add test for StringUtils
...
- Proper example for the purpose of javadoc and how it could look like
- Fix containsAny to be null safe
- Add tests
2015-11-21 08:28:53 +01:00
ljacqu
38cc217cff
Revert certain JavaDoc changes
...
Ideally JavaDoc should provide additional information to the developer
as to the method's purpose and usage. Typically you do not add the
return type of the method and the parameter's types since this can be
seen in the code.
A short description of what the parameter really is (e.g. a String can
hold many types of information) is a lot more beneficial. A JavaDoc
statement simply restating the parameter types and the method name is,
put bluntly, simply noise, since all of these things are already
contained in the code itself.
Similarly, @see references are great for pointing to other, related
methods but aren't very helpful to point to a superclass method (the
implemented or overriden method) since it is implied by @Override. A
developer can navigate easily to the superclass method with any
reasonable IDE.
2015-11-21 07:41:56 +01:00
Tim Visée
504106f835
Added base of setGroup method in permissions manager
2015-11-21 03:01:45 +01:00
Tim Visée
06d6bd4a7e
Fixed formatting in PermissionsManager class
2015-11-21 02:43:32 +01:00
Tim Visée
5ff9b7550e
Combined Plugin and Server listener, removed plugin listener
2015-11-21 02:33:59 +01:00
Gabriele C
bd1f868c6d
standard javadoc
2015-11-21 01:31:18 +01:00
Gabriele C
118c79401a
Prepare the project for javadocs
2015-11-21 01:27:06 +01:00
Gabriele C
adcd70b91d
auto cleanup
2015-11-21 01:15:52 +01:00
Gabriele C
ada992785c
login process cleanup
2015-11-21 00:36:46 +01:00
Gabriele C
68ae6ee701
remove useless inventory store event
2015-11-20 23:59:25 +01:00
Gabriele C
d6355adb51
cleanup
2015-11-20 23:52:20 +01:00
Gabriele C
ba483af807
fix project layout
2015-11-20 23:43:26 +01:00
Gabriele C
35ef562d35
Update pom.xml
2015-11-20 23:36:25 +01:00
Gabriele C
4d2e48ede7
Merge pull request #67 from ljacqu/unit-tests
...
Unit tests
2015-11-20 23:23:49 +01:00
ljacqu
84de22c9c0
Refactor Log4JFilter and improve branch coverage
2015-11-20 23:17:50 +01:00
ljacqu
019390dfe0
Add unit test dependencies and create test for Log4JFilter
...
Note that the new dependencies in the pom have the scope set to test, so
they will not be included into the built artifact. A first test class
illustrates the general way unit tests can be set up with JUnit, Mockito
and Hamcrest matchers.
2015-11-20 23:00:13 +01:00
Tim Visée
4978f195f8
Use different logger in permissions manager
2015-11-20 20:50:45 +01:00
Tim Visée
9932242f6f
Merge pull request #66 from AuthMe-Team/PermissionsManager
...
Created permissions manager, with proper permissions support
2015-11-20 20:42:06 +01:00
Tim Visée
a4b2306e16
Added some comments to legacy permissions methods
2015-11-20 20:23:52 +01:00
Tim Visée
3500ee6fb7
Replaced code that used legacy deprecated permissions methods
2015-11-20 20:23:03 +01:00
Tim Visée
33ca2691b2
Updated deprecated information for legacy permission methods
2015-11-20 20:16:02 +01:00
Tim Visée
8ba126b681
Updated permissions checking system in command handler
2015-11-20 20:13:23 +01:00
Tim Visée
10b69403fc
Deprecated legacy permissions methods
2015-11-20 20:11:46 +01:00
Tim Visée
ffd36ba325
Updated authmePermissable methods in main class
2015-11-20 20:08:02 +01:00
Tim Visée
eae6eb384f
Updated soft depends
2015-11-20 20:04:59 +01:00
Tim Visée
5e7e7a14fd
Added comment to permissions manager
2015-11-20 20:03:44 +01:00
Tim Visée
71e24fe80a
Improved permissions manager
2015-11-20 20:01:43 +01:00
Tim Visée
82e65250b8
Added permissions manager to main class, along with a setup and get method
2015-11-20 20:01:31 +01:00
Tim Visée
f17f1fe5fb
Fixed plugin listener
2015-11-20 19:56:06 +01:00
