mirror of
https://github.com/PaperMC/Folia.git
synced 2025-01-24 21:51:24 +01:00
7595ff6bb2
It must be marked as completed during that lock hold since the waiters field is set to null. Thus, any other thread attempting a cancellation will fail to remove from waiters. Also, any other thread attempting to cancel may set the completed field to true which would cause accept() to fail as well. Completion was always designed to happen while holding the scheduling lock to prevent these race conditions. The code was originally set up to complete while not holding the scheduling lock to avoid invoking callbacks while holding the lock, however the access to the completion field was not considered. Resolve this by marking the callback as completed during the lock, but invoking the accept() function after releasing the lock. This will prevent any cancellation attempts to be blocked, and allow the current thread to complete the callback without any issues. |
||
|---|---|---|
| .. | ||
| 0001-Build-changes.patch | ||
| 0002-MC-Dev-fixes.patch | ||
| 0003-New-player-chunk-loader-system.patch | ||
| 0004-Make-ChunkStatus.EMPTY-not-rely-on-the-main-thread-f.patch | ||
| 0005-Threaded-Regions.patch | ||
| 0006-Increase-parallelism-for-neighbour-writing-chunk-sta.patch | ||
| 0007-Cache-whether-region-files-do-not-exist.patch | ||
| 0008-Max-pending-logins.patch | ||
| 0009-Add-chunk-system-throughput-counters-to-tps.patch | ||
| 0010-Make-CraftEntity-getHandle-and-overrides-perform-thr.patch | ||
| 0011-Disable-mid-tick-task-execution.patch | ||
| 0012-Throw-UnsupportedOperationException-for-broken-APIs.patch | ||
| 0013-Fix-tests-by-removing-them.patch | ||
| 0014-Work-around-https-github.com-PaperMC-paperweight-iss.patch | ||
| 0015-Require-plugins-to-be-explicitly-marked-as-Folia-sup.patch | ||
| 0016-Acquire-scheduling-lock-in-NewChunkHolder-onFullChun.patch | ||
| 0017-Fix-destroying-beehive-without-any-players-nearby-th.patch | ||
| 0018-Lag-compensate-block-breaking.patch | ||
| 0019-Prevent-block-updates-in-non-loaded-or-non-owned-chu.patch | ||
| 0020-Block-reading-in-world-tile-entities-on-worldgen-thr.patch | ||
| 0021-Skip-worldstate-access-when-waking-players-up-during.patch | ||
| 0022-Break-redstone-on-top-of-trap-doors-early.patch | ||
| 0023-Do-not-access-POI-data-for-lodestone-compass.patch | ||
| 0024-Undo-making-JavaPlugin-logger-field-public.patch | ||
| 0025-Use-coordinate-based-locking-to-increase-chunk-syste.patch | ||
| 0026-Fix-concurrenct-access-to-lookups-field-in-RegistryO.patch | ||
| 0027-Synchronize-PaperPermissionManager.patch | ||
| 0028-Mark-POI-Entity-load-tasks-as-completed-before-relea.patch | ||