Upstream/Minestom
1
0
Fork 0
mirror of https://github.com/Minestom/Minestom.git synced 2025-02-05 06:51:22 +01:00
Code Issues Projects Releases Wiki Activity

Avoid unnecessary volatile read

Browse Source
This commit is contained in:
themode 2021-12-24 10:12:27 +01:00 committed by TheMode
parent dd27edee50
commit 8ae02109b9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/net/minestom/server/network/packet/server/CachedPacket.java
View File

@ -48,7 +48,7 @@ public final class CachedPacket implements SendablePacket {
public @NotNull ByteBuffer body() { public @NotNull ByteBuffer body() {
FramedPacket cache = updatedCache(); FramedPacket cache = updatedCache();
return cache != null ? cache.body() : PacketUtils.createFramedPacket(packet()); return cache != null ? cache.body() : PacketUtils.createFramedPacket(packetSupplier.get());
} }
private @Nullable FramedPacket updatedCache() { private @Nullable FramedPacket updatedCache() {
@ -57,7 +57,7 @@ public final class CachedPacket implements SendablePacket {
SoftReference<FramedPacket> ref; SoftReference<FramedPacket> ref;
FramedPacket cache; FramedPacket cache;
if (updated == 0 || ((ref = packet) == null || (cache = ref.get()) == null)) { if (updated == 0 || ((ref = packet) == null || (cache = ref.get()) == null)) {
cache = PacketUtils.allocateTrimmedPacket(packet()); cache = PacketUtils.allocateTrimmedPacket(packetSupplier.get());
this.packet = new SoftReference<>(cache); this.packet = new SoftReference<>(cache);
UPDATER.compareAndSet(this, 0, 1); UPDATER.compareAndSet(this, 0, 1);
} }