2018-07-26 01:05:07 +02:00
|
|
|
From a5933b1c3c740f9eb59ce6db6ea847ee2a588a26 Mon Sep 17 00:00:00 2001
|
2016-11-04 06:33:08 +01:00
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Thu, 3 Nov 2016 21:52:22 -0400
|
2016-11-04 06:55:36 +01:00
|
|
|
Subject: [PATCH] Prevent Auto Save if Save Queue is full
|
2016-11-04 06:33:08 +01:00
|
|
|
|
2016-11-04 06:55:36 +01:00
|
|
|
If the save queue already has 50 (configurable) of chunks pending,
|
|
|
|
then avoid processing auto save (which would add more)
|
2016-11-04 06:33:08 +01:00
|
|
|
|
2016-11-04 06:55:36 +01:00
|
|
|
diff --git a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
2018-07-26 01:05:07 +02:00
|
|
|
index 189ec79f05..4d0f2051aa 100644
|
2016-11-04 06:55:36 +01:00
|
|
|
--- a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
|
|
|
+++ b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
2018-07-24 02:24:44 +02:00
|
|
|
@@ -316,6 +316,11 @@ public class PaperWorldConfig {
|
2016-11-04 06:55:36 +01:00
|
|
|
maxAutoSaveChunksPerTick = getInt("max-auto-save-chunks-per-tick", 24);
|
|
|
|
}
|
|
|
|
|
|
|
|
+ public int queueSizeAutoSaveThreshold = 50;
|
|
|
|
+ private void queueSizeAutoSaveThreshold() {
|
|
|
|
+ queueSizeAutoSaveThreshold = getInt("save-queue-limit-for-auto-save", 50);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
public boolean removeCorruptTEs = false;
|
|
|
|
private void removeCorruptTEs() {
|
|
|
|
removeCorruptTEs = getBoolean("remove-corrupt-tile-entities", false);
|
2016-11-04 06:33:08 +01:00
|
|
|
diff --git a/src/main/java/net/minecraft/server/ChunkProviderServer.java b/src/main/java/net/minecraft/server/ChunkProviderServer.java
|
2018-07-26 01:05:07 +02:00
|
|
|
index aa8d25e765..c1a42e61e7 100644
|
2016-11-04 06:33:08 +01:00
|
|
|
--- a/src/main/java/net/minecraft/server/ChunkProviderServer.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/ChunkProviderServer.java
|
2018-07-26 01:05:07 +02:00
|
|
|
@@ -260,6 +260,14 @@ public class ChunkProviderServer implements IChunkProvider {
|
2018-07-16 22:08:09 +02:00
|
|
|
ArrayList arraylist = Lists.newArrayList(this.chunks.values());
|
|
|
|
Iterator iterator = arraylist.iterator();
|
2016-11-04 06:33:08 +01:00
|
|
|
|
|
|
|
+ // Paper start
|
|
|
|
+ final ChunkRegionLoader chunkLoader = (ChunkRegionLoader) world.getChunkProviderServer().chunkLoader;
|
2016-11-04 06:55:36 +01:00
|
|
|
+ final int queueSize = chunkLoader.getQueueSize();
|
|
|
|
+ if (queueSize > world.paperConfig.queueSizeAutoSaveThreshold){
|
2016-11-04 06:33:08 +01:00
|
|
|
+ return false;
|
|
|
|
+ }
|
2016-11-04 06:55:36 +01:00
|
|
|
+ final int autoSaveLimit = world.paperConfig.maxAutoSaveChunksPerTick;
|
2016-11-04 06:33:08 +01:00
|
|
|
+ // Paper end
|
|
|
|
while (iterator.hasNext()) {
|
|
|
|
Chunk chunk = (Chunk) iterator.next();
|
2018-07-16 22:08:09 +02:00
|
|
|
|
2018-07-26 01:05:07 +02:00
|
|
|
@@ -271,7 +279,7 @@ public class ChunkProviderServer implements IChunkProvider {
|
2017-08-12 23:32:01 +02:00
|
|
|
this.saveChunk(chunk, false); // Spigot
|
2018-07-16 22:08:09 +02:00
|
|
|
chunk.a(false);
|
2016-11-04 06:33:08 +01:00
|
|
|
++i;
|
|
|
|
- if (!flag && i >= world.paperConfig.maxAutoSaveChunksPerTick) { // Spigot - // Paper - Incremental Auto Save - cap max per tick
|
|
|
|
+ if (!flag && i >= autoSaveLimit) { // Spigot - // Paper - Incremental Auto Save - cap max per tick
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/ChunkRegionLoader.java b/src/main/java/net/minecraft/server/ChunkRegionLoader.java
|
2018-07-26 01:05:07 +02:00
|
|
|
index 2f1488ee53..859148cb86 100644
|
2016-11-04 06:33:08 +01:00
|
|
|
--- a/src/main/java/net/minecraft/server/ChunkRegionLoader.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/ChunkRegionLoader.java
|
2018-07-19 06:42:43 +02:00
|
|
|
@@ -137,6 +137,8 @@ public class ChunkRegionLoader implements IChunkLoader, IAsyncChunkSaver {
|
2018-07-16 22:08:09 +02:00
|
|
|
}
|
2016-11-04 06:33:08 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
+ public int getQueueSize() { return queue.size(); } // Paper
|
2017-04-29 02:25:52 +02:00
|
|
|
+
|
|
|
|
// CraftBukkit start - Add async variant, provide compatibility
|
|
|
|
@Nullable
|
2018-07-16 22:08:09 +02:00
|
|
|
public synchronized Chunk a(GeneratorAccess generatoraccess, int i, int j, Consumer<Chunk> consumer) throws IOException {
|
2016-11-04 06:33:08 +01:00
|
|
|
--
|
2018-07-04 09:55:24 +02:00
|
|
|
2.18.0
|
2016-11-04 06:33:08 +01:00
|
|
|
|