2018-07-04 09:55:24 +02:00
|
|
|
From 8b4d08357734d240e14b6cef4b3ad9563cbfb822 Mon Sep 17 00:00:00 2001
|
2016-11-04 06:33:08 +01:00
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Thu, 3 Nov 2016 21:52:22 -0400
|
2016-11-04 06:55:36 +01:00
|
|
|
Subject: [PATCH] Prevent Auto Save if Save Queue is full
|
2016-11-04 06:33:08 +01:00
|
|
|
|
2016-11-04 06:55:36 +01:00
|
|
|
If the save queue already has 50 (configurable) of chunks pending,
|
|
|
|
then avoid processing auto save (which would add more)
|
2016-11-04 06:33:08 +01:00
|
|
|
|
2016-11-04 06:55:36 +01:00
|
|
|
diff --git a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
2018-07-04 09:55:24 +02:00
|
|
|
index 93b0af036..086a7fdaa 100644
|
2016-11-04 06:55:36 +01:00
|
|
|
--- a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
|
|
|
+++ b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
2018-05-30 22:31:55 +02:00
|
|
|
@@ -380,6 +380,11 @@ public class PaperWorldConfig {
|
2016-11-04 06:55:36 +01:00
|
|
|
maxAutoSaveChunksPerTick = getInt("max-auto-save-chunks-per-tick", 24);
|
|
|
|
}
|
|
|
|
|
|
|
|
+ public int queueSizeAutoSaveThreshold = 50;
|
|
|
|
+ private void queueSizeAutoSaveThreshold() {
|
|
|
|
+ queueSizeAutoSaveThreshold = getInt("save-queue-limit-for-auto-save", 50);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
public boolean removeCorruptTEs = false;
|
|
|
|
private void removeCorruptTEs() {
|
|
|
|
removeCorruptTEs = getBoolean("remove-corrupt-tile-entities", false);
|
2016-11-04 06:33:08 +01:00
|
|
|
diff --git a/src/main/java/net/minecraft/server/ChunkProviderServer.java b/src/main/java/net/minecraft/server/ChunkProviderServer.java
|
2018-07-04 09:55:24 +02:00
|
|
|
index db81b4a8c..93e938a9d 100644
|
2016-11-04 06:33:08 +01:00
|
|
|
--- a/src/main/java/net/minecraft/server/ChunkProviderServer.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/ChunkProviderServer.java
|
2016-11-17 03:23:38 +01:00
|
|
|
@@ -254,6 +254,14 @@ public class ChunkProviderServer implements IChunkProvider {
|
2016-11-04 06:33:08 +01:00
|
|
|
int i = 0;
|
|
|
|
|
|
|
|
// CraftBukkit start
|
|
|
|
+ // Paper start
|
|
|
|
+ final ChunkRegionLoader chunkLoader = (ChunkRegionLoader) world.getChunkProviderServer().chunkLoader;
|
2016-11-04 06:55:36 +01:00
|
|
|
+ final int queueSize = chunkLoader.getQueueSize();
|
|
|
|
+ if (queueSize > world.paperConfig.queueSizeAutoSaveThreshold){
|
2016-11-04 06:33:08 +01:00
|
|
|
+ return false;
|
|
|
|
+ }
|
2016-11-04 06:55:36 +01:00
|
|
|
+ final int autoSaveLimit = world.paperConfig.maxAutoSaveChunksPerTick;
|
2016-11-04 06:33:08 +01:00
|
|
|
+ // Paper end
|
|
|
|
Iterator iterator = this.chunks.values().iterator();
|
|
|
|
while (iterator.hasNext()) {
|
|
|
|
Chunk chunk = (Chunk) iterator.next();
|
2016-11-17 03:23:38 +01:00
|
|
|
@@ -267,7 +275,7 @@ public class ChunkProviderServer implements IChunkProvider {
|
2017-08-12 23:32:01 +02:00
|
|
|
this.saveChunk(chunk, false); // Spigot
|
2016-11-04 06:33:08 +01:00
|
|
|
chunk.f(false);
|
|
|
|
++i;
|
|
|
|
- if (!flag && i >= world.paperConfig.maxAutoSaveChunksPerTick) { // Spigot - // Paper - Incremental Auto Save - cap max per tick
|
|
|
|
+ if (!flag && i >= autoSaveLimit) { // Spigot - // Paper - Incremental Auto Save - cap max per tick
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/ChunkRegionLoader.java b/src/main/java/net/minecraft/server/ChunkRegionLoader.java
|
2018-07-04 09:55:24 +02:00
|
|
|
index 8747d9a45..77943821e 100644
|
2016-11-04 06:33:08 +01:00
|
|
|
--- a/src/main/java/net/minecraft/server/ChunkRegionLoader.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/ChunkRegionLoader.java
|
2017-08-12 23:32:01 +02:00
|
|
|
@@ -39,6 +39,8 @@ public class ChunkRegionLoader implements IChunkLoader, IAsyncChunkSaver {
|
2017-04-29 02:25:52 +02:00
|
|
|
this.e = dataconvertermanager;
|
2016-11-04 06:33:08 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
+ public int getQueueSize() { return queue.size(); } // Paper
|
2017-04-29 02:25:52 +02:00
|
|
|
+
|
|
|
|
// CraftBukkit start - Add async variant, provide compatibility
|
|
|
|
@Nullable
|
|
|
|
public Chunk a(World world, int i, int j) throws IOException {
|
2016-11-04 06:33:08 +01:00
|
|
|
--
|
2018-07-04 09:55:24 +02:00
|
|
|
2.18.0
|
2016-11-04 06:33:08 +01:00
|
|
|
|