Upstream/Plan
1
0
Fork 0
mirror of https://github.com/plan-player-analytics/Plan.git synced 2025-02-02 05:21:36 +01:00
Code Issues Projects Releases Wiki Activity

Fixed some new code smells

Browse Source 
- Files.isDirectory call apparently slow
- Unused private method removed in WorldPie
- Replaced OptionalAssert with Assertions.assertEquals
This commit is contained in:
Rsl1122 2019-11-10 10:20:55 +02:00
parent 32ccc6ac7f
commit 0ccf7678c4
3 changed files with 4 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Plan/common/src/main/java/com/djrapitops/plan/delivery/rendering/json/graphs/pie/WorldPie.java
View File

@ -79,24 +79,4 @@ public class WorldPie extends PieWithDrilldown {
}
return data;
}
private void appendGMTimesForWorld(StringBuilder drilldownBuilder, Map.Entry<String, GMTimes> world) {
Map<String, Long> gmTimes = world.getValue().getTimes();
int smallSize = gmTimes.size();
int j = 0;
for (Map.Entry<String, Long> entry : gmTimes.entrySet()) {
Long time = entry.getValue();
drilldownBuilder.append("['")
.append(entry.getKey())
.append("',")
.append(time)
.append("]");
if (j < smallSize - 1) {
drilldownBuilder.append(",");
}
j++;
}
drilldownBuilder.append("]}");
}
}

2
Plan/common/src/main/java/com/djrapitops/plan/settings/config/ConfigWriter.java
View File

@ -70,7 +70,7 @@ public class ConfigWriter {
writing.updateParent(null);
Path directory = outputPath.getParent();
if (!Files.isDirectory(directory.toRealPath())) {
if (!directory.toRealPath().toFile().isDirectory()) {
Files.createDirectories(directory);
}
Files.write(outputPath, parseLines(writing), StandardCharsets.UTF_8, StandardOpenOption.TRUNCATE_EXISTING, StandardOpenOption.CREATE);

5
Plan/common/src/test/java/com/djrapitops/plan/identification/UUIDUtilityTest.java
View File

@ -19,10 +19,11 @@ package com.djrapitops.plan.identification;
import org.junit.jupiter.api.Test;
import org.junit.platform.runner.JUnitPlatform;
import org.junit.runner.RunWith;
import utilities.OptionalAssert;
import java.util.UUID;
import static org.junit.jupiter.api.Assertions.assertEquals;
/**
* Tests for {@link UUIDUtility}.
*
@ -34,6 +35,6 @@ class UUIDUtilityTest {
@Test
void stringUUIDIsParsed() {
String test = "f3cc3e96-1bc9-35ad-994f-d894e9764b93";
OptionalAssert.equals(UUID.fromString(test), UUIDUtility.parseFromString(test));
assertEquals(UUID.fromString(test), UUIDUtility.parseFromString(test).orElse(null));
}
}