Upstream/Plan
1
0
Fork 0
mirror of https://github.com/plan-player-analytics/Plan.git synced 2025-03-11 22:31:42 +01:00
Code Issues Projects Releases Wiki Activity

Add display names to some tests

Browse Source
This commit is contained in:
Aurora Lahtela 2022-02-28 19:31:17 +02:00
parent 47e74f5ad5
commit 206c4e7d96
3 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Plan/common/src/test/java/com/djrapitops/plan/delivery/export/ExportJSErrorRegressionTest.java
View File

@ -154,7 +154,7 @@ class ExportJSErrorRegressionTest {
} }
@TestFactory @TestFactory
Collection<DynamicTest> playerPageDoesNotHaveJavascriptErrors(ChromeDriver driver) { Collection<DynamicTest> exportedWebpageDoesNotHaveErrors(ChromeDriver driver) {
String[] endpointsToTest = new String[]{ String[] endpointsToTest = new String[]{
"/player/" + TestConstants.PLAYER_ONE_UUID_STRING + "/index.html", "/player/" + TestConstants.PLAYER_ONE_UUID_STRING + "/index.html",
// "/network/index.html", // "/network/index.html",
@ -163,7 +163,7 @@ class ExportJSErrorRegressionTest {
}; };
return Arrays.stream(endpointsToTest).map( return Arrays.stream(endpointsToTest).map(
endpoint -> DynamicTest.dynamicTest("Test exported endpoint " + endpoint, () -> { endpoint -> DynamicTest.dynamicTest("Exported page does not log errors to js console " + endpoint, () -> {
String address = nginx.getBaseUrl("http", 80).toURI().resolve(endpoint).toString(); String address = nginx.getBaseUrl("http", 80).toURI().resolve(endpoint).toString();
driver.get(address); driver.get(address);

9
Plan/common/src/test/java/com/djrapitops/plan/delivery/webserver/AccessControlTest.java
View File

@ -30,6 +30,7 @@ import com.djrapitops.plan.utilities.PassEncryptUtil;
import org.apache.commons.compress.utils.IOUtils; import org.apache.commons.compress.utils.IOUtils;
import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.io.TempDir; import org.junit.jupiter.api.io.TempDir;
import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.CsvSource; import org.junit.jupiter.params.provider.CsvSource;
@ -136,11 +137,12 @@ class AccessControlTest {
System.out.println("Got cookie: " + cookie); System.out.println("Got cookie: " + cookie);
} }
} finally { } finally {
loginConnection.disconnect(); if (loginConnection != null) loginConnection.disconnect();
} }
return cookie; return cookie;
} }
@DisplayName("Access control test, level 0:")
@ParameterizedTest(name = "{0}: expecting {1}") @ParameterizedTest(name = "{0}: expecting {1}")
@CsvSource({ @CsvSource({
"/,302", "/,302",
@ -206,6 +208,7 @@ class AccessControlTest {
assertEquals(Integer.parseInt(expectedResponseCode), responseCode, () -> "User level 0, Wrong response code for " + resource + ", expected " + expectedResponseCode + " but was " + responseCode); assertEquals(Integer.parseInt(expectedResponseCode), responseCode, () -> "User level 0, Wrong response code for " + resource + ", expected " + expectedResponseCode + " but was " + responseCode);
} }
@DisplayName("Access control test, level 1:")
@ParameterizedTest(name = "{0}: expecting {1}") @ParameterizedTest(name = "{0}: expecting {1}")
@CsvSource({ @CsvSource({
"/,302", "/,302",
@ -271,6 +274,7 @@ class AccessControlTest {
assertEquals(Integer.parseInt(expectedResponseCode), responseCode, () -> "User level 1, Wrong response code for " + resource + ", expected " + expectedResponseCode + " but was " + responseCode); assertEquals(Integer.parseInt(expectedResponseCode), responseCode, () -> "User level 1, Wrong response code for " + resource + ", expected " + expectedResponseCode + " but was " + responseCode);
} }
@DisplayName("Access control test, level 2:")
@ParameterizedTest(name = "{0}: expecting {1}") @ParameterizedTest(name = "{0}: expecting {1}")
@CsvSource({ @CsvSource({
"/,302", "/,302",
@ -336,6 +340,7 @@ class AccessControlTest {
assertEquals(Integer.parseInt(expectedResponseCode), responseCode, () -> "User level 2, Wrong response code for " + resource + ", expected " + expectedResponseCode + " but was " + responseCode); assertEquals(Integer.parseInt(expectedResponseCode), responseCode, () -> "User level 2, Wrong response code for " + resource + ", expected " + expectedResponseCode + " but was " + responseCode);
} }
@DisplayName("Access control test, level 100:")
@ParameterizedTest(name = "{0}: expecting {1}") @ParameterizedTest(name = "{0}: expecting {1}")
@CsvSource({ @CsvSource({
"/,403", "/,403",
@ -408,7 +413,7 @@ class AccessControlTest {
return connection.getResponseCode(); return connection.getResponseCode();
} finally { } finally {
connection.disconnect(); if (connection != null) connection.disconnect();
} }
} }

6
Plan/common/src/test/java/com/djrapitops/plan/delivery/webserver/JSErrorRegressionTest.java
View File

@ -32,6 +32,7 @@ import extension.SeleniumExtension;
import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.extension.ExtendWith; import org.junit.jupiter.api.extension.ExtendWith;
import org.junit.jupiter.api.io.TempDir; import org.junit.jupiter.api.io.TempDir;
import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.ParameterizedTest;
@ -106,7 +107,8 @@ class JSErrorRegressionTest {
SeleniumExtension.newTab(driver); SeleniumExtension.newTab(driver);
} }
@ParameterizedTest @DisplayName("Page does not log anything on js console: ")
@ParameterizedTest(name = "{0}")
@CsvSource({ @CsvSource({
"http://localhost:" + TEST_PORT_NUMBER + "/player/" + TestConstants.PLAYER_ONE_NAME, "http://localhost:" + TEST_PORT_NUMBER + "/player/" + TestConstants.PLAYER_ONE_NAME,
"http://localhost:" + TEST_PORT_NUMBER + "/player/" + TestConstants.PLAYER_ONE_UUID_STRING, "http://localhost:" + TEST_PORT_NUMBER + "/player/" + TestConstants.PLAYER_ONE_UUID_STRING,
@ -114,7 +116,7 @@ class JSErrorRegressionTest {
"http://localhost:" + TEST_PORT_NUMBER + "/server/Server 1", "http://localhost:" + TEST_PORT_NUMBER + "/server/Server 1",
"http://localhost:" + TEST_PORT_NUMBER + "/players" "http://localhost:" + TEST_PORT_NUMBER + "/players"
}) })
void playerPageDoesNotHaveJavascriptErrors(String address, ChromeDriver driver) { void javascriptRegressionTest(String address, ChromeDriver driver) {
driver.get(address); driver.get(address);
List<LogEntry> logs = new ArrayList<>(); List<LogEntry> logs = new ArrayList<>();