Simplify PlayersTableCreator#getActivityString

Remove @SafeVarargs annotation

Plan/src/main/java/com/djrapitops/plan/Log.java

@@ -77,7 +77,6 @@ public class Log {
      * @param messages All messages to add to the debug log.
      * @return full debug complex so far.
      */
-    @SafeVarargs
     public static DebugInfo debug(String task, String... messages) {
         DebugInfo debug = getDebug(task);
         long time = MiscUtils.getTime();

Plan/src/main/java/com/djrapitops/plan/database/sql/Select.java

@@ -27,11 +27,11 @@ public class Select extends SqlParser {
 
     public Select where(String... conditions) {
         append(" WHERE ");
-        for (int i = 0; i < conditions.length; i++) {
+        for (String condition : conditions) {
             if (this.conditions > 0) {
                 append(" AND ");
             }
-            append("(").append(conditions[i]).append(")");
+            append("(").append(condition).append(")");
             this.conditions++;
         }
         return this;

Plan/src/main/java/com/djrapitops/plan/ui/html/tables/PlayersTableCreator.java

@@ -66,9 +66,14 @@ public class PlayersTableCreator {
     }
 
     private static String getActivityString(boolean isBanned, boolean isUnknown, boolean isActive) {
-        return isBanned ? "Banned"
+        if (isBanned) {
-                : (isUnknown ? "Unknown"
+            return "Banned";
-                : (isActive ? "Active"
+        }
-                : "Inactive"));
+
+        if (isUnknown) {
+            return "Unknown";
+        }
+
+        return isActive ? "Active" : "Inactive";
     }
 }

Plan/src/main/java/com/djrapitops/plan/utilities/file/dump/DumpLog.java

@@ -18,8 +18,7 @@ public class DumpLog {
      * @param header The name of the header
      */
     public void addHeader(String header) {
-        addLine("");
+        addLines("", "--- " + header + " ---");
-        addLine("--- " + header + " ---");
     }
 
     /**

Plan/test/test/java/main/java/com/djrapitops/plan/SettingsTest.java

@@ -74,5 +74,4 @@ public class SettingsTest {
     public void testGetPath() {
         assertEquals("Settings.WebServer.Enabled", Settings.WEBSERVER_ENABLED.getPath());
     }
-
 }

Plan/test/test/java/main/java/com/djrapitops/plan/data/cache/queue/DataCacheQueueTest.java

@@ -106,15 +106,12 @@ public class DataCacheQueueTest {
     public void testGetQueue_cache() {
         List<Integer> calls = new ArrayList<>();
         List<Integer> errors = new ArrayList<>();
-        handler.getUserDataForProcessing(new DBCallableProcessor() {
+        handler.getUserDataForProcessing(data -> {
-            @Override
-            public void process(UserData data) {
             if (data.equals(data1)) {
                 calls.add(1);
             } else {
                 errors.add(1);
             }
-            }
         }, uuid1);
         while (calls.size() < 1) {
             if (errors.size() > 0) {
@@ -131,15 +128,12 @@ public class DataCacheQueueTest {
     public void testGetQueue_dontCache() {
         List<Integer> getCalls = new ArrayList<>();
         List<Integer> errors = new ArrayList<>();
-        handler.getUserDataForProcessing(new DBCallableProcessor() {
+        handler.getUserDataForProcessing(data -> {
-            @Override
-            public void process(UserData data) {
             if (data.equals(data1)) {
                 getCalls.add(1);
             } else {
                 errors.add(1);
             }
-            }
         }, uuid1, false);
         while (getCalls.size() < 1) {
             if (errors.size() > 0) {

Plan/test/test/java/main/java/com/djrapitops/plan/utilities/analysis/MathUtilsTest.java

@@ -10,6 +10,7 @@ import org.junit.Test;
 
 import java.io.Serializable;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 import java.util.Random;
 
@@ -46,7 +47,7 @@ public class MathUtilsTest {
      */
     @Test
     public void testAverageIntEmpty() {
-        List<Integer> l = new ArrayList<>();
+        List<Integer> l = Collections.emptyList();
         double exp = 0;
         double result = MathUtils.averageInt(l.stream());
         assertTrue(result + "/" + exp, Double.compare(exp, result) == 0);

Plan/test/test/java/main/java/com/djrapitops/plan/utilities/dump/HastebinTest.java

@@ -46,7 +46,6 @@ public class HastebinTest {
                 /* Ignored */
             }
 
-            Log.info(link);
             testLink.set(link);
         });
 

Plan/test/test/java/utils/TestInit.java

@@ -139,7 +139,7 @@ public class TestInit {
 
                     @Override
                     public ITask runTask() {
-                        new Thread(() -> runnable.run()).start();
+                        new Thread(runnable::run).start();
                         return null;
                     }