Upstream
/
Plan
mirror of https://github.com/plan-player-analytics/Plan.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Bump org.seleniumhq.selenium:selenium-java from 4.12.1 to 4.17.0 in /Plan (#3434) 

* Bump org.seleniumhq.selenium:selenium-java in /Plan

Bumps [org.seleniumhq.selenium:selenium-java](https://github.com/SeleniumHQ/selenium) from 4.12.1 to 4.17.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.17.0)

---
updated-dependencies:
- dependency-name: org.seleniumhq.selenium:selenium-java
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Use new headless setup method

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aurora Lahtela <24460436+AuroraLS3@users.noreply.github.com>
This commit is contained in:
dependabot[bot] 2024-01-27 09:49:50 +02:00 committed by GitHub
parent 89355d4975
commit 512defb3f8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Plan/common/build.gradle
View File

@ -94,7 +94,7 @@ dependencies {
testArtifacts project(":extensions:adventure")
testImplementation project(":extensions:adventure")
testImplementation "com.google.code.gson:gson:$gsonVersion"
testImplementation "org.seleniumhq.selenium:selenium-java:4.12.1"
testImplementation "org.seleniumhq.selenium:selenium-java:4.17.0"
testImplementation "org.testcontainers:testcontainers:$testContainersVersion"
testImplementation "org.testcontainers:junit-jupiter:$testContainersVersion"
testImplementation "org.testcontainers:nginx:$testContainersVersion"

4
Plan/common/src/test/java/extension/SeleniumExtension.java
View File

@ -49,7 +49,7 @@ public class SeleniumExtension implements ParameterResolver, BeforeAllCallback,
public static void waitForPageLoadForSeconds(int i, ChromeDriver driver) {
Awaitility.await("waitForPageLoadForSeconds")
.atMost(5, TimeUnit.SECONDS)
.atMost(i, TimeUnit.SECONDS)
.until(() -> "complete".equals(driver.executeScript("return document.readyState")));
}
@ -92,7 +92,7 @@ public class SeleniumExtension implements ParameterResolver, BeforeAllCallback,
// Using environment variable assumes linux
if (System.getenv(CIProperties.CHROME_DRIVER) != null) {
chromeOptions.setBinary("/usr/bin/google-chrome-stable");
chromeOptions.setHeadless(true);
chromeOptions.addArguments("--headless=new");
}
return new ChromeDriver(chromeOptions);