Removed uses of PlanConfig#getString

This commit is contained in:
Rsl1122 2018-12-16 14:37:38 +02:00
parent bacfa2c181
commit 715111b433
24 changed files with 79 additions and 79 deletions

View File

@ -61,7 +61,7 @@ public class BukkitDBSystem extends DBSystem {
@Override
public void enable() throws EnableException {
String dbType = config.getString(DatabaseSettings.TYPE).toLowerCase().trim();
String dbType = config.get(DatabaseSettings.TYPE).toLowerCase().trim();
db = getActiveDatabaseByName(dbType);
super.enable();
}

View File

@ -145,7 +145,7 @@ public class NetworkContainer extends DataContainer {
putCachingSupplier(NetworkKeys.NETWORK_NAME, () ->
Check.isBungeeAvailable() || Check.isVelocityAvailable() ?
config.getString(ProxySettings.NETWORK_NAME) :
config.get(ProxySettings.NETWORK_NAME) :
bungeeContainer.getValue(ServerKeys.NAME).orElse("Plan")
);
putSupplier(NetworkKeys.PLAYERS_ONLINE, serverProperties::getOnlinePlayers);

View File

@ -92,8 +92,8 @@ public class H2DB extends SQLDB {
}
private Connection getConnectionFor(String dbFilePath) throws SQLException {
String username = config.getString(DatabaseSettings.MYSQL_USER);
String password = config.getString(DatabaseSettings.MYSQL_PASS);
String username = config.get(DatabaseSettings.MYSQL_USER);
String password = config.get(DatabaseSettings.MYSQL_PASS);
JdbcDataSource jdbcDataSource = new JdbcDataSource();
jdbcDataSource.setURL("jdbc:h2:file:" + dbFilePath + ";mode=MySQL");

View File

@ -81,18 +81,18 @@ public class MySQLDB extends SQLDB {
try {
HikariConfig hikariConfig = new HikariConfig();
String host = config.getString(DatabaseSettings.MYSQL_HOST);
String port = config.getString(DatabaseSettings.MYSQL_PORT);
String database = config.getString(DatabaseSettings.MYSQL_DATABASE);
String launchOptions = config.getString(DatabaseSettings.MYSQL_LAUNCH_OPTIONS);
String host = config.get(DatabaseSettings.MYSQL_HOST);
String port = config.get(DatabaseSettings.MYSQL_PORT);
String database = config.get(DatabaseSettings.MYSQL_DATABASE);
String launchOptions = config.get(DatabaseSettings.MYSQL_LAUNCH_OPTIONS);
if (launchOptions.isEmpty() || !launchOptions.startsWith("?") || launchOptions.endsWith("&")) {
launchOptions = "?rewriteBatchedStatements=true&useSSL=false";
logger.error(locale.getString(PluginLang.DB_MYSQL_LAUNCH_OPTIONS_FAIL, launchOptions));
}
hikariConfig.setJdbcUrl("jdbc:mysql://" + host + ":" + port + "/" + database + launchOptions);
String username = config.getString(DatabaseSettings.MYSQL_USER);
String password = config.getString(DatabaseSettings.MYSQL_PASS);
String username = config.get(DatabaseSettings.MYSQL_USER);
String password = config.get(DatabaseSettings.MYSQL_PASS);
hikariConfig.setUsername(username);
hikariConfig.setPassword(password);

View File

@ -66,7 +66,7 @@ public abstract class Patch {
public void prepare(PreparedStatement statement) throws SQLException {
statement.setString(1, tableName);
if (secondParameter) {
statement.setString(2, db.getConfig().getString(DatabaseSettings.MYSQL_DATABASE));
statement.setString(2, db.getConfig().get(DatabaseSettings.MYSQL_DATABASE));
}
}
@ -95,7 +95,7 @@ public abstract class Patch {
statement.setString(1, tableName);
statement.setString(2, columnName);
if (dbType != DBType.H2) {
statement.setString(3, db.getConfig().getString(DatabaseSettings.MYSQL_DATABASE));
statement.setString(3, db.getConfig().get(DatabaseSettings.MYSQL_DATABASE));
}
}

View File

@ -91,7 +91,7 @@ public class ServerServerInfo extends ServerInfo {
if (!serverID.isPresent()) {
return registerServer(serverUUID);
}
String name = config.getString(PluginSettings.SERVER_NAME).replaceAll("[^a-zA-Z0-9_\\s]", "_");
String name = config.get(PluginSettings.SERVER_NAME).replaceAll("[^a-zA-Z0-9_\\s]", "_");
String webAddress = webServer.get().getAccessAddress();
if ("plan".equalsIgnoreCase(name)) {
name = "Server " + serverID.get();
@ -109,7 +109,7 @@ public class ServerServerInfo extends ServerInfo {
private Server registerServer(UUID serverUUID) throws IOException {
String webAddress = webServer.get().getAccessAddress();
String name = config.getString(PluginSettings.SERVER_NAME).replaceAll("[^a-zA-Z0-9_\\s]", "_");
String name = config.get(PluginSettings.SERVER_NAME).replaceAll("[^a-zA-Z0-9_\\s]", "_");
int maxPlayers = serverProperties.getMaxPlayers();
Server server = new Server(-1, serverUUID, name, webAddress, maxPlayers);

View File

@ -130,12 +130,12 @@ public class LocaleSystem implements SubSystem {
private Optional<Locale> loadSettingLocale() {
try {
String setting = config.getString(PluginSettings.LOCALE);
String setting = config.get(PluginSettings.LOCALE);
if (!setting.equalsIgnoreCase("default")) {
return Optional.of(Locale.forLangCodeString(plugin, setting));
}
} catch (IOException e) {
logger.warn("Failed to read locale from jar: " + config.getString(PluginSettings.LOCALE) + ", " + e.toString());
logger.warn("Failed to read locale from jar: " + config.get(PluginSettings.LOCALE) + ", " + e.toString());
logger.warn("Using Default Locale as a fallback (EN)");
}
return Optional.empty();

View File

@ -82,7 +82,7 @@ public abstract class ConfigSystem implements SubSystem {
}
private void setDebugMode() {
String debugMode = config.getString(PluginSettings.DEBUG);
String debugMode = config.get(PluginSettings.DEBUG);
List<DebugLogger> loggers = new ArrayList<>();
if (Verify.equalsOne(debugMode, "true", "both", "console")) {

View File

@ -23,6 +23,7 @@ import com.djrapitops.plan.system.settings.paths.TimeSettings;
import com.djrapitops.plan.system.settings.paths.key.Setting;
import com.djrapitops.plugin.config.Config;
import com.djrapitops.plugin.config.ConfigNode;
import com.djrapitops.plugin.utilities.Verify;
import javax.inject.Inject;
import javax.inject.Named;
@ -69,10 +70,9 @@ public class PlanConfig extends Config {
public <T> T get(Setting<T> setting) {
T value = setting.getValueFrom(this);
boolean valid = setting.isValid(value);
if (!valid) {
throw new IllegalStateException("Config value for " + setting.getPath() + " has a bad value: '" + value + "'");
}
Verify.isTrue(setting.isValid(value), () -> new IllegalStateException(
"Config value for " + setting.getPath() + " has a bad value: '" + value + "'"
));
return value;
}

View File

@ -133,10 +133,10 @@ public class WebServer implements SubSystem {
if (!usingHttps) {
logger.log(L.INFO_COLOR, "§e" + locale.getString(PluginLang.WEB_SERVER_NOTIFY_HTTP_USER_AUTH));
server = HttpServer.create(new InetSocketAddress(config.getString(WebserverSettings.INTERNAL_IP), port), 10);
server = HttpServer.create(new InetSocketAddress(config.get(WebserverSettings.INTERNAL_IP), port), 10);
} else if (server == null) {
logger.log(L.INFO_COLOR, "§eWebServer: Proxy HTTPS Override enabled. HTTP Server in use, make sure that your Proxy webserver is routing with HTTPS and AlternativeIP.Link points to the Proxy");
server = HttpServer.create(new InetSocketAddress(config.getString(WebserverSettings.INTERNAL_IP), port), 10);
server = HttpServer.create(new InetSocketAddress(config.get(WebserverSettings.INTERNAL_IP), port), 10);
}
server.createContext("/", requestHandler);
@ -157,7 +157,7 @@ public class WebServer implements SubSystem {
}
private boolean startHttpsServer() {
String keyStorePath = config.getString(WebserverSettings.CERTIFICATE_PATH);
String keyStorePath = config.get(WebserverSettings.CERTIFICATE_PATH);
if (keyStorePath.equalsIgnoreCase("proxy")) {
return true;
@ -172,9 +172,9 @@ public class WebServer implements SubSystem {
errorHandler.log(L.ERROR, this.getClass(), e);
}
char[] storepass = config.getString(WebserverSettings.CERTIFICATE_STOREPASS).toCharArray();
char[] keypass = config.getString(WebserverSettings.CERTIFICATE_KEYPASS).toCharArray();
String alias = config.getString(WebserverSettings.CERTIFICATE_ALIAS);
char[] storepass = config.get(WebserverSettings.CERTIFICATE_STOREPASS).toCharArray();
char[] keypass = config.get(WebserverSettings.CERTIFICATE_KEYPASS).toCharArray();
String alias = config.get(WebserverSettings.CERTIFICATE_ALIAS);
boolean startSuccessful = false;
try (FileInputStream fIn = new FileInputStream(keyStorePath)) {
@ -195,7 +195,7 @@ public class WebServer implements SubSystem {
TrustManagerFactory trustManagerFactory = TrustManagerFactory.getInstance("SunX509");
trustManagerFactory.init(keystore);
server = HttpsServer.create(new InetSocketAddress(config.getString(WebserverSettings.INTERNAL_IP), port), 10);
server = HttpsServer.create(new InetSocketAddress(config.get(WebserverSettings.INTERNAL_IP), port), 10);
SSLContext sslContext = SSLContext.getInstance("TLSv1.2");
sslContext.init(keyManagerFactory.getKeyManagers(), null/*trustManagerFactory.getTrustManagers()*/, null);
@ -281,12 +281,12 @@ public class WebServer implements SubSystem {
}
public String getAccessAddress() {
return isEnabled() ? getProtocol() + "://" + getIP() : config.getString(WebserverSettings.EXTERNAL_LINK);
return isEnabled() ? getProtocol() + "://" + getIP() : config.get(WebserverSettings.EXTERNAL_LINK);
}
private String getIP() {
return config.isTrue(WebserverSettings.SHOW_ALTERNATIVE_IP)
? config.getString(WebserverSettings.ALTERNATIVE_IP).replace("%port%", String.valueOf(port))
? config.get(WebserverSettings.ALTERNATIVE_IP).replace("%port%", String.valueOf(port))
: serverProperties.getIp() + ":" + port;
}
}

View File

@ -37,6 +37,6 @@ public class DecimalFormatter implements Formatter<Double> {
@Override
public String apply(Double value) {
// DecimalFormat is initialized here because config is not fully enabled in the constructor
return new DecimalFormat(config.getString(FormatSettings.DECIMALS)).format(value);
return new DecimalFormat(config.get(FormatSettings.DECIMALS)).format(value);
}
}

View File

@ -37,7 +37,7 @@ public class ClockFormatter extends DateFormatter {
}
private String format(Long date) {
String format = config.getString(FormatSettings.DATE_CLOCK);
String format = config.get(FormatSettings.DATE_CLOCK);
return format(date, format);
}

View File

@ -48,7 +48,7 @@ public abstract class DateFormatter implements Formatter<Long> {
protected String format(long epochMs, String format) {
boolean useServerTime = config.isTrue(TimeSettings.USE_SERVER_TIME);
String localeSetting = config.getString(PluginSettings.LOCALE);
String localeSetting = config.get(PluginSettings.LOCALE);
java.util.Locale usedLocale = localeSetting.equalsIgnoreCase("default")
? java.util.Locale.ENGLISH
: java.util.Locale.forLanguageTag(localeSetting);
@ -59,7 +59,7 @@ public abstract class DateFormatter implements Formatter<Long> {
}
protected String replaceRecentDays(long epochMs, String format) {
return replaceRecentDays(epochMs, format, config.getString(FormatSettings.DATE_RECENT_DAYS_PATTERN));
return replaceRecentDays(epochMs, format, config.get(FormatSettings.DATE_RECENT_DAYS_PATTERN));
}
protected String replaceRecentDays(long epochMs, String format, String pattern) {

View File

@ -37,7 +37,7 @@ public class SecondFormatter extends DateFormatter {
}
private String format(Long date) {
String format = config.getString(FormatSettings.DATE_FULL);
String format = config.get(FormatSettings.DATE_FULL);
if (config.isTrue(FormatSettings.DATE_RECENT_DAYS)) {
format = replaceRecentDays(date, format);

View File

@ -66,9 +66,9 @@ public class TimeAmountFormatter implements Formatter<Long> {
appendMonths(builder, months);
appendDays(builder, days);
String hourFormat = config.getString(FormatSettings.HOURS);
String minuteFormat = config.getString(FormatSettings.MINUTES);
String secondFormat = config.getString(FormatSettings.SECONDS);
String hourFormat = config.get(FormatSettings.HOURS);
String minuteFormat = config.get(FormatSettings.MINUTES);
String secondFormat = config.get(FormatSettings.SECONDS);
appendHours(builder, hours, hourFormat);
appendMinutes(builder, minutes, hours, hourFormat, minuteFormat);
@ -76,7 +76,7 @@ public class TimeAmountFormatter implements Formatter<Long> {
String formattedTime = StringUtils.remove(builder.toString(), ZERO_PH);
if (formattedTime.isEmpty()) {
return config.getString(FormatSettings.ZERO_SECONDS);
return config.get(FormatSettings.ZERO_SECONDS);
}
return formattedTime;
}
@ -124,21 +124,21 @@ public class TimeAmountFormatter implements Formatter<Long> {
}
private void appendDays(StringBuilder builder, long days) {
String singular = config.getString(FormatSettings.DAY);
String plural = config.getString(FormatSettings.DAYS);
String singular = config.get(FormatSettings.DAY);
String plural = config.get(FormatSettings.DAYS);
appendValue(builder, days, singular, plural, DAYS_PH);
}
private void appendMonths(StringBuilder builder, long months) {
String singular = config.getString(FormatSettings.MONTH);
String plural = config.getString(FormatSettings.MONTHS);
String singular = config.get(FormatSettings.MONTH);
String plural = config.get(FormatSettings.MONTHS);
appendValue(builder, months, singular, plural, MONTHS_PH);
}
private void appendYears(StringBuilder builder, long years) {
String singular = config.getString(FormatSettings.YEAR);
String plural = config.getString(FormatSettings.YEARS);
String singular = config.get(FormatSettings.YEAR);
String plural = config.get(FormatSettings.YEARS);
appendValue(builder, years, singular, plural, YEARS_PH);
}

View File

@ -37,7 +37,7 @@ public class YearFormatter extends DateFormatter {
}
private String format(Long date) {
String format = config.getString(FormatSettings.DATE_NO_SECONDS);
String format = config.get(FormatSettings.DATE_NO_SECONDS);
if (config.isTrue(FormatSettings.DATE_RECENT_DAYS)) {
format = replaceRecentDays(date, format);

View File

@ -249,7 +249,7 @@ public class InspectPage implements Page {
String serverName = serverNames.get(serverUUID);
replacer.put("networkName",
serverName.equalsIgnoreCase("bungeecord")
? config.getString(ProxySettings.NETWORK_NAME)
? config.get(ProxySettings.NETWORK_NAME)
: serverName
);

View File

@ -76,7 +76,7 @@ public class PlayersPage implements Page {
if (Check.isBukkitAvailable()) {
placeholderReplacer.put("networkName", serverInfo.getServer().getName());
} else {
placeholderReplacer.put("networkName", config.getString(ProxySettings.NETWORK_NAME));
placeholderReplacer.put("networkName", config.get(ProxySettings.NETWORK_NAME));
}
timings.start("Players page players table parsing");

View File

@ -22,7 +22,7 @@ public class DecimalFormatterTest {
@Before
public void setUp() {
PlanConfig config = Mockito.mock(PlanConfig.class);
when(config.getString(FormatSettings.DECIMALS)).thenReturn("#.##");
when(config.get(FormatSettings.DECIMALS)).thenReturn("#.##");
underTest = new DecimalFormatter(config);
}

View File

@ -24,18 +24,18 @@ public class TimeAmountFormatterDefaultTest {
@BeforeClass
public static void setUpClass() {
PlanConfig config = Mockito.mock(PlanConfig.class);
when(config.getString(FormatSettings.YEAR)).thenReturn("1 year, ");
when(config.getString(FormatSettings.YEARS)).thenReturn("%years% years, ");
when(config.getString(FormatSettings.MONTH)).thenReturn("1 month, ");
when(config.getString(FormatSettings.YEAR)).thenReturn("1 year, ");
when(config.getString(FormatSettings.MONTH)).thenReturn("1 month, ");
when(config.getString(FormatSettings.MONTHS)).thenReturn("%months% months, ");
when(config.getString(FormatSettings.DAY)).thenReturn("1d ");
when(config.getString(FormatSettings.DAYS)).thenReturn("%days%d ");
when(config.getString(FormatSettings.HOURS)).thenReturn("%hours%h ");
when(config.getString(FormatSettings.MINUTES)).thenReturn("%minutes%m ");
when(config.getString(FormatSettings.SECONDS)).thenReturn("%seconds%s");
when(config.getString(FormatSettings.ZERO_SECONDS)).thenReturn("0s");
when(config.get(FormatSettings.YEAR)).thenReturn("1 year, ");
when(config.get(FormatSettings.YEARS)).thenReturn("%years% years, ");
when(config.get(FormatSettings.MONTH)).thenReturn("1 month, ");
when(config.get(FormatSettings.YEAR)).thenReturn("1 year, ");
when(config.get(FormatSettings.MONTH)).thenReturn("1 month, ");
when(config.get(FormatSettings.MONTHS)).thenReturn("%months% months, ");
when(config.get(FormatSettings.DAY)).thenReturn("1d ");
when(config.get(FormatSettings.DAYS)).thenReturn("%days%d ");
when(config.get(FormatSettings.HOURS)).thenReturn("%hours%h ");
when(config.get(FormatSettings.MINUTES)).thenReturn("%minutes%m ");
when(config.get(FormatSettings.SECONDS)).thenReturn("%seconds%s");
when(config.get(FormatSettings.ZERO_SECONDS)).thenReturn("0s");
underTest = new TimeAmountFormatter(config);
}

View File

@ -24,16 +24,16 @@ public class TimeAmountFormatterExtraZerosTest {
@BeforeClass
public static void setUpClass() {
PlanConfig config = Mockito.mock(PlanConfig.class);
when(config.getString(FormatSettings.YEAR)).thenReturn("1 year, ");
when(config.getString(FormatSettings.YEARS)).thenReturn("%years% years, ");
when(config.getString(FormatSettings.MONTH)).thenReturn("1 month, ");
when(config.getString(FormatSettings.MONTHS)).thenReturn("%months% months, ");
when(config.getString(FormatSettings.DAY)).thenReturn("1d ");
when(config.getString(FormatSettings.DAYS)).thenReturn("%days%d ");
when(config.getString(FormatSettings.HOURS)).thenReturn("%zero%%hours%:");
when(config.getString(FormatSettings.MINUTES)).thenReturn("%hours%%zero%%minutes%:");
when(config.getString(FormatSettings.SECONDS)).thenReturn("%minutes%%zero%%seconds%");
when(config.getString(FormatSettings.ZERO_SECONDS)).thenReturn("00:00:00");
when(config.get(FormatSettings.YEAR)).thenReturn("1 year, ");
when(config.get(FormatSettings.YEARS)).thenReturn("%years% years, ");
when(config.get(FormatSettings.MONTH)).thenReturn("1 month, ");
when(config.get(FormatSettings.MONTHS)).thenReturn("%months% months, ");
when(config.get(FormatSettings.DAY)).thenReturn("1d ");
when(config.get(FormatSettings.DAYS)).thenReturn("%days%d ");
when(config.get(FormatSettings.HOURS)).thenReturn("%zero%%hours%:");
when(config.get(FormatSettings.MINUTES)).thenReturn("%hours%%zero%%minutes%:");
when(config.get(FormatSettings.SECONDS)).thenReturn("%minutes%%zero%%seconds%");
when(config.get(FormatSettings.ZERO_SECONDS)).thenReturn("00:00:00");
underTest = new TimeAmountFormatter(config);
}

View File

@ -59,7 +59,7 @@ public class PluginSuperClassBindingModule {
@Override
public void enable() throws EnableException {
databases.add(sqLiteDB.usingDefaultFile());
String dbType = config.getString(DatabaseSettings.TYPE).toLowerCase().trim();
String dbType = config.get(DatabaseSettings.TYPE).toLowerCase().trim();
db = getActiveDatabaseByName(dbType);
super.enable();
}

View File

@ -61,7 +61,7 @@ public class SpongeDBSystem extends DBSystem {
@Override
public void enable() throws EnableException {
String dbType = config.getString(DatabaseSettings.TYPE).toLowerCase().trim();
String dbType = config.get(DatabaseSettings.TYPE).toLowerCase().trim();
db = getActiveDatabaseByName(dbType);
super.enable();
}

View File

@ -63,18 +63,18 @@ public class SpongeMySQLDB extends MySQLDB {
return;
}
String host = config.getString(DatabaseSettings.MYSQL_HOST);
String port = config.getString(DatabaseSettings.MYSQL_PORT);
String database = config.getString(DatabaseSettings.MYSQL_DATABASE);
String launchOptions = config.getString(DatabaseSettings.MYSQL_LAUNCH_OPTIONS);
String host = config.get(DatabaseSettings.MYSQL_HOST);
String port = config.get(DatabaseSettings.MYSQL_PORT);
String database = config.get(DatabaseSettings.MYSQL_DATABASE);
String launchOptions = config.get(DatabaseSettings.MYSQL_LAUNCH_OPTIONS);
if (launchOptions.isEmpty() || !launchOptions.startsWith("?") || launchOptions.endsWith("&")) {
logger.error("Launch Options were faulty, using default (?rewriteBatchedStatements=true&useSSL=false)");
launchOptions = "?rewriteBatchedStatements=true&useSSL=false";
}
String url = host + ":" + port + "/" + database + launchOptions;
String username = config.getString(DatabaseSettings.MYSQL_USER);
String password = config.getString(DatabaseSettings.MYSQL_PASS);
String username = config.get(DatabaseSettings.MYSQL_USER);
String password = config.get(DatabaseSettings.MYSQL_PASS);
try {
this.dataSource = sqlServiceProvider.get().getDataSource(
"jdbc:mysql://" + username + ":" + password + "@" + url