Upstream/Plan
1
0
Fork 0
mirror of https://github.com/plan-player-analytics/Plan.git synced 2025-01-08 17:37:34 +01:00
Code Issues Projects Releases Wiki Activity

Rewrote RemoveDuplicateUserInfoTransaction

Browse Source 
NOT IN has a long execution time and leads to lock time being large.

Modified the transaction to select the duplicates and then remove them

Affects issues:
- Possibly fixed #1212
This commit is contained in:
Rsl1122 2019-11-02 11:35:04 +02:00
parent 1790095b82
commit 8749d12128
1 changed files with 40 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
Plan/common/src/main/java/com/djrapitops/plan/storage/database/transactions/init/RemoveDuplicateUserInfoTransaction.java
View File

@ -16,9 +16,18 @@
*/ */
package com.djrapitops.plan.storage.database.transactions.init; package com.djrapitops.plan.storage.database.transactions.init;
import com.djrapitops.plan.storage.database.queries.QueryAllStatement;
import com.djrapitops.plan.storage.database.sql.tables.UserInfoTable; import com.djrapitops.plan.storage.database.sql.tables.UserInfoTable;
import com.djrapitops.plan.storage.database.transactions.ExecBatchStatement;
import com.djrapitops.plan.storage.database.transactions.ThrowawayTransaction; import com.djrapitops.plan.storage.database.transactions.ThrowawayTransaction;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
import static com.djrapitops.plan.storage.database.sql.parsing.Sql.*; import static com.djrapitops.plan.storage.database.sql.parsing.Sql.*;
/** /**
@ -31,20 +40,40 @@ import static com.djrapitops.plan.storage.database.sql.parsing.Sql.*;
*/ */
public class RemoveDuplicateUserInfoTransaction extends ThrowawayTransaction { public class RemoveDuplicateUserInfoTransaction extends ThrowawayTransaction {
private static final String COLUMN_ID = UserInfoTable.TABLE_NAME + '.' + UserInfoTable.ID;
private static final String STATEMENT_SELECT_DUPLICATE_IDS = private static final String STATEMENT_SELECT_DUPLICATE_IDS =
SELECT + "MIN(" + COLUMN_ID + ") as id" + FROM + UserInfoTable.TABLE_NAME + SELECT + DISTINCT + "u2." + UserInfoTable.ID + " as id" +
GROUP_BY + UserInfoTable.USER_UUID + ',' + UserInfoTable.SERVER_UUID; FROM + UserInfoTable.TABLE_NAME + " u1" +
INNER_JOIN + UserInfoTable.TABLE_NAME + " u2 on " +
"u1." + UserInfoTable.USER_UUID + "=u2." + UserInfoTable.USER_UUID + AND +
"u1." + UserInfoTable.SERVER_UUID + "=u2." + UserInfoTable.SERVER_UUID + AND +
"u1." + UserInfoTable.ID + "<u2." + UserInfoTable.ID;
@Override @Override
protected void performOperations() { protected void performOperations() {
execute( Collection<Integer> duplicateIDs = getDuplicates();
"DELETE" + FROM + UserInfoTable.TABLE_NAME + if (duplicateIDs.isEmpty()) return;
WHERE + COLUMN_ID +
// Nested query here is required because MySQL limits update statements with nested queries: execute(new ExecBatchStatement(DELETE_FROM + UserInfoTable.TABLE_NAME + WHERE + UserInfoTable.ID + "=?") {
// The nested query creates a temporary table that bypasses the same table query-update limit. @Override
// Note: MySQL versions 5.6.7+ might optimize this nested query away leading to an exception. public void prepare(PreparedStatement statement) throws SQLException {
" NOT IN (" + SELECT + "id" + FROM + '(' + STATEMENT_SELECT_DUPLICATE_IDS + ") as ids)" for (Integer id : duplicateIDs) {
); statement.setInt(1, id);
statement.addBatch();
}
}
});
}
private Collection<Integer> getDuplicates() {
return query(new QueryAllStatement<Collection<Integer>>(STATEMENT_SELECT_DUPLICATE_IDS) {
@Override
public Collection<Integer> processResults(ResultSet set) throws SQLException {
Set<Integer> duplicateIDs = new HashSet<>();
while (set.next()) {
duplicateIDs.add(set.getInt("id"));
}
return duplicateIDs;
}
});
} }
} }