Upstream/Plan
1
0
Fork 0
mirror of https://github.com/plan-player-analytics/Plan.git synced 2025-01-29 19:41:35 +01:00
Code Issues Projects Releases Wiki Activity

Escape json data in /v1/players endpoint

Browse Source 
Improper serialization was causing issues loading the page

Affects issues:
- Fixed #1516
This commit is contained in:
Risto Lahtela 2020-08-08 17:16:15 +03:00
parent 23b9d79dca
commit 9e235518b3
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Plan/common/src/main/java/com/djrapitops/plan/delivery/rendering/json/PlayersTableJSONCreator.java
View File

@ -153,11 +153,11 @@ public class PlayersTableJSONCreator {
}
private String makeDataEntry(Object data, String dataName) {
return "\"" + dataName + "\":\"" + data.toString().replace('"', '\'') + "\"";
return "\"" + dataName + "\":\"" + StringEscapeUtils.escapeJson(data.toString()) + "\"";
}
private String makeDataEntry(Object data, String formatted, String dataName) {
return "\"" + dataName + "\":{\"v\":\"" + data.toString().replace('"', '\'') + "\", \"d\":\"" + formatted.replace('"', '\'') + "\"}";
return "\"" + dataName + "\":{\"v\":\"" + StringEscapeUtils.escapeJson(data.toString()) + "\", \"d\":\"" + StringEscapeUtils.escapeJson(formatted) + "\"}";
}
private void appendExtensionData(StringBuilder dataJSON, ExtensionTabData tabData) {
@ -207,11 +207,11 @@ public class PlayersTableJSONCreator {
}
private String makeColumnHeader(String title, String dataProperty) {
return "{\"title\": \"" + title.replace('"', '\'') + "\",\"data\":\"" + dataProperty + "\"}";
return "{\"title\": \"" + StringEscapeUtils.escapeJson(title) + "\",\"data\":\"" + dataProperty + "\"}";
}
private String makeFColumnHeader(String title, String dataProperty) {
return "{\"title\": \"" + title.replace('"', '\'') + "\",\"data\":{\"_\":\"" + dataProperty + ".v\",\"display\":\"" + dataProperty + ".d\"}}";
return "{\"title\": \"" + StringEscapeUtils.escapeJson(title) + "\",\"data\":{\"_\":\"" + dataProperty + ".v\",\"display\":\"" + dataProperty + ".d\"}}";
}
private void appendExtensionHeaders(StringBuilder columnHeaders) {