Upstream/Plan
1
0
Fork 0
mirror of https://github.com/plan-player-analytics/Plan.git synced 2025-02-08 08:21:30 +01:00
Code Issues Projects Releases Wiki Activity

Disabled SQLite rollbacks on 1.8.8 or older

Browse Source 
- SQLite version on 1.8.8 does not support savepoints that are in
  use with Transactions, so they have been disabled.
This commit is contained in:
Rsl1122 2019-08-21 10:40:26 +03:00
parent 98462c3ac4
commit 9e825aac24
1 changed files with 28 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
Plan/common/src/main/java/com/djrapitops/plan/db/access/transactions/Transaction.java
View File

@ -24,11 +24,9 @@ import com.djrapitops.plan.db.access.Executable;
import com.djrapitops.plan.db.access.Query; import com.djrapitops.plan.db.access.Query;
import com.djrapitops.plugin.utilities.Verify; import com.djrapitops.plugin.utilities.Verify;
import java.sql.Connection; import java.sql.*;
import java.sql.PreparedStatement;
import java.sql.SQLException;
import java.sql.Savepoint;
import java.util.UUID; import java.util.UUID;
import java.util.concurrent.atomic.AtomicBoolean;
/** /**
* Represents a database transaction. * Represents a database transaction.
@ -37,6 +35,9 @@ import java.util.UUID;
*/ */
public abstract class Transaction { public abstract class Transaction {
// SQLite version on 1.8.8 does not support savepoints, see createSavePoint() method
private static final AtomicBoolean SUPPORTS_SAVE_POINTS = new AtomicBoolean(true);
private SQLDB db; private SQLDB db;
protected DBType dbType; protected DBType dbType;
@ -75,6 +76,9 @@ public abstract class Transaction {
private void manageFailure(Exception statementFail) { private void manageFailure(Exception statementFail) {
String failMsg = getClass().getSimpleName() + " failed: " + statementFail.getMessage(); String failMsg = getClass().getSimpleName() + " failed: " + statementFail.getMessage();
if (!SUPPORTS_SAVE_POINTS.get()) {
throw new DBOpException(failMsg + ", additionally rollbacks are not supported on this server version.", statementFail);
}
try { try {
if (Verify.notNull(connection, savepoint)) { if (Verify.notNull(connection, savepoint)) {
connection.rollback(savepoint); connection.rollback(savepoint);
@ -105,12 +109,31 @@ public abstract class Transaction {
private void initializeTransaction(SQLDB db) { private void initializeTransaction(SQLDB db) {
try { try {
this.connection = db.getConnection(); this.connection = db.getConnection();
this.savepoint = connection.setSavepoint(); createSavePoint();
} catch (SQLException e) { } catch (SQLException e) {
throw new DBOpException(getClass().getSimpleName() + " initialization failed: " + e.getMessage(), e); throw new DBOpException(getClass().getSimpleName() + " initialization failed: " + e.getMessage(), e);
} }
} }
private void createSavePoint() throws SQLException {
try {
this.savepoint = connection.setSavepoint();
} catch (SQLFeatureNotSupportedException noSavePoints) {
SUPPORTS_SAVE_POINTS.set(false);
} catch (SQLException sqlException) {
handleUnsupportedSQLiteSavePoints(sqlException);
}
}
private void handleUnsupportedSQLiteSavePoints(SQLException sqlException) throws SQLException {
String errorMsg = sqlException.getMessage();
if (errorMsg.contains("unsupported") && errorMsg.contains("savepoints")) {
SUPPORTS_SAVE_POINTS.set(false);
} else {
throw sqlException;
}
}
protected <T> T query(Query<T> query) { protected <T> T query(Query<T> query) {
return query.executeQuery(db); return query.executeQuery(db);
} }