Upstream/Plan
1
0
Fork 0
mirror of https://github.com/plan-player-analytics/Plan.git synced 2025-01-10 18:37:57 +01:00
Code Issues Projects Releases Wiki Activity

Replace String concatenation in loop with StringBuilders

Browse Source
This commit is contained in:
Fuzzlemann 2017-07-23 13:54:24 +02:00
parent 7337801124
commit a45f092208
4 changed files with 27 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Plan/src/main/java/com/djrapitops/plan/data/handling/LoginHandling.java
View File

@ -1,11 +1,12 @@
package main.java.com.djrapitops.plan.data.handling;
import main.java.com.djrapitops.plan.Phrase;
import main.java.com.djrapitops.plan.data.UserData;
import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.net.InetAddress;
import java.net.URL;
import main.java.com.djrapitops.plan.Phrase;
import main.java.com.djrapitops.plan.data.UserData;
/**
* Class containing static methods for processing information contained in a
@ -46,17 +47,17 @@ public class LoginHandling {
*/
public static void updateGeolocation(InetAddress ip, UserData data) {
try {
String result = "";
StringBuilder result = new StringBuilder();
URL url = new URL("http://freegeoip.net/csv/" + ip.getHostAddress());
BufferedReader in = new BufferedReader(new InputStreamReader(url.openStream()));
String resultline;
while ((resultline = in.readLine()) != null) {
result += resultline + ",";
result.append(resultline).append(",");
}
in.close();
String[] results = result.split(",");
String[] results = result.toString().split(",");
if (!results[2].isEmpty()) {
data.setGeolocation(results[2]);
}

15
Plan/src/main/java/com/djrapitops/plan/ui/html/tables/KillsTableCreator.java
View File

@ -2,12 +2,13 @@ package main.java.com.djrapitops.plan.ui.html.tables;
import com.djrapitops.plugin.utilities.player.Fetch;
import com.djrapitops.plugin.utilities.player.IOfflinePlayer;
import java.util.List;
import main.java.com.djrapitops.plan.data.KillData;
import main.java.com.djrapitops.plan.ui.html.Html;
import main.java.com.djrapitops.plan.utilities.FormatUtils;
import main.java.com.djrapitops.plan.utilities.HtmlUtils;
import java.util.List;
/**
*
* @author Rsl1122
@ -20,9 +21,9 @@ public class KillsTableCreator {
* @return
*/
public static String createSortedSessionDataTable10(List<KillData> killData) {
String html = Html.TABLE_KILLS_START.parse();
StringBuilder html = new StringBuilder(Html.TABLE_KILLS_START.parse());
if (killData.isEmpty()) {
html += Html.TABLELINE_3.parse(Html.KILLDATA_NONE.parse(), "", "");
html.append(Html.TABLELINE_3.parse(Html.KILLDATA_NONE.parse(), "", ""));
} else {
int i = 0;
for (KillData kill : killData) {
@ -32,15 +33,15 @@ public class KillsTableCreator {
long date = kill.getDate();
IOfflinePlayer victim = Fetch.getIOfflinePlayer(kill.getVictim());
String name = victim.getName();
html += Html.TABLELINE_3_CUSTOMKEY_1.parse(
html.append(Html.TABLELINE_3_CUSTOMKEY_1.parse(
date + "", FormatUtils.formatTimeStamp(date),
Html.LINK.parse(HtmlUtils.getInspectUrl(name), name),
kill.getWeapon()
);
));
i++;
}
}
html += Html.TABLE_END.parse();
return html;
html.append(Html.TABLE_END.parse());
return html.toString();
}
}

12
Plan/src/main/java/com/djrapitops/plan/ui/html/tables/SessionTableCreator.java
View File

@ -19,9 +19,9 @@ public class SessionTableCreator {
* @return
*/
public static String createSortedSessionDataTable10(List<SessionData> sessionData) {
String html = Html.TABLE_SESSIONS_START.parse();
StringBuilder html = new StringBuilder(Html.TABLE_SESSIONS_START.parse());
if (sessionData.isEmpty()) {
html += Html.TABLELINE_3.parse(Html.SESSIONDATA_NONE.parse(), "", "");
html.append(Html.TABLELINE_3.parse(Html.SESSIONDATA_NONE.parse(), "", ""));
} else {
sessionData.sort(new SessionDataComparator());
Collections.reverse(sessionData);
@ -36,15 +36,15 @@ public class SessionTableCreator {
if (length < 0) {
continue;
}
html += Html.TABLELINE_3_CUSTOMKEY.parse(
html.append(Html.TABLELINE_3_CUSTOMKEY.parse(
start + "", FormatUtils.formatTimeStamp(start),
end + "", FormatUtils.formatTimeStamp(end),
length + "", FormatUtils.formatTimeAmount(length)
);
));
i++;
}
}
html += Html.TABLE_END.parse();
return html;
html.append(Html.TABLE_END.parse());
return html.toString();
}
}

13
Plan/src/main/java/com/djrapitops/plan/utilities/HtmlUtils.java
View File

@ -1,14 +1,15 @@
package main.java.com.djrapitops.plan.utilities;
import main.java.com.djrapitops.plan.Plan;
import main.java.com.djrapitops.plan.Settings;
import main.java.com.djrapitops.plan.ui.html.Html;
import java.io.File;
import java.io.FileNotFoundException;
import java.io.InputStream;
import java.util.List;
import java.util.Map;
import java.util.Scanner;
import main.java.com.djrapitops.plan.Plan;
import main.java.com.djrapitops.plan.Settings;
import main.java.com.djrapitops.plan.ui.html.Html;
/**
*
@ -35,12 +36,12 @@ public class HtmlUtils {
resourceStream = plugin.getResource(fileName);
scanner = new Scanner(resourceStream);
}
String html = "";
StringBuilder html = new StringBuilder();
while (scanner.hasNextLine()) {
String line = scanner.nextLine();
html += line + "\r\n";
html.append(line).append("\r\n");
}
return html;
return html.toString();
} finally {
MiscUtils.close(resourceStream, scanner);
}