* feat: add cost for the merge when using plot auto-merge
- Closes#3814
* fix: Don't charge for auto merge if there is no auto merge
---------
Co-authored-by: Alexander Brandes <mc.cache@web.de>
* fix: ensure plots are fully unlinked before the clear itself is run
* Update Core/src/main/java/com/plotsquared/core/plot/PlotModificationManager.java
Co-authored-by: Alexander Brandes <mc.cache@web.de>
* feature: implement road flags as widely as seems reasonable
- Closes#3047
- Any further road flag implementations would be very specific from what I can gather, and thus the gist of #3047 is now implemented
* Add javadoc since tag
Co-authored-by: Alexander Brandes <mc.cache@web.de>
* Create util class for method
Co-authored-by: Alexander Brandes <mc.cache@web.de>
* feat: Move ExpireManager to Guice by removing legacy IMP references
* Mark ExpireManager IMP as deprecated and add comments
* Add import for PlotPlatform for function reference
* Add ExpireManager instance call and optimize performance
* Fix#3820
* Reword message and add link to completed translations
* Fix#3820
* Reword message and add link to completed translations
* Add line breaks for better code readability
* Add line breaks for better code readability
Co-authored-by: Alexander Brandes <mc.cache@web.de>
* feature: add flag for beacon effects of other plots
Took 7 minutes
* fix: don't add the beacon effect flag if the platform is not paper
Took 2 minutes
* fix: creating consistency in documentation
Took 7 minutes
* feature: add global paper setting for the beacon-effect
* fix: description of the plot flag and rewrite of the listener
* fix: renamed flag and added road support
* fix: renamed flag and changed flag functionality
* fix: added spigot fallback listener and fixed NPE
* refactor: Address checkstyle violations
* addition: remove beacon effects when player leaves a plot
* fix: updated javadoc and fixed usage of the PlotListener#addEffect method
* chore: Run license updater
Co-authored-by: BuildTools <unconfigured@null.spigotmc.org>
Co-authored-by: Alexander Brandes <mc.cache@web.de>
- No need to wrap the final analysis into another async method. It's already contained in an async task
- Don't overstretch a chunk bounday when setting blocks to newBlocks array
* Address deprecations in queue/generation code
* Move to new generation API
- Currently not working due to lack of biome-setting capability via BiomeProvider for flat worlds
* Any fixes to flat world biome setting will target 1.19
* Ensure compiled is actually set to true in BlockBucket
* Delegate to platformGenerator in deprecated generation method if applicable when using new generation methods (1.19)
* Re-add wrongly removed method
* Handle exceptions using logger
* We can simplify getting relative offset using floormod
* Replace many booleans with EnumSet
* Address comments, remove needless boolean return for populateChunk
* Implement build height limits into more events
* Implement util method to check if y is within world build limits
* Extract duplicate player-build-height-checking to plot area
- Extract to core module to allow any possible future platforms to access the method, as they will always duplicate
* Add code tag to javadoc
Co-authored-by: Alexander Brandes <mc.cache@web.de>
Co-authored-by: Alexander Brandes <mc.cache@web.de>
* Ensure forceSync is provided when constructing chunk coordinators
* Re-add old factory create method and deprecate for removal
* Remove old create method that Guice doesn't like
* Implement tile entities to generation using Populators
- Fixes#3051
* Javadocs
* Don't do the big error if heads don't work
* Address comments regarding javadocs/comments
* Ensure Location is still sealed, and add api description annotation to public methods in UncheckedWorldLocation
* Clean up HybridGen
- There's no need for while loops acting as a modulo after we've already performed a modulo
- Make the code-sections calculating if positions are in the wall/road more readable
- Collaps duplicate if-elseif bodies
* Better exception handling when setting data to LimitedRegion during chunk population
* Address comments
Co-authored-by: Alexander Brandes <mc.cache@web.de>
* Better naming for "legacy" block state populator
Co-authored-by: Alexander Brandes <mc.cache@web.de>
* Only load world cofigurations if WorldEdit has fully enabled (safe to do)
- Fixes#3664
(cherry picked from commit f2e1e99be3b4f1fd5ce00e32ea7773dd4d1855aa)
* Fix imports
* QueryCapability is effectively a "dumb" method
* Update Core/src/main/java/com/plotsquared/core/PlotSquared.java
Co-authored-by: Alexander Brandes <mc.cache@web.de>
- Begin by implementing forceSync to the queue system as we know the chunk will be accessible to edits in some cases (i.e. population).
- Also implement custom SideEffectSets to override any decided by the default chunk consumer, as we do NOT want to update neighbours in population (this caused infinite generation to be required causing the lag and server death). We also do not want to enqueue the QueueCoordinator in AugmentedUtils as this would write to the world and update neighbours before we might want to (plus it's just used to restrict and offset the blocks being set)
- Then implement disabling any biomes from being saved/set to the queue to prevent augmented worlds having their biomes overridden in roads
- Consequently fix ScopedQueueCoordinator, preventing the y value of blocks being set from needlessly being changed, fixing road heights in augmented worlds
- Finally we do not need a method with chunkObject in the signature in AugmentedUtils as this is no longer used by the method
* Fix plot analysis
- Stop using deprecated ChunkQueueCoordinator and create a new purpose-built coordinator
- Generation is chunk-by-chunk thus the old blocks cache needs to be filled accordingly
- Remove the **four** System#gc calls
- Fixes#3464
- Fix really weird dumb... maths? in ExpiryTask
- Fixes#3600
* Add since annotation
* Address comments and maxY should be inclusive
* Annotate new queue as internal use only
* Deprecations and niceties
- Deprecate ScopedQueueCoordinator as it is poorly named
- Deprecate ChunkQueueCoordinator for complete removal as it is poorly designed (though still used)
* Add since tags
* chore!: bump MiniMessage to 4.10.1
BREAKING CHANGE: bumping MiniMessage and Adventure removes the adventure Template class and breaks the whole messaging system api wise
* chore: fix minimessage messages, fix circular method reference
* refactor: list command shows owner better
added check for:
- unknown owners (UUID not cached/invalid)
- server plots
- plots owner by everyone
* fix: show correct color in list command if plot is owned by everyone
* refactor: improved List command for server plots
(cherry picked from commit fed700f0d8)
* refactor: removed duplicate code
* refactor: renamed placeholders to reflect their use
Co-authored-by: Alexander Brandes <mc.cache@web.de>
* Begin to implement extended world heights:
- Implemented in Bukkit module (and where required in Core module)
* Implement extended world heights into core module
* Add min gen height to setup,
* Default gen/build heights based on minecraft version
* Few fixes
* Fix up queues
* Address comments
* Make road schematic stuff slightly more efficient by sharing queues
* Minor fixes, don't overlay error many times for the same y
* Fix incorrect schematic paste height, undo changes to HybridUtils
* Overhall regenallroads method to make it work, make sure BukkitChunkCoordinator can/will finish
* Process chunks in order when regenerating all roads
* Address comments
* Address comments
* Ground level//bedrock is at min gen height
- Add comment on == rather than <= being used
- It's because it's only checking for the bedrock layer being broken if that's disabled
* Fix offset for min build height in SchematicHandler
* Better javadoc
Co-authored-by: Hannes Greule <SirYwell@users.noreply.github.com>
* Address inclusivity issues for max world height
* Javadocs/comments/deprecation
* Use world min/max heights if present in QueueCoordinator
* Address some deprecations for regions and biome setting
* Add a count for chunks we're currently trying to load to not skip chunks at the end of a queue's edit
* Use minGenHeight + 1 rather than build height in AugmentedUtils
* Create utility method for layer index in GenChunk
* Correct height in HybridUtils, also use minGenHeight + 1
* Don't magically split to 128 height in regeneration
* Add utility methods for world height in QueueCoordinator
* Clean up ClassicPlotManager road creation/removal
* Start generation at min gen height if bedrock is disabled
* min gen height is set in PlotArea
* Add note on schem y normalisation
* Improve plot getVolume method readability
* Don't overly extend height when regenerating road region
* y index utility method in ChunknQueueCoordinator
* Layer index utility method in LocalChunk
* Use version min/max heights if world not present in QueueCoordinator
* Fix min -> max
* Don't allow players to modify outside build height when using plot set / schematics.
- Also fixes schematic height issues
* Remove debug
* Address comments
* Switch loadingChunks to AtomicInteger to be safe (in case of multi-threaded)
* Fix "security" issue that was already present
* Ensure sign isn't physicsed
Co-authored-by: Hannes Greule <SirYwell@users.noreply.github.com>
