Upstream
/
ProtocolLib
mirror of https://github.com/dmulloy2/ProtocolLib.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix logging issue hiding underlying issue

This commit is contained in:
Dan Mulloy 2023-06-07 22:26:16 -05:00
parent c1ceb472f1
commit 260cb22f53
No known key found for this signature in database
GPG Key ID: F379C293F178751F
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/main/java/com/comphenix/protocol/error/DetailedErrorReporter.java
View File

@ -30,6 +30,8 @@ import java.util.concurrent.atomic.AtomicInteger;
import java.util.logging.Level;
import java.util.logging.Logger;
import com.comphenix.protocol.ProtocolConfig;
import com.comphenix.protocol.ProtocolLib;
import com.comphenix.protocol.ProtocolLibrary;
import com.comphenix.protocol.ProtocolLogger;
import com.comphenix.protocol.collections.ExpireHashMap;
@ -391,7 +393,7 @@ public class DetailedErrorReporter implements ErrorReporter {
writer.println(addPrefix(Bukkit.getServer().getVersion(), SECOND_LEVEL_PREFIX));
// Inform of this occurrence
if (ERROR_PERMISSION != null && ProtocolLibrary.getConfig().isChatWarnings()) {
if (isChatWarnings()) {
Bukkit.getServer().broadcast(
String.format("Error %s (%s) occurred in %s.", report.getReportMessage(), report.getException(), sender),
ERROR_PERMISSION
@ -402,7 +404,15 @@ public class DetailedErrorReporter implements ErrorReporter {
// Make sure it is reported
logger.severe(addPrefix(text.toString(), prefix));
}
private boolean isChatWarnings() {
try {
ProtocolConfig config = ProtocolLibrary.getConfig();
return config != null && config.isChatWarnings();
} catch (Exception ignored) {}
return false;
}
/**
* Print the call stack to the given logger.
* @param logger - the logger.