Modernize and clean up pom.xml + plugin.yml

UltimateStacker-API/pom.xml

@@ -10,22 +10,10 @@
         <version>3.0.0-SNAPSHOT</version>
     </parent>
     <artifactId>UltimateStacker-API</artifactId>
-    <version>1.0.0</version>
+    <version>${craftaro.ultimateStackerApiVersion}</version>
 
     <build>
         <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.11.0</version>
-
-                <configuration>
-                    <source>${java.version}</source>
-                    <target>${java.version}</target>
-
-                    <release>${java.release}</release>
-                </configuration>
-            </plugin>
             <plugin>
                 <groupId>de.m3y.maven</groupId>
                 <artifactId>inject-maven-plugin</artifactId>
@@ -55,16 +43,16 @@
 
     <dependencies>
         <dependency>
-            <groupId>org.spigotmc</groupId>
-            <artifactId>spigot-api</artifactId>
-            <version>1.8.8-R0.1-SNAPSHOT</version>
+            <groupId>com.craftaro</groupId>
+            <artifactId>CraftaroCore</artifactId>
+            <version>${craftaro.coreVersion}</version>
             <scope>provided</scope>
         </dependency>
 
         <dependency>
-            <groupId>com.craftaro</groupId>
-            <artifactId>CraftaroCore</artifactId>
-            <version>3.0.0-SNAPSHOT</version>
+            <groupId>org.spigotmc</groupId>
+            <artifactId>spigot-api</artifactId>
+            <version>1.8.8-R0.1-SNAPSHOT</version>
             <scope>provided</scope>
         </dependency>
 

UltimateStacker-Plugin/pom.xml

@@ -13,19 +13,6 @@
 
     <build>
         <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.11.0</version>
-
-                <configuration>
-                    <source>${java.version}</source>
-                    <target>${java.version}</target>
-
-                    <release>${java.release}</release>
-                </configuration>
-            </plugin>
-
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-shade-plugin</artifactId>
@@ -39,7 +26,7 @@
                         </goals>
 
                         <configuration>
-                            <finalName>${project.name}-${project.version}</finalName>
+                            <finalName>${project.parent.name}-${project.version}</finalName>
 
                             <shadedArtifactAttached>false</shadedArtifactAttached>
                             <useDependencyReducedPomInJar>true</useDependencyReducedPomInJar>
@@ -86,26 +73,48 @@
         </resources>
     </build>
 
+    <repositories>
+        <repository>
+            <id>bg-repo</id>
+            <url>https://repo.bg-software.com/repository/api/</url>
+        </repository>
+
+        <repository>
+            <id>CodeMC</id>
+            <url>https://repo.codemc.org/repository/maven-public/</url>
+        </repository>
+
+        <repository>
+            <id>lumine-repo</id>
+            <url>https://mvn.lumine.io/repository/maven-public/</url>
+        </repository>
+
+        <repository>
+            <id>songoda-public</id>
+            <url>https://repo.craftaro.com/repository/public/</url>
+        </repository>
+    </repositories>
+
     <dependencies>
         <dependency>
-            <groupId>org.spigotmc</groupId>
-            <artifactId>spigot-api</artifactId>
-            <version>1.18-R0.1-SNAPSHOT</version>
-            <scope>provided</scope>
+            <groupId>com.craftaro</groupId>
+            <artifactId>UltimateStacker-API</artifactId>
+            <version>${craftaro.ultimateStackerApiVersion}</version>
+            <scope>compile</scope>
         </dependency>
 
         <dependency>
             <groupId>com.craftaro</groupId>
             <artifactId>CraftaroCore</artifactId>
-            <version>${core.version}</version>
+            <version>${craftaro.coreVersion}</version>
             <scope>compile</scope>
         </dependency>
 
         <dependency>
-            <groupId>com.craftaro</groupId>
-            <artifactId>UltimateStackerAPI</artifactId>
-            <version>1.0</version>
-            <scope>compile</scope>
+            <groupId>org.spigotmc</groupId>
+            <artifactId>spigot-api</artifactId>
+            <version>1.18-R0.1-SNAPSHOT</version>
+            <scope>provided</scope>
         </dependency>
 
         <dependency>

UltimateStacker-Plugin/src/main/resources/plugin.yml

@@ -1,4 +1,4 @@
-name: ${project.name}
+name: ${project.parent.name}
 description: ${project.description}
 version: ${project.version}
 api-version: 1.13
@@ -21,7 +21,7 @@ loadbefore:
   - WorldGuard
 
 author: Craftaro
-website: ${project.url}
+website: ${project.parent.url}
 
 commands:
   us:

pom.xml

@@ -6,8 +6,8 @@
 
     <groupId>com.craftaro</groupId>
     <artifactId>UltimateStacker-Parent</artifactId>
-    <version>3.0.0-SNAPSHOT</version>
     <packaging>pom</packaging>
+    <version>3.0.0-SNAPSHOT</version>
 
     <modules>
         <module>UltimateStacker-API</module>
@@ -19,37 +19,37 @@
     <url>https://craftaro.com/marketplace/product/16</url>
 
     <properties>
-        <java.version>1.8</java.version>
-        <java.release>8</java.release>
+        <craftaro.ultimateStackerApiVersion>1.0.0</craftaro.ultimateStackerApiVersion>
+        <craftaro.coreVersion>3.0.0-SNAPSHOT</craftaro.coreVersion>
 
-        <core.version>3.0.0-SNAPSHOT</core.version>
+        <maven.compiler.release>8</maven.compiler.release>
+        <maven.compiler.target>1.8</maven.compiler.target>
+        <maven.compiler.source>1.8</maven.compiler.source>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
+        <sonar.host.url>https://sonarcloud.io</sonar.host.url>
+        <sonar.moduleKey>${project.groupId}:${project.artifactId}</sonar.moduleKey>
     </properties>
 
+    <issueManagement>
+        <url>https://discord.gg/craftaro</url>
+        <system>Discord server</system>
+    </issueManagement>
+
+    <scm>
+        <url>https://github.com/craftaro/UltimateStacker</url>
+        <connection>scm:git:git://github.com/craftaro/UltimateStacker.git</connection>
+    </scm>
+
     <repositories>
         <repository>
-            <id>bg-repo</id>
-            <url>https://repo.bg-software.com/repository/api/</url>
+            <id>craftaro-minecraft-plugins</id>
+            <url>https://repo.craftaro.com/repository/minecraft-plugins/</url>
         </repository>
 
         <repository>
-            <id>songoda-public</id>
-            <url>https://repo.songoda.com/repository/public/</url>
-        </repository>
-
-        <repository>
-            <id>spigotmc-repo</id>
+            <id>SpigotMC</id>
             <url>https://hub.spigotmc.org/nexus/content/repositories/snapshots/</url>
         </repository>
-
-        <repository>
-            <id>CodeMC</id>
-            <url>https://repo.codemc.org/repository/maven-public/</url>
-        </repository>
-
-        <repository>
-            <id>lumine-repo</id>
-            <url>https://mvn.lumine.io/repository/maven-public/</url>
-        </repository>
     </repositories>
 </project>