Remove some todos

This commit is contained in:
Matsv 2017-06-13 17:10:56 +02:00
parent adc84452d5
commit e4998e267e
No known key found for this signature in database
GPG Key ID: 97CEC2A2EA31350F
6 changed files with 9 additions and 16 deletions

View File

@ -1,14 +1,7 @@
# ViaBackwards # ViaBackwards
Allows 1.9.x on a 1.10 Spigot server Allows older Minecraft versions on a newer Minecraft server
Requires [ViaVersion](http://viaversion.com) to be installed Requires [ViaVersion](http://viaversion.com) to be installed
**Spigot page:** https://www.spigotmc.org/resources/viabackwards.27448/ **Spigot page:** https://www.spigotmc.org/resources/viabackwards.27448/
TODO:
- Entity names that changed?
- llama inventory slots
- Rewrite Shulker box name

View File

@ -55,8 +55,8 @@ public interface ViaBackwardsPlatform {
if (clazz == null) { if (clazz == null) {
getLogger().severe("================================"); getLogger().severe("================================");
getLogger().severe("YOUR VIAVERSION IS OUTDATED"); getLogger().severe("YOUR VIAVERSION IS OUTDATED");
getLogger().severe("PLEASE USE THE LATEST DEVBUILD"); getLogger().severe("PLEASE USE THE LATEST VERSION");
getLogger().severe("LINK: https://ci.viaversion.com/job/ViaVersion-DEV/"); getLogger().severe("LINK: https://viaversion.com");
getLogger().severe("VIABACKWARDS WILL NOW DISABLE"); getLogger().severe("VIABACKWARDS WILL NOW DISABLE");
getLogger().severe("================================"); getLogger().severe("================================");

View File

@ -300,7 +300,7 @@ public class BlockItemPackets1_11 extends BlockItemRewriter<Protocol1_10To1_11>
handler(new PacketHandler() { handler(new PacketHandler() {
@Override @Override
public void handle(PacketWrapper wrapper) throws Exception { public void handle(PacketWrapper wrapper) throws Exception {
// Remove on shulkerbox decleration TODO convert to normal chest to make it work correctly? // Remove on shulkerbox decleration
if (wrapper.get(Type.UNSIGNED_BYTE, 0) == 10) { if (wrapper.get(Type.UNSIGNED_BYTE, 0) == 10) {
wrapper.cancel(); wrapper.cancel();
} }
@ -410,7 +410,7 @@ public class BlockItemPackets1_11 extends BlockItemRewriter<Protocol1_10To1_11>
return tag; return tag;
}); });
// Rewrite spawn eggs TODO maybe intercept / handle server for creative instead of ViaBackwards NBT // Rewrite spawn eggs
rewrite(383).itemHandler((i) -> { rewrite(383).itemHandler((i) -> {
EntityTypeNames.toClientItem(i); EntityTypeNames.toClientItem(i);
return i; return i;

View File

@ -407,7 +407,7 @@ public class EntityPackets1_11 extends EntityRewriter<Protocol1_10To1_11> {
regEntType(EntityType.EVOCATION_ILLAGER, EntityType.VILLAGER).mobName("Evoker"); regEntType(EntityType.EVOCATION_ILLAGER, EntityType.VILLAGER).mobName("Evoker");
regEntType(EntityType.VEX, EntityType.BAT).mobName("Vex"); regEntType(EntityType.VEX, EntityType.BAT).mobName("Vex");
regEntType(EntityType.VINDICATION_ILLAGER, EntityType.VILLAGER).mobName("Vindicator").spawnMetadata(storage -> storage.add(new Metadata(13, MetaType1_9.VarInt, 4))); // Base Profession regEntType(EntityType.VINDICATION_ILLAGER, EntityType.VILLAGER).mobName("Vindicator").spawnMetadata(storage -> storage.add(new Metadata(13, MetaType1_9.VarInt, 4))); // Base Profession
regEntType(EntityType.LIAMA, EntityType.HORSE).mobName("Llama").spawnMetadata(storage -> storage.add(getHorseMetaType(1))); // TODO fix chest slots regEntType(EntityType.LIAMA, EntityType.HORSE).mobName("Llama").spawnMetadata(storage -> storage.add(getHorseMetaType(1)));
regEntType(EntityType.LIAMA_SPIT, EntityType.SNOWBALL); regEntType(EntityType.LIAMA_SPIT, EntityType.SNOWBALL);
regObjType(ObjectType.LIAMA_SPIT, ObjectType.SNOWBALL, -1); regObjType(ObjectType.LIAMA_SPIT, ObjectType.SNOWBALL, -1);

View File

@ -83,7 +83,7 @@ public class ChangedPacketIds1_12 extends Rewriter<Protocol1_11_1To1_12> {
} }
}); });
} }
}); // Advancements TODO }); // Advancements
p.registerOutgoing(State.PLAY, 0x4D, 0x4A); // Entity Properties p.registerOutgoing(State.PLAY, 0x4D, 0x4A); // Entity Properties
p.registerOutgoing(State.PLAY, 0x4E, 0x4B); // Entity Effect p.registerOutgoing(State.PLAY, 0x4E, 0x4B); // Entity Effect

View File

@ -366,7 +366,7 @@ public class EntityPackets1_12 extends EntityRewriter<Protocol1_11_1To1_12> {
regEntType(EntityType.PARROT, EntityType.BAT).mobName("Parrot").spawnMetadata(storage -> storage.add(new Metadata(12, MetaType1_12.Byte, (byte) 0x00))); regEntType(EntityType.PARROT, EntityType.BAT).mobName("Parrot").spawnMetadata(storage -> storage.add(new Metadata(12, MetaType1_12.Byte, (byte) 0x00)));
regEntType(EntityType.ILLUSION_ILLAGER, EntityType.EVOCATION_ILLAGER).mobName("Illusioner"); regEntType(EntityType.ILLUSION_ILLAGER, EntityType.EVOCATION_ILLAGER).mobName("Illusioner");
// Handle Illager TODO wtf does this metadata do? Is aggresive it is a bitmask? // Handle Illager
registerMetaHandler().filter(EntityType.EVOCATION_ILLAGER, true, 12).removed(); registerMetaHandler().filter(EntityType.EVOCATION_ILLAGER, true, 12).removed();
registerMetaHandler().filter(EntityType.EVOCATION_ILLAGER, true, 13).handleIndexChange(12); registerMetaHandler().filter(EntityType.EVOCATION_ILLAGER, true, 13).handleIndexChange(12);