Commit Graph

40589 Commits

Author SHA1 Message Date
Sergey Biryukov
05b9f27d11 Administration: Correct checkbox width in list tables on smaller screens.
Previously, checkboxes for pending comments were partially hidden due to an added `4px` border.

Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93.
Merges [46845] to the 5.3 branch.
Fixes #48815.
Built from https://develop.svn.wordpress.org/branches/5.3@46846


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 14:30:02 +00:00
Sergey Biryukov
9870e114af Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created.
This ensures that the actual UI controls state matches the visually conveyed state.

Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Merges [46842] to the 5.3 branch.
Fixes #48409.
Built from https://develop.svn.wordpress.org/branches/5.3@46843


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 13:51:02 +00:00
Sergey Biryukov
ad8e49e8dd Twenty Twenty: Correct alignment for embedded Instagram posts.
Props SGr33n, audrasjb, nielslange, JarretC.
Merges [46840] to the 5.3 branch.
Fixes #48688.
Built from https://develop.svn.wordpress.org/branches/5.3@46841


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 13:41:00 +00:00
Sergey Biryukov
97b8443321 Users: Introduce admin_email_remind_interval filter for dismissing the admin email confirmation screen.
Props desrosj, birgire.
Merges [46838], [46837] to the 5.3 branch.
Fixes #48334.
Built from https://develop.svn.wordpress.org/branches/5.3@46839


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 13:30:03 +00:00
Sergey Biryukov
176a6206a3 Upload: fix wp_unique_filename() to prevent name collisions with existing or future image sub-size file names, and add unit tests.
Props Viper007Bond, pbiron, azaozz.
Merges [46822], [46835] to the 5.3 branch.
Fixes #42437.
Built from https://develop.svn.wordpress.org/branches/5.3@46836


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 12:21:03 +00:00
Sergey Biryukov
d6875bc495 Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original.
Props azaozz.
Merges [46809] to the 5.3 branch.
Fixes #48736.
Built from https://develop.svn.wordpress.org/branches/5.3@46834


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 12:04:02 +00:00
Sergey Biryukov
33da7d7e7f Twenty Twenty: Pass $post_meta and $location values to twentytwenty_start_of_post_meta_list and twentytwenty_end_of_post_meta_list actions to provide better context.
Props msaari, SergeyBiryukov.
Merges [46832] to the 5.3 branch.
Fixes #48906.
Built from https://develop.svn.wordpress.org/branches/5.3@46833


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 11:51:05 +00:00
Sergey Biryukov
bd3bd0c6ff Twenty Twenty: Replace Smooth Scroll JS implementation with scroll-behavior CSS property.
The JS implementation had multiple issues and did not work as expected.

This change includes an accessibility enhancement by using `prefers-reduced-motion: reduce` media query property for users that don't want motion effects. For further explanation on this media query, see MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#Accessibility_concerns

Props audrasjb, melchoyce, joostdevalk, Anlino, mauteri, sergiomdgomes, littlebigthing, williampatton, netweb, andraganescu, joyously, acosmin, mukesh27, hareesh-pillai.
Merges [46824] to the 5.3 branch.
Fixes #48763, #48551, #48866.
Built from https://develop.svn.wordpress.org/branches/5.3@46825


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-07 11:08:01 +00:00
Sergey Biryukov
4c4662e95c Accessibility: Administration: Correct active button color for the alternative color schemes.
Follow-up to [46815].

Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Merges [46817] to the 5.3 branch.
Fixes #48598.
Built from https://develop.svn.wordpress.org/branches/5.3@46818


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-05 22:14:04 +00:00
Sergey Biryukov
6cd7126ff2 Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes.
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.

Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Merges [46815] to the 5.3 branch.
Fixes #48585.
Built from https://develop.svn.wordpress.org/branches/5.3@46816


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-05 21:34:05 +00:00
Sergey Biryukov
b7f33680dc Site Health: Add a test for PHP default timezone.
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.

WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.

Props Rarst, Clorith, TimothyBlynJacobs.
Merges [46797] to the 5.3 branch.
Fixes #48692.
Built from https://develop.svn.wordpress.org/branches/5.3@46798


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-28 15:57:05 +00:00
Sergey Biryukov
9156181d27 Date/Time: Make get_permalink() more resilient against PHP timezone changes.
Overriding default PHP timezone with `date_default_timezone_set()`, while not recommended, should not inadvertently result in changing existing permalinks.

Add a unit test.

Props Rarst, steevithak, archon810, maciejmackowiak, Ov3rfly, Cybr, hometowntrailers, scvleon, miette49.
Merges [46795] to the 5.3 branch.
Fixes #48623.
Built from https://develop.svn.wordpress.org/branches/5.3@46796


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-28 13:57:02 +00:00
Sergey Biryukov
2fed57f1b0 KSES: Add support for gradient backgrounds.
Props jorgefilipecosta.
Merges [46793] to the 5.3 branch.
Fixes #48376.
Built from https://develop.svn.wordpress.org/branches/5.3@46794


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-28 00:31:02 +00:00
Sergey Biryukov
b06ee36d81 Users: Display admin email verification screen in user's locale instead of site locale.
Props sathyapulse, TimothyBlynJacobs.
Merges [46788] to the 5.3 branch.
Fixes #48313.
Built from https://develop.svn.wordpress.org/branches/5.3@46789


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 14:40:00 +00:00
desrosj
6f3a28818e Bundled Themes: Fixes JS TypeError in Twenty Twenty.
On mobile devices using a webkit browser, the menu and search modals could not be opened due to a `TypeError: document.body is null`. This commit fixes that issue by adding a `touch-enabled` class to the body for browsers that do not support media queries.

Props quicoto, poena, Boga86, acosmin, macmanx, ianbelanger.
Fixes #48601.
Built from https://develop.svn.wordpress.org/branches/5.3@46787


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-26 18:43:04 +00:00
Sergey Biryukov
d6c12ac919 Users: Use correct variable when displaying the Additional Capabilities list in user profile.
Addresses a regression in [45926].

Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Merges [46782] to the 5.3 branch.
Fixes #48725.
Built from https://develop.svn.wordpress.org/branches/5.3@46783


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 14:03:02 +00:00
Sergey Biryukov
fd1e68a6a4 Widgets: Avoid to move focus to the Image Widget "Insert from URL" field.
Fixes a bug after [45499], where the backbone view element isn't the input field any longer. Also, managing focus programmatically is often an assumption on a specific user flow and should generally be avoided, see #43169.

Props dufresnesteven, afercia.
Merges [46745] to the 5.3 branch.
See #43169.
Fixes #48588.
Built from https://develop.svn.wordpress.org/branches/5.3@46781


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 13:51:03 +00:00
Sergey Biryukov
50f419f0a8 Options, Meta APIs: Avoid a race condition causing the first of two subsequent requests updating different options at the same time to lose changes.
Every time an autoloaded option is updated or deleted, the `alloptions` cache is similarly updated. Due to the race condition, on any autoloaded option being updated, every other autoloaded option had its value set to the value at load time, causing a mismatch between the data in the persistent cache and the database.

This change introduces a `$force_cache` parameter for `wp_load_alloptions()` to force an update of the local `alloptions` cache from the persistent cache when an option is added, updated, or deleted, to minimize the chance of affecting other options.

Props fabifott, rmccue, tollmanz, johnjamesjacoby, spacedmonkey, dd32, jipmoors, tellyworth, jeremyclarke, joehoyle, boonebgorges, danielbachhuber, flixos90, jeichorn, mihdan, Grzegorz.Janoszka, SergeyBiryukov.
Merges [46753] and [46779] to the 5.3 branch.
Fixes #31245.
Built from https://develop.svn.wordpress.org/branches/5.3@46780


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 13:46:12 +00:00
Sergey Biryukov
c54903a12e Accessibility: Media: Add an aria-pressed attribute to active button within a button group.
The `aria-pressed` attribute communicates semantically the "active" state of buttons that otherwise only look "active".

Props afercia.
Merges [46748] to the 5.3 branch.
Fixes #48355.
Built from https://develop.svn.wordpress.org/branches/5.3@46778


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 11:20:02 +00:00
Sergey Biryukov
159068b2a0 Accessibility: Add an aria-current attribute to the Media Library switch links.
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.

Props mayanksonawat, afercia.
Merges [46746] to the 5.3 branch.
Fixes #48271.
Built from https://develop.svn.wordpress.org/branches/5.3@46777


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 10:23:03 +00:00
Sergey Biryukov
ff1db3c4a9 Docs: Fix typo in wp_credits_section_title() description.
Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards.

Props hareesh-pillai.
Merges [46738] to the 5.3 branch.
Fixes #48674.
Built from https://develop.svn.wordpress.org/branches/5.3@46776


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 10:20:03 +00:00
Sergey Biryukov
4baea39a4d Editor: Improve the appearance of tag cloud in Tags meta box in classic editor.
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Merges [46758] to the 5.3 branch.
Fixes #48592.
Built from https://develop.svn.wordpress.org/branches/5.3@46775


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 10:14:04 +00:00
Sergey Biryukov
abbe0c7912 Date/Time: Remove mysql2date() usage in get_feed_build_date() to ensure the output includes correct timezone offset.
With the changes in [45908], `mysql2date()` works correctly for all local time inputs, but should not be used for UTC time inputs.

Add a unit test.

Props Rarst, lisota.
Merges [46756] and [46757] to the 5.3 branch.
Fixes #48675.
Built from https://develop.svn.wordpress.org/branches/5.3@46774


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 10:12:01 +00:00
Sergey Biryukov
35e045286d Media: Avoid a PHP notice in image_downsize() when trying to replace a non-image URL with a rendered image from its meta.
Props Mte90, jrf, hareesh-pillai.
Merges [46772] to the 5.3 branch.
Fixes #48324.
Built from https://develop.svn.wordpress.org/branches/5.3@46773


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 10:09:01 +00:00
Sergey Biryukov
0a417c0dc9 Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined:
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box

Split "Manage widgets or menus" into separate items for consistency with other links.

For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.

Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone

Props afercia, audrasjb, karmatosed.
Merges [46770] to the 5.3 branch.
Fixes #48406.
Built from https://develop.svn.wordpress.org/branches/5.3@46771


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-24 20:00:04 +00:00
Sergey Biryukov
7df949e31e Twenty Twenty: Fix typos in a variable name and inline comment in assets/js/color-calculations.js.
Props tanvirul.
Merges [46747] to the 5.3 branch.
Fixes #48704.
Built from https://develop.svn.wordpress.org/branches/5.3@46769


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-24 11:05:02 +00:00
Sergey Biryukov
27e67093f7 Embeds: Remove CollegeHumor oEmbed provider, as the service does not exist anymore.
Props audrasjb, youknowriad.
Merges [46761] to the 5.3 branch.
Fixes #48696.
Built from https://develop.svn.wordpress.org/branches/5.3@46768


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-24 11:03:02 +00:00
Sergey Biryukov
e5296ce359 Twenty Twenty: Correctly align the author bio and bottom post meta on single posts on mobile.
Props nielslange, Anlino.
Merges [46762] to the 5.3 branch.
Fixes #48619.
Built from https://develop.svn.wordpress.org/branches/5.3@46767


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-24 11:01:04 +00:00
Sergey Biryukov
51ba5fd05b Twenty Twenty: Remove duplicate array key/value in TwentyTwenty_Non_Latin_Languages::get_non_latin_css().
Props manikmist09.
Merges [46765] to the 5.3 branch.
Fixes #48624.
Built from https://develop.svn.wordpress.org/branches/5.3@46766


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-24 10:59:04 +00:00
Sergey Biryukov
01c05f6ba4 Post WordPress 5.3 version bump.
Built from https://develop.svn.wordpress.org/branches/5.3@46728


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 21:57:01 +00:00
Sergey Biryukov
1d39158963 WordPress 5.3.
Built from https://develop.svn.wordpress.org/branches/5.3@46726


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 20:28:04 +00:00
Sergey Biryukov
ace691cd92 Help/About: Move images to the CDN.
Props ryelle.
Merges [46724] to the 5.3 branch.
Fixes #47708.
Built from https://develop.svn.wordpress.org/branches/5.3@46725


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 18:32:03 +00:00
Sergey Biryukov
adfc7aad8d Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see fa8c3fc...a9e73ab.

Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110, #48386, #48450, #48505, #48557.
Merges [46722] to the 5.3 branch.
Fixes #48571.
Built from https://develop.svn.wordpress.org/branches/5.3@46723


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 18:26:03 +00:00
Sergey Biryukov
492e68fa7c Bundled Themes: Update copyright year in readme.txt.
Add a unit test to ensure the year stays up to date.

Props dkarfa, SergeyBiryukov.
Merges [46719] and [46720] to the 5.3 branch.
Fixes #48566.
Built from https://develop.svn.wordpress.org/branches/5.3@46721


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 18:06:04 +00:00
Sergey Biryukov
1bbf386977 Post WordPress 5.3 RC5 version bump.
Built from https://develop.svn.wordpress.org/branches/5.3@46718


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 02:48:03 +00:00
Sergey Biryukov
c6be5ae66c WordPress 5.3 RC5.
Built from https://develop.svn.wordpress.org/branches/5.3@46717


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 02:19:01 +00:00
Sergey Biryukov
70f65b8fcd Bundled Themes: Update Twenty Twenty.
* Add `.has-background` excluding condition to wide and full group-blocks.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see 162edc0...fa8c3fc.

Reviewed by azaozz, SergeyBiryukov.
Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Merges [46715] to the 5.3 branch.
Fixes #48557.
Built from https://develop.svn.wordpress.org/branches/5.3@46716


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 02:08:02 +00:00
Sergey Biryukov
f8218720fb Bundled Themes: Update Twenty Twenty.
* Add a11y-friendly default text-colors when selecting a background-color.
* Remove margins for the group block when a background-color is set.
* Excluding pullquote block from width resize rules.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see ab5fa23...162edc0.

Reviewed by azaozz, SergeyBiryukov.
Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Merges [46713] to the 5.3 branch.
Fixes #48557.
Built from https://develop.svn.wordpress.org/branches/5.3@46714


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 01:46:02 +00:00
Sergey Biryukov
4c19b2c3c3 Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see c267289...ab5fa23.

Reviewed by SergeyBiryukov.
Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07, allancole, karmatosed, pierlo, joen, ianbelanger.
See #48110, #48386, #48450, #48505.
Merges [46701], [46702], [46711] to the 5.3 branch.
Fixes #48557.
Built from https://develop.svn.wordpress.org/branches/5.3@46712


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 21:05:01 +00:00
Sergey Biryukov
79ea28c053 Help/About: Update the 5.3 About page.
* Remove the SVG from the upper right corner.
* Make sure admin notices that should be hidden stay hidden.
* Address a11y issues with contrast.
* Fix an issue with the active nav tab hover.
* Prevent names on the credits from breaking out of the box.
* Update two strings with a more accurate information.
* Remove extra padding on the Credits tab.

Previously [46556], [46572], [46616].

Reviewed by SergeyBiryukov.
Props ryelle, afercia, audrasjb, francina, mapk, desrosj, YordanSoares, melchoyce, azaozz, johnbillion, davidbaumwald, luminuu, bwmarkle, la-geek, SergeyBiryukov.
Merges [46705] and [46709] to the 5.3 branch.
Fixes #47708.
Built from https://develop.svn.wordpress.org/branches/5.3@46710


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 20:48:02 +00:00
Sergey Biryukov
f542e3f870 Tests: Fix a typo in an inline comment introduced in [46568].
Reviewed by whyisjake, SergeyBiryukov.
Props david.binda.
Merges [46707] to the 5.3 branch.
Fixes #48564. See #48312.
Built from https://develop.svn.wordpress.org/branches/5.3@46708


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 20:32:05 +00:00
whyisjake
d804c8218d Comments: Check if comment form element exists before adding a key handler to detect the cmd/ctrl-enter key press.
Brings [46700] to the 5.3 branch.

Follow-up to [45790].
Props raamdev.
Fixes #48543. See #41545.


Built from https://develop.svn.wordpress.org/branches/5.3@46706


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 16:59:02 +00:00
Sergey Biryukov
0dcfbcca36 Script Loader: In wp_default_packages_inline_scripts(), make sure the root URL middleware is registered before using the media middleware.
This allows for requests to retry post-processing large images using the `post-process` REST API endpoint to work as expected.

Reviewed by johnbillion, youknowriad, SergeyBiryukov.
Props azaozz, mikeschroder, TimothyBlynJacobs, epiqueras, johnbillion, youknowriad.
Merges [46703] to the 5.3 branch.
Fixes #48542.
Built from https://develop.svn.wordpress.org/branches/5.3@46704


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 15:13:02 +00:00
Sergey Biryukov
a4ea358a27 Bundled Themes: Standardize the Required PHP and Tested Up To headers.
This change makes several changes to ensure consistency and accuracy for default theme headers:

- Removes `WordPress` from `Requires at least` headers.
- Ensures the `Requires at least` and `Requires PHP` headers are present in every default theme’s `style.css` file.
- Ensures `Tested up to` is present in every `readme.txt` file.
- Removes any headers not processed in both the `style.css` and `readme.txt` files for each theme.

Props Otto42, afragen.
Merges [46676] to the 5.3 branch.
Fixes #48517.
Built from https://develop.svn.wordpress.org/branches/5.3@46699


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 11:39:04 +00:00
Andrew Ozz
5e93894c98 Upload: When an image was scaled because it is larger than the big image threshold, use the originally uploaded image's dimensions in wp_get_missing_image_subsizes(). Fixes an edge case/inconsistent behaviour when a registered image sub-size is also larger than the big image threshold.
Props desrosj, azaozz.
Merges [46677] to the 5.3 branch.
Fixes #48518.
Built from https://develop.svn.wordpress.org/branches/5.3@46680


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-08 22:58:03 +00:00
John Blackbourn
69f5738ed0 Post WordPress 5.3 RC4 version bump.
Built from https://develop.svn.wordpress.org/branches/5.3@46673


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-06 00:02:02 +00:00
John Blackbourn
3189b48619 WordPress 5.3 RC4.
Built from https://develop.svn.wordpress.org/branches/5.3@46672


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 23:24:02 +00:00
desrosj
f252700dec Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC3, see dea9290...c267289.

Props williampatton, poena, andersnoren.
See #48110, #48386, #48450, #48293.
Fixes #48505.
Built from https://develop.svn.wordpress.org/branches/5.3@46669


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 22:30:04 +00:00
desrosj
30ea8d0dd9 Emoji: Upgrade Twemoji to 12.1.3.
This point release does not add any images and only slightly modifies a few images without changing their meanings. Because of this, the same CDN location can be used and has been updated.

Merges [46665] to the 5.3 branch.

Reviewed by desrosj, SergeyBiryukov.
Props matstars, desrosj, Otto42, pento.
Fixes #48293.
Built from https://develop.svn.wordpress.org/branches/5.3@46667


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 22:16:02 +00:00
John Blackbourn
181367b5c6 Block Editor: Bug fixes targeted for WordPress 5.3 RC4.
Merges [46656] to the 5.3 branch.
Fixes #48502

Built from https://develop.svn.wordpress.org/branches/5.3@46666


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 22:06:04 +00:00