Commit Graph

43537 Commits

Author SHA1 Message Date
Sergey Biryukov
10a084a067 Coding Standards: Move some translator comments to the correct place.
Follow-up to [46273], [50060], [50117].

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50654


git-svn-id: http://core.svn.wordpress.org/trunk@50266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-04 18:30:05 +00:00
Sergey Biryukov
b6e32b9d4f REST API: Correct enum validation for numeric values.
When validating `enum` values as `integer` or `number`, consider a number with a zero fractional part to be equivalent to an integer of the same value.

In `rest_are_values_equal()`, when comparing two values of type `int` or `float` (in any combination), first cast both of them to `float` and then compare.

This matches some test cases from the official JSON Schema test suite.

Follow-up to [50010].

Props yakimun, stefanjoebstl, TimothyBlynJacobs, rachelbaker.
Fixes #52932.
Built from https://develop.svn.wordpress.org/trunk@50653


git-svn-id: http://core.svn.wordpress.org/trunk@50265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-04 18:07:04 +00:00
Sergey Biryukov
907bfe74cd Coding Standards: Use strict comparison in wp-admin/includes/class-core-upgrader.php.
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50652


git-svn-id: http://core.svn.wordpress.org/trunk@50264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-04 16:49:09 +00:00
Sergey Biryukov
b70c00d6ac Build/Test Tools: Rename some Grunt tasks to use hyphens instead of camelCase.
This makes the task names more consistent with other tasks.

Follow-up to [41043], [48096], [50650].

See #52625.
Built from https://develop.svn.wordpress.org/trunk@50651


git-svn-id: http://core.svn.wordpress.org/trunk@50263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-03 12:46:10 +00:00
davidbaumwald
3912ca99fd External Libraries: Update Underscore to version 1.12.1.
Full set of changes at https://github.com/jashkenas/underscore/compare/1.8.3...1.12.1.  
The new version includes a `sourceMappingURL` that causes a build failure, so this change 
also introduces a task to remove this from the source during the build.

Props mukesh27, hareesh-pillai, desrosj, SergeyBiryukov, TimoTijhof.
Fixes #45785.
Built from https://develop.svn.wordpress.org/trunk@50650


git-svn-id: http://core.svn.wordpress.org/trunk@50262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-02 19:42:21 +00:00
desrosj
75923de5ef Build/Test Tools: Prevent the workflow for testing old branches from running on forks.
This adds a conditional statement to ensure the workflow that tests old branches only runs on the official `wordpress-develop` mirror. This prevents it from running on forks and private mirrors.

See #52653.
Built from https://develop.svn.wordpress.org/trunk@50648


git-svn-id: http://core.svn.wordpress.org/trunk@50260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-02 16:22:04 +00:00
davidbaumwald
cc0ce2c91d Editor: Update the default writing prompt to match the block editor.
Recently merged, https://github.com/WordPress/gutenberg/pull/29611, changed the default writing prompt text.  WordPress core offers the `write_your_story` filter with a default value using the same text.  This change updates the default text to match the recent change in the block editor.

Props Joen, SergeyBiryukov.
Fixes #52948.
Built from https://develop.svn.wordpress.org/trunk@50647


git-svn-id: http://core.svn.wordpress.org/trunk@50259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-02 16:08:04 +00:00
davidbaumwald
133c4e2e50 Docs: Clarify return results for a non-existing ID in metadata functions.
[48658] documented that various metadata functions return false for an invalid ID. However, that does not clarify what an invalid ID is: a non-numeric, zero, or negative value. This change adds the clarification in all relevant metadata function docblocks.

Props icopydoc, SergeyBiryukov, davidkryzaniak, audrasjb.
Fixes #51797.
Built from https://develop.svn.wordpress.org/trunk@50641


git-svn-id: http://core.svn.wordpress.org/trunk@50253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-02 15:49:05 +00:00
Sergey Biryukov
526dfa8b12 KSES: Add object-position to the list of safe CSS properties.
This resolves an issue with the Cover block, where the `object-position` property is removed from the content when a non-admin user saves the post, leading to block recovery loop.

Props Mamaduka, aristath.
Fixes #52961.
Built from https://develop.svn.wordpress.org/trunk@50634


git-svn-id: http://core.svn.wordpress.org/trunk@50246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-02 12:41:09 +00:00
davidbaumwald
5767dbd5ff Build/Test Tools: Cleanup link-manager.zip after REST API tests are finished.
Introduced in [48242], the `link-manager` plugin is copied from `DIR_TESTDATA/plugins` to `DIR_TESTDATA` during the REST API unit tests, but was not cleaned up afterward.  This created a "dirty" local working copy.  This change `unlink`s the copied plugin from `DIR_TESTDATA` after unit tests are completed.

Props johnbillion, TimothyBlynJacobs, desrosj, rachelbaker.
Fixes #52579.
Built from https://develop.svn.wordpress.org/trunk@50633


git-svn-id: http://core.svn.wordpress.org/trunk@50245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-01 20:41:07 +00:00
davidbaumwald
739dfb756f Coding Standards: Remove some extra whitespace in get_item_schema.
Introduced in [50527].

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50632


git-svn-id: http://core.svn.wordpress.org/trunk@50244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-01 15:54:04 +00:00
davidbaumwald
ab6c10948f Coding Standards: Removing unnecessary parentheses from require_once in wp-admin/options-privacy.php.
In [47198], parentheses were removed from `include` and `require` statements, as they are language constructs, not function calls.  However, [50161] introduced a new `require_once` instance in `wp-admin/options-privacy.php`.  This change removes the unnecessary parentheses.

See #53627.
Built from https://develop.svn.wordpress.org/trunk@50631


git-svn-id: http://core.svn.wordpress.org/trunk@50243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-01 15:36:08 +00:00
Sergey Biryukov
3697386083 Editor: Consolidate enqueueing block editor assets in wp-includes/default-filters.php.
Follow-up to [44157], [46111], [48537], [50620].

See #52920.
Built from https://develop.svn.wordpress.org/trunk@50629


git-svn-id: http://core.svn.wordpress.org/trunk@50241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-01 11:46:09 +00:00
Dominik Schilling
07b7afd60a External Libraries: Upgrade PHPMailer from 6.3.0 to 6.4.0.
6.4.0 reverts a change that made the `mail()` and sendmail transports set the envelope sender if one isn't explicitly provided, as it was causing problems in specific PHP/server configurations.

Release post: https://github.com/PHPMailer/PHPMailer/releases/tag/v6.4.0
Changelog: https://github.com/PHPMailer/PHPMailer/compare/v6.3.0...v6.4.0

Props Synchro, tigertech, ayeshrajans, galbaras, audrasjb, SergeyBiryukov, desrosj, ocean90.
Fixes #52822.
Built from https://develop.svn.wordpress.org/trunk@50628


git-svn-id: http://core.svn.wordpress.org/trunk@50240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-31 21:30:03 +00:00
Aaron Jorbin
f4678dff60 Build/Test & External Libraries : Fix jQuery deprecation.
jQuery.isArray is deprecated. Array.isArray is safe and used in other parts of the code base.

See: #51812

Built from https://develop.svn.wordpress.org/trunk@50627


git-svn-id: http://core.svn.wordpress.org/trunk@50239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-31 20:29:06 +00:00
Sergey Biryukov
4d1595b6d4 Docs: Document the import_id parameter of wp_insert_post().
Follow-up to [9100].

Props donmhico.
Fixes #52943.
Built from https://develop.svn.wordpress.org/trunk@50621


git-svn-id: http://core.svn.wordpress.org/trunk@50234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-31 13:05:06 +00:00
gziolo
6d42a21103 Editor: Enqueue assets for format library for the block editor
Ensures that `wp-format-library` assets are always loaded for the block editor. Otherwise, they have to be loaded individually for every screen that needs it. It's similar to how `wp-block-directory` assets are handled.

Props ellatrix.
See #52920.


Built from https://develop.svn.wordpress.org/trunk@50620


git-svn-id: http://core.svn.wordpress.org/trunk@50233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-31 05:52:10 +00:00
desrosj
5c451da5e9 External Libraries: Update polyfill versions in the script loader.
Follow up to [50615, 50617].

See #52854.
Built from https://develop.svn.wordpress.org/trunk@50619


git-svn-id: http://core.svn.wordpress.org/trunk@50232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-30 17:57:05 +00:00
Sergey Biryukov
f701ad4999 Coding Standards: Remove some extra whitespace in _wp_translate_postdata().
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50618


git-svn-id: http://core.svn.wordpress.org/trunk@50231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-30 15:19:03 +00:00
desrosj
85c90c4e01 External Libraries: Update the path to polyfill-library files in Webpack.
Follow up to [50615].

Props gziolo.
Fixes #52854.
Built from https://develop.svn.wordpress.org/trunk@50617


git-svn-id: http://core.svn.wordpress.org/trunk@50230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-30 14:49:04 +00:00
Sergey Biryukov
1a9eb60625 Docs: Add documentation for the ::setup_export_contents_test method used in personal data export tests.
Follow-up to [50613].

Props hellofromTonya.
See #51423.
Built from https://develop.svn.wordpress.org/trunk@50616


git-svn-id: http://core.svn.wordpress.org/trunk@50229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-30 14:24:03 +00:00
desrosj
7eee8521b0 External Libraries: Update several polyfill libraries.
This updates the following polyfill libraries:

- `formdata-polyfill` from `3.0.13` to `3.0.20`.
- `objectFitPolyfill` from `2.3.4` to `2.3.5`.
- `polyfill-library` from `3.42.0` to `3.104.0`.

Props gziolo, desrosj.
Fixes #52854.
Built from https://develop.svn.wordpress.org/trunk@50615


git-svn-id: http://core.svn.wordpress.org/trunk@50228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-30 14:16:33 +00:00
davidbaumwald
67d6f5f6c6 Docs: Fix indentation for wp_term_query->construct method parameters.
The `fields` and `orderby` properties in `WP_Term_Query` are arrays and each accepts a variety of keys.  To properly indent each key in the docblock, a `*` should be used, not `-`.

Props whyisjake, audrasjb, SergeyBiryukov.
Fixes #52839.
Built from https://develop.svn.wordpress.org/trunk@50614


git-svn-id: http://core.svn.wordpress.org/trunk@50227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-29 21:35:07 +00:00
Sergey Biryukov
69a7063a49 Code Modernization: Check if the _export_data_grouped post meta is an array when generating a personal data export file.
This avoids a fatal error on PHP 8 in `wp_privacy_generate_personal_data_export_file()` if the `_export_data_grouped` post meta exists but is not an array.

Additionally, refactor unit tests for the function to:
* Reduce redundant code
* Switch to data provider
* Test on the full HTML output instead of select pieces of the output
* Expand unhappy path coverage

Follow-up to [43012], [44786], [47146], [47278].

Props hellofromTonya, jrf, xknown.
See #51423.
Built from https://develop.svn.wordpress.org/trunk@50613


git-svn-id: http://core.svn.wordpress.org/trunk@50226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-29 19:37:04 +00:00
Sergey Biryukov
59d32bfe24 Build/Test Tools: Remove explicit puppeteer dependency.
This was added in [48177] to fix an issue where Puppeteer was not being installed correctly as a dependency of `@wordpress/wp-scripts`. This has been fixed, so this explicit dependency can be removed.

Props isabel_brison, desrosj, SergeyBiryukov.
Fixes #52843.
Built from https://develop.svn.wordpress.org/trunk@50612


git-svn-id: http://core.svn.wordpress.org/trunk@50225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-29 18:07:25 +00:00
Sergey Biryukov
dc4de0d5a5 Login and Registration: Add the "Error:" prefix to some password reset messages.
This makes the messages more consistent with other error messages related to authentication and registration.

Follow-up to [50589].

Props dd32.
Fixes #52914.
Built from https://develop.svn.wordpress.org/trunk@50611


git-svn-id: http://core.svn.wordpress.org/trunk@50224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-28 10:24:05 +00:00
Sergey Biryukov
05631ab4cd Docs: Spell "non-existent" in a consistent way.
See #52628.
Built from https://develop.svn.wordpress.org/trunk@50610


git-svn-id: http://core.svn.wordpress.org/trunk@50223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-27 13:34:12 +00:00
desrosj
87a4101834 Build/Test Tools: Update some devDependencies.
This updates the following `devDependencies`:

- `sinon` from `9.2.4` to `10.0.0`.
- `uglify-js` from `3.13.1` to `3.13.2`.

See #52624.
Built from https://develop.svn.wordpress.org/trunk@50598


git-svn-id: http://core.svn.wordpress.org/trunk@50211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 15:47:21 +00:00
desrosj
755882578e Twenty Twelve: Change theme version back to 3.3.
Because the changes in Twenty Twelve did not impact site look or functionality, version 3.4 of Twenty Twelve was not released in coordination with WordPress 5.7.

This reverts the portion of [50508] relevant to Twenty Twelve, changing the version back to 3.3 so that version 3.4 is not skipped accidentally when there are changes that should be released.

See #52704.
Built from https://develop.svn.wordpress.org/trunk@50596


git-svn-id: http://core.svn.wordpress.org/trunk@50209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 15:28:05 +00:00
desrosj
219cf1dd5f Build/Test Tools: Run code coverage workflow when the file is updated.
When the workflow file is updated, it should always be run to verify changes.

Follow up to [50592].

See #52786.
Built from https://develop.svn.wordpress.org/trunk@50595


git-svn-id: http://core.svn.wordpress.org/trunk@50208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 15:14:04 +00:00
desrosj
2a76425048 Build/Test Tools: Run code coverage workflow using parallel jobs.
This splits the code coverage workflow into two separate jobs, allowing single site and multisite to run in parallel. This cuts the total workflow run time in half.

Fixes #52923.
Built from https://develop.svn.wordpress.org/trunk@50594


git-svn-id: http://core.svn.wordpress.org/trunk@50207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 15:11:04 +00:00
desrosj
ae3ae14958 Build/Test Tools: Do not checkout the Importer plugin in the Code Coverage workflow.
Since [50285], the WordPress Importer plugin (which is required for the test suite to run successfully) has been installed as part of the `npm run env:install` script.

See #52625.
Built from https://develop.svn.wordpress.org/trunk@50593


git-svn-id: http://core.svn.wordpress.org/trunk@50206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 14:59:03 +00:00
desrosj
952acb240a Build/Test Tools: Fix code coverage reporting to generate report from src.
Since [50441-50442] switched the test workflows to run from `src` instead of `build`, code coverage reporting has stopped working. This was caused by the code coverage configuration continuing to reference `build`. This corrects the configuration so coverage reporting can resume.

This change also introduces the `workflow_dispatch` event to the workflow, which will allow committers to manually run the workflow when desired. For example, to confirm changes to the test suite do not break reporting.

This also adds the `phpunit.xml.dist` and `tests/phpunit/multisite.xml` files to the `paths` list. Since these files are responsible for configuring the test suite and code coverage reporting, any changes to them should verify that no problems were introduced.

Props jrf, johnbillion.
Fixes #52786. See #51734.
Built from https://develop.svn.wordpress.org/trunk@50592


git-svn-id: http://core.svn.wordpress.org/trunk@50205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 13:25:05 +00:00
desrosj
bbc301ca6e Build/Test Tools: Run test workflows on old branches on a schedule.
On TravisCI, old branches still receiving security updates were tested on a regular basis. This ensured tests continued to pass as time passed even if updates were not made to these branches.

On GitHub Actions, there is no interface to configure this (TravisCI had a UI), but there is a `schedule` event that can trigger workflow runs on cron that can be used to accomplish the same thing.

This introduces a workflow file that runs twice a month (on the 1st and 15th) to verify the tests within older branches.

Because the `schedule` event only runs within the primary branch, the appropriate workflows in each old branch will be triggered manually through the `workflow_dispatch` trigger using the GitHub REST API. `workflow_dispatch` will need to be added to all workflows in all old branches in order for the event to dispatch successfully.

Fixes #52653.
Built from https://develop.svn.wordpress.org/trunk@50590


git-svn-id: http://core.svn.wordpress.org/trunk@50203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 13:08:03 +00:00
Sergey Biryukov
2c6e1dc1f9 Login and Registration: Restore the "Error:" prefix for the "Unknown username" message.
This makes the message more consistent with other error messages related to authentication and registration.

Follow-up to [46417].

Props dd32.
See #52914, #52915.
Built from https://develop.svn.wordpress.org/trunk@50589


git-svn-id: http://core.svn.wordpress.org/trunk@50202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 12:14:07 +00:00
Peter Wilson
cc7bdc71e8 Media: Conditionally pass 2nd parameter to getimagesize().
In the wrapper function `wp_getimagesize()` check if the second parameter was passed before sending it to the PHP function `getimagesize()`. 

The PHP function has a different execution path depending on the number of parameters passed, this ensures the wrapper function follows the appropriate path.

Follow up to [50552].
Props azaozz, hellofromtonya, Mista-Flo, peterwilsoncc, rinatkhaziev, RogerTheriault, SergeyBiryukov, terriann, whyisjake.
Fixes #52826.

Built from https://develop.svn.wordpress.org/trunk@50586


git-svn-id: http://core.svn.wordpress.org/trunk@50199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 00:09:04 +00:00
davidbaumwald
9b8c498eea Privacy: Print screen reader text for the "Copy suggested policy text..." action button.
This change switches out `sprintf` for `printf` on the "Copy suggested policy text from..." button screen reader text.  Also, wrap the actual button text in a `<span aria-hidden="true">` to prevent both the button text and the screen reader text from being spoken.

Props mukesh27, SergeyBiryukov, sabernhardt.
Fixes #52891.
Built from https://develop.svn.wordpress.org/trunk@50585


git-svn-id: http://core.svn.wordpress.org/trunk@50198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 20:21:04 +00:00
davidbaumwald
bf267e05ca Docs: Fix description for $htmlhint argument in code editor settings.
Introduced in [41558].

Props sabernhardt.
See #52628.
Built from https://develop.svn.wordpress.org/trunk@50583


git-svn-id: http://core.svn.wordpress.org/trunk@50196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 20:00:05 +00:00
davidbaumwald
eaffb58ce8 Posts, Post Types: Remove / from non-self-closing "clear" div tags.
In [49178], self-closing `br` tags were switched to non-self-closing `div` elements for "clearing" purposes, but the self-closing "/" remained in place.  This fix removes the unnecessary slash.

Props pavelvisualcomposer, audrasjb, sabernhardt, akabarikalpesh, SergeyBiryukov.
Fixes #52878.
Built from https://develop.svn.wordpress.org/trunk@50582


git-svn-id: http://core.svn.wordpress.org/trunk@50195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 19:33:04 +00:00
desrosj
2e34561536 Build/Test Tools: Disable fail-fast for the NPM testing workflow.
This disables the `fail-fast` option in the GitHub Actions workflow for testing NPM. This allows all jobs in the test matrix to complete, even if one fails, painting a clear picture of where the issue lies.

Follow up to [50435].

See #52625.
Built from https://develop.svn.wordpress.org/trunk@50579


git-svn-id: http://core.svn.wordpress.org/trunk@50192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 15:10:06 +00:00
ryelle
14eddefa5e Login, Registration: Prevent button misalignment on login screen.
Replace the float CSS removed in [50569], which is used to align the login & register buttons.

Props mukesh27, audrasjb.
Fixes #52834.


Built from https://develop.svn.wordpress.org/trunk@50577


git-svn-id: http://core.svn.wordpress.org/trunk@50190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 14:23:03 +00:00
Sergey Biryukov
d6cc4f1aec Query: Consistently include a space in parentheses in WP_Meta_Query::get_sql_for_clause().
Props jillebehm, kaavyaiyer, hareesh-pillai.
Fixes #49279.
Built from https://develop.svn.wordpress.org/trunk@50576


git-svn-id: http://core.svn.wordpress.org/trunk@50189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 12:39:07 +00:00
Peter Wilson
a66cb4bb18 Script Loader: Escape HTML5 boolean attribute names.
Add escaping of boolean attribute names in `wp_sanitize_script_attributes()` for themes supporting HTML5 script elements.

Props tmatsuur, johnbillion, joyously.
Fixes #52894.

Built from https://develop.svn.wordpress.org/trunk@50575


git-svn-id: http://core.svn.wordpress.org/trunk@50188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 00:27:06 +00:00
Sergey Biryukov
fc6e4cbe3e Accessibility: Administration: Use a darker gray color for various admin UI items.
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.

Follow-up to [50025], [50525].

Props sabernhardt, ryelle.
Fixes #52760.
Built from https://develop.svn.wordpress.org/trunk@50571


git-svn-id: http://core.svn.wordpress.org/trunk@50184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-24 16:41:07 +00:00
gziolo
8f6ed34331 Editor: Add image default size to block editor settings
Related: https://github.com/WordPress/gutenberg/pull/29966

Add new imageDefaultSize value to block editor settings.

Props Mamaduka.
Fixes #52896.



Built from https://develop.svn.wordpress.org/trunk@50570


git-svn-id: http://core.svn.wordpress.org/trunk@50183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-24 07:33:08 +00:00
Peter Wilson
270f2011f8 Login, Registration: Prevent button misalignment on password reset screen.
Prevent misalignment of "generate password" and "save password" buttons on the password reset screen on narrow screens and in languages requiring longer text than English.

Props audrasjb, grapplerulrich, ryelle.
Fixes #52834.

Built from https://develop.svn.wordpress.org/trunk@50569


git-svn-id: http://core.svn.wordpress.org/trunk@50182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-24 00:22:02 +00:00
Peter Wilson
ea83435668 Privacy: Wrap text in buttons on privacy policy guide.
On narrow screens allow the text to wrap in the copy buttons on the privacy policy guide screen to avoid horizontal overflow of the parent container.

Props audrasjb, davidbaumwald, jaymanpandya, paaljoachim, palmiak, sabernhardt, SergeyBiryukov, sumitsingh.
Fixes #52751.

Built from https://develop.svn.wordpress.org/trunk@50568


git-svn-id: http://core.svn.wordpress.org/trunk@50181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-24 00:04:04 +00:00
Peter Wilson
c41990398c REST API: Prevent database error when deleting meta data.
Add a check to `WP_REST_Meta_Fields::delete_meta_value()` ensuring meta data is set before attempting to delete it from the database. If the data does not exist, the delete is considered successful as the data matches the desired state.

Props BrechtVds, goaroundagain, TimothyBlynJacobs.
Fixes #52787.

Built from https://develop.svn.wordpress.org/trunk@50567


git-svn-id: http://core.svn.wordpress.org/trunk@50180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-23 23:36:04 +00:00
Peter Wilson
fedd1d2b63 Robots: Remove contradictory directive check in wp_robots().
Removes the mutually exclusive directives check in `wp_robots()`, ie allow both `follow` and `nofollow` to be specified and for `archive` and `noarchive` to be specified.

This fixes a bug in which WordPress would defer to the most permissive over the least permissive. When contradictory instructions are included, WordPress will defer to the search engine's or archivist's resolution policy: generally this is to observe the least, not most permissive.

Props Cybr, flixos90.
Fixes #52713.


Built from https://develop.svn.wordpress.org/trunk@50566


git-svn-id: http://core.svn.wordpress.org/trunk@50179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-23 23:02:05 +00:00
Sergey Biryukov
d5a6a1ab44 Taxonomy: Use a consistent check for the $rewrite['hierarchical'] parameter.
This avoids a "Trying to access array offset on value of type bool" PHP warning in `get_term_link()` if the `$rewrite` parameter of `register_taxonomy()` is set as `false`.

Props Tkama, SergeyBiryukov.
Fixes #52882.
Built from https://develop.svn.wordpress.org/trunk@50565


git-svn-id: http://core.svn.wordpress.org/trunk@50178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-23 13:55:03 +00:00