This changeset fixes a margin issue in the search input box on the Add New Plugins screen, which was previously breaking below 1138px. Specifically, the top margin was set to 0px, and the overall appearance of the search box was inconsistent between 1000px and 1138px. Now, the margin is consistent across all breakpoints.
Props jomonthomaslobo1, narenin, iflairwebtechnologies, peterwilsoncc, audrasjb, shailu25.
Fixes#61785.
Built from https://develop.svn.wordpress.org/trunk@59706
git-svn-id: http://core.svn.wordpress.org/trunk@59048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset replaces the light grey background color with the white color defined in the Editor Storybook. This change also impacts admin color schemes that previously utilized the default admin background color.
This is an initial implementation of the WordPress design system, aligning with the broader goal of achieving a more consistent and unified design across the administration.
Props karmatosed, audrasjb.
Fixes#62831.
Built from https://develop.svn.wordpress.org/trunk@59705
git-svn-id: http://core.svn.wordpress.org/trunk@59047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Since [13683], `the_shortlink()` has included a `title` attribute. By default, that gives the sanitized post title, and it does not sanitize custom text. Given the low value of this attribute, this changeset removes it.
Props sabernhardt, audrasjb, joedolson.
Fixes#62838.
See #24766.
Built from https://develop.svn.wordpress.org/trunk@59703
git-svn-id: http://core.svn.wordpress.org/trunk@59045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This new argument, which defaults to the value of `public`, can be used to determine whether a post can be embedded using oEmbed. A new `is_post_embeddable()` function is added to easily check this.
Props pampfelimetten, swissspidy, bradleyt, DrewAPicture, gadelhas, mukesh27.
Fixes#35567.
Built from https://develop.svn.wordpress.org/trunk@59700
git-svn-id: http://core.svn.wordpress.org/trunk@59042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset introduces new classes to the body tag. The classes `wp-theme-<name>` and `wp-child-theme-<name>` (when the current theme is a child theme) are added, where `<name>` represents the sanitized name of the active theme.
Props cais, GaryJ, nacin, SergeyBiryukov, johnjamesjacoby, nirajgirixd, poena, audrasjb, rinkalpagdar.
Fixes#19736.
Built from https://develop.svn.wordpress.org/trunk@59698
git-svn-id: http://core.svn.wordpress.org/trunk@59040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Rename the 'Text' tab of the classic editor to 'Code', mimicking the labels used in the block editor: "Visual editor" and "Code editor".
Update code comment and Help documentation to reference the editor using the new label.
Props lukecavanagh, ctienshi, travel_girl, audrasjb, sabernhardt, joedolson, rseigel, mark-k, sergeybiryukov, presskopp, giuriani, afercia, knutsp, audrasjb, sukhendu2002.
Fixes#38061.
Built from https://develop.svn.wordpress.org/trunk@59696
git-svn-id: http://core.svn.wordpress.org/trunk@59038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Remove the option "Disable the visual editor when writing" from the user profile if it is currently false. If enabled, the option will stay available until disabled.
This was blocked due to issues with tab order and focusability in the classic editor environment until [59188].
Props mark-k, SergeyBiryukov, joedolson, pento, iseulde, chriscct7, afercia, prasadkarmalkar, rcreators, jamieblomerus.
Fixes#34681.
Built from https://develop.svn.wordpress.org/trunk@59695
git-svn-id: http://core.svn.wordpress.org/trunk@59037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Prior to r59679 this value was echoed to GitHub output which meant that its surrounding double quotes lost their significance. Now this value is used directly in the job output it needs to be treated as a plain string.
This concludes the conclusion confusion.
See #82221
Built from https://develop.svn.wordpress.org/trunk@59693
git-svn-id: http://core.svn.wordpress.org/trunk@59035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This aims to avoid confusion with `the_date()` and `get_the_date()`.
Includes synchronizing the description for `the_weekday()` and `the_weekday_date()`, which have very similar functionality, except that the latter will only output the weekday if the current post's weekday is different from the previous one output.
Follow-up to [59691].
See #51289.
Built from https://develop.svn.wordpress.org/trunk@59692
git-svn-id: http://core.svn.wordpress.org/trunk@59034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset clarifies the purpose of these functions and make the documentation more accurate and flexible. Instead of referring to the "date the post was written," the functions and filter descriptions now refer to the "date of the post." This change accommodates scenarios where the displayed date might not strictly correspond to the writing date (e.g. scheduled posts, backdated posts, or content where the "date" represents something other than creation).
Props casiepa, audrasjb, SergeyBiryukov, Rarst, helen, azouamauriac, pbearne.
Fixes#51289.
Built from https://develop.svn.wordpress.org/trunk@59691
git-svn-id: http://core.svn.wordpress.org/trunk@59033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset deletes the arrow that is typically added next to WordPress admin menu items that have submenus. The `.wp-menu-arrow` element is no longer visible since the WP 3.8 redesign, but the HTML and CSS remained. With this changeset, the HTML generating the arrow is removed, and the corresponding CSS styling is deleted.
Props helen, azaozz, jbkkd, pbearne, flixos90.
Fixes#26960.
Built from https://develop.svn.wordpress.org/trunk@59690
git-svn-id: http://core.svn.wordpress.org/trunk@59032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The `wp-singular` class includes a `wp` prefix to avoid conflicts with existing classes. This changeset also updates the `Tests_Post_GetBodyClass` PHPUnit test to include the new CSS class.
Props danielpataki, peterwilsoncc, swissspidy, johnbillion, eceleste, poena, audrasjb, raj198, shailu25.
Fixes#35164.
Built from https://develop.svn.wordpress.org/trunk@59689
git-svn-id: http://core.svn.wordpress.org/trunk@59031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates `@playwright/test` to the latest version, currently `1.49.1`.
In older branches using Playwright, the E2E and Performance workflows have recently started failing. This is due to changes in the GitHub Actions runner images. Updating Playwright ensures more modern dependency trees are used when installing browsers for testing and fixes the issue.
Props swissspidy.
See #62843.
Built from https://develop.svn.wordpress.org/trunk@59682
git-svn-id: http://core.svn.wordpress.org/trunk@59025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This includes removing use of dangerous inline GitHub Actions expressions, preventing word splitting, further tightening permissions, and generally improving many aspects of the workflows.
This also introduces a new workflow that runs Actionlint to detect incorrect and insecure code and configuration in workflow files.
Props johnbillion, swissspidy, flixos90, desrosj.
See #62221
Built from https://develop.svn.wordpress.org/trunk@59679
git-svn-id: http://core.svn.wordpress.org/trunk@59022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset ensures the `target="_blank"` attribute is preserved when adding links in the Biographical Info and Category Description fields. Previously, this attribute was being stripped by the KSES sanitization process.
Additionally, new unit tests have been added to verify the preservation of the `target="_blank"` attribute in these specific contexts.
Props lovewpmu, miqrogroove, bsutcliffe, sjefen6, nofearinc, nacin, harmr, blogitsolutions, stefahn, nirajgirixd, martinkrcho, spacedmonkey, sukhendu2002, audrasjb, gaellebesson, nuryko, guillaumeturpin, maximemeganck, ranafge, azaozz, joedolson, rinkalpagdar, mikinc860.
Fixes#12056.
Built from https://develop.svn.wordpress.org/trunk@59677
git-svn-id: http://core.svn.wordpress.org/trunk@59020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This is part of an effort to reduce `title` attribute usage in WordPress Admin. This changeset updates the Customizer Widgets sidebar list to show sidebar name and description (as these informations may benefit to everyone), and remove the `title` attribute.
Follow-up to [22439], [27548], [31513], [32991], [50804], [53414], [59675].
Props karlgroves, sabernhardt, mukesh27, joedolson.
Fixes#62836.
See #24766.
Built from https://develop.svn.wordpress.org/trunk@59676
git-svn-id: http://core.svn.wordpress.org/trunk@59019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset updates the old list tables for themes and theme installation to remove `title` attributes or replace them with a more acessible implementation:
- Removes `title` attributes from `span` elements
- Replaces `title` with `aria-label` for links whose visible text starts with the same word, consistently with links on the "Add Plugins" screen
- Reuses the `$preview_title` variable to keep ARIA labels consistent for both Preview links
Follow-up to [22439], [27548], [31513], [32991], [50804], [53414].
Props karlgroves, sabernhardt, audrasjb, alh0319.
Fixes#62834.
See #24766.
Built from https://develop.svn.wordpress.org/trunk@59675
git-svn-id: http://core.svn.wordpress.org/trunk@59018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The `start_el()` method in `Walker_Nav_Menu` was calling `get_privacy_policy_url()` for every menu item when building menus. This resulted in redundant queries, particularly for menus with many items. This obtains the `get_privacy_policy_url()` value in the constructor for reuse in the `start_el()` method to improve performance.
Redundant code to construct the privacy policy page is also refactored into the `set_up()` method during tests.
Props arzola, swissspidy, westonruter, mukesh27.
Fixes#62818.
Built from https://develop.svn.wordpress.org/trunk@59674
git-svn-id: http://core.svn.wordpress.org/trunk@59017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The benefit of this is that when PRs are made to make changes to a reusable workflow, the references doesn't need to be updated to point to the fork in order for the changed workflow to run.
A `npm run grunt replace:workflow-references-local-to-remote` command has also been introduced in order to convert these local references back to remote ones. This command can be used to switch release branches over to using remote workflows, as they are currently, so they continue to benefit from workflow changes in trunk without the need for continual backporting to all the branches.
Props desrosj, johnbillion
Fixes#62416
Built from https://develop.svn.wordpress.org/trunk@59673
git-svn-id: http://core.svn.wordpress.org/trunk@59016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This allows development tools to read the host path information from the `HOST_PATH` environment variable in order to, for example, map a path in a stack trace from the path in the container to the path on the host machine.
Fixes#62833
Built from https://develop.svn.wordpress.org/trunk@59668
git-svn-id: http://core.svn.wordpress.org/trunk@59011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changes some text to better match the guidelines and recommendations set forth in the make/core handbook, specifically:
> the word “we” should be avoided (...) unless its made very clear which group is speaking
Fixes#62295
Built from https://develop.svn.wordpress.org/trunk@59667
git-svn-id: http://core.svn.wordpress.org/trunk@59010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This resolves a few WPCS warnings:
{{{
Variable "$isPrimary" is not in valid snake_case format, try "$is_primary"
}}}
Additionally, this commit renames `$catids` to `$cat_ids` for consistency.
Follow-up to [1671].
See #62279.
Built from https://develop.svn.wordpress.org/trunk@59665
git-svn-id: http://core.svn.wordpress.org/trunk@59008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures that when block context is filtered via `render_block_context`, the filtered value is provided as available context to inner blocks.
For backwards compatibility reasons, filtered context is added to inner block context regardless of whether that block has declared support via the `uses_context` property.
Props mukesh27, flixos90, gziolo, dlh, joemcgill, santosguillamot.
Fixes#62046.
Built from https://develop.svn.wordpress.org/trunk@59662
git-svn-id: http://core.svn.wordpress.org/trunk@59005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
There are currently ~2,000 open pull requests on GitHub for `wordpress-develop`. Many of these were for testing changes that have already been merged.
To help prevent orphaned pull requests, this new workflow will search for any pull requests referencing the `Fixed` Trac tickets as noted in the commit message and close them out. For now, this only happens for `push` events.
Props peterwilsoncc, swissspidy, johnbillion, davidbaumwald.
Fixes#62817.
Built from https://develop.svn.wordpress.org/trunk@59661
git-svn-id: http://core.svn.wordpress.org/trunk@59004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When running a command that goes via docker.js and produces a non-zero exit code, the error message and stack trace from node an safely be hidden because the stack trace only points to the `execSync()` call and is of no use.
Fixes#62814
Built from https://develop.svn.wordpress.org/trunk@59659
git-svn-id: http://core.svn.wordpress.org/trunk@59002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Document that unserialised data types are stored as strings in the database and returned as such by the meta data functions. For example, setting meta data to the integer value `1` will be returned as `"1"` when subsequently queried via `get_metadata()` and the related functions.
Props sukhendu2002, azaozz, jrf, rodrigosprimo.
Fixes ticket:61950.
Built from https://develop.svn.wordpress.org/trunk@59657
git-svn-id: http://core.svn.wordpress.org/trunk@59000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates the admin color scheme `.sass` files to address some deprecated notices caused by upstream changes.
- `string` and `colors` are no longer globally available functions.
- `@import` is deprecated in favor of `@use`.
There are still a few notices that are output, however this will require an update to the `grunt-sass` package to resolve.
Props MattyRob.
Fixes#62323.
Built from https://develop.svn.wordpress.org/trunk@59656
git-svn-id: http://core.svn.wordpress.org/trunk@58999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Old branches requiring outdated versions of Chromium to run JavaScript tests have recently started failing as a result of the `ubuntu-latest` container being updated to point to `ubuntu-24`.
This introduces a new input to the reusable JavaScript testing workflow to allow a fix to be used without having to update Chromium or tests in these branches.
Props swissspidy.
See #62808.
Built from https://develop.svn.wordpress.org/trunk@59635
git-svn-id: http://core.svn.wordpress.org/trunk@58998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This aims to bring consistency with a similar fragment in other files, since relocating `wp-admin` or `wp-load.php` is not supported at this time.
Follow-up to [6659], [7971], [8315].
Props hussain896, swissspidy, knutsp, SergeyBiryukov.
Fixes#62809.
Built from https://develop.svn.wordpress.org/trunk@59634
git-svn-id: http://core.svn.wordpress.org/trunk@58997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Prior to this change a new session was unnecessarily created when a user changed their own password.
Existing authentication cookies for the user will still be invalidated regardless of whether they share the same session token because session cookie keys contain a substring of the password hash.
Props snicco, narenin, johnbillion
Fixes#61366
Built from https://develop.svn.wordpress.org/trunk@59633
git-svn-id: http://core.svn.wordpress.org/trunk@58996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
