Ryan McCue
1326d9e2c7
REST API: Correctly serve the index with PATH_INFO
...
When hitting the index, untrailingslashit() would make the REST route empty, which would then use the fallback inside WP_REST_Server. This isn't a problem most of the time, but WP_REST_Server contains a fallback to PATH_INFO. Combined with PATH_INFO permalinks, this would give a 404 on the API index, as it attempts to look up a route for "/wp-json/".
Props ccprog.
Fixes #39432 .
Built from https://develop.svn.wordpress.org/trunk@39923
git-svn-id: http://core.svn.wordpress.org/trunk@39860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 05:40:40 +00:00
Ryan McCue
dc133c3f2d
REST API: Allow shortcircuiting rest_pre_insert_comment
...
rest_pre_insert_{post_type} allows returning a WP_Error from the filter to shortcircuit actually creating the object, so it makes sense to do so for comments too.
Props dspilka.
Fixes #39578 .
Built from https://develop.svn.wordpress.org/trunk@39922
git-svn-id: http://core.svn.wordpress.org/trunk@39859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 05:18:41 +00:00
Gary Pendergast
096b09d941
dbDelta: Ignore index subparts when checking for duplicate indices.
...
If index lengths change in table definitions, we don't recreate the index - instead, we throw a database error, as `dbDelta()` tries to create a new index with the same name.
It's better to leave the index as is, MySQL doesn't have an efficient process for resizing indices, and dropping/creating is a slow process which we don't want to trigger automatically.
Fixes #34870 .
Built from https://develop.svn.wordpress.org/trunk@39921
git-svn-id: http://core.svn.wordpress.org/trunk@39858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 04:01:42 +00:00
Sergey Biryukov
3c1ce66767
Users: Introduce signup_site_meta
and signup_user_meta
for filtering signup metadata in wpmu_signup_blog()
and wpmu_signup_user()
, respectively.
...
Props Mista-Flo.
Fixes #39223 .
Built from https://develop.svn.wordpress.org/trunk@39920
git-svn-id: http://core.svn.wordpress.org/trunk@39857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 03:53:42 +00:00
Sergey Biryukov
4a1108b9f9
Build/Test Tools: Add assertNotFalse()
method to WP_UnitTestCase
and use it where appropriate.
...
Props peterwilsoncc.
Fixes #39219 .
Built from https://develop.svn.wordpress.org/trunk@39919
git-svn-id: http://core.svn.wordpress.org/trunk@39856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 03:40:43 +00:00
Sergey Biryukov
6b89d68cc1
Build/Test Tools: Correctly reference function names in @covers
entries.
...
Props pbearne.
Fixes #39235 .
Built from https://develop.svn.wordpress.org/trunk@39918
git-svn-id: http://core.svn.wordpress.org/trunk@39855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 02:44:43 +00:00
Sergey Biryukov
54001e2756
List Tables: Pass the $which
parameter to restrict_manage_posts
filter instance in WP_Media_List_Table
, missed in [37422].
...
Props wpsmith.
Fixes #38772 .
Built from https://develop.svn.wordpress.org/trunk@39917
git-svn-id: http://core.svn.wordpress.org/trunk@39854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 02:38:42 +00:00
Andrew Ozz
66a39611f6
TinyMCE: strip browser inserted <u>
and <font>` tags from inside links when copying and pasting in IE and Edge.
...
Fixes #39570 .
Built from https://develop.svn.wordpress.org/trunk@39916
git-svn-id: http://core.svn.wordpress.org/trunk@39853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 01:25:44 +00:00
Gary Pendergast
1071dfb4ec
User Query: Cast $user_total
as an int
.
...
The `$user_total` member of `WP_User_Query`, and corresponding `get_total()` method, have always been documented as returning an `int`. `$user_total`, however, is populated by `$wpdb->get_var()`, which returns
a string (containing an integer value). Casting the return value from `get_var()` as an `int` rectifies this discrepency.
Props runciters.
Fixes #39297 .
Built from https://develop.svn.wordpress.org/trunk@39915
git-svn-id: http://core.svn.wordpress.org/trunk@39852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-16 23:24:45 +00:00
Andrew Ozz
458746f631
Tests: wpautop()
should not add extra </p>
before <figcaption>
.
...
Props pbearne.
See #39307 .
Built from https://develop.svn.wordpress.org/trunk@39914
git-svn-id: http://core.svn.wordpress.org/trunk@39851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-16 17:57:43 +00:00
James Nylen
fa20ce762a
REST API: Improve test coverage of single user endpoint for public data.
...
Add test coverage for requests of a single user resource for authors of post types registered as:
- public = true, show_in_rest = true: success without auth.
- public = true, show_in_rest = false: fail without auth.
- public = false, show_in_rest = true: success without auth.
- public = false, show_in_rest = false: fail without auth.
See #38878 .
Fixes #39546 .
Built from https://develop.svn.wordpress.org/trunk@39913
git-svn-id: http://core.svn.wordpress.org/trunk@39850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-16 16:21:43 +00:00
Andrew Ozz
85ee190163
Formatting: fix wpautop()
to stop adding paragraph tags around <figcaption>
.
...
Fixes #39307 for trunk.
Built from https://develop.svn.wordpress.org/trunk@39912
git-svn-id: http://core.svn.wordpress.org/trunk@39849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-16 01:06:40 +00:00
Andrew Ozz
ee3052fdbe
Docs: some improvements/fixes for editor.js.
...
See #38933 .
Built from https://develop.svn.wordpress.org/trunk@39911
git-svn-id: http://core.svn.wordpress.org/trunk@39848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-16 00:49:41 +00:00
Andrew Ozz
82a8065f70
TinyMCE: ensure the inline toolbar is shown and properly positioned when there are several wpview blocks in the editor and the user selects one after the other.
...
Props gitlost.
Fixes #38849 .
Built from https://develop.svn.wordpress.org/trunk@39910
git-svn-id: http://core.svn.wordpress.org/trunk@39847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-16 00:22:43 +00:00
Sergey Biryukov
1ba4484186
Twenty Seventeen: Remove duplicate global $post
declaration in twentyseventeen_front_page_section()
.
...
Props ixkaito.
Fixes #39590 .
Built from https://develop.svn.wordpress.org/trunk@39909
git-svn-id: http://core.svn.wordpress.org/trunk@39846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 12:50:39 +00:00
Sergey Biryukov
4d546a12cf
I18N: Reference correct placeholder in a translator comment added in [30333].
...
See #30264 .
Built from https://develop.svn.wordpress.org/trunk@39908
git-svn-id: http://core.svn.wordpress.org/trunk@39845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 08:07:43 +00:00
Sergey Biryukov
9ba7ab1cfc
Users: Display the name of user being edited on Edit User screen.
...
Props seanchayes.
Fixes #28182 .
Built from https://develop.svn.wordpress.org/trunk@39907
git-svn-id: http://core.svn.wordpress.org/trunk@39844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 07:14:39 +00:00
Sergey Biryukov
649d554294
Themes: Add a unit test for get_theme_feature_list()
to make sure that the list of theme features pulled from the WordPress.org API returns the expected data structure.
...
Props iandunn.
Fixes #28121 .
Built from https://develop.svn.wordpress.org/trunk@39906
git-svn-id: http://core.svn.wordpress.org/trunk@39843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 06:50:43 +00:00
Sergey Biryukov
6e3073c1eb
Posts, Post Types: Increase the height of post slug input to prevent certain characters from being cut in Firefox on Windows.
...
Props Ankit K Gupta, Presskopp.
Fixes #28084 .
Built from https://develop.svn.wordpress.org/trunk@39905
git-svn-id: http://core.svn.wordpress.org/trunk@39842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 04:03:43 +00:00
Andrew Ozz
35c91b7c0d
TinyMCE: prevent the inline toolbar from appearing on partially selected wpview nodes. This can happen when HTML is initially loaded in the editor and wpview is the first node, or sometimes on repeatedly pasting the same wpview.
...
Props gitlost.
Fixes #38849 .
Built from https://develop.svn.wordpress.org/trunk@39904
git-svn-id: http://core.svn.wordpress.org/trunk@39841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 03:00:43 +00:00
Andrew Ozz
45f3ee380c
TinyMCE: when inserting a wpview, place the caret after is so the user can continue typing without interruption.
...
Props iseulde.
Fixes #39337 .
Built from https://develop.svn.wordpress.org/trunk@39903
git-svn-id: http://core.svn.wordpress.org/trunk@39840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 02:41:40 +00:00
Andrew Ozz
90f441e1b4
TinyMCE: improve removal of spaces from empty paragraphs when loading HTML in the editor.
...
Fixes #39437 .
Built from https://develop.svn.wordpress.org/trunk@39902
git-svn-id: http://core.svn.wordpress.org/trunk@39839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 02:06:41 +00:00
Sergey Biryukov
82e17902a9
Twenty Seventeen: Correct @param
entries for twentyseventeen_custom_colors_css
filter.
...
Props Soean.
Fixes #39575 .
Built from https://develop.svn.wordpress.org/trunk@39901
git-svn-id: http://core.svn.wordpress.org/trunk@39838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-13 15:03:41 +00:00
Sergey Biryukov
b75023ee1a
Docs: Add missing @param
type for wp_cache_get_last_changed()
.
...
Props afzalmultani, Soean.
Fixes #39571 .
Built from https://develop.svn.wordpress.org/trunk@39900
git-svn-id: http://core.svn.wordpress.org/trunk@39837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-13 14:16:44 +00:00
Sergey Biryukov
d2a6ea340e
REST API: Update unit tests to account for the string changes in [39896].
...
See #39054 .
Built from https://develop.svn.wordpress.org/trunk@39899
git-svn-id: http://core.svn.wordpress.org/trunk@39836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-13 05:15:42 +00:00
Sergey Biryukov
5d83b14893
Build/Test Tools: After [29858], update .jsintrc
to use spaces, not tabs.
...
Props netweb.
Fixes #39359 .
Built from https://develop.svn.wordpress.org/trunk@39898
git-svn-id: http://core.svn.wordpress.org/trunk@39835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-13 04:45:41 +00:00
Sergey Biryukov
2a7400c956
Administration: Improve tab character width in Plugins and Themes editor.
...
Props afercia.
Fixes #38684 .
Built from https://develop.svn.wordpress.org/trunk@39897
git-svn-id: http://core.svn.wordpress.org/trunk@39834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-13 04:41:41 +00:00
Sergey Biryukov
b3c28838f7
REST API: Improve error messages for number relational validation.
...
Props jblz.
Fixes #39054 .
Built from https://develop.svn.wordpress.org/trunk@39896
git-svn-id: http://core.svn.wordpress.org/trunk@39833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-13 04:38:40 +00:00
Sergey Biryukov
8603da629f
Taxonomy: Add an explanation for "Parent" dropdown for hierarchical custom taxonomies.
...
Props F J Kaiser, raggedrobins, DrewAPicture, diddledan, SergeyBiryukov.
Fixes #23447 .
Built from https://develop.svn.wordpress.org/trunk@39895
git-svn-id: http://core.svn.wordpress.org/trunk@39832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-13 04:19:39 +00:00
Sergey Biryukov
139a58b70a
Twenty Seventeen: Remove extra asterisk from a translator comment so the comment could be parsed correctly.
...
Props swissspidy.
See #39116 .
Built from https://develop.svn.wordpress.org/trunk@39894
git-svn-id: http://core.svn.wordpress.org/trunk@39831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-12 21:37:43 +00:00
Sergey Biryukov
36cb41145e
Docs: In wp_set_object_terms()
, add a note that passing an empty value as $terms
argument will remove all related terms.
...
Props barryceelen.
Fixes #36690 .
Built from https://develop.svn.wordpress.org/trunk@39893
git-svn-id: http://core.svn.wordpress.org/trunk@39830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-12 06:54:42 +00:00
Sergey Biryukov
a1319d63a0
Widgets: In unregister_sidebar()
, rename the $name
parameter to $sidebar_id
for consistency with is_registered_sidebar()
.
...
Also correct the parameter type in `@param` entry.
Props Soean, tmatsuur.
Fixes #35147 .
Built from https://develop.svn.wordpress.org/trunk@39892
git-svn-id: http://core.svn.wordpress.org/trunk@39829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-12 06:38:54 +00:00
Sergey Biryukov
11d81ecc7c
Media: Use a consistent error message for file type errors on uploading.
...
Props pavelevap, jackreichert.
Fixes #33242 .
Built from https://develop.svn.wordpress.org/trunk@39891
git-svn-id: http://core.svn.wordpress.org/trunk@39828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-12 06:29:43 +00:00
Sergey Biryukov
327a11ad65
Docs: Use a consistent description for $plugin
parameter in various plugin API functions.
...
See #36333 .
Built from https://develop.svn.wordpress.org/trunk@39890
git-svn-id: http://core.svn.wordpress.org/trunk@39827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-12 06:16:41 +00:00
Sergey Biryukov
a989f0b168
Docs: Improve the DocBlock for validate_plugin()
.
...
Props theMikeD.
Fixes #36333 .
Built from https://develop.svn.wordpress.org/trunk@39889
git-svn-id: http://core.svn.wordpress.org/trunk@39826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-12 06:15:42 +00:00
Sergey Biryukov
8b9a3a08bf
Docs: After [37083], change "HEX format" to "3- or 6-digit hexadecimal form" for clarity.
...
Props swissspidy, theMikeD.
Fixes #36336 .
Built from https://develop.svn.wordpress.org/trunk@39888
git-svn-id: http://core.svn.wordpress.org/trunk@39825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-12 05:56:40 +00:00
Sergey Biryukov
351a3b6d69
Docs: Make $meta
parameter description in multisite signup and registration functions more consistent.
...
See #38781 .
Built from https://develop.svn.wordpress.org/trunk@39887
git-svn-id: http://core.svn.wordpress.org/trunk@39824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-12 05:21:41 +00:00
Sergey Biryukov
3f59be8c97
Users: In wpmu_signup_blog()
and wpmu_signup_user()
, pass unserialized signup meta data to after_signup_site
and after_signup_user
filters introduced in [34112], to match the documented value.
...
Props MaximeCulea.
Fixes #38781 .
Built from https://develop.svn.wordpress.org/trunk@39886
git-svn-id: http://core.svn.wordpress.org/trunk@39823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-12 04:57:39 +00:00
Sergey Biryukov
a4f106ff9d
I18N: Move "Site Language" setting above "Timezone".
...
This brings all locale-specific site settings closer together and prevents the language setting from being pushed down by unrelated settings added by plugins.
Props johnjamesjacoby.
Fixes #38562 .
Built from https://develop.svn.wordpress.org/trunk@39885
git-svn-id: http://core.svn.wordpress.org/trunk@39822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-12 04:28:40 +00:00
Sergey Biryukov
32564f9332
Themes: Use curly braces for variables inside strings in `get_page_template() to explicitly specify the end of the variable name.
...
Props kuck1u.
Fixes #38625 .
Built from https://develop.svn.wordpress.org/trunk@39884
git-svn-id: http://core.svn.wordpress.org/trunk@39821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-12 04:13:42 +00:00
Joe McGill
52897df8cd
Media: Fix exif_imagetype check in wp_get_image_mime
...
This is a follow up to [39831].
Props gitlost.
See #11946 .
Built from https://develop.svn.wordpress.org/trunk@39850
git-svn-id: http://core.svn.wordpress.org/trunk@39787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 16:36:39 +00:00
Joe McGill
0df85f5bab
Tests: Replace broken codeispoetry.png file.
...
This also updates the test filename in
`WP_Test_REST_Attachments_Controller::test_create_item_default_filename_title()`
to accurately match the actual file name.
Built from https://develop.svn.wordpress.org/trunk@39848
git-svn-id: http://core.svn.wordpress.org/trunk@39786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 16:25:41 +00:00
Aaron Campbell
daf358983c
REST API: Change which users are shown in the users endpoint.
...
Only show users that have authored a post of a post type that has `show_in_rest` set to true.
Props rachelbaker, jnylen0.
See #38878 .
Built from https://develop.svn.wordpress.org/trunk@39843
git-svn-id: http://core.svn.wordpress.org/trunk@39781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 14:14:42 +00:00
Joe McGill
8eff927823
Media: Improve image filetype checking.
...
This adds a new function `wp_get_image_mime()` which is used by
`wp_check_filetype_and_ext()` to validate image files using
`exif_imagetype()` if available instead of `getimagesize()`.
`getimagesize()` is less performant than `exif_imagetype()` and is
dependent on GD. If `exif_imagetype()` is not available, it falls back to
`getimagesize()` as before.
If `wp_check_filetype_and_ext()` can't validate the filetype, we now return
`false` for ext/MIME values.
See #11946 .
Built from https://develop.svn.wordpress.org/trunk@39831
git-svn-id: http://core.svn.wordpress.org/trunk@39769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 13:08:44 +00:00
Dominik Schilling
c9ea1de144
Updates: Translate plugin data on the Updates screen.
...
Built from https://develop.svn.wordpress.org/trunk@39808
git-svn-id: http://core.svn.wordpress.org/trunk@39746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 10:37:48 +00:00
Dominik Schilling
ce7fb2934d
Themes: Fix markup for theme name fallbacks.
...
Built from https://develop.svn.wordpress.org/trunk@39807
git-svn-id: http://core.svn.wordpress.org/trunk@39745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 10:34:44 +00:00
Jeremy Felt
cea9e2dc62
Multisite: Use wp_rand()
in signup key creation.
...
Built from https://develop.svn.wordpress.org/trunk@39795
git-svn-id: http://core.svn.wordpress.org/trunk@39733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 05:30:42 +00:00
Jeremy Felt
061e878881
Mail: Disable wp-mail.php when mailserver_url
is mail.example.com.
...
Built from https://develop.svn.wordpress.org/trunk@39772
git-svn-id: http://core.svn.wordpress.org/trunk@39710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 05:13:43 +00:00
Aaron Campbell
03e5c0314a
Add nonce for widget accessibility mode.
...
Props vortfu.
See #23328 .
Built from https://develop.svn.wordpress.org/trunk@39760
git-svn-id: http://core.svn.wordpress.org/trunk@39698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 01:32:41 +00:00
Dion Hulse
5eb452d15b
Update PHPMailer to 5.2.22.
...
The full list of changes is available here:
https://github.com/PHPMailer/PHPMailer/compare/v5.2.21...v5.2.22
Fixes #37210 for trunk.
Built from https://develop.svn.wordpress.org/trunk@39759
git-svn-id: http://core.svn.wordpress.org/trunk@39697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 01:23:41 +00:00