Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-09-17 18:11:11 +02:00
Code Issues Projects Releases Wiki Activity
27,012 Commits 49 Branches 747 Tags 718 MiB
1335ff3e40
Commit Graph

13102 Commits

Author SHA1 Message Date
Scott Taylor
856e5ef55e Remove noscript from wpautop()'s list of block elements. 
Props mdawaffe.
Fixes #27268.

Built from https://develop.svn.wordpress.org/trunk@28817


git-svn-id: http://core.svn.wordpress.org/trunk@28624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 00:54:17 +00:00
Scott Taylor
317e5c9616 Adjust CSS for "Moved to the trash" message for a pingback in the dashboard. 
Props zoerooney, codenameEli.
Fixes #28286.

Built from https://develop.svn.wordpress.org/trunk@28811


git-svn-id: http://core.svn.wordpress.org/trunk@28619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 00:03:16 +00:00
Scott Taylor
396e77b643 Use unobtrusive JS for Comment list table row actions. 
Props aubreypwd.
Fixes #27533.

Built from https://develop.svn.wordpress.org/trunk@28810


git-svn-id: http://core.svn.wordpress.org/trunk@28618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 23:55:16 +00:00
Sergey Biryukov
8b272f4379 Remove mbstring_binary_safe_strlen(). Use mbstring_binary_safe_encoding() and reset_mbstring_encoding() directly. 
fixes #28162.
Built from https://develop.svn.wordpress.org/trunk@28808


git-svn-id: http://core.svn.wordpress.org/trunk@28617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 22:21:15 +00:00
Sergey Biryukov
9ceb642b2a Introduce a binary-safe wrapper for strlen() and use it in seems_utf8(), utf8_uri_encode(), and wp_read_image_metadata(). 
Use binary-safe POMO_Reader::strlen() in MO::export_to_file_handle().

fixes #28162.
Built from https://develop.svn.wordpress.org/trunk@28806


git-svn-id: http://core.svn.wordpress.org/trunk@28615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 14:48:14 +00:00
Scott Taylor
5357fecf1a Remove unused globals from link-parse-opml.php after [28743]. 
Props SergeyBiryukov.
Fixes #27881.

Built from https://develop.svn.wordpress.org/trunk@28786


git-svn-id: http://core.svn.wordpress.org/trunk@28599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-20 17:26:14 +00:00
Andrew Nacin
a90a53d574 Narrower screen when choosing a language. see #28577. 
Built from https://develop.svn.wordpress.org/trunk@28780


git-svn-id: http://core.svn.wordpress.org/trunk@28593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-19 04:47:14 +00:00
Andrew Nacin
23de72f9e0 Fix variable usage in new language install choices. see #28577. 
Built from https://develop.svn.wordpress.org/trunk@28779


git-svn-id: http://core.svn.wordpress.org/trunk@28592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-19 04:37:15 +00:00
Helen Hou-Sandí
95deee2de5 Restore the ability to pass classes to admin menu submenu items, important for the Customize link. Accidentally left out in [24048]. fixes #28583. 
Built from https://develop.svn.wordpress.org/trunk@28778


git-svn-id: http://core.svn.wordpress.org/trunk@28591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-19 02:18:15 +00:00
Sergey Biryukov
1dd9c189e9 Fix copy/paste error in a comment. 
see #28581.
Built from https://develop.svn.wordpress.org/trunk@28777


git-svn-id: http://core.svn.wordpress.org/trunk@28590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-19 01:36:14 +00:00
Andrew Nacin
c504fb41a1 Allow a language to be chosen before installing WordPress. First pass. 
* Checks WordPress.org for available languages.
* In get_locale(), starts using the WPLANG option that has existed in multisite since the MU days.
* Adds new argument to wp_install() for setting WPLANG.

see #28577. 

Built from https://develop.svn.wordpress.org/trunk@28774


git-svn-id: http://core.svn.wordpress.org/trunk@28587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-18 19:58:15 +00:00
Sergey Biryukov
5bd180bcbd Revert [28766]. 
see #28555.
Built from https://develop.svn.wordpress.org/trunk@28772


git-svn-id: http://core.svn.wordpress.org/trunk@28585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-18 02:23:13 +00:00
Sergey Biryukov
d2a43e7cb2 Don't add # to URL when clicking 'OK' without changing the permalink. 
props avryl.
fixes #27594.
Built from https://develop.svn.wordpress.org/trunk@28771


git-svn-id: http://core.svn.wordpress.org/trunk@28584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-18 00:29:15 +00:00
Sergey Biryukov
cd7618399e Prevent bulk actions from being performed when Filter button is clicked. 
props layotte.
fixes #28555.
Built from https://develop.svn.wordpress.org/trunk@28766


git-svn-id: http://core.svn.wordpress.org/trunk@28579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 22:17:14 +00:00
Sergey Biryukov
c171f2ef77 Fix labels on installation screen. 
props avryl.
fixes #28548.
Built from https://develop.svn.wordpress.org/trunk@28759


git-svn-id: http://core.svn.wordpress.org/trunk@28572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 14:37:16 +00:00
Andrew Ozz
84f3e30f7b wpView: improve handling of embed errors/error messages, see #28195 
Built from https://develop.svn.wordpress.org/trunk@28754


git-svn-id: http://core.svn.wordpress.org/trunk@28568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-15 22:53:16 +00:00
Andrew Nacin
aeac3e1654 Add a new 'Beta Testing' tab on the plugin installer, for features as plugins such as Press This. 
fixes #28513.

Built from https://develop.svn.wordpress.org/trunk@28749


git-svn-id: http://core.svn.wordpress.org/trunk@28563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-12 18:09:13 +00:00
Scott Taylor
27523183bf Don't use variable variables in touch_time(). 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28747


git-svn-id: http://core.svn.wordpress.org/trunk@28561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 21:05:16 +00:00
Scott Taylor
69fbe27f48 Don't use variable variables in wp_reset_vars(). Test by searching in list tables, etc. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28746


git-svn-id: http://core.svn.wordpress.org/trunk@28560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 20:00:15 +00:00
Scott Taylor
9a286d75fd Don't use variable variables in user-new.php. Test by causing errors when creating a new user. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28745


git-svn-id: http://core.svn.wordpress.org/trunk@28559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 19:54:13 +00:00
Scott Taylor
fd838ccb2b Don't use variable variables in setup-config.php (Step 2). 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28744


git-svn-id: http://core.svn.wordpress.org/trunk@28558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 19:41:14 +00:00
Scott Taylor
f014067f06 OPML: 
* Learn how OPML works, cry.
* Remove unused globals in `startElement()`
* Stop using variable variables in `startElement()`

Tested with the OPML importer plugin

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28743


git-svn-id: http://core.svn.wordpress.org/trunk@28557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 19:31:15 +00:00
Scott Taylor
812ea43343 Don't use variable variables in wp_dashboard_plugins_output(). Variable variables aren't the worst thing about this function. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28742


git-svn-id: http://core.svn.wordpress.org/trunk@28556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 18:55:14 +00:00
John Blackbourn
eb62aecbc3 Only include relevant post authors in WXR exports. Fixes #20206. Props jeremyfelt. 
Built from https://develop.svn.wordpress.org/trunk@28731


git-svn-id: http://core.svn.wordpress.org/trunk@28545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 19:15:13 +00:00
John Blackbourn
03131233e2 Add screen reader labels to the date inputs on the post editing screen. Fixes #25461. Props frank-klein. 
Built from https://develop.svn.wordpress.org/trunk@28730


git-svn-id: http://core.svn.wordpress.org/trunk@28544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 18:50:14 +00:00
Scott Taylor
0da44fad8e edit.php?post_type=attachment should redirect to upload.php. Without the redirect, the user is presented with an empty list table. There are probably other issues to address overall, but this accomplishes what the ticket wants. 
Props knutsp.
Fixes #27951.

Built from https://develop.svn.wordpress.org/trunk@28729


git-svn-id: http://core.svn.wordpress.org/trunk@28543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 18:48:15 +00:00
Scott Taylor
05eeb16e30 Replace all uses of like_escape() with $wpdb->esc_like(). 
Props miqrogroove.
See #10041.

Built from https://develop.svn.wordpress.org/trunk@28712


git-svn-id: http://core.svn.wordpress.org/trunk@28528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 00:44:15 +00:00
Scott Taylor
b964ac0148 Live update the menu item title when the user is editing the "Navigation Label" field. 
Props celloexpressions.
See #23076.

Built from https://develop.svn.wordpress.org/trunk@28707


git-svn-id: http://core.svn.wordpress.org/trunk@28523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-09 18:39:15 +00:00
Helen Hou-Sandí
d558331e18 Properly indicate with the cursor that the editor can be vertically resized using the entire info bar, not just the handle displayed in the corner. 
props torresga. fixes #28420.

Built from https://develop.svn.wordpress.org/trunk@28703


git-svn-id: http://core.svn.wordpress.org/trunk@28520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-08 19:47:14 +00:00
Helen Hou-Sandí
b5ef672c6b Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further. 
props ericlewis, shaunandrews, wonderboymusic.
see #24716.

Built from https://develop.svn.wordpress.org/trunk@28682


git-svn-id: http://core.svn.wordpress.org/trunk@28500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 22:01:18 +00:00
Sergey Biryukov
4b14fe0593 Remove one-time variable from add_settings_error(). 
props niallkennedy.
fixes #22228.
Built from https://develop.svn.wordpress.org/trunk@28681


git-svn-id: http://core.svn.wordpress.org/trunk@28499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 18:29:14 +00:00
Sergey Biryukov
26d0ad5e12 Remove redundant 'Visit author homepage' title attributes for plugins and themes. 
props joedolson.
fixes #26554.
Built from https://develop.svn.wordpress.org/trunk@28673


git-svn-id: http://core.svn.wordpress.org/trunk@28491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 04:52:16 +00:00
Drew Jaynes
a6e536fba6 Make sure to use 3-digit x.x.x style for two 3.9.0 @since versions. 
Props netweb.
Fixes #28446.

Built from https://develop.svn.wordpress.org/trunk@28658


git-svn-id: http://core.svn.wordpress.org/trunk@28476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-04 05:35:16 +00:00
Drew Jaynes
b0877f02a4 Make sure $post is properly documented as optional where applicable. 
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28653


git-svn-id: http://core.svn.wordpress.org/trunk@28471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-03 03:53:17 +00:00
Sergey Biryukov
dc6b95589a Plugin activation/deletion errors should be styled as such. 
props johnbillion.
fixes #28260.
Built from https://develop.svn.wordpress.org/trunk@28646


git-svn-id: http://core.svn.wordpress.org/trunk@28464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-31 20:10:15 +00:00
Sergey Biryukov
ee9d9133ac Avoid stomping of the $plugin variable in activate_plugin(). 
fixes #28102.
Built from https://develop.svn.wordpress.org/trunk@28644


git-svn-id: http://core.svn.wordpress.org/trunk@28462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 22:08:14 +00:00
Sergey Biryukov
66bfea485a Display the site scheme, not the current scheme on Edit Site screen in network admin. 
props johnbillion.
fixes #28406.
Built from https://develop.svn.wordpress.org/trunk@28643


git-svn-id: http://core.svn.wordpress.org/trunk@28461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 22:01:15 +00:00
Sergey Biryukov
df597224e5 Add paragraph tags to 'Add Existing User' section on 'Add New User' screen in multisite. 
props jkudish, topher1kenobe.
fixes #20271.
Built from https://develop.svn.wordpress.org/trunk@28642


git-svn-id: http://core.svn.wordpress.org/trunk@28460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 21:51:14 +00:00
Scott Taylor
ecdcfb55bb Make the image editor less jumpy when opening. 
Props eddiemoya, ericlewis.
Fixes #22793.


Built from https://develop.svn.wordpress.org/trunk@28639


git-svn-id: http://core.svn.wordpress.org/trunk@28457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 19:53:15 +00:00
Scott Taylor
9187e3bd55 Restore $val in WP_Importer::bump_request_timeout() - even though the parent class and WP_Import ignore the parameter, it creates an incompatible interface notice in the plugin. 
See [28629].


Built from https://develop.svn.wordpress.org/trunk@28637


git-svn-id: http://core.svn.wordpress.org/trunk@28455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 19:35:16 +00:00
Scott Taylor
af860fbe84 Cleanup for switch statements: 
* Move `default` to the bottom in `WP_Theme_Install_List_Table`
* `switch/endswitch` syntax is not supported in Hack. Switch to `switch (...) {  .... }` syntax. (A few template-type instances linger).

Fixes #28409.
See #27881.


Built from https://develop.svn.wordpress.org/trunk@28633


git-svn-id: http://core.svn.wordpress.org/trunk@28452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 17:58:15 +00:00
Drew Jaynes
1868c1fc4b Remove unnecessary "not used" notation for filter parameters in wp-admin/includes/media.php. 
Also add `@param` and `@return` descriptions.

See #28408.

Built from https://develop.svn.wordpress.org/trunk@28632


git-svn-id: http://core.svn.wordpress.org/trunk@28451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 17:38:14 +00:00
Scott Taylor
c403768fa2 Remove some dead variable assignments. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28629


git-svn-id: http://core.svn.wordpress.org/trunk@28449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 16:59:14 +00:00
Andrew Ozz
15a1f80885 TinyMCE in iOS: 
- Fix placing the caret at the bottom of longer posts when the keyboard is open.
- Disable resizing on switching editors and on show/hide the kitchen sink row.
See #28242
Built from https://develop.svn.wordpress.org/trunk@28626


git-svn-id: http://core.svn.wordpress.org/trunk@28446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 02:38:16 +00:00
Helen Hou-Sandí
3f1deae10b Don't use the box shadow focus styling for the admin menu or toolbar. see #28267. 
Built from https://develop.svn.wordpress.org/trunk@28616


git-svn-id: http://core.svn.wordpress.org/trunk@28440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 14:23:15 +00:00
Helen Hou-Sandí
ec121f9899 Better align link element focus with form focus styling, which also improves the visibility. props zamfeer. see #28267. 
Built from https://develop.svn.wordpress.org/trunk@28608


git-svn-id: http://core.svn.wordpress.org/trunk@28432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 03:58:14 +00:00
Sergey Biryukov
78a9cb855e Fix displaying taxonomies in bulk edit if the post type does not support titles. 
props scribu.
fixes #16793.
Built from https://develop.svn.wordpress.org/trunk@28600


git-svn-id: http://core.svn.wordpress.org/trunk@28425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-28 13:50:14 +00:00
Sergey Biryukov
d3e6a5ded0 Remove obsolete code from wp_dashboard_setup(). 
props kitchin.
fixes #26604.
Built from https://develop.svn.wordpress.org/trunk@28592


git-svn-id: http://core.svn.wordpress.org/trunk@28417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 15:41:15 +00:00
Sergey Biryukov
e94ee8f08c Move 'Documentation on date and time formatting' link under the 'Time Format' block. 
props gauravmittal1995.
fixes #28348.
Built from https://develop.svn.wordpress.org/trunk@28591


git-svn-id: http://core.svn.wordpress.org/trunk@28416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 14:50:14 +00:00
Sergey Biryukov
84422e6d7d Add BMP to the list of displayable image types. 
props ericlewis.
fixes #26808.
Built from https://develop.svn.wordpress.org/trunk@28589


git-svn-id: http://core.svn.wordpress.org/trunk@28414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 13:25:14 +00:00
Sergey Biryukov
db9057f308 Remove redundant get_shortcode_regex() check. 
props kovshenin.
see #28195.
Built from https://develop.svn.wordpress.org/trunk@28587


git-svn-id: http://core.svn.wordpress.org/trunk@28412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 11:30:16 +00:00
Scott Taylor
3c1723afd7 When adding a URL in the Insert from URL state in the media modal, attempt to show a preview of the content. Drop the unused width and height fields. 
This will probably be iterated upon.

Props helen, jtsternberg, wonderboymusic.
See #15490.

Built from https://develop.svn.wordpress.org/trunk@28581


git-svn-id: http://core.svn.wordpress.org/trunk@28406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 23:57:14 +00:00
Scott Taylor
89864b4a5a Don't pass embeds through the_content() when trying to render MCE previews, leverage WP_Embed and do_shortcode() instead. 
Props kovshenin.
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28580


git-svn-id: http://core.svn.wordpress.org/trunk@28405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 23:43:15 +00:00
Scott Taylor
8b7b72d75e In media_sideload_image(), check the returned value of download_url() earlier to avoid attempting to unlink() an instance of WP_Error. 
Props georgestephanis. 
Fixes #28204.

Built from https://develop.svn.wordpress.org/trunk@28567


git-svn-id: http://core.svn.wordpress.org/trunk@28392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 21:33:14 +00:00
Scott Taylor
5b5b756edf In get_terms_to_edit(), call get_object_term_cache() before priming cache with wp_get_object_terms(). 
In `get_inline_data()`, do the same.

On list table screens with taxonomies in the admin, this dramatically reduces the number of database queries (3x less). Even more so with a persistent object cache (5x less).

Props johnbillion, jeffstieler, wonderboymusic.
Fixes #18968.


Built from https://develop.svn.wordpress.org/trunk@28561


git-svn-id: http://core.svn.wordpress.org/trunk@28387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 19:29:14 +00:00
Scott Taylor
8d4d645629 Fix parsing in wp_match_mime_types() to allow some mime-types with + in them to appear in the list of filter links shown above the list table on upload.php. 
Props _duck.
Fixes #20672.


Built from https://develop.svn.wordpress.org/trunk@28553


git-svn-id: http://core.svn.wordpress.org/trunk@28379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 21:36:15 +00:00
Scott Taylor
d22b5226a8 In wp_dashboard_recent_posts(), $i is set and never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28545


git-svn-id: http://core.svn.wordpress.org/trunk@28371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 18:56:15 +00:00
Scott Taylor
0e03abda62 $theme_name is set but no longer used in wp_dashboard_right_now(). The theme name is displayed with the call to update_right_now_message(). 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28544


git-svn-id: http://core.svn.wordpress.org/trunk@28370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 18:54:13 +00:00
Scott Taylor
b8d469600b These functions import $wpdb but do not use it. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28539


git-svn-id: http://core.svn.wordpress.org/trunk@28365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 17:37:14 +00:00
Sergey Biryukov
219321eedc Fix inconsistent header underlining and spacing in background update emails. 
fixes #28306.
Built from https://develop.svn.wordpress.org/trunk@28537


git-svn-id: http://core.svn.wordpress.org/trunk@28363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 09:41:15 +00:00
Sergey Biryukov
45d5e5d32f Use correct function name. 
props ericlewis.
fixes #28329.
Built from https://develop.svn.wordpress.org/trunk@28535


git-svn-id: http://core.svn.wordpress.org/trunk@28361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 07:59:16 +00:00
Scott Taylor
7de0b2b2c8 Upgrade _WP_List_Table_Compat to PHP5-style constructor. 
Add `public` to methods/members of `WP_Role`.
Add `public` to methods/members of `WP_User` where appropriate. Don't set `private` where indicated until more study has occurred and tests have been written for compatibiliy with existing magic methods.

See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28531


git-svn-id: http://core.svn.wordpress.org/trunk@28357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 17:20:17 +00:00
Scott Taylor
7415ae10a3 hackificator doesn't like mixed single/double-quoted attributes. These were 2 lingering instances in the admin. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28530


git-svn-id: http://core.svn.wordpress.org/trunk@28356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 17:10:15 +00:00
Scott Taylor
09ecc213c8 In WP_Filesystem_Base, the constructor is a noop, so it shouldn't even be declared. Setting it implies that parent::__construct() should be called by its subclasses. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28529


git-svn-id: http://core.svn.wordpress.org/trunk@28355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 16:46:14 +00:00
Scott Taylor
85f73cf458 Classes that have __set() also need __isset() and __unset(). 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28524


git-svn-id: http://core.svn.wordpress.org/trunk@28350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:52:14 +00:00
Scott Taylor
821246b4ae Some classes with __get() method also need __set(). 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28521


git-svn-id: http://core.svn.wordpress.org/trunk@28347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:31:15 +00:00
Scott Taylor
dfa4de15fa Add missing access modifiers to methods/members in Walker and subclasses. Add a magic __get() method. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28514


git-svn-id: http://core.svn.wordpress.org/trunk@28340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:00:15 +00:00
Scott Taylor
2f513d3320 Fix some hackificator odds and ends in wp-admin: 
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28500


git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:04:16 +00:00
Drew Jaynes
511eabe5f3 Improve inline documentation of default arguments for post_format_meta_box(), post_tags_meta_box(), and post_categories_meta_box(). 
See #28298.

Built from https://develop.svn.wordpress.org/trunk@28499


git-svn-id: http://core.svn.wordpress.org/trunk@28325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 03:23:13 +00:00
Scott Taylor
130771a383 hackificator doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28497


git-svn-id: http://core.svn.wordpress.org/trunk@28323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:59:15 +00:00
Scott Taylor
1383990ae2 Add access modifier (public) to methods and members of WP_Upgrader and its subclasses. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28496


git-svn-id: http://core.svn.wordpress.org/trunk@28322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:29:15 +00:00
Scott Taylor
58ca85e106 Add access modifier (public) to methods and members of WP_Upgrader_Skin and its subclasses. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28495


git-svn-id: http://core.svn.wordpress.org/trunk@28321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:23:15 +00:00
Scott Taylor
f090ff507d Add access modifiers to methods and members of WP_Users_List_Table. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28494


git-svn-id: http://core.svn.wordpress.org/trunk@28320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:19:14 +00:00
Scott Taylor
d28f6344de Add access modifiers to methods and members of list table classes: 
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`

See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28493


git-svn-id: http://core.svn.wordpress.org/trunk@28319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:17:15 +00:00
Scott Taylor
4e894f05f5 Add access modifier (public) to methods in WP_Importer. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28492


git-svn-id: http://core.svn.wordpress.org/trunk@28318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:19:15 +00:00
Scott Taylor
d5e35d187f Add access modifier (public) to members and methods in WP_Filesystem_SSH2. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28491


git-svn-id: http://core.svn.wordpress.org/trunk@28317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:18:14 +00:00
Scott Taylor
41e1ecdfaf Add access modifier (public) to members and methods in WP_Filesystem_ftpsockets. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28490


git-svn-id: http://core.svn.wordpress.org/trunk@28316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:14:14 +00:00
Scott Taylor
0dbc6b37a7 Add access modifier (public) to members and methods in WP_Filesystem_FTPext. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28489


git-svn-id: http://core.svn.wordpress.org/trunk@28315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:12:15 +00:00
Scott Taylor
eb750d0bd1 Add access modifier (public) to methods in WP_Filesystem_Direct. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28488


git-svn-id: http://core.svn.wordpress.org/trunk@28314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:09:14 +00:00
Scott Taylor
7a378bc48f Add access modifiers to members and methods in WP_Filesystem_Base. Add magic __get() method for backwards compatibility. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28487


git-svn-id: http://core.svn.wordpress.org/trunk@28313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:06:14 +00:00
Scott Taylor
e43e775c45 Add access modifier (public) to members and methods in WP_Comments_List_Table and WP_Post_Comments_List_Table. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28486


git-svn-id: http://core.svn.wordpress.org/trunk@28312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 23:59:15 +00:00
Scott Taylor
e917c14144 In edit-link-form.php, hackificator bails because there is a </form> with no open <form>. It exists, but is needlessly constructed with PHP. It always returns a <form>, only the id and name are different. The dynamic piece just returns the ID now. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28485


git-svn-id: http://core.svn.wordpress.org/trunk@28311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 22:07:15 +00:00
Scott Taylor
a659275338 hackificator bails on this file because of mixed quote styles on some HTML attributes. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28484


git-svn-id: http://core.svn.wordpress.org/trunk@28310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 21:47:14 +00:00
Scott Taylor
6a765cdd03 Remove public keyword from some JS functions. Sorry. 
Props ocean90.
See #22234.


Built from https://develop.svn.wordpress.org/trunk@28483


git-svn-id: http://core.svn.wordpress.org/trunk@28309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 21:43:14 +00:00
Scott Taylor
68cfacf9ec hackificator bails on this file because the <meta> isn't self-closing. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28482


git-svn-id: http://core.svn.wordpress.org/trunk@28308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 21:36:15 +00:00
Scott Taylor
2e912d3108 Use proper access modifiers and add a magic __get() method to Custom_Background and Custom_Image_Header. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28481


git-svn-id: http://core.svn.wordpress.org/trunk@28307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 21:31:16 +00:00
Scott Taylor
b9afafffe3 hackificator complains if you call include 'file.php' without the parens, needs to be include( 'file.php' ) 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28479


git-svn-id: http://core.svn.wordpress.org/trunk@28306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 20:52:15 +00:00
Scott Taylor
112ca4e055 Because the WP_ADMIN constant name can be bound in multiple files, all instances should check ! defined first. wp-admin/admin.php already has this check. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28478


git-svn-id: http://core.svn.wordpress.org/trunk@28305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 20:42:16 +00:00
Scott Taylor
fc23dc3551 The About page has a <div> that doesn't close. Also, <hr>s should self-close. hackificator complains about these things. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28477


git-svn-id: http://core.svn.wordpress.org/trunk@28304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 20:33:15 +00:00
Sergey Biryukov
8dacdb77be Fix wp_insert_link(), broken in [28406]/[28408]. 
see #22400.
Built from https://develop.svn.wordpress.org/trunk@28475


git-svn-id: http://core.svn.wordpress.org/trunk@28302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 09:56:15 +00:00
Drew Jaynes
d75ca7aaaf Add inline documentation for default arguments in wp_insert_category(). 
See #28298.

Built from https://develop.svn.wordpress.org/trunk@28474


git-svn-id: http://core.svn.wordpress.org/trunk@28301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 07:28:14 +00:00
Sergey Biryukov
c453340a49 Update help text on Add Themes screen. 
props thomasvanderbeek.
fixes #28132.
Built from https://develop.svn.wordpress.org/trunk@28473


git-svn-id: http://core.svn.wordpress.org/trunk@28300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 23:44:15 +00:00
Scott Taylor
4ce9706db1 Add inline comment after fix in [28467]. 
Props jesin.
Fixes #28292.


Built from https://develop.svn.wordpress.org/trunk@28468


git-svn-id: http://core.svn.wordpress.org/trunk@28295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 15:42:14 +00:00
Scott Taylor
bdd1ae2fc7 Restore $soucrce in WP_Upgrader::install_package(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28467


git-svn-id: http://core.svn.wordpress.org/trunk@28294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 15:40:15 +00:00
Scott Taylor
8eb9f2ffe4 Eliminate use of extract() in request_filesystem_credentials(). 
The only property that doesn't need to be set to a variable is `$password`.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28456


git-svn-id: http://core.svn.wordpress.org/trunk@28283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 18:26:15 +00:00
Andrew Ozz
f184243aa3 DFW: fix closing only the wpLink or media modal when pressing Esc. 
Built from https://develop.svn.wordpress.org/trunk@28455


git-svn-id: http://core.svn.wordpress.org/trunk@28282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 18:17:14 +00:00
Scott Taylor
39de969bf2 Update inline docs for wp_handle_upload|sideload to reflect their non-use of extract(). 
See #22400.


Built from https://develop.svn.wordpress.org/trunk@28452


git-svn-id: http://core.svn.wordpress.org/trunk@28279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 17:41:16 +00:00
Scott Taylor
632eb5b17e Eliminate use of extract() in wp_handle_sideload(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28451


git-svn-id: http://core.svn.wordpress.org/trunk@28278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 16:15:14 +00:00
Scott Taylor
4caf3e79f3 Eliminate use of extract() in wp_handle_upload(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28450


git-svn-id: http://core.svn.wordpress.org/trunk@28277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 16:10:38 +00:00
Sergey Biryukov
abc830ca9d DFW: Properly handle Esc key when the content is focused or when switching browser tabs. 
props avryl.
fixes #28279.
Built from https://develop.svn.wordpress.org/trunk@28443


git-svn-id: http://core.svn.wordpress.org/trunk@28270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 10:43:14 +00:00
Scott Taylor
b2d1e73fd5 Eliminate the use of extract() in WP_Upgrader. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28418


git-svn-id: http://core.svn.wordpress.org/trunk@28245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 05:02:14 +00:00
Scott Taylor
d74272ecf5 Eliminate one of the uses of extract() in wp_handle_upload(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28417


git-svn-id: http://core.svn.wordpress.org/trunk@28244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 04:31:14 +00:00
Scott Taylor
fc59804352 Eliminate one of the uses of extract() in wp_handle_sideload(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28416


git-svn-id: http://core.svn.wordpress.org/trunk@28243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 04:29:15 +00:00
Scott Taylor
a7a6cb5bef Eliminate use of extract() in Walker_Category_Checklist::start_el(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28411


git-svn-id: http://core.svn.wordpress.org/trunk@28238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:14:14 +00:00
Scott Taylor
7ebab48f4c Eliminate use of extract() in wp_terms_checklist(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28410


git-svn-id: http://core.svn.wordpress.org/trunk@28237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:09:15 +00:00
Scott Taylor
a75f8137bc Eliminate use of extract() in wp_star_rating(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28409


git-svn-id: http://core.svn.wordpress.org/trunk@28236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:57:14 +00:00
Scott Taylor
ff665b2f38 (REALLY) Eliminate use of extract() in wp_insert_link(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28408


git-svn-id: http://core.svn.wordpress.org/trunk@28235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:55:16 +00:00
Scott Taylor
54321f4c6e Eliminate use of extract() in get_media_item(). 
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`	
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28407


git-svn-id: http://core.svn.wordpress.org/trunk@28234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:45:15 +00:00
Scott Taylor
5f06d0f50a Eliminate use of extract() in wp_insert_link(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28406


git-svn-id: http://core.svn.wordpress.org/trunk@28233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:28:14 +00:00
Scott Taylor
1121efb54c Eliminate use of extract() in display_setup_form(). Only needs to read password and password_message. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28396


git-svn-id: http://core.svn.wordpress.org/trunk@28224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-14 16:43:15 +00:00
Drew Jaynes
a23cc5634f Properly split and document the admin_post* actions into the following four hooks: 
* `admin_post_nopriv` – for logged-out requests lacking a supplied action
* `admin_post_nopriv_$action – for logged-out requests with a supplied action
* `admin_post` – for logged-in requests lacking a supplied action
* `admin_post_$action` – for logged-in requests with a supplied action

See [28349], [28350], [28351].
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28394


git-svn-id: http://core.svn.wordpress.org/trunk@28222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 07:24:15 +00:00
Drew Jaynes
40a738c21c Clarify inline documentation for back-compat load-* action hooks. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28393


git-svn-id: http://core.svn.wordpress.org/trunk@28221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 06:28:15 +00:00
Scott Taylor
fd9abeb0f9 Eliminate use of extract() in post_tags_meta_box() and post_categories_meta_box(). 
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28391


git-svn-id: http://core.svn.wordpress.org/trunk@28219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:48:17 +00:00
Scott Taylor
9476cd33a3 Eliminate use of extract() in WP_Terms_List_Table::display_rows_or_placeholder(): 
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract		

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28390


git-svn-id: http://core.svn.wordpress.org/trunk@28218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:37:14 +00:00
Scott Taylor
aef35fe6a2 Eliminate use of extract() in WP_List_Table::pagination(): 
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise. 		

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28389


git-svn-id: http://core.svn.wordpress.org/trunk@28217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:27:14 +00:00
Scott Taylor
530a107ec9 Eliminate use of extract() in WP_Plugin_Install_List_Table::get_table_classes(). It only needs to read plural, no need to extract. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28388


git-svn-id: http://core.svn.wordpress.org/trunk@28216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:17:14 +00:00
Scott Taylor
192e235672 Eliminate use of extract() in WP_List_Table::ajax_response(): 
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28387


git-svn-id: http://core.svn.wordpress.org/trunk@28215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:14:14 +00:00
Scott Taylor
08d73b9e23 Eliminate use of extract() in WP_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28386


git-svn-id: http://core.svn.wordpress.org/trunk@28214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:08:13 +00:00
Scott Taylor
f617b8669a Eliminate use of extract() in WP_Post_Comments_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary. 
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28385


git-svn-id: http://core.svn.wordpress.org/trunk@28213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:04:14 +00:00
Scott Taylor
4c60b2e207 Eliminate use of extract() in Custom_Image_Header::step_2(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28384


git-svn-id: http://core.svn.wordpress.org/trunk@28212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:54:14 +00:00
Drew Jaynes
ec88da1ee3 Clarify documentation for *what* gets "automatically fired" when the do_mu_upgrade filter evaluates to true in Multisite. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28376


git-svn-id: http://core.svn.wordpress.org/trunk@28204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:18:14 +00:00
Drew Jaynes
b4ca72583a Fix incomplete inline documentation for the wp_header_image_attachment_metadata filter. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28375


git-svn-id: http://core.svn.wordpress.org/trunk@28203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:13:15 +00:00
Scott Taylor
6bbc5b570c Eliminate use of extract() in wp_insert_category(). Adds unit tests. All unit tests pass. 
Props MikeHansenMe.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28374


git-svn-id: http://core.svn.wordpress.org/trunk@28202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 03:27:13 +00:00
Scott Taylor
2bea9fcc0b In media_upload_gallery_form()'s inline JavaScript, remove unnecessary comment tags. 
Fixes #25637.


Built from https://develop.svn.wordpress.org/trunk@28368


git-svn-id: http://core.svn.wordpress.org/trunk@28196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 06:12:15 +00:00
Scott Taylor
88b96dc036 In wp_read_image_metadata(), the values from exif_read_data() should only override values from iptcparse() that are empty. 
Props SergeyBiryukov.
Fixes #23706.

Built from https://develop.svn.wordpress.org/trunk@28367


git-svn-id: http://core.svn.wordpress.org/trunk@28195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 05:54:15 +00:00
Scott Taylor
e9f87b2688 Avoid a notice in wp_save_image() by checking $meta['sizes']['thumbnail'] for ! empty() before setting a variable to it. 
Props MikeHansenMe.
Fixes #17736.


Built from https://develop.svn.wordpress.org/trunk@28366


git-svn-id: http://core.svn.wordpress.org/trunk@28194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 03:42:14 +00:00
Scott Taylor
0b6729c3f9 In WP_Terms_List_Table::single_row(), call sanitize_term() on the passed term ($tag). 
Props oso96_2000, c3mdigital, scribu. 
It takes a village.
Fixes #16864.

Built from https://develop.svn.wordpress.org/trunk@28360


git-svn-id: http://core.svn.wordpress.org/trunk@28188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 00:05:15 +00:00
Scott Taylor
f22beb987c First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet. 
Props avryl, wonderboymusic.
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28358


git-svn-id: http://core.svn.wordpress.org/trunk@28186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 23:36:18 +00:00
Drew Jaynes
81cfb9427a Fix mid-file section header style in wp-admin/includes/ajax-actions.php. 
See #28200.

Built from https://develop.svn.wordpress.org/trunk@28356


git-svn-id: http://core.svn.wordpress.org/trunk@28184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 05:02:13 +00:00
Drew Jaynes
0ef7244ce7 Add baseline doc blocks for all ajax handlers in ajax-actions.php. 
Fixes #28200.

Built from https://develop.svn.wordpress.org/trunk@28355


git-svn-id: http://core.svn.wordpress.org/trunk@28183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 05:00:19 +00:00
Drew Jaynes
f609524261 Minor phpDoc fixes for the got_rewrite, got_url_rewrite, and documentation_ignore_functions hooks. 
Props GaryJ.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28352


git-svn-id: http://core.svn.wordpress.org/trunk@28180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 11:13:14 +00:00
Drew Jaynes
c02696f43f Rename the $action hook in wp-admin/admin-post.php to admin_post{$action}. 
Also, clarify documentation of priv vs nopriv prefixing of the hook name.

See #26869.

Built from https://develop.svn.wordpress.org/trunk@28351


git-svn-id: http://core.svn.wordpress.org/trunk@28179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 11:00:15 +00:00
Drew Jaynes
f427187fa8 Revert [28349] in favor of retaining the single dynamic admin_post* hook. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28350


git-svn-id: http://core.svn.wordpress.org/trunk@28178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 10:47:15 +00:00
Drew Jaynes
a6755201d8 Convert and rename the $action hook in wp-admin/admin-post to two dynamic hook sets. 
* `admin_post_nopriv{$request_action}` is fired for logged-out users
* `admin_post{$request_action}` is fired for logged-in users

Props Otto42, DrewAPicture.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28349


git-svn-id: http://core.svn.wordpress.org/trunk@28177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 10:27:14 +00:00
Drew Jaynes
32e674f44e Use interpolation instead of concatenation for the manage_{$screen->id}_columns hook name. 
Props Otto42.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28348


git-svn-id: http://core.svn.wordpress.org/trunk@28176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 09:58:14 +00:00
Drew Jaynes
8906f83802 Use an interpolated hook name for edit_{$post_type}_per_page instead of $per_page and adjust docs accordingly. 
Also references the correct variable for the `$posts_per_page` parameter in the `edit_posts_per_page` hook doc.

Props Otto42 for the initial patch.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28347


git-svn-id: http://core.svn.wordpress.org/trunk@28175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 08:16:15 +00:00
Scott Taylor
1daa7d6723 Leverage size_format() when displaying max_upload_size: 
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.


Built from https://develop.svn.wordpress.org/trunk@28343


git-svn-id: http://core.svn.wordpress.org/trunk@28171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 18:25:14 +00:00
Scott Taylor
5f27d149a3 In wp-admin/users.php, break is unreachabled after exit. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28315


git-svn-id: http://core.svn.wordpress.org/trunk@28143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:19:14 +00:00
Scott Taylor
402d8b80fb In core_upgrade_preamble(), $alternate is set then never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28314


git-svn-id: http://core.svn.wordpress.org/trunk@28142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:17:18 +00:00
Scott Taylor
e9bb9c0f12 In wp-admin/theme-editor.php, break is unreachabled after exit. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28313


git-svn-id: http://core.svn.wordpress.org/trunk@28141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:16:26 +00:00
Scott Taylor
517dbfaa21 In wp-admin/post.php, break is unreachabled after exit. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28312


git-svn-id: http://core.svn.wordpress.org/trunk@28140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:15:15 +00:00
Scott Taylor
327b38f298 In wp-admin/plugins.php, break is unreachabled after exit. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28311


git-svn-id: http://core.svn.wordpress.org/trunk@28139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:13:14 +00:00
Scott Taylor
ac63c66c5a In wp-admin/plugin-editor.php, break is unreachabled after exit. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28310


git-svn-id: http://core.svn.wordpress.org/trunk@28138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:12:14 +00:00
Scott Taylor
0f8fb8a148 In wp-admin/network/users.php, break is unreachabled after exit. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28309


git-svn-id: http://core.svn.wordpress.org/trunk@28137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:11:14 +00:00
Scott Taylor
64418c0192 In wp-admin/network/themes.php, break is unreachabled after exit. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28308


git-svn-id: http://core.svn.wordpress.org/trunk@28136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:08:14 +00:00
Scott Taylor
f5d23b82bd In wp-admin/link.php, break is unreachabled after exit. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28307


git-svn-id: http://core.svn.wordpress.org/trunk@28135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:06:14 +00:00
Scott Taylor
213a7de0b7 In display_setup_form(), $admin_password is set and (fortunately) not used or displayed. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28306


git-svn-id: http://core.svn.wordpress.org/trunk@28134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:04:15 +00:00
Scott Taylor
c2d44c5736 In wp-admin/includes/upgrade.php, remove dead code: 
* In `maybe_create_table()` and `maybe_add_column()`, the response of `$wpdb->query()` is set to a variable that is never used.
* In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a variable is set that is not used. This function appears to be a copy-paste of `make_db_current()`'s `dbDelta()` call but is meant to return nothing, and still does not.  

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28305


git-svn-id: http://core.svn.wordpress.org/trunk@28133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:27:15 +00:00
Scott Taylor
aaa3eb07ad In wp-admin/includes/update.php, remove dead code: 
* In `get_core_checksums()`, `$return` is set and never used.
* In `core_update_footer()`, `break` is unnecessary and unreachable after `return`.
* In `get_theme_updates()`, `$themes` is set and never used.
* In `wp_theme_update_row()`, `$theme_name` is the only user of `$themes_allowedtags`... neither are used. 	

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28304


git-svn-id: http://core.svn.wordpress.org/trunk@28132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:21:14 +00:00
Scott Taylor
b80cda5d17 In WP_Screen::render_screen_options(), remove dead code: 
* `$wp_list_table` does not need to be imported.
* `$post` is set and never used.

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28303


git-svn-id: http://core.svn.wordpress.org/trunk@28131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:14:15 +00:00
Scott Taylor
2e417f0ca4 In get_sample_permalink_html(), $view_link is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28302


git-svn-id: http://core.svn.wordpress.org/trunk@28130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:11:14 +00:00
Scott Taylor
44e2d48a3c In install_plugin_information(), $title is set in a foreach loop and never used. This appears to be due to copy-pasting a previous foreach loop and not discarding these bits. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28301


git-svn-id: http://core.svn.wordpress.org/trunk@28129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:00:18 +00:00
Scott Taylor
e57fa7300d In wp-admin/includes/nav-menu.php, remove dead code: 
* In `_wp_ajax_menu_quick_search()`, in an `else` block, `$post_obj` was set and not used. Another block sets it again and does use it. 
* In `wp_nav_menu_item_post_type_meta_box()`, `$post_type_object` was set and, sadly, never used. `$error` was set and not used. 

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28300


git-svn-id: http://core.svn.wordpress.org/trunk@28128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:55:14 +00:00
Scott Taylor
85bdc64173 In update_option_new_admin_email(), $email is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28299


git-svn-id: http://core.svn.wordpress.org/trunk@28127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:48:14 +00:00
Scott Taylor
6066f85853 In attachment_submit_meta_box(), remove dead code: 
* `$action` doesn't need to be imported.
* `$can_publish` is set and never used, which means it doesn't need...
* `$post_type_object` or `$post_type`, which only served `$can_publish`.

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28298


git-svn-id: http://core.svn.wordpress.org/trunk@28126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:45:14 +00:00
Scott Taylor
71ac0f21c2 In get_media_item(), $tags and $_tags are set and never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28297


git-svn-id: http://core.svn.wordpress.org/trunk@28125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:41:17 +00:00
Scott Taylor
3054b924a3 In WP_Users_List_Table::get_views(), $current_role is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28296


git-svn-id: http://core.svn.wordpress.org/trunk@28124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:33:15 +00:00
Scott Taylor
209f008d77 In WP_MS_Users_List_Table::get_views(), remove dead code: 
* `$wp_roles` doesn't need to be imported.
* `$current_role` is set and never used.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28295


git-svn-id: http://core.svn.wordpress.org/trunk@28123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:30:14 +00:00
Dominik Schilling
f7539feb4d Custom Header: Fix logic when a theme doesn't set default-text-color. 
fixes #28042.
Built from https://develop.svn.wordpress.org/trunk@28294


git-svn-id: http://core.svn.wordpress.org/trunk@28122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:27:54 +00:00
Scott Taylor
970477d25e In WP_Media_List_Table, remove dead code: 
* In `->prepare_items()`, importing `$wpdb` is unnecessary.
* In `->get_columns()`, `$taxonomies` is set twice before it is used.
* In `->display_rows()`, `$taxonomy_object` is set and never used.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28293


git-svn-id: http://core.svn.wordpress.org/trunk@28121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:27:33 +00:00
Scott Taylor
28d98a89f3 In ajax-actions.php, remove dead code: 
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used. 

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28292


git-svn-id: http://core.svn.wordpress.org/trunk@28120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:19:14 +00:00
Scott Taylor
d433f8f1ed Remove unreachable break statements in wp-admin/edit-tags.php. break is unnecessary after die, exit, and wp_die. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28291


git-svn-id: http://core.svn.wordpress.org/trunk@28119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 14:52:16 +00:00
Scott Taylor
d3dd9916d8 In wp-admin/custom-header.php, $default_color is set twice before it is used. The first is unnecessary. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28290


git-svn-id: http://core.svn.wordpress.org/trunk@28118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 14:51:19 +00:00
Scott Taylor
97e6942e4a Remove unreachable break statements in wp-admin/comments.php. break is unnecessary after die, exit, and wp_die. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28289


git-svn-id: http://core.svn.wordpress.org/trunk@28117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 14:46:16 +00:00
Sergey Biryukov
10ab8b1055 Translate a string added in 3.7 but never translated previously. 
props andrezrv.
fixes #28025.
Built from https://develop.svn.wordpress.org/trunk@28288


git-svn-id: http://core.svn.wordpress.org/trunk@28116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 12:49:15 +00:00
Sergey Biryukov
527a1ea6e3 Use a consistent context to remove duplicate strings. 
props pavelevap.
fixes #28123.
Built from https://develop.svn.wordpress.org/trunk@28287


git-svn-id: http://core.svn.wordpress.org/trunk@28115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 12:34:14 +00:00
Sergey Biryukov
28cafbb868 Add context for 'Previous' and 'Next' theme strings. 
see #28120, for trunk.
Built from https://develop.svn.wordpress.org/trunk@28286


git-svn-id: http://core.svn.wordpress.org/trunk@28114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 12:20:14 +00:00
Dominik Schilling
8b72aebdaa Add missing Dashicons classes to User Admin menu. 
props imath.
see #28144, #26630.
Built from https://develop.svn.wordpress.org/trunk@28284


git-svn-id: http://core.svn.wordpress.org/trunk@28112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 07:58:15 +00:00
Scott Taylor
ded4871368 In WP_List_Table::display_rows_or_placeholder(), the call to get_column_info() in unnecessary and unused. The call to get_column_count() immediately after makes the same call internally. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28279


git-svn-id: http://core.svn.wordpress.org/trunk@28107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 05:32:15 +00:00
Andrew Nacin
7509795517 Custom header: Avoid warnings in the process_default_headers() method. 
props obenland.
fixes #27850.

Built from https://develop.svn.wordpress.org/trunk@28275


git-svn-id: http://core.svn.wordpress.org/trunk@28103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 05:07:13 +00:00
Scott Taylor
dd73ad4299 In edit_form_image_editor(), $filename and $title are set and then unused. They shall be removed. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28271


git-svn-id: http://core.svn.wordpress.org/trunk@28099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:45:16 +00:00
Andrew Nacin
962e8113ab Customizer: Only tie header button action events to the header controls. 
props danielbachhuber.
fixes #28046. see #27848.

Built from https://develop.svn.wordpress.org/trunk@28269


git-svn-id: http://core.svn.wordpress.org/trunk@28097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:30:23 +00:00
Scott Taylor
644024dfc4 Dead code in wp-admin/includes/file.php: 
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28268


git-svn-id: http://core.svn.wordpress.org/trunk@28096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:22:14 +00:00
Scott Taylor
3d7a4e6798 Remove unused variable setting for $revisions in wp_prepare_revisions_for_js(). 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28264


git-svn-id: http://core.svn.wordpress.org/trunk@28092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 03:45:14 +00:00
Scott Taylor
21379dcde0 Remove a dead variable, $start, from wp_dashboard_recent_comments(). 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28263


git-svn-id: http://core.svn.wordpress.org/trunk@28091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 03:35:14 +00:00
Andrew Nacin
f44e4226fa Move 'home' option to the top of populate_options(). 
fixes #28141.

Built from https://develop.svn.wordpress.org/trunk@28260


git-svn-id: http://core.svn.wordpress.org/trunk@28088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-05 21:57:14 +00:00
Sergey Biryukov
751e624ff7 Deprecate unused argument of delete_plugins(). Clarify @return value. 
props jdgrimes for initial patch.
fixes #28111.
Built from https://develop.svn.wordpress.org/trunk@28256


git-svn-id: http://core.svn.wordpress.org/trunk@28084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-05 10:24:15 +00:00
Sergey Biryukov
13cbcc92cf Fix closing tag in image editor. 
props t4k1s.
fixes #28130.
Built from https://develop.svn.wordpress.org/trunk@28255


git-svn-id: http://core.svn.wordpress.org/trunk@28083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-05 10:17:19 +00:00
Sergey Biryukov
db4423c5cd Avoid displaying a negative number of plugin updates in admin menu. 
fixes #28073.
Built from https://develop.svn.wordpress.org/trunk@28254


git-svn-id: http://core.svn.wordpress.org/trunk@28082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-05 09:39:17 +00:00
Sergey Biryukov
997cbaa03c Use a time constant in get_theme_feature_list() and File_Upload_Upgrader. 
props GaVrA.
fixes #28124.
Built from https://develop.svn.wordpress.org/trunk@28253


git-svn-id: http://core.svn.wordpress.org/trunk@28081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-05 08:26:24 +00:00
Dominik Schilling
e6644720f9 Color Picker: Close color picker when clicking outside of them and when opening another one. 
props mattwiebe.
fixes #25539.
Built from https://develop.svn.wordpress.org/trunk@28239


git-svn-id: http://core.svn.wordpress.org/trunk@28067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-02 11:18:15 +00:00
Dominik Schilling
8e7e53b22e Widgets: Toggle widget arrow when widget is open/closed. 
props MikeHansenMe.
fixes #26748.
Built from https://develop.svn.wordpress.org/trunk@28235


git-svn-id: http://core.svn.wordpress.org/trunk@28063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-01 14:09:16 +00:00
Dominik Schilling
a0086bd102 Quick Draft: Use text cursor for description label. 
fixes #27766.
Built from https://develop.svn.wordpress.org/trunk@28234


git-svn-id: http://core.svn.wordpress.org/trunk@28062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-01 13:12:16 +00:00
Drew Jaynes
058ff61dec Mark the $hook and $page_hook hooks as @internal to skip parsing. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28216


git-svn-id: http://core.svn.wordpress.org/trunk@28046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 07:54:21 +00:00
Drew Jaynes
d77e78d685 Clean up duplicate hook notations and adjacency for calls to the wp_signup_location filter. 
Also adds braces missed in [25535].

See #26869.

Built from https://develop.svn.wordpress.org/trunk@28215


git-svn-id: http://core.svn.wordpress.org/trunk@28045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 07:12:14 +00:00
Drew Jaynes
029dd247be Ensure the wp_edit_nav_menu_walker filter is only documented once. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28213


git-svn-id: http://core.svn.wordpress.org/trunk@28043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 06:50:15 +00:00
Drew Jaynes
ef643d9136 Ensure all duplicate calls of the wp_create_file_in_uploads filter are labeled as such. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28212


git-svn-id: http://core.svn.wordpress.org/trunk@28042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 06:46:19 +00:00
Drew Jaynes
a866838b31 Ensure adjacency of a duplicate hook comment for a the_category filter call. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28211


git-svn-id: http://core.svn.wordpress.org/trunk@28041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 06:43:16 +00:00
Drew Jaynes
73c851c227 Ensure the submitlink_box action hook is only documented once. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28210


git-svn-id: http://core.svn.wordpress.org/trunk@28040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 06:34:15 +00:00
Drew Jaynes
a9b74e2088 Ensure the nav_menu_meta_box_object filter hook is only documented once. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28207


git-svn-id: http://core.svn.wordpress.org/trunk@28037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 06:14:15 +00:00
Mark Jaquith
a43313fe12 Use '&mdash; Select &mdash;' instead of '-- Select --' for nav menus. Looks nicer. 
see #27878
Built from https://develop.svn.wordpress.org/trunk@28205


git-svn-id: http://core.svn.wordpress.org/trunk@28035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 00:35:25 +00:00
Andrew Ozz
46bdcce0eb Ensure the editor height is saved properly, props jupiterwise, see #28000, for trunk. 
Built from https://develop.svn.wordpress.org/trunk@28193


git-svn-id: http://core.svn.wordpress.org/trunk@28023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-24 04:11:15 +00:00
Andrew Ozz
571353164f Fix cursor style for the resize handle of the editor, props avryl, see #27595, for trunk. 
Built from https://develop.svn.wordpress.org/trunk@28186


git-svn-id: http://core.svn.wordpress.org/trunk@28017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-22 21:48:15 +00:00
Helen Hou-Sandí
be7a2513cf Don't allow disabled input styling to get lost in the cascade. props ocean90. see #27906 for trunk. 
Built from https://develop.svn.wordpress.org/trunk@28179


git-svn-id: http://core.svn.wordpress.org/trunk@28010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-21 20:55:15 +00:00
Helen Hou-Sandí
51cf3e9f9a Simplify the admin menu notification selector so color schemes don't get stomped. props celloexpressions. see #27920 for trunk. 
Built from https://develop.svn.wordpress.org/trunk@28177


git-svn-id: http://core.svn.wordpress.org/trunk@28008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-21 18:55:16 +00:00
Andrew Nacin
b89775445e Theme Installer: Proper redirection and action links post-install in multisite. 
fixes #27869.

Built from https://develop.svn.wordpress.org/trunk@28163


git-svn-id: http://core.svn.wordpress.org/trunk@27994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-19 18:18:16 +00:00
Andrew Nacin
cd6b973b54 Use correct echoing context function. see #27889. 
Built from https://develop.svn.wordpress.org/trunk@28160


git-svn-id: http://core.svn.wordpress.org/trunk@27991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-19 18:09:16 +00:00
Andrew Nacin
3a9851d0fa Context for 'Installed' and 'Already Installed' theme strings. 
props SergeyBiryukov.
see #27889, for trunk.

Built from https://develop.svn.wordpress.org/trunk@28159


git-svn-id: http://core.svn.wordpress.org/trunk@27990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-19 18:08:17 +00:00
Andrew Nacin
b0f672d552 About page: Don't use wp_playlist_scripts() as that prints stuff. 
fixes #27713.

Built from https://develop.svn.wordpress.org/trunk@28151


git-svn-id: http://core.svn.wordpress.org/trunk@27982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 17:55:15 +00:00
Andrew Nacin
e3a4c57563 Final about page. 
props melchoyce, helen, wonderboymusic, nacin, and the illustrious Michael Pick.
fixes #27713, #27837.

Built from https://develop.svn.wordpress.org/trunk@28150


git-svn-id: http://core.svn.wordpress.org/trunk@27981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 17:40:14 +00:00
Andrew Nacin
dd8531a3b3 Widgets: Better padding for translations of "Reorder". 
fixes #27788.

Built from https://develop.svn.wordpress.org/trunk@28148


git-svn-id: http://core.svn.wordpress.org/trunk@27979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 13:07:16 +00:00
Andrew Nacin
f5c0ad0115 Theme Installer: Properly call router navigation. 
props gcorne.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@28147


git-svn-id: http://core.svn.wordpress.org/trunk@27978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 03:06:16 +00:00
Andrew Nacin
e23f57ec56 About page: Use a better preposition to describe drag-and-drop. 
see #27713.

Built from https://develop.svn.wordpress.org/trunk@28146


git-svn-id: http://core.svn.wordpress.org/trunk@27977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 00:46:14 +00:00
Andrew Nacin
2bc282957c Translate a string added in 3.7.1 but never translated previously. 
props SergeyBiryukov.
fixes #27819.

Built from https://develop.svn.wordpress.org/trunk@28145


git-svn-id: http://core.svn.wordpress.org/trunk@27976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 00:38:14 +00:00
Andrew Nacin
dbca0c5e15 Widgets: Remove create_function() from the customizer class. 
props westonruter.
fixes #27805.

Built from https://develop.svn.wordpress.org/trunk@28143


git-svn-id: http://core.svn.wordpress.org/trunk@27974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 00:11:35 +00:00
Andrew Ozz
55e3a1101a TinyMCE: fix icons in IE7, fixes #27829 
Built from https://develop.svn.wordpress.org/trunk@28142


git-svn-id: http://core.svn.wordpress.org/trunk@27973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 00:10:14 +00:00
Andrew Nacin
d46037e0b5 Theme Installer: Fixes for browsers without pushState. 
props gcorne.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@28141


git-svn-id: http://core.svn.wordpress.org/trunk@27972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 00:04:15 +00:00
Dion Hulse
ca0b5c9859 Background Updates: Avoid a PHP warning during theme update checks when there are multiple theme directories registered. Fixes #27815 
Built from https://develop.svn.wordpress.org/trunk@28137


git-svn-id: http://core.svn.wordpress.org/trunk@27968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 10:57:14 +00:00
Andrew Nacin
03d953d963 Fix entities on about page. see #27713. 
Built from https://develop.svn.wordpress.org/trunk@28136


git-svn-id: http://core.svn.wordpress.org/trunk@27967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 09:22:14 +00:00
Andrew Nacin
fa3900168e Allow the API to add text to auto update emails. 
fixes #27812.

Built from https://develop.svn.wordpress.org/trunk@28134


git-svn-id: http://core.svn.wordpress.org/trunk@27965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 08:52:15 +00:00
Andrew Nacin
82da8e9b0b Fix typo on about page. 
props helen.
see #27713.

Built from https://develop.svn.wordpress.org/trunk@28133


git-svn-id: http://core.svn.wordpress.org/trunk@27964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 08:26:15 +00:00
Andrew Nacin
4a0ae35eb1 Final about page text. 
props siobhan, kerikae, DH-Shredder, nacin.
see #27713.

Built from https://develop.svn.wordpress.org/trunk@28132


git-svn-id: http://core.svn.wordpress.org/trunk@27963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 07:53:14 +00:00
Andrew Nacin
86daa61c45 About page design, first pass. 
props melchoyce, ryelle.
see #27713.

Built from https://develop.svn.wordpress.org/trunk@28127


git-svn-id: http://core.svn.wordpress.org/trunk@27958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 01:31:14 +00:00
Andrew Nacin
9f81d0526e Theme Installer: Revert to proxying through PHP for WordPress.org API requests. 
This is to ensure we have valid installation nonces, though we've run into this as a problem previously (see #27639, #27581, #27055).

A tad slower, but we gained speed in 3.9 by simplifying the request made to the API.

props ocean90.
fixes #27798.

Built from https://develop.svn.wordpress.org/trunk@28126


git-svn-id: http://core.svn.wordpress.org/trunk@27957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 01:16:14 +00:00
Andrew Nacin
6b579e0d59 Customizer: Properly handle widget settings when activating a previewed theme. 
props westonruter, ocean90, gcorne.
fixes #27767.

Built from https://develop.svn.wordpress.org/trunk@28124


git-svn-id: http://core.svn.wordpress.org/trunk@27955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 22:46:16 +00:00
Andrew Nacin
f911d99902 Theme installer: Improve route handling and make ?theme= work. 
props matveb.
fixes #27708.

Built from https://develop.svn.wordpress.org/trunk@28123


git-svn-id: http://core.svn.wordpress.org/trunk@27954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 22:06:15 +00:00
Andrew Nacin
77e2da21cf Color scheme support for widget choosers. 
props ocean90.
fixes #27793.

Built from https://develop.svn.wordpress.org/trunk@28122


git-svn-id: http://core.svn.wordpress.org/trunk@27953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 20:22:14 +00:00
Andrew Ozz
3de93ccba3 DFW: 
- Add background color and remove the top border from the status bar (at the bottom).
- Fix spinner to always be next to the Save button.
- Remove width: auto; from .mce-fixed-width.
Fixes #27709
Built from https://develop.svn.wordpress.org/trunk@28116


git-svn-id: http://core.svn.wordpress.org/trunk@27947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 08:15:16 +00:00
Andrew Nacin
cb4eb9c13f Avoid stomping of bulk postdata inside the bulk_edit_posts() loop. 
Reverts [27990] which did not fix it for authors and comment/ping status.

props dd32, DrewAPicture.
fixes #27792.

Built from https://develop.svn.wordpress.org/trunk@28113


git-svn-id: http://core.svn.wordpress.org/trunk@27944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 07:48:14 +00:00
Andrew Ozz
c9f5ed0801 Plupload: restore the settings in media_upload_form(), see #27763 
Built from https://develop.svn.wordpress.org/trunk@28110


git-svn-id: http://core.svn.wordpress.org/trunk@27941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 00:41:15 +00:00
Andrew Nacin
55b0cd935e Fix feature pointer RTL placement. 
props SergeyBiryukov, ocean90.
fixes #27778.

Built from https://develop.svn.wordpress.org/trunk@28107


git-svn-id: http://core.svn.wordpress.org/trunk@27938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 00:00:14 +00:00
Andrew Nacin
cd5f8d517c Theme install: Set a timeout and error message for API responses. 
props ocean90.
fixes #27708.

Built from https://develop.svn.wordpress.org/trunk@28105


git-svn-id: http://core.svn.wordpress.org/trunk@27936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-13 19:02:14 +00:00
Andrew Nacin
6fc0120e20 Themes screen: Fix RTL layout issue in Firefox. 
props SergeyBiryukov.
fixes #27779.

Built from https://develop.svn.wordpress.org/trunk@28104


git-svn-id: http://core.svn.wordpress.org/trunk@27935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-13 18:26:15 +00:00
Andrew Nacin
c593fe63d3 Don't auto-resize Quick Draft textarea in IE < 9. Avoids IE8 crash. 
props morganestes.
fixes #27761.

Built from https://develop.svn.wordpress.org/trunk@28103


git-svn-id: http://core.svn.wordpress.org/trunk@27934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-13 18:25:15 +00:00
Andrew Nacin
a2924c6be0 Custom header: Fix image ordering. 
props ehg.
see #21785. fixes #27791.

Built from https://develop.svn.wordpress.org/trunk@28102


git-svn-id: http://core.svn.wordpress.org/trunk@27933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-13 18:22:14 +00:00
Andrew Nacin
e77dc6b97b Fix feature pointer border when using a color scheme. 
props ryelle.
see #27778.

Built from https://develop.svn.wordpress.org/trunk@28098


git-svn-id: http://core.svn.wordpress.org/trunk@27929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-13 16:33:14 +00:00
Andrew Nacin
41d2a7f82b RTL for login screen. 
props yoavf.
fixes #27784.

Built from https://develop.svn.wordpress.org/trunk@28096


git-svn-id: http://core.svn.wordpress.org/trunk@27927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-13 16:06:14 +00:00
Andrew Nacin
eca26bc5ae The widgets pointer requires the edit_theme_options capability. 
(It's hypothetically possible to have only switch_themes.)

see #27777.

Built from https://develop.svn.wordpress.org/trunk@28093


git-svn-id: http://core.svn.wordpress.org/trunk@27924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 20:53:15 +00:00
Andrew Nacin
826d79d572 Translate another About string and use _e(). see #27713. 
Built from https://develop.svn.wordpress.org/trunk@28092


git-svn-id: http://core.svn.wordpress.org/trunk@27923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 20:52:14 +00:00
Andrew Nacin
497b0df4a5 Add a feature pointer for widgets in the customizer in 3.9. Remove older pointers from 3.3 and 3.4. 
see #27777.

Built from https://develop.svn.wordpress.org/trunk@28090


git-svn-id: http://core.svn.wordpress.org/trunk@27921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 20:48:15 +00:00
Andrew Nacin
da29181acd About page: Translate all Under the Hood strings. 
see #27713.

Built from https://develop.svn.wordpress.org/trunk@28088


git-svn-id: http://core.svn.wordpress.org/trunk@27919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 19:39:15 +00:00
Andrew Nacin
d50e4bc08c Custom Headers: Allow for longer strings. 
props ehg.
see #27755.

Built from https://develop.svn.wordpress.org/trunk@28086


git-svn-id: http://core.svn.wordpress.org/trunk@27917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 18:40:14 +00:00
Andrew Nacin
c87ac82d7b Update $_old_files for 3.9. see #27775. 
Built from https://develop.svn.wordpress.org/trunk@28085


git-svn-id: http://core.svn.wordpress.org/trunk@27916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 18:27:17 +00:00
Drew Jaynes
5e51ea9940 Priority fixes for various existing hook documentation. 
Props kpdesign.
See #26869

Built from https://develop.svn.wordpress.org/trunk@28083


git-svn-id: http://core.svn.wordpress.org/trunk@27914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 00:01:15 +00:00
Andrew Ozz
3ddc52b236 Add the new modlas styling to the importer details Thickbox on Tools -> Import. Props ocean90, fixes #26952 
Built from https://develop.svn.wordpress.org/trunk@28080


git-svn-id: http://core.svn.wordpress.org/trunk@27911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-11 21:50:15 +00:00
Andrew Ozz
a32f0dcd4c Fix color of disabled buttons in non-default color schemes, props ryelle, fixes #27759 
Built from https://develop.svn.wordpress.org/trunk@28079


git-svn-id: http://core.svn.wordpress.org/trunk@27910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-11 21:35:17 +00:00
Andrew Nacin
51412f2e9b Account for new cropping settings in the image editor. 
props Otto42, SergeyBiryukov.
fixes #19393.

Built from https://develop.svn.wordpress.org/trunk@28072


git-svn-id: http://core.svn.wordpress.org/trunk@27903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-11 03:10:14 +00:00
Andrew Ozz
dea2eaa1e3 Fix typo in var definition in [28069], see #27750 
Built from https://develop.svn.wordpress.org/trunk@28070


git-svn-id: http://core.svn.wordpress.org/trunk@27901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-10 22:14:15 +00:00
Andrew Ozz
8072976c06 Fix tabbing out of the title field on Media -> Edit Media screen, fixes #27750 
Built from https://develop.svn.wordpress.org/trunk@28069


git-svn-id: http://core.svn.wordpress.org/trunk@27900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-10 22:10:15 +00:00
Andrew Ozz
cc694bac21 Fix TinyMCE Views in IE8 and 7: 
- Add fallback background images for dashicons.
- Fix hiding the clipboard while still allowing the contents to be selected.
- Work around lack of border-box in gallery styles.
(Includes precommit cleanup for theme.js)
Props gcorne, fixes 27546
Built from https://develop.svn.wordpress.org/trunk@28062


git-svn-id: http://core.svn.wordpress.org/trunk@27894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-09 00:58:15 +00:00
Andrew Nacin
5fa5b037ec 3.9 about page text, rough cut. 
props markjaquith, nacin.
see #27713.

Built from https://develop.svn.wordpress.org/trunk@28052


git-svn-id: http://core.svn.wordpress.org/trunk@27882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 17:47:15 +00:00
Andrew Nacin
e8da400c69 Don't show featured images for image attachments. Remove abstractions for now. 
fixes #27673.

Built from https://develop.svn.wordpress.org/trunk@28051


git-svn-id: http://core.svn.wordpress.org/trunk@27881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 17:40:28 +00:00
Andrew Nacin
b631825414 Theme installer keyboard fixes. Updates [28033] and [28036]. 
props matveb.
see #27521.

Built from https://develop.svn.wordpress.org/trunk@28049


git-svn-id: http://core.svn.wordpress.org/trunk@27879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 16:24:14 +00:00
Dominik Schilling
f2d874e3db Theme Installer: Prevent default events for "Upload Theme" and "Browse" buttons. 
see #27055.
Built from https://develop.svn.wordpress.org/trunk@28047


git-svn-id: http://core.svn.wordpress.org/trunk@27877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 12:35:18 +00:00
Andrew Ozz
fd0ae7e406 Precommit cleanup for theme.js, editor.css amd wpdialogs/plugin.js, See #27055, #26907, #16284 
Built from https://develop.svn.wordpress.org/trunk@28045


git-svn-id: http://core.svn.wordpress.org/trunk@27875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 08:29:14 +00:00
Dominik Schilling
3f3a1380d2 Widget Customizer: Fix widget filtering. 
props westonruter.
fixes #27451.
Built from https://develop.svn.wordpress.org/trunk@28044


git-svn-id: http://core.svn.wordpress.org/trunk@27874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 08:12:15 +00:00
Andrew Ozz
268092761d DFW: 
- Move the word count and "Just Write" to a fixed bar at the bottom.
- Fix responsive mode to 480px. Narrower screens will have a scroll bar.
- Hide the Help button on screens < 480px, move the Save button to the right, make it bigger to match the others, and other responsive mode fixes.
Fixes #26907, see #27709
Built from https://develop.svn.wordpress.org/trunk@28043


git-svn-id: http://core.svn.wordpress.org/trunk@27873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 07:49:14 +00:00
Drew Jaynes
252a5434ff Inline documentation for hooks in wp-admin/includes/class-wp-upgrader-skins.php. 
Fixes #27711.

Built from https://develop.svn.wordpress.org/trunk@28040


git-svn-id: http://core.svn.wordpress.org/trunk@27870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 06:26:16 +00:00
Andrew Nacin
9a82e9070e Theme Installer: Show 'Preview' button for installed themes. 
props adamsilverstein.
see #27055, see #27708.

Built from https://develop.svn.wordpress.org/trunk@28038


git-svn-id: http://core.svn.wordpress.org/trunk@27868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 04:38:15 +00:00
Andrew Nacin
e7fc009f7c Theme Installer: Combine 'Layout' and 'Columns' filters so 'Features' can span two columns. 
see #27055.

Built from https://develop.svn.wordpress.org/trunk@28037


git-svn-id: http://core.svn.wordpress.org/trunk@27867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 04:30:15 +00:00
Andrew Nacin
640d9cb1a1 Theme Installer: Left/right arrow keys in the overlay. 
props adamsilverstein.
see #27521.

Built from https://develop.svn.wordpress.org/trunk@28036


git-svn-id: http://core.svn.wordpress.org/trunk@27866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 04:13:30 +00:00
Andrew Nacin
93d2e831cb Theme Installer: Use 'browse' instead of 'sort' for routes. 
see #27055.

Built from https://develop.svn.wordpress.org/trunk@28035


git-svn-id: http://core.svn.wordpress.org/trunk@27865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 04:13:16 +00:00
Andrew Nacin
5ea061ef8d Widget Customizer: Fix incorrect replacement in [27995]. 
props westonruter.
fixes #27690.

Built from https://develop.svn.wordpress.org/trunk@28034


git-svn-id: http://core.svn.wordpress.org/trunk@27864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 04:03:14 +00:00
Andrew Nacin
658032c9f9 Theme Installer: Disable prev/next buttons on first/last themes, add Esc handling, use IDs. 
props adamsilverstein, DH-Shredder.
fixes #27521.

Built from https://develop.svn.wordpress.org/trunk@28033


git-svn-id: http://core.svn.wordpress.org/trunk@27863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 03:57:15 +00:00
Andrew Nacin
c870767d98 Header Images: Add suggested dimensions to the media workflow. 
This updates [28030] to the latest patch.

props gcorne.
see #21785.

Built from https://develop.svn.wordpress.org/trunk@28031


git-svn-id: http://core.svn.wordpress.org/trunk@27861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 01:57:16 +00:00
Andrew Nacin
6b41f728d4 Header Images: Add suggested dimensions to the media workflow. 
props ehg, gcorne.
see #21785.

Built from https://develop.svn.wordpress.org/trunk@28030


git-svn-id: http://core.svn.wordpress.org/trunk@27860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 01:55:15 +00:00
Andrew Nacin
131c940cf8 Expose toolbar keyboard shortcut in Help documentation for TinyMCE. 
props joedolson, jorbin.
fixes #27024.

Built from https://develop.svn.wordpress.org/trunk@28029


git-svn-id: http://core.svn.wordpress.org/trunk@27859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 01:39:14 +00:00
Andrew Nacin
56c1deba7c Theme Installer: Handle currently installed themes, add search route, let prev/next refresh collections. 
props matveb.
see #27055. fixes #27695.

Built from https://develop.svn.wordpress.org/trunk@28025


git-svn-id: http://core.svn.wordpress.org/trunk@27855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 23:04:15 +00:00
Dominik Schilling
418aa98588 Widget Customizer: Update icons to new Dashicons, part 2. 
props Michael Arestad.
fixes #27400.
Built from https://develop.svn.wordpress.org/trunk@28013


git-svn-id: http://core.svn.wordpress.org/trunk@27843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 21:37:14 +00:00
Dominik Schilling
382a5aa4c2 Widget Customizer: Update icons to new Dashicons. 
props melchoyce.
see #27400.
Built from https://develop.svn.wordpress.org/trunk@28005


git-svn-id: http://core.svn.wordpress.org/trunk@27835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:50:15 +00:00
Drew Jaynes
f6df2c6921 Use the correct parameter variables in the hook docs for wp_upgrade. 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@27998


git-svn-id: http://core.svn.wordpress.org/trunk@27828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:13:15 +00:00
Drew Jaynes
181fe84d47 Align parameters in the hook docs for the attachment_thumbnail_args filter. 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@27997


git-svn-id: http://core.svn.wordpress.org/trunk@27827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:10:16 +00:00
Drew Jaynes
bf75eebfa7 Add missing parameter descriptions to the PHPDocs for WP_Upgrader_Skin::decrement_update_count() and Bulk_Upgrader_Skin::decrement_update_count(). 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@27996


git-svn-id: http://core.svn.wordpress.org/trunk@27826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:02:15 +00:00
Dominik Schilling
f69f3d3d18 Widget Customizer: Cleanup wp.customize.Widgets.SidebarControl. 
see #27690.
Built from https://develop.svn.wordpress.org/trunk@27995


git-svn-id: http://core.svn.wordpress.org/trunk@27825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:00:16 +00:00
Andrew Nacin
2d710c6fad Avoid stomping of bulk postdata inside the bulk_edit_posts() loop. 
props kovshenin.
see [27964], see #27452.

Built from https://develop.svn.wordpress.org/trunk@27990


git-svn-id: http://core.svn.wordpress.org/trunk@27820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 17:59:14 +00:00
Dominik Schilling
5bd1e16992 Widget Customizer: Cleanup wp.customize.Widgets.WidgetControl. 
see #27690.
Built from https://develop.svn.wordpress.org/trunk@27988


git-svn-id: http://core.svn.wordpress.org/trunk@27818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 16:32:15 +00:00
Dominik Schilling
5f76bf3b0d Widget Customizer: Make the available widgets panel a Backbone view. 
see #27690.
Built from https://develop.svn.wordpress.org/trunk@27986


git-svn-id: http://core.svn.wordpress.org/trunk@27816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 14:10:14 +00:00
Dominik Schilling
fabc65b787 Widget Customizer: Move WidgetCustomizer to wp.customize.Widgets. First pass. 
see #27690.
Built from https://develop.svn.wordpress.org/trunk@27985


git-svn-id: http://core.svn.wordpress.org/trunk@27815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 09:04:14 +00:00
Andrew Nacin
2f80a1c72f Apply checks in [27964] to wp_write_post(), which is unused and due for dismantling and deprecation. 
see #27452.

Built from https://develop.svn.wordpress.org/trunk@27975


git-svn-id: http://core.svn.wordpress.org/trunk@27805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-06 22:08:15 +00:00
Dominik Schilling
5f1c818477 Header images: Improve accessibility of Randomize buttons. 
props ehg.
see #27598, #21785.
Built from https://develop.svn.wordpress.org/trunk@27970


git-svn-id: http://core.svn.wordpress.org/trunk@27800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-06 19:28:16 +00:00
Dominik Schilling
0c5d4db466 Widgets: Trigger jQuery events for widget updates. 
* `widget-added` when a widget is added to a sidebar
* `widget-updated` when a widget is updated
A jQuery object of the widget is passed along to the event handler. Same events are used in the Widget Customizer, see [27909].

fixes #19675.
Built from https://develop.svn.wordpress.org/trunk@27969


git-svn-id: http://core.svn.wordpress.org/trunk@27799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-06 19:06:14 +00:00
Drew Jaynes
a11553eafe Inline documentation for remaining hooks in wp-admin/includes/upgrade.php. 
Props jackreichert, vancoder.
Fixes #27646.

Built from https://develop.svn.wordpress.org/trunk@27965


git-svn-id: http://core.svn.wordpress.org/trunk@27795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 22:30:14 +00:00
Andrew Nacin
1ec9b44673 Better checks for contributors when saving posts. 
props dd32, kovshenin, plocha.
see #27452.

Built from https://develop.svn.wordpress.org/trunk@27964


git-svn-id: http://core.svn.wordpress.org/trunk@27794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 21:19:14 +00:00
Andrew Nacin
7cd04f4829 Theme Installer: Separate API from an event handler to avoid issues where a false return value stops the event. 
see #27055.

Built from https://develop.svn.wordpress.org/trunk@27963


git-svn-id: http://core.svn.wordpress.org/trunk@27793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 20:46:15 +00:00
Andrew Nacin
f532f117e1 Theme Installer: Don't encode description entities/HTML. 
props johnbillion.
fixes #27641.

Built from https://develop.svn.wordpress.org/trunk@27962


git-svn-id: http://core.svn.wordpress.org/trunk@27792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 20:30:15 +00:00
Andrew Nacin
9fc1d41ec1 Theme Installer: Use JSONP for api.wordpress.org requests. 
fixes #27639.

Built from https://develop.svn.wordpress.org/trunk@27961


git-svn-id: http://core.svn.wordpress.org/trunk@27791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 20:28:14 +00:00
Andrew Nacin
c5127a9232 Theme Installer: Better responsive styles for feature filters. 
props matveb.
fixes #27661.

Built from https://develop.svn.wordpress.org/trunk@27959


git-svn-id: http://core.svn.wordpress.org/trunk@27789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 20:04:14 +00:00
Andrew Nacin
e36c1cbf9e Theme Installer: Fix displaying of errors. 
props SergeyBiryukov.
fixes #27640.

Built from https://develop.svn.wordpress.org/trunk@27958


git-svn-id: http://core.svn.wordpress.org/trunk@27788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 19:26:14 +00:00
Andrew Nacin
df9b44649c RTL: Fix taxonomy quick edit list alignment. 
props SergeyBiryukov.
fixes #27629.

Built from https://develop.svn.wordpress.org/trunk@27956


git-svn-id: http://core.svn.wordpress.org/trunk@27786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 18:14:15 +00:00
Dominik Schilling
12334929d7 Fix typo in hook description for async_upload_{$type}. 
Built from https://develop.svn.wordpress.org/trunk@27955


git-svn-id: http://core.svn.wordpress.org/trunk@27785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 14:12:16 +00:00
Dominik Schilling
5803c6bc2f Customizer: Add height: auto; for select[multiple]. 
fixes #27662.
Built from https://develop.svn.wordpress.org/trunk@27954


git-svn-id: http://core.svn.wordpress.org/trunk@27784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 13:12:15 +00:00
Andrew Ozz
2194145373 When autosaving a new post for the first time after a title was typed, cancel the autosave if the user is submitting the form. (Includes a precommit fix for customize-controls.css.) Props Nessworthy, davidmarichal, fixes #27657 
Built from https://develop.svn.wordpress.org/trunk@27951


git-svn-id: http://core.svn.wordpress.org/trunk@27781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 01:29:14 +00:00
Andrew Nacin
27c422364c Header images: Accessibility and style improvements. Headers no longer jump around when chosen. 
props mcsf, ehg.
see #21785.

Built from https://develop.svn.wordpress.org/trunk@27947


git-svn-id: http://core.svn.wordpress.org/trunk@27777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-04 15:49:15 +00:00
Andrew Nacin
5e79b94d81 Header images: Handle cropping failures. 
props ehg.
see #21785.

Built from https://develop.svn.wordpress.org/trunk@27946


git-svn-id: http://core.svn.wordpress.org/trunk@27776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-04 15:48:16 +00:00
Andrew Ozz
d4755ebea3 TinyMCE: add image backgrounds for more and nextpage tags (also jshint fix for theme.js). Fixes #27106 
Built from https://develop.svn.wordpress.org/trunk@27944


git-svn-id: http://core.svn.wordpress.org/trunk@27774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-04 05:23:14 +00:00
Andrew Ozz
2d0ce517e8 TinyMCE: better calculation for editor height when switching Text to Visual and back. Add stopping of editor resizing when the mouse leaves the browser window. See #27279 
Built from https://develop.svn.wordpress.org/trunk@27941


git-svn-id: http://core.svn.wordpress.org/trunk@27771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-04 01:31:15 +00:00
Andrew Nacin
be70db8c5f Theme Installer: Center spinner, remove plural string. 
fixes #27581. see #27055.

Built from https://develop.svn.wordpress.org/trunk@27940


git-svn-id: http://core.svn.wordpress.org/trunk@27770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-04 00:46:15 +00:00
Sergey Biryukov
b48021f65f Clarify tooltips on Edit Image screen. 
props siobhan.
fixes #27651.
Built from https://develop.svn.wordpress.org/trunk@27939


git-svn-id: http://core.svn.wordpress.org/trunk@27769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-04 00:03:28 +00:00
Sergey Biryukov
2cb849fc52 Fix typo in verify_file_md5() description. see [25541]. 
props siobhan.
see #27651.
Built from https://develop.svn.wordpress.org/trunk@27938


git-svn-id: http://core.svn.wordpress.org/trunk@27768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-04 00:03:14 +00:00
Andrew Nacin
0163a95d79 Theme Installer: Fix sorting, counts, keyboard navigation; add prev/next to previews. 
props matveb.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@27937


git-svn-id: http://core.svn.wordpress.org/trunk@27767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-03 23:53:15 +00:00
Andrew Nacin
dcb39d4dad Themes: Hide 'Add New' with no JS. see #27055. 
Built from https://develop.svn.wordpress.org/trunk@27936


git-svn-id: http://core.svn.wordpress.org/trunk@27766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-03 23:06:16 +00:00
Dominik Schilling
96203ceb97 Fix styling for plugin update details Thickbox. 
see #26952.
Built from https://develop.svn.wordpress.org/trunk@27932


git-svn-id: http://core.svn.wordpress.org/trunk@27762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-03 14:08:15 +00:00
Sergey Biryukov
f8c39d6186 Use multiplication sign instead of a colon for selection size when editing an image. 
props siobhan.
fixes #27652.
Built from https://develop.svn.wordpress.org/trunk@27931


git-svn-id: http://core.svn.wordpress.org/trunk@27761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-03 09:46:17 +00:00
Andrew Ozz
a2e1d9f4c8 Edit Image modal: 
- Fix issue with adding a link to an image that didn't have one previously.
- Adjust the look-and-feel of the advance options toggle so that it becomes a section heading that can be open/closed.
- Add a Custom Size option to the size drop-down that reveals fields for soft-resizing the image inserted into the post.
Props gcorne, and props sdasse for the design help, see #27366
Built from https://develop.svn.wordpress.org/trunk@27918


git-svn-id: http://core.svn.wordpress.org/trunk@27748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-03 03:21:15 +00:00
Andrew Nacin
803d4ff54d Remove old links_recently_updated_* DB options that never had a UI. 
fixes #27649.

Built from https://develop.svn.wordpress.org/trunk@27916


git-svn-id: http://core.svn.wordpress.org/trunk@27746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-03 03:10:15 +00:00
Dominik Schilling
158597a5e3 Widget Customizer: Restore deferral of previewer-loading class removal until preview is synced. 
props westonruter.
fixes #27635.
Built from https://develop.svn.wordpress.org/trunk@27913


git-svn-id: http://core.svn.wordpress.org/trunk@27744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-02 19:25:15 +00:00
Dominik Schilling
074d31f253 Widget Customizer: Don't use opacity for the update spinner. 
`opacity` isn't supported in IE8 and makes the spinner always visible.

see #27485.
Built from https://develop.svn.wordpress.org/trunk@27912


git-svn-id: http://core.svn.wordpress.org/trunk@27743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-02 19:20:15 +00:00
Dominik Schilling
944fba8e2f Widget Customizer: Improve support for dynamically-created inputs. 
* Re-work how and when widget forms get updated.
* Replace ad hoc hooks system with jQuery events,
* Add `widget-updated`/`widget-synced` events for widget soft/hard updates.
* Enter into a non-live form update mode, where the Apply button is restored when a sanitized form does not have the same fields as currently in the form, and so the fields cannot be easily updated to their sanitized values without doing a complete form replacement. Also restores live update mode if sanitized fields are aligned with the existing fields again.

Note: jQuery events are *not* final yet, see #19675.

props westonruter.
see #27491.
Built from https://develop.svn.wordpress.org/trunk@27909


git-svn-id: http://core.svn.wordpress.org/trunk@27740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-02 18:20:16 +00:00
Dominik Schilling
cde6d602ea Widget Customizer: Improve plugin compatibility. 
Some plugins are using custom scripts and styles for there widgets. These are available on the Widgets screens, but not in the Customizer yet.
Scripts and styles can be enqueued via: 
* `admin_enqueue_scripts`
* `admin_print_scripts` and `admin_print_scripts-widgets.php`
* `admin_print_styles` and `admin_print_styles-widgets.php`
* `admin_print_footer_scripts` and `admin_footer-widgets.php`
All this hooks are now called in the Customizer too.

Previously we have add the `#widgets-right` ID to a container div via jQuery. Remember: `#widgets-right` exists on the Widgets screen and is used by many plugins to do event delegation from that element.
But since our script files are loaded in the footer, the JavaScript way is a bit late for some plugins.
We have decided to add a `div#widgets-right` container element to customizer. "Less hacky hack."

props westonruter, ocean90. Thanks dpe415 for testing.
fixes #27619.
Built from https://develop.svn.wordpress.org/trunk@27907


git-svn-id: http://core.svn.wordpress.org/trunk@27738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-02 17:04:14 +00:00
Dion Hulse
50a7503c2e Background Updates: Record Plugin & Theme update statistics like we for for Core updates, Pass Plugin/Theme update objects into the Background updater for consistency with Core & Translations. See #27633 
Built from https://develop.svn.wordpress.org/trunk@27905


git-svn-id: http://core.svn.wordpress.org/trunk@27736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-02 13:05:15 +00:00