Boone Gorges
1370d8b869
Don't double-unslash meta key when update_metadata()
falls back on add_metadata()
.
...
Props jdgrimes.
Fixes #35795 .
Built from https://develop.svn.wordpress.org/trunk@36509
git-svn-id: http://core.svn.wordpress.org/trunk@36476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-11 17:35:28 +00:00
Boone Gorges
dae31f7d95
Remove unused variable from get_terms()
.
...
Unused since [31284].
Props TimothyBlynJacobs.
Fixes #35784 .
Built from https://develop.svn.wordpress.org/trunk@36508
git-svn-id: http://core.svn.wordpress.org/trunk@36475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-11 04:33:29 +00:00
Eric Lewis
a64dbc805b
Menus: Revert larger menu support in Edit Menus screen in [36506].
...
JSON encoding the form as it exists on the page will not scale.
See #14134 .
Built from https://develop.svn.wordpress.org/trunk@36507
git-svn-id: http://core.svn.wordpress.org/trunk@36474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-10 14:11:26 +00:00
Eric Lewis
48fdbf96de
Menus: Allow larger menus to be created in the Edit Menu screen.
...
In the Edit Menu screen, each menu item creates 11 form input elements. In menus with more than 71 menu items, often items after the 71st weren't saved. This was because PHP's runtime configuration `max_input_vars` default value is 1000. Large menus exceed this, so PHP didn't populate the `$_POST` superglobal for the latter menu items.
The entire form is now JSON-encoded into a single input which populates `$_POST` manually on form submission.
See #14134 .
Built from https://develop.svn.wordpress.org/trunk@36506
git-svn-id: http://core.svn.wordpress.org/trunk@36473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-10 03:32:25 +00:00
Dominik Schilling
cbe5fc6fb8
Multisite: Don't show the database upgrade admin notice on the upgrade page itself.
...
Fixes #35782 .
Built from https://develop.svn.wordpress.org/trunk@36505
git-svn-id: http://core.svn.wordpress.org/trunk@36472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-09 14:30:28 +00:00
Dominik Schilling
d9a5894c2e
Users: Display the new user email notice in user admin too.
...
Also, in `new_user_email_admin_notice()` use the global `$pagenow` and add a translators comment for the placeholder.
Fixes #35767 .
Built from https://develop.svn.wordpress.org/trunk@36504
git-svn-id: http://core.svn.wordpress.org/trunk@36471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 13:54:25 +00:00
Dominik Schilling
0eb4f6ccfc
Users: Use self_admin_url()
for the email change confirmation link.
...
Prevents sending users to wp-admin/profile.php if they only have access to wp-admin/user/profile.php.
Fixes #35766 .
Built from https://develop.svn.wordpress.org/trunk@36503
git-svn-id: http://core.svn.wordpress.org/trunk@36470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 13:26:27 +00:00
Drew Jaynes
deeb5f1471
Themes: Pass information about the old theme in the form of a WP_Theme
object when the switch_theme
action is fired.
...
Props MikeHansenMe.
See #22401 .
Built from https://develop.svn.wordpress.org/trunk@36502
git-svn-id: http://core.svn.wordpress.org/trunk@36469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 08:26:25 +00:00
Drew Jaynes
12bdf5a6da
Docs: Improove the DocBlock summary for wp_signon()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36501
git-svn-id: http://core.svn.wordpress.org/trunk@36468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 08:11:25 +00:00
Drew Jaynes
48988c505f
Docs: Make a couple of minor improvements to the DocBlock for wp_get_raw_referer()
, introduced in [36266].
...
* Uses a third-person singular verb in the summary
* Makes the return types more specific with `string|false` vs `string|bool`.
See #27152 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36500
git-svn-id: http://core.svn.wordpress.org/trunk@36467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 08:09:25 +00:00
Drew Jaynes
b45a6228d0
Docs: Add a changelog entry for the introduction of maxlength character limits for the 'author', 'email', and 'url' fields in comment_form()
.
...
Introduced in [36272].
See #10377 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36499
git-svn-id: http://core.svn.wordpress.org/trunk@36466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 08:05:27 +00:00
Drew Jaynes
c55f447ad4
Docs: Revert unintended changes in wp-includes/post.php, mistakenly included in [36497].
...
See #34988 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@36498
git-svn-id: http://core.svn.wordpress.org/trunk@36465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 02:46:25 +00:00
Drew Jaynes
3785385ea2
Docs: Add a missing version to the file header for wp-admin/term.php, introduced in [36308].
...
See #34988 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@36497
git-svn-id: http://core.svn.wordpress.org/trunk@36464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 02:43:26 +00:00
Drew Jaynes
f3aeb0def3
Docs: Update several function DocBlock summaries in wp-includes/nav-menu.php to use third-person singular verbs.
...
Also removes some unnecessary capitalizations.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36496
git-svn-id: http://core.svn.wordpress.org/trunk@36463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 02:18:26 +00:00
Drew Jaynes
e2cec35437
Docs: Make some minor improvements to inline docs for WP_Site
, introduced in [36393].
...
* Uses third-person singular verbs in method summaries
* Adds an `@static` tag to the `WP_Site::get_instance()` DocBlock
* Adjusts return types for `WP_Site::get_instance()` to the more explicit `WP_Site|false`
See #32450 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36495
git-svn-id: http://core.svn.wordpress.org/trunk@36462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 02:13:26 +00:00
Drew Jaynes
3e7db642a6
Docs: Slightly simplify the DocBlock summaries for home_url()
, get_home_url()
, site_url()
, and get_site_url()
.
...
See #35238 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36494
git-svn-id: http://core.svn.wordpress.org/trunk@36461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 02:06:26 +00:00
Drew Jaynes
b0ef4d14c5
Docs: Add an @access
tag and fix a typo in the DocBlock for wpdb::close()
.
...
See #34903 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36493
git-svn-id: http://core.svn.wordpress.org/trunk@36460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 02:03:26 +00:00
Drew Jaynes
9daf7a88a3
Docs: Add a note to the DocBlock for current_user_can()
to explain that it will always return true for super admins, unless specifically denied.
...
Props finnj.
Fixes #35551 .
Built from https://develop.svn.wordpress.org/trunk@36492
git-svn-id: http://core.svn.wordpress.org/trunk@36459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 01:27:26 +00:00
Drew Jaynes
a06a5ecfe9
Docs: Fix two notations in the DocBlocks for show_admin_bar()
and is_admin_bar_showing()
to reflect use of the $show_admin_bar
global rather than $wp_admin_bar
.
...
Props Frozzare.
Fixes #35686 .
Built from https://develop.svn.wordpress.org/trunk@36491
git-svn-id: http://core.svn.wordpress.org/trunk@36458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 01:22:26 +00:00
Drew Jaynes
b1127321ec
Docs: Fix one line of the DocBlock for the JsonSerializable
compat interface to use a tab instead of spaces.
...
Props Frozzare.
Fixes #35699 .
Built from https://develop.svn.wordpress.org/trunk@36490
git-svn-id: http://core.svn.wordpress.org/trunk@36457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 01:18:27 +00:00
Drew Jaynes
6a94d3e2e3
Docs: Use the correct parameter name in the DocBlock for wp_kses_post_deep()
, introduced in [36429].
...
Props sebastianpisula.
Fixes #35700 . See #35316 .
Built from https://develop.svn.wordpress.org/trunk@36489
git-svn-id: http://core.svn.wordpress.org/trunk@36456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 00:18:26 +00:00
Drew Jaynes
c1b837b47f
Docs: Add a missing type to the return description for map_deep()
.
...
Props sebastianpisula.
See #35700 .
Built from https://develop.svn.wordpress.org/trunk@36488
git-svn-id: http://core.svn.wordpress.org/trunk@36455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-07 00:15:27 +00:00
Sergey Biryukov
6e60f8b6f8
Login: In login_header()
, use correct separator for RTL locales.
...
Props ramiy.
Fixes #35737 .
Built from https://develop.svn.wordpress.org/trunk@36487
git-svn-id: http://core.svn.wordpress.org/trunk@36454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-06 22:56:27 +00:00
Boone Gorges
146320744f
Allow comments to be queried by 'any' post_type
or post_status
.
...
Props kouratoras.
Fixes #35512 .
Built from https://develop.svn.wordpress.org/trunk@36486
git-svn-id: http://core.svn.wordpress.org/trunk@36453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-06 04:51:25 +00:00
Boone Gorges
fe1dd15126
Allow get_terms()
results to ordered by metadata.
...
The `$orderby` parameter of `get_terms()` now accepts the following values,
related to term meta:
* 'meta_value'
* 'meta_value_num'
* the value of the `$meta_key` parameter
* any key from the `$meta_query` array
This brings order-by-meta support for terms in line with post, comment, and
user queries.
As a byproduct of these improvements, `$meta_key` and `$meta_value` parameters
have been introduced to `get_terms()`. They interact with `$meta_query` in the
same way as in `WP_Query` and other query classes.
Props jadpm, eherman24.
Fixes #34996 .
Built from https://develop.svn.wordpress.org/trunk@36485
git-svn-id: http://core.svn.wordpress.org/trunk@36452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-06 04:42:26 +00:00
Boone Gorges
f1c0ed714a
WP_Query
taxonomy query vars should be set to first of multiple taxonomies.
...
This provides better parity with `get_queried_object()`, which will return the
first taxonomy/term matched by the current query.
[29891] introduced the abnormal behavior for the 'taxonomy' and 'term'
query vars.
Props Chouby.
Fixes #35619 .
Built from https://develop.svn.wordpress.org/trunk@36484
git-svn-id: http://core.svn.wordpress.org/trunk@36451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-06 03:58:27 +00:00
Andrew Ozz
3a2ef071d4
TinyMCE inline link:
...
- Fix not displaying anything when the URL is only a fragment. Show the whole URL.
- Fix editing a link when it is the very first word in the editor.
- Fix editing a link then some of the surrounding text or space is selected. Change the selection to only the link node.
- Add placeholder when adding new link.
See #33301 .
Built from https://develop.svn.wordpress.org/trunk@36483
git-svn-id: http://core.svn.wordpress.org/trunk@36450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-06 00:51:27 +00:00
Boone Gorges
20c07afbd5
When updating a user, invalidate its 'userslugs' cache.
...
`user_nicename` can be changed via `wp_update_user()`, so we invalidate just
to be safe.
Props thebrandonallen.
Fixes #35750 .
Built from https://develop.svn.wordpress.org/trunk@36482
git-svn-id: http://core.svn.wordpress.org/trunk@36449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-05 19:03:26 +00:00
Boone Gorges
8db393ada6
Make the $post
param optional in get_post_field()
.
...
When `$post` is `null`, the current post object will be returned.
Props sebastian.pisula.
Fixes #35683 .
Built from https://develop.svn.wordpress.org/trunk@36481
git-svn-id: http://core.svn.wordpress.org/trunk@36448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-05 18:58:25 +00:00
Boone Gorges
b5d12e130c
Comments: Restore the ability to bypass post_id filter using 0 or '0'.
...
The changes introduced in [36381], while logical and clearly awesome, introduce
the potential for much breakage. Those who want to query for comments with a
null `comment_post_ID` should use `'post_in' => array( 0 )` instead.
Reverts [36381], [36387].
See #35090 .
Built from https://develop.svn.wordpress.org/trunk@36480
git-svn-id: http://core.svn.wordpress.org/trunk@36447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-05 18:50:25 +00:00
Boone Gorges
8e5cf1c2fe
Comments: Add 'parent__in' and 'parent__not_in' to query var defaults.
...
Query var defaults are used to calculate a cache key. The fact that these
params were not listed among the defaults was causing cache keys to be
insufficiently specific.
Props danielbachhuber.
Fixes #35677 .
Built from https://develop.svn.wordpress.org/trunk@36479
git-svn-id: http://core.svn.wordpress.org/trunk@36446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-05 18:36:28 +00:00
Gary Pendergast
e42e8c6d72
Tests: Use the new wpdb::close()
method for closing the DB connection.
...
Props markoheijnen.
Fixes #34903 .
Built from https://develop.svn.wordpress.org/trunk@36478
git-svn-id: http://core.svn.wordpress.org/trunk@36445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-05 01:06:28 +00:00
Andrea Fercia
f75f20edb2
Accessibility: simplify the Plugins and Themes tables on the Updates screen.
...
Although it may seem counterintuitive at first, in very limited cases it's
better to remove improper semantics (this is not a tabular data table) in
order to reduce noise for screen reader users and simplify all the things.
Also improves headings to better separate sections.
Fixes #34780 .
Built from https://develop.svn.wordpress.org/trunk@36477
git-svn-id: http://core.svn.wordpress.org/trunk@36444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-04 19:19:27 +00:00
Drew Jaynes
94fdeabe27
Docs: Document the $args
parameter for get_categories()
as a hash notation.
...
The only specific default for `get_categories()` is `$taxonomy` with a value of 'category', all the other arguments are documented separately in `get_terms()`.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36476
git-svn-id: http://core.svn.wordpress.org/trunk@36443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-04 14:50:26 +00:00
Drew Jaynes
6bbb34818c
Docs: Reference get_terms()
for arguments available in get_categories()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36475
git-svn-id: http://core.svn.wordpress.org/trunk@36442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-04 14:38:28 +00:00
Drew Jaynes
26bf8cda9b
Docs: Add more complete information to DocBlocks for private core functions _wp_dashboard_control_callback()
and _wp_dashboard_recent_comments_row()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36474
git-svn-id: http://core.svn.wordpress.org/trunk@36441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-03 20:20:26 +00:00
Drew Jaynes
6995ec613e
Docs: Add private access notation to the DocBlock for the core _wp_handle_upload()
function.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36473
git-svn-id: http://core.svn.wordpress.org/trunk@36440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-03 20:19:25 +00:00
Drew Jaynes
d62a1bf1e9
Docs: Mark two private functions as such in wp-admin/ajax-actions.php.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36472
git-svn-id: http://core.svn.wordpress.org/trunk@36439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-03 20:17:26 +00:00
Drew Jaynes
9351a7c9ff
Docs: Add a missing DocBlock for the private _add_themes_utility_last()
function.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36471
git-svn-id: http://core.svn.wordpress.org/trunk@36438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-03 20:07:27 +00:00
Dominik Schilling
72c6f7f86f
Suppress possible warnings in PHP < 5.3.3 by parse_url()
in wp_validate_redirect()
.
...
PHP 5.3.3 removed the E_WARNING that was emitted when URL parsing failed.
Built from https://develop.svn.wordpress.org/trunk@36446
git-svn-id: http://core.svn.wordpress.org/trunk@36413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 16:34:27 +00:00
Aaron Jorbin
5c4031dd84
Revert [35792]
...
This causes a regression and causes redirects to potentially fail.
See #5114 #34028
props ocean90
Built from https://develop.svn.wordpress.org/trunk@36445
git-svn-id: http://core.svn.wordpress.org/trunk@36412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 16:24:26 +00:00
Dominik Schilling
361ed7a3d6
Better validation of the URL used in HTTP redirects.
...
Built from https://develop.svn.wordpress.org/trunk@36444
git-svn-id: http://core.svn.wordpress.org/trunk@36411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 15:11:28 +00:00
Dominik Schilling
f65de8ec9f
HTTP: 0.1.2.3
is not a valid IP.
...
Built from https://develop.svn.wordpress.org/trunk@36435
git-svn-id: http://core.svn.wordpress.org/trunk@36402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 12:55:29 +00:00
Gary Pendergast
e19a8796fd
Database: Allow loading when only the mysqlnd
extension is loaded.
...
We do an early check for a mysql extension being loaded, but it fails if the `mysqlnd` extension is the only one present.
Props nexurium.
Fixes #33261 .
Built from https://develop.svn.wordpress.org/trunk@36434
git-svn-id: http://core.svn.wordpress.org/trunk@36401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 00:59:25 +00:00
Gary Pendergast
5779ed9d8a
WPDB: Add a close()
method to wpdb
, for when the connection needs to be manually closed.
...
In the event that it was closed prematurely, `wpdb::query()` will re-open the connection automatically.
Fixes #34903 .
Built from https://develop.svn.wordpress.org/trunk@36433
git-svn-id: http://core.svn.wordpress.org/trunk@36400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-02 00:13:26 +00:00
Weston Ruter
9f7d608a6a
Customizer: Fix searching for available nav menu items by updating reference to nonce.
...
Fixes regression introduced in [36414] where the nonce for listing available nav menu items was updated to use the new centralized location at `wp.customize.settings.nonce`, but the nonce for search did not get updated.
See #35617 .
Built from https://develop.svn.wordpress.org/trunk@36432
git-svn-id: http://core.svn.wordpress.org/trunk@36399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-01 21:36:28 +00:00
Dominik Schilling
cd892b86b4
Media: In wp_read_image_metadata()
make sure that IPTC keywords are UTF8 encoded.
...
Prevents missing `_wp_attachment_metadata` when an image contains keywords with latin extended characters.
Fixes #35316 .
Built from https://develop.svn.wordpress.org/trunk@36429
git-svn-id: http://core.svn.wordpress.org/trunk@36396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-01 14:53:27 +00:00
Andrea Fercia
c9e5edd637
Menus: Avoid displaying two spinners when adding selected menu items.
...
Fixes #35682 .
Built from https://develop.svn.wordpress.org/trunk@36427
git-svn-id: http://core.svn.wordpress.org/trunk@36394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-31 18:06:27 +00:00
Andrea Fercia
82f59fc6ef
Menus: after [36379] prevent "Quick Search" form submission when pressing Enter.
...
Fixes #35374 .
Built from https://develop.svn.wordpress.org/trunk@36426
git-svn-id: http://core.svn.wordpress.org/trunk@36393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-31 14:03:27 +00:00
Rachel Baker
2573fa7ab8
Comments: Add back $req
variable in comments_template()
.
...
The variables in `comments_template()` should never be assumed to be unused. This function includes the `comments.php` template file from the active theme or falls back to `theme-compat/comments.php`. This is why including a file within a function only brings pain and sorrow.
Reverts r36322.
See #35473 .
Built from https://develop.svn.wordpress.org/trunk@36425
git-svn-id: http://core.svn.wordpress.org/trunk@36392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-30 22:13:26 +00:00