Scott Taylor
1b3f91f500
Declare $wp_version
, $required_php_version
, and $required_mysql_version
as globals in install and upgrade admin files.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31124
git-svn-id: http://core.svn.wordpress.org/trunk@31105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:57:22 +00:00
Scott Taylor
1bac6fb886
In wp-admin/includes/revision.php
, $post->modified
is a coding error. It should be $post->post_modified
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31123
git-svn-id: http://core.svn.wordpress.org/trunk@31104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:50:22 +00:00
Scott Taylor
d6ce5dd553
WP_Upgrader
will take any "skin" that is passed to it, and set ->skin
via composition. The default type of ->skin
is WP_Upgrader_Skin
, which doesn't have methods declared for ->bulk_header()
and ->bulk_footer()
. Add noop methods to WP_Upgrader_Skin
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31122
git-svn-id: http://core.svn.wordpress.org/trunk@31103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:42:22 +00:00
Scott Taylor
84867b3e9c
Admin globals:
...
* Declare `$wp_importers` as a global in `admin.php`
* Declare `$post_type`, `$post_type_object`, and `$post` as globals where applicable
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31121
git-svn-id: http://core.svn.wordpress.org/trunk@31102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:29:22 +00:00
Scott Taylor
ac654632fe
Use PHP_SAPI
constant instead of php_sapi_name()
in iis7_supports_permalinks()
, wp_fix_server_vars()
, and wp_redirect()
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31120
git-svn-id: http://core.svn.wordpress.org/trunk@31101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 04:59:22 +00:00
Scott Taylor
afd09f1f04
In wp_ajax_upload_attachment()
, wp_check_filetype_and_ext()
doesn't need a 3rd param - it already defaults to null
. Passing false
would fail a strict check
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31119
git-svn-id: http://core.svn.wordpress.org/trunk@31100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 04:55:25 +00:00
Andrew Ozz
3324fb71f6
TinyMCE editor-expand: when kitchensink is off hide the statusbar on loading, and when the editor is shorter then the viewport. Props avryl, fixes #30961 .
...
Built from https://develop.svn.wordpress.org/trunk@31118
git-svn-id: http://core.svn.wordpress.org/trunk@31099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 01:32:26 +00:00
Andrew Ozz
71885dceca
Media modal: do not attempt to focus the hidden file input field added by Plupload when tabbing. Props afercia, fixes #30392 .
...
Built from https://develop.svn.wordpress.org/trunk@31117
git-svn-id: http://core.svn.wordpress.org/trunk@31098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 21:47:29 +00:00
Scott Taylor
709698a579
In Custom_Background
and Custom_Header
:
...
* In `->init()`, don't check `current_user_can()` since `add_theme_page()` will return `false` immediately if the cap check fails.
* Bail if `add_theme_page()` returns `false`
* `wp_check_filetype_and_ext()` doesn't need a 3rd param, it already defaults to `null`. Passing `false` would fail a strict check.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31116
git-svn-id: http://core.svn.wordpress.org/trunk@31097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 21:07:22 +00:00
Scott Taylor
236d8ae9dc
After [31016], would be cool if we actually included the froogaloop
file to interact with Vimeo.
...
Props dimadin.
Fixes #29267 .
Built from https://develop.svn.wordpress.org/trunk@31115
git-svn-id: http://core.svn.wordpress.org/trunk@31096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 20:04:23 +00:00
Boone Gorges
df945fcdcb
In get_permalink()
, don't resolve to pretty permalink if post has 'future' status.
...
We already do this for other non-public statuses, to prevent leaking non-public
information about unpublished posts.
Props e.mazovetskiy, CalEvans.
Fixes #30910 .
Built from https://develop.svn.wordpress.org/trunk@31114
git-svn-id: http://core.svn.wordpress.org/trunk@31095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 16:40:22 +00:00
Sergey Biryukov
7b04e6d4f4
Add variable type for sync_category_tag_slugs() parameters.
...
props tillkruess.
fixes #30718 .
Built from https://develop.svn.wordpress.org/trunk@31113
git-svn-id: http://core.svn.wordpress.org/trunk@31094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 11:19:22 +00:00
Sergey Biryukov
2be2af7789
Avoid a PHP notice in _WP_Editors::wp_fullscreen_html() when no $post global is set.
...
props marcochiesi.
fixes #30071 .
Built from https://develop.svn.wordpress.org/trunk@31112
git-svn-id: http://core.svn.wordpress.org/trunk@31093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 10:28:23 +00:00
Sergey Biryukov
a2f9b410f8
Toolbar: Make network admin accessible via keyboard.
...
props Cheffheid.
fixes #29422 .
Built from https://develop.svn.wordpress.org/trunk@31111
git-svn-id: http://core.svn.wordpress.org/trunk@31092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 09:51:22 +00:00
Sergey Biryukov
e214fce67f
Use localized format for Last Updated date in plugin details modal, for consistency with [31055].
...
see #30717 .
Built from https://develop.svn.wordpress.org/trunk@31110
git-svn-id: http://core.svn.wordpress.org/trunk@31091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 06:21:22 +00:00
Sergey Biryukov
d5d0b367ab
Improve documentation for media_handle_upload().
...
props ericlewis.
fixes #30962 .
Built from https://develop.svn.wordpress.org/trunk@31109
git-svn-id: http://core.svn.wordpress.org/trunk@31090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 05:05:23 +00:00
Sergey Biryukov
e24b443f50
Correct @return value for WP_Theme::load_textdomain() after [30681].
...
see #30224 .
Built from https://develop.svn.wordpress.org/trunk@31108
git-svn-id: http://core.svn.wordpress.org/trunk@31089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 04:54:24 +00:00
Gary Pendergast
5ee3ff435d
Add get_avatar_url()
, for retrieving just the URL of an avatar, rather than the entire <img>
tag that get_avatar()
produces.
...
Unlike `get_avatar()`, `get_avatar_url()` is not pluggable. It can be extended/or modified through the new filters included.
Fixes #21195 .
Props mdawaffe, pento, pathawks, DrewAPicture
Built from https://develop.svn.wordpress.org/trunk@31107
git-svn-id: http://core.svn.wordpress.org/trunk@31088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 04:43:23 +00:00
Scott Taylor
8ee598169f
After [31105], don't ditch the isset()
calls for BC. Declare $page_hook
as null
so it is initialized for all execution paths but will still fail isset()
checks.
...
Fixes #30958 .
Built from https://develop.svn.wordpress.org/trunk@31106
git-svn-id: http://core.svn.wordpress.org/trunk@31087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 22:52:22 +00:00
Scott Taylor
60e1dd409b
Properly declare $hook_suffix
, $plugin_page
, $typenow
, and $taxnow
as globals in wp-admin/admin.php
.
...
Fixes #30958 .
Built from https://develop.svn.wordpress.org/trunk@31105
git-svn-id: http://core.svn.wordpress.org/trunk@31086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 22:15:24 +00:00
Sergey Biryukov
91297b7a30
If WP_Rewrite::flush_rules() is called on 'init' or earlier, wait until 'wp_loaded' before actually flushing the rules, to make sure all the rules registered on 'init' are included.
...
props joostdevalk.
see #30501 .
Built from https://develop.svn.wordpress.org/trunk@31104
git-svn-id: http://core.svn.wordpress.org/trunk@31085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 22:00:23 +00:00
Sergey Biryukov
6e29458407
Remove a redundant inline comment with a typo.
...
props nicnicnicdevos.
fixes #30956 .
Built from https://develop.svn.wordpress.org/trunk@31103
git-svn-id: http://core.svn.wordpress.org/trunk@31084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:29:24 +00:00
Sergey Biryukov
24b3ee8680
Make a hint on Edit Selection view in media modal more accurate, as it applies to all media files, not just images.
...
props pavelevap.
see #30931 .
Built from https://develop.svn.wordpress.org/trunk@31102
git-svn-id: http://core.svn.wordpress.org/trunk@31083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:24:23 +00:00
Scott Taylor
e4b6265c7a
Overriding methods should do more than simply call the same method in the super class.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31101
git-svn-id: http://core.svn.wordpress.org/trunk@31082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:20:22 +00:00
Scott Taylor
4a1ad9acec
Jump statements should not be followed by other statements (there were 5 lingering).
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31100
git-svn-id: http://core.svn.wordpress.org/trunk@31081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:15:22 +00:00
Scott Taylor
4feecb922c
Use &&
instead of and
in the 3 places where and
was used.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31099
git-svn-id: http://core.svn.wordpress.org/trunk@31080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:12:22 +00:00
Sergey Biryukov
dfac056cf1
Pass post type to count_user_posts() in get_the_author_posts().
...
props Caspie, tyxla.
fixes #30904 .
Built from https://develop.svn.wordpress.org/trunk@31098
git-svn-id: http://core.svn.wordpress.org/trunk@31079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 19:53:22 +00:00
Sergey Biryukov
ff4968ebc4
Use home_url() instead of hardcoded domain in Tests_Link_GetAdjacentPostLink.
...
props CalEvans.
fixes #30955 .
Built from https://develop.svn.wordpress.org/trunk@31097
git-svn-id: http://core.svn.wordpress.org/trunk@31078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 18:45:23 +00:00
Sergey Biryukov
e53b581817
Remove non-functional date filter from Edit Selection view in media modal.
...
props tyxla.
fixes #30931 .
Built from https://develop.svn.wordpress.org/trunk@31096
git-svn-id: http://core.svn.wordpress.org/trunk@31077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 18:23:23 +00:00
Helen Hou-Sandí
bc7cc3bb12
Collapse additional avatar settings if avatars are disabled.
...
props markjaquith, krogsgard, valendesigns.
fixes #30168 .
Built from https://develop.svn.wordpress.org/trunk@31095
git-svn-id: http://core.svn.wordpress.org/trunk@31076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 17:01:24 +00:00
Gary Pendergast
c777f6a29c
WPDB: When sanity checking a string, check that it's a string, first - PHP notices can occur if an array or object is handled like a string.
...
See #21212
Built from https://develop.svn.wordpress.org/trunk@31094
git-svn-id: http://core.svn.wordpress.org/trunk@31075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 08:45:22 +00:00
Gary Pendergast
83a229084f
WPDB: When wpdb::query()
needs to sanity check a query string, make sure to run wpdb:flush()
afterwards, to ensure the results from sanity check queries aren't mixed up with the results for the user query.
...
See #21212 .
Fixes #30948 .
Built from https://develop.svn.wordpress.org/trunk@31093
git-svn-id: http://core.svn.wordpress.org/trunk@31074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 08:32:22 +00:00
Scott Taylor
ac6fddee35
In wp_xmlrpc_server
, remove dead code.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31092
git-svn-id: http://core.svn.wordpress.org/trunk@31073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:21:22 +00:00
Scott Taylor
383a5c6c24
In wp-includes/plugin.php
, collapse 3 else-newline-tab-if
statements.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31091
git-svn-id: http://core.svn.wordpress.org/trunk@31072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:13:24 +00:00
Scott Taylor
60b0cd7943
The keyword elseif
should be used instead of else if
so that all control keywords look like single words.
...
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31090
git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:05:25 +00:00
Dion Hulse
a4ed093250
Enable Pretty Permalinks for new sites during install if the server supports it.
...
See #6481 , Props valendesigns, DrewAPicture & ericlewis
Built from https://develop.svn.wordpress.org/trunk@31089
git-svn-id: http://core.svn.wordpress.org/trunk@31070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:47:23 +00:00
Scott Taylor
bc4cd01190
In wp-includes/taxonomy.php
:
...
The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31087
git-svn-id: http://core.svn.wordpress.org/trunk@31068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:26:23 +00:00
Scott Taylor
29cd3fa5bf
PHP keywords and constants "true", "false", "null" should be in lower case - there was one lingering capitalized false
in _http_build_query()
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31086
git-svn-id: http://core.svn.wordpress.org/trunk@31067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:14:23 +00:00
Scott Taylor
55fdfb529a
There is no need to use the final
modifier inside a final
class. Everything in it is final
by default.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31085
git-svn-id: http://core.svn.wordpress.org/trunk@31066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:10:46 +00:00
Scott Taylor
905f35f289
In Customizer classes:
...
* `public final function` methods should be `final public function` - confusing Hack and aligns with PSR2
* Some methods were missing access modifiers
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31083
git-svn-id: http://core.svn.wordpress.org/trunk@31064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:02:24 +00:00
Scott Taylor
80915aaf16
WP_Query->parse_tax_query()
- for BC, this method is not marked as protected. See [28987]. It needs an access modifier, it shall have public
. The comment remains.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31081
git-svn-id: http://core.svn.wordpress.org/trunk@31062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:54:44 +00:00
Scott Taylor
ac4e67b82e
Perl-style comments should not be used
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31079
git-svn-id: http://core.svn.wordpress.org/trunk@31060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:52:24 +00:00
Scott Taylor
e029005847
Access Modifiers:
...
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31078
git-svn-id: http://core.svn.wordpress.org/trunk@31059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:44:23 +00:00
Scott Taylor
ff98cfcf45
Pinking Shears.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31077
git-svn-id: http://core.svn.wordpress.org/trunk@31058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:03:23 +00:00
Sergey Biryukov
9b0e279e82
In dashboard activity widget, display a front-end link if the user cannot edit the post.
...
props UaMV, DrewAPicture.
fixes #29025 .
Built from https://develop.svn.wordpress.org/trunk@31075
git-svn-id: http://core.svn.wordpress.org/trunk@31056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 00:26:22 +00:00
Sergey Biryukov
f2b5ac8ef1
Call the init() method for the upgrader in wp_can_install_language_pack() to avoid undefined index notices.
...
props ocean90.
fixes #30827 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31074
git-svn-id: http://core.svn.wordpress.org/trunk@31055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:43:24 +00:00
Sergey Biryukov
f601e45055
TinyMCE: Remove dashicon-no-alt.png, unused since [30694].
...
props kpdesign, MattyRob.
fixes #30791 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31073
git-svn-id: http://core.svn.wordpress.org/trunk@31054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:32:22 +00:00
Sergey Biryukov
da4a8f56f5
Theme install: Display an appropriate string if theme has not been rated yet.
...
props kevdotbadger, valendesigns.
fixes #28147 .
Built from https://develop.svn.wordpress.org/trunk@31072
git-svn-id: http://core.svn.wordpress.org/trunk@31053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:17:22 +00:00
Sergey Biryukov
3dcd0e2119
Add context for 'Previous' and 'Next' strings in get_the_posts_pagination().
...
fixes #30762 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31071
git-svn-id: http://core.svn.wordpress.org/trunk@31052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:07:22 +00:00
Andrew Ozz
00ff6675a2
Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167 .
...
Built from https://develop.svn.wordpress.org/trunk@31070
git-svn-id: http://core.svn.wordpress.org/trunk@31051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 22:48:22 +00:00